Why is it not working ?

Right, I wrote a plugin, which listens for command, and on command, it runs a class file, which has normal, nothing to do with craftbukkit, code. The code is to put a folder into .zip and upload it to FTP server.

I have tested the .zip and upload code in eclipse and it worked, I got my zipped file on desktop and it was uploaded on my FTP server.

Now, When I tried to make it a bukkit plugin, it starts-up but when I execute a command to begin this process it throws me back an error. Any idea why ?
Question is, is it possible to run not-related craftbukkit code, as a plugin.

I will upload code snippets and error log when I get home, if needed.

 

You're going to need to provide a lot more information before anyone can help you. we'll need to see the actual error messages at the very least. and seeing the code would help too. I don't understand what the relevance of the .zip file is. bukkit can't run code in a zip file.

 

You either didn't read what I wrote, or you just misunderstood everything. It's all written in Java in one package (.jar) just different classes. There's only one file which contains "extends JavaPlugin{" and that's working, but the other classes don't. Just as if they were not able to be ran by console as plugin. The other class is responsible for zipping folders and yet the other, last class is responsible for uploading the zip files to FTP servers, which doesn't work when it's converted into a plugin, but works as a standalone plugin.

 

I did read what you wrote, it just wasn't very clear, I still don't understand what you mean by: "doesn't work when it's converted into a plugin, but works as a standalone plugin" but that's really beside the point. The real issue is that you're saying it:

If you would show us the error, maybe. what's in the server logs? there's probably a stack trace that tells you exactly why it's happening. You've literally given *no* useable information for anyone to help you, just: "I wrote some code that works, but doesn't work as a bukkit plugin, it just throws an error."

 

He is simply asking for some code/error. We know that you will upload them when you reach home, and we don't know what time or how long that will take, but we need you to supply us with the error code or log message, so we can help.

I really don't see what you would be expecting when you decided to post a thread about an error, and not providing the error. In addition, your explanation was not really the best either.

P.S
Do you actually know the basics of coding a bukkit plugin, e.g registering commandexecutors, getCommand().setExecutor(); , and actually putting the command into the plugin.yml under the

Code:

commands:
    testcommand:
        description: description of test command.
        permissions: permission.of.test.command

?

Just giving a few examples of things you would normally need to take note of when adding commands to your plugin. Maybe watch a few youtube videos about it? Bukkit has been around for quite awhile now, so maybe search for an already existing thread on this exact same forum that you posted a thread on?

TheBCBroz on youtube does some great plugin development videos, thenewboston does some great java tutorial videos, maybe those would be of some help to you.

 

Okay so this is the basics:

Code:java

public class classname extends JavaPlugin {
public void onEnable() {
PluginManager pm = getServer().getPluginManager();
//use this if the class file doesn't have a command, type this. If you are using this methord, then you have to let it implement Listener.
pm.registerEvents(new classname(), this);
//use this is the class file has a command. if it does type this. also you have to let the class implement CommandExecutor.
getCommand("example").setExecutor(new classname());
 
 
 
System.out.println("pluginname enabled!");
}
}

 

kevinspl2000

Code:java

//another way of putting it:
 
public ListenerClass lc;
public CommandClass cc;
 
public void onEnable(){
//ignore this. this is just how i code.
lc = new ListenerClass();
cc = new CommandClass();
//this is for registering events. e.g PlayerMoveEvent, BlockBreakEvent, etc.
getServer().getPluginManager().registerEvents(lc);
//this is for registering commands. don't forget to add it in the plugin.yml!
getCommand("testcommand").setExecutor(cc);
}
 

 

What is the point of adding the variable unless you are only using it more than once?

 

Posting the errors you are getting would help a lot. Just saying that there is an error wont help you at all

 

Ok. I'm home now, here's the codes and errors.

This is class called "Plugin" it's the main class of the plugin.

Code:java

package adriani6.zip1;
 
import org.bukkit.command.CommandExecutor;
import org.bukkit.plugin.PluginManager;
import org.bukkit.plugin.java.JavaPlugin;
 
public class Plugin extends JavaPlugin {
 
public void onEnable()
{
    PluginManager pm = getServer().getPluginManager();
 
    getCommand("backup").setExecutor((CommandExecutor) new Main());
 
    System.out.println("BackUp enabled!");
}
public void onDisable(){
    System.out.println("BackUp Disabled!");
}
}

This is class which I want to be ran at the start of the plugin, it's called "Main", I know how to add commands, no worry here.

Code:java

package adriani6.zip1;
import java.io.File;
import java.io.FileInputStream;
import java.io.FileOutputStream;
import java.util.zip.ZipEntry;
import java.util.zip.ZipOutputStream;
import org.bukkit.plugin.java.JavaPlugin;
 
 
public class Main extends JavaPlugin {
  public static void main(String[] a) throws Exception {
    zipFolder("C:/Users/Adriani6/Desktop/1", "c:\\Users/Adriani6/Desktop/a.zip");
  }
 
  static public void zipFolder(String srcFolder, String destZipFile) throws Exception {
    ZipOutputStream zip = null;
    FileOutputStream fileWriter = null;
 
    fileWriter = new FileOutputStream(destZipFile);
    zip = new ZipOutputStream(fileWriter);
 
    addFolderToZip("", srcFolder, zip);
    zip.flush();
    zip.close();
  }
 
  static private void addFileToZip(String path, String srcFile, ZipOutputStream zip)
      throws Exception {
 
    File folder = new File(srcFile);
    if (folder.isDirectory()) {
      addFolderToZip(path, srcFile, zip);
    } else {
      byte[] buf = new byte[1024];
      int len;
      FileInputStream in = new FileInputStream(srcFile);
      zip.putNextEntry(new ZipEntry(path + "/" + folder.getName()));
      while ((len = in.read(buf)) > 0) {
        zip.write(buf, 0, len);
      }
    }
  }
 
  static private void addFolderToZip(String path, String srcFolder, ZipOutputStream zip)
      throws Exception {
    File folder = new File(srcFolder);
 
    for (String fileName : folder.list()) {
      if (path.equals("")) {
        addFileToZip(folder.getName(), srcFolder + "/" + fileName, zip);
      } else {
        addFileToZip(path + "/" + folder.getName(), srcFolder + "/" + fileName, zip);
      }
    }
  }
}

Now the Error....

Code:

2013-10-09 00:42:53 [INFO] [AI6BACKUP] Enabling AI6BACKUP v0.1
2013-10-09 00:42:53 [SEVERE] Error occurred while enabling AI6BACKUP v0.1 (Is it up to date?)
java.lang.ClassCastException: adriani6.zip1.Main cannot be cast to org.bukkit.command.CommandExecutor
    at adriani6.zip1.Plugin.onEnable(Plugin.java:14)
    at org.bukkit.plugin.java.JavaPlugin.setEnabled(JavaPlugin.java:217)
    at org.bukkit.plugin.java.JavaPluginLoader.enablePlugin(JavaPluginLoader.java:457)
    at org.bukkit.plugin.SimplePluginManager.enablePlugin(SimplePluginManager.java:381)
    at org.bukkit.craftbukkit.v1_6_R2.CraftServer.loadPlugin(CraftServer.java:282)
    at org.bukkit.craftbukkit.v1_6_R2.CraftServer.enablePlugins(CraftServer.java:264)
    at net.minecraft.server.v1_6_R2.MinecraftServer.l(MinecraftServer.java:313)
    at net.minecraft.server.v1_6_R2.MinecraftServer.f(MinecraftServer.java:290)
    at net.minecraft.server.v1_6_R2.MinecraftServer.a(MinecraftServer.java:250)
    at net.minecraft.server.v1_6_R2.DedicatedServer.init(DedicatedServer.java:151)
    at net.minecraft.server.v1_6_R2.MinecraftServer.run(MinecraftServer.java:391)
    at net.minecraft.server.v1_6_R2.ThreadServerApplication.run(SourceFile:582)

Goblom kevinspl2000 xigsag metalhedd

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

You can't have 2 class that extend JavaPlugin, only 1. Main should implement the CommandExecutor or TabExecutor interface instead.

 

Normally, I use it more than once in my plugins. I also use them in the main class itself, so it would be easier for me to create variables. It is just my way of doing things. I just included it there, together with the comment which tells you to ignore it unless you understand what it means.

Adriani6

Code:java

public class Main() extends JavaPlugin implements CommandExecutor, Listener{
 
public void onEnable(){
getServer().getPluginManager().registerEvents(this, this);
getCommand("backup").setExecutor(this);
// although the .setExecutor() part is not required if your main class is the commandexecutor.
}
 
public boolean onCommand(CommandSender sender, Command cmd, String label, String[] args){
if(sender instanceof Player){
Player p = (Player) sender;
 
if(label.equalsIgnoreCase("backup")){
//insert backup code here
}
 
}
}
 
@EventHandler
public void onBlockBreak(BlockBreakEvent e){
//example event
}
 
}

I just crammed the commandexecutor and the events listener into one class. If you want it to be tidy, split them up into different classes.

EDIT:

By the way, I just noticed. You casted CommandExecutor on the getCommand() method. You have to implement it, not cast it. Implement it in the class like this:

Code:java

public class CommandClass() implements CommandExecutor{
Plugin javaplugin_extended_class;
public CommandClass(Plugin javaplugin_extended_class){
this.javaplugin_extended_class = javaplugin_extended_class;
}
 
public boolean onCommand(CommandSender sender, Command cmd, String label, String[] args){
//yada yada yada.
}
}

That should be the problem. Although you might have already fixed it by now.

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

Your main class is written like a Java Application not a bukkit plugin. Here are a few things missing

Code:java

public class BackupCommand implements CommandExecutor

Code:java

public boolean onCommand(CommandSender sender, Command cmd, String label, String[] args)

With the current "Main" class you would want to run the "zipFolder(String, String);"

Code:java

public boolean onCommand(CommandSender sender, Command cmd, String label, String[] args) {
  if (args.length == 3) {
      zipFolder(args[1].toString(), args[2].toString());
      return true;
  }
  return false;
}

 

Goblom
Well damn, that explained everything I typed in that single post.

 

Ok. I feel like an absolute ass asking over and over again, but please understand that this is my first bukkit plugin, on this scale

Code:java

package adriani6.Main;
 
import org.bukkit.command.Command;
import org.bukkit.command.CommandExecutor;
import org.bukkit.command.CommandSender;
import org.bukkit.entity.Player;
import org.bukkit.event.EventHandler;
import org.bukkit.event.Listener;
import org.bukkit.plugin.java.JavaPlugin;
import java.io.File;
import java.io.FileInputStream;
import java.io.FileNotFoundException;
import java.io.FileOutputStream;
import java.io.IOException;
import java.util.ArrayList;
import java.util.List;
import java.util.zip.ZipEntry;
import java.util.zip.ZipOutputStream;
 
public class Main extends JavaPlugin implements CommandExecutor, Listener {
 
    public void onEnable(){
        getServer().getPluginManager().registerEvents(this, this);
        getCommand("backup").setExecutor(this);
    }
 
public boolean onCommand(CommandSender sender, Command cmd, String label, String[] args){
    if(sender instanceof Player){
        Player p = (Player) sender;
 
        if(label.equalsIgnoreCase("backup")){
 
        return true;
        public static void main(String[] args) throws IOException {
            File directoryToZip = new File("C:\\projects\\workspace\\testing\\stuff");
 
            List<File> fileList = new ArrayList<File>();
            System.out.println("---Getting references to all files in: " + directoryToZip.getCanonicalPath());
            getAllFiles(directoryToZip, fileList);
            System.out.println("---Creating zip file");
            writeZipFile(directoryToZip, fileList);
            System.out.println("---Done");
        }
 
        public static void getAllFiles(File dir, List<File> fileList) {
            try {
                File[] files = dir.listFiles();
                for (File file : files) {
                    fileList.add(file);
                    if (file.isDirectory()) {
                        System.out.println("directory:" + file.getCanonicalPath());
                        getAllFiles(file, fileList);
                    } else {
                        System.out.println("    file:" + file.getCanonicalPath());
                    }
                }
            } catch (IOException e) {
                e.printStackTrace();
            }
        }
 
        public static void writeZipFile(File directoryToZip, List<File> fileList) {
 
            try {
                FileOutputStream fos = new FileOutputStream(directoryToZip.getName() + ".zip");
                ZipOutputStream zos = new ZipOutputStream(fos);
 
                for (File file : fileList) {
                    if (!file.isDirectory()) { // we only zip files, not directories
                        addToZip(directoryToZip, file, zos);
                    }
                }
 
                zos.close();
                fos.close();
            } catch (FileNotFoundException e) {
                e.printStackTrace();
            } catch (IOException e) {
                e.printStackTrace();
            }
        }
 
        public static void addToZip(File directoryToZip, File file, ZipOutputStream zos) throws FileNotFoundException,
                IOException {
 
            FileInputStream fis = new FileInputStream(file);
 
            // we want the zipEntry's path to be a relative path that is relative
            // to the directory being zipped, so chop off the rest of the path
            String zipFilePath = file.getCanonicalPath().substring(directoryToZip.getCanonicalPath().length() + 1,
                    file.getCanonicalPath().length());
            System.out.println("Writing '" + zipFilePath + "' to zip file");
            ZipEntry zipEntry = new ZipEntry(zipFilePath);
            zos.putNextEntry(zipEntry);
 
            byte[] bytes = new byte[1024];
            int length;
            while ((length = fis.read(bytes)) >= 0) {
                zos.write(bytes, 0, length);
            }
 
            zos.closeEntry();
            fis.close();
        }
 
 
        }
        return false;
 
 
 
    }
}
}
}
 
 
 
 
 
 
 

I made it all into one class, to save hussle. But new error came up. I have literally no idea how to fix it, but probably it's simple as hell.

Code:

2013-10-10 23:29:01 [SEVERE] Could not load 'plugins\AI6BACKUP.jar' in folder 'plugins'
org.bukkit.plugin.InvalidPluginException: java.lang.Error: Unresolved compilation problems:
    Syntax error, insert "}" to complete Statement
    Syntax error, insert "else Statement" to complete IfStatement
    Syntax error, insert "}" to complete Statement
    Syntax error, insert "else Statement" to complete BlockStatements
    Syntax error, insert "}" to complete MethodBody
 
    at org.bukkit.plugin.java.JavaPluginLoader.loadPlugin(JavaPluginLoader.java:182)
    at org.bukkit.plugin.SimplePluginManager.loadPlugin(SimplePluginManager.java:305)
    at org.bukkit.plugin.SimplePluginManager.loadPlugins(SimplePluginManager.java:230)
    at org.bukkit.craftbukkit.v1_6_R2.CraftServer.loadPlugins(CraftServer.java:239)
    at org.bukkit.craftbukkit.v1_6_R2.CraftServer.<init>(CraftServer.java:217)
    at net.minecraft.server.v1_6_R2.PlayerList.<init>(PlayerList.java:56)
    at net.minecraft.server.v1_6_R2.DedicatedPlayerList.<init>(SourceFile:11)
    at net.minecraft.server.v1_6_R2.DedicatedServer.init(DedicatedServer.java:106)
    at net.minecraft.server.v1_6_R2.MinecraftServer.run(MinecraftServer.java:391)
    at net.minecraft.server.v1_6_R2.ThreadServerApplication.run(SourceFile:582)
Caused by: java.lang.Error: Unresolved compilation problems:
    Syntax error, insert "}" to complete Statement
    Syntax error, insert "else Statement" to complete IfStatement
    Syntax error, insert "}" to complete Statement
    Syntax error, insert "else Statement" to complete BlockStatements
    Syntax error, insert "}" to complete MethodBody
 
    at adriani6.Main.Main.<init>(Main.java:30)
    at sun.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method)
    at sun.reflect.NativeConstructorAccessorImpl.newInstance(Unknown Source)
    at sun.reflect.DelegatingConstructorAccessorImpl.newInstance(Unknown Source)
    at java.lang.reflect.Constructor.newInstance(Unknown Source)
    at org.bukkit.plugin.java.JavaPluginLoader.loadPlugin(JavaPluginLoader.java:178)
    ... 9 more

Help again pleaseeeeees.

 

What the hell. You can't just drop the entire contents of your original CLASS into a METHOD body.

 

No offense, Adriani6, but do you know java to begin with? Doesn't seem so.. You should probably go learn some java first, 'cos these are pretty beginner level java mistakes.

And you cant drop a method into a method.

Code:java

public boolean onCommand(blah bla){
//this is a method.
 
public static void blahblah(){
//this is a method in a method.
//this is what you are doing.
//this is wrong.
}
 
}

Imagine a container being the method. You don't normally put a glass jar inside a glass jar, now do you? Unless you do, then I have nothing to say.. but in a normal situation, you don't.

 

I know basics. Just a beginner with java. Thanks for explanation, i got it now

 

What is the purpose of his plugin?

 

lycano
Apparently, to back up stuff.

 

Oh i see, thank you.