Updating Inventory Problems And Other Stuff

So I have tried for god knows how long to fix this problem but it seems to be recuring. when a player right clicks the piston, it gives them the message, but doesn't take the ingots and doesn't give them the random item, but when i relog, it gives the items and doesn't take the ingots, i tried player.updateInventory() but that's deprived, can someone take a look at my code and help me fix this? I've tried returning it and all sorts but nothing seems to work.

Thanks

- Mat



Code \/

Code:java

package me.mat.mysterybox;
 
import java.util.ArrayList;
import java.util.Arrays;
import java.util.List;
import java.util.Random;
 
import org.bukkit.ChatColor;
import org.bukkit.Material;
import org.bukkit.block.Block;
import org.bukkit.entity.Player;
import org.bukkit.event.EventHandler;
import org.bukkit.event.Listener;
import org.bukkit.event.block.Action;
import org.bukkit.event.player.PlayerInteractEvent;
import org.bukkit.inventory.Inventory;
import org.bukkit.inventory.ItemStack;
import org.bukkit.inventory.PlayerInventory;
 
public class BoxListener implements Listener {
 
    public String Prefix = ChatColor.RED + "[" + ChatColor.GOLD + "Mystery" + ChatColor.DARK_AQUA + "Box" + ChatColor.RED + "] ";
 
 
 
 
    Random random = new Random();
    List<Material> itemMaterials = Arrays.asList(Material.DIRT, Material.STONE, Material.DIAMOND);
 
 
 
    @EventHandler
    public void BoxInteract(PlayerInteractEvent event) {
        Player player = event.getPlayer();
        Action action = event.getAction();
        Inventory inv = player.getInventory();
        PlayerInventory pi = player.getInventory();
        Material block = event.getClickedBlock().getType();
        if(action == Action.RIGHT_CLICK_BLOCK) {
            if(block == Material.PISTON_BASE) {       
                if (player.getInventory().contains(Material.GOLD_INGOT, 35)) {
 
                    player.sendMessage(Prefix + ChatColor.RED + "Thanks For Ya Business Kid");
 
                    player.getInventory().removeItem(new ItemStack(Material.GOLD_INGOT, 35));
 
 
 
                    player.getInventory().addItem(new ItemStack(itemMaterials.get(this.random.nextInt(itemMaterials.size()))));
 
                }
 
 
 
                else if (!player.getInventory().contains(Material.GOLD_INGOT, 35)) {
 
                    player.sendMessage(Prefix + ChatColor.RED + "You Do Not Have 35 Gold Ingots");
 
                }
 
            } return;
 
        } return;
 
    }
 
}
 

 

I would either use player.updateInventory() (who needs Bukkit deprecations when you can yolo) or make schedule a 5 tick delayed task that removes the item then adds the new item.

Change "Player player = event.getPlayer()" into "final Player player = event.getPlayer()"
Where you're adding the items, replace it with:

Code:

player.getServer().getScheduler().runTaskLater(plugin, new Runnable() {
    public void run() {
        if (player != null && player.isOnline()) {
            player.getInventory().removeItem(new ItemStack(Material.GOLD_INGOT, 35));
            player.getInventory().addItem(new ItemStack(itemMaterials.get(random.nextInt(itemMaterials.size()))));
        }
    }
}, 2L);

 

KingFaris11


how would i make a delayed task? just add them to an array list and run it using the scheduler? I'm not too good with that could you show me how i would do that in my code?

OMG I YOLO'd it and it worked DD I cannot thank you enough, I am so happy right now ))))

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

Already did so. Edited.

 

Tip Of The Day: When In Doubt, Yolo Bukkit Deprications.