[TUTORIAL] Safe Commands

I see and I am also guilty of writing terrible commands because I was too lazy to write a couple more lines of code. Also enabling a plugin on a server with no Console commands sucks and it's not the hard to allow admins to do stuff from console.
First, the onCommand methd:

Code:java

@Override
public boolean onCommand(CommandSender sender, Command cmd, String string, String[] arg)
 

Not too hard?
Second, if statements:

Code:java

@Override
public boolean onCommand(CommandSender sender, Command cmd, String string, String[] arg){
    if(sender instanceof ConsoleCommandSender{
          if(cmd.getName().equalsIgnoreCase("bawse"){
             if(args.length > 1) {
               if(args[0].equalsIgnoreCase("stop"){
            //whatever
       }     
     }
    }
 } else {
 //samething
}
return true;
}
 

Thats a lot better than:

Code:java

//...method
if(cmd.getName().toLowerCase().equals("bawse"){
}
 

Because you have widdled out; the sender, the command name, and args length! In the above example the sender can be either one, and you have no idea how many args there will be.

Errors that I commonly see and I have learned from:

Code:java

 @Override
public boolean onCommand(CommandSender sender, Command cmd, String string, String[] args){
    Player target = (Bukkit.getServer().getPlayer(args[0]));
       if//....
}

That code will throw an ArrayIndexOutOfBoundsException because you don't know if there are more than one args. You need to define your variable after you "if(args.length...)" statment. Avoid args.length ==, because it will save you time in the future.

If you can think of anymore things that will benefit this tutorial don't be afraid to share.

 

Theres an error in you code, I think, you missed the if-closing ) on line 3 in your second code block.

 

This are just examples, no one has said that these examples also compile...

 

I just said that there is a bug, not critilized his work ...