Tokens Shop

I am having a plugin yml problem here is my error it says invalild plugin yml here is my plugin yml

Code:

name: MC-Tokens
version: 1.0
main: me.JoeyLangston.MCTokens.Shop
description: A really cool eco system
author: Joey Langston
 
commands:
  tokens shop:
    description: open up
    aliases: [t-shop]

 

XgXXSnipz Provide the full error and put it through this

 

Your name as to be the same as your plugins main class (the one that extends JavaPlugin).

 

Oh nvm I got it

But now i have a question every thing works fine just one thing, IM horrible with integers so this is why i need help here is my class files

Code:java

package me.JoeyLangston.MCTokens;
 
import java.util.ArrayList;
 
import org.bukkit.Bukkit;
import org.bukkit.Material;
import org.bukkit.command.Command;
import org.bukkit.command.CommandSender;
import org.bukkit.configuration.file.FileConfiguration;
import org.bukkit.entity.Player;
import org.bukkit.event.Listener;
import org.bukkit.inventory.Inventory;
import org.bukkit.inventory.ItemStack;
import org.bukkit.inventory.meta.ItemMeta;
import org.bukkit.plugin.java.JavaPlugin;
 
public class Shop extends JavaPlugin implements Listener {
 
 
    public static FileConfiguration config;
 
    public static Shop plugin = null;
 
    public void onEnable() {
        getServer().getPluginManager().registerEvents(new EventHandlers(), this);
 
        config = getConfig();
 
        plugin = this;
    }
 
    public static void saveFile(){
        plugin.saveConfig();
    }
 
    public ItemStack createItem(Material material, int amount, short shrt,
            String displayname, String lore) {
        ItemStack item = new ItemStack(material, amount, (short) shrt);
        ItemMeta meta = item.getItemMeta();
        meta.setDisplayName(displayname);
        ArrayList<String> Lore = new ArrayList<String>();
        Lore.add(lore);
        meta.setLore(Lore);
 
        item.setItemMeta(meta);
        return item;
    }
 
    static Inventory Shop;
    {
        Shop = Bukkit.createInventory(null, 9, "§0§nMC-Tokens Store");
 
        Shop.setItem(0, createItem(Material.APPLE, 1, (short) 0, "§3GodApple","§fPrice §2 §fTokens"));
    }
 
    public boolean onCommand(CommandSender sender, Command cmd, String label, String[] a) {
        Player player = (Player) sender;
        if (cmd.getName().equalsIgnoreCase("token shop")) {
            player.openInventory(Shop);
        }
        return false;
    }
 
}
 

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

You cant have a space in your command....

 

Here is second class

Code:java

package me.JoeyLangston.MCTokens;
 
import org.bukkit.ChatColor;
import org.bukkit.entity.Player;
import org.bukkit.event.EventHandler;
import org.bukkit.event.Listener;
import org.bukkit.event.inventory.InventoryClickEvent;
import org.bukkit.event.player.PlayerJoinEvent;
 
public class EventHandlers implements Listener {
 
 
 
    //The place to buy and store player info
 
    @EventHandler
    public void onJoin(PlayerJoinEvent e) {
        Player p = e.getPlayer();
 
        if (!Shop.config.contains(p.getName())) {
            Shop.config.set(p.getName() + ".Tokens", 0);
        }
    }
 
    @EventHandler
    public void onClick(InventoryClickEvent event) {
        Player p = (Player) event.getWhoClicked();
 
        if (event.getInventory().getName().equals(Shop.Shop.getName())) {
            event.setCancelled(true);
 
            if (event.getCurrentItem() == null) {
                return;
            }
 
            if (!(event.getCurrentItem().hasItemMeta())) {
                return;
            }
 
            if (event.getCurrentItem().getItemMeta().getDisplayName().equals("§3GodApple")) {
                if (MyAPI.hasEnough(p, 2)) {
                    MyAPI.takeSilver(p, 2);
                    p.sendMessage(ChatColor.YELLOW + "You bought the item GodApple for 2 coins");
 
                } else {
                    p.sendMessage("§cYou dont have enough :(!");
                }
            }
        }
    }
 
}
 

Last class file

Code:java

package me.JoeyLangston.MCTokens;
 
import org.bukkit.entity.Player;
 
public class MyAPI {
 
 
    //The config stuff and the money storage
 
    public static void giveSilver(Player p, int i) {
        Shop.config.set(p.getName() + ".Tokens",
                Shop.config.getInt(p.getName() + ".Tokens", 0) + i);
        Shop.saveFile();
        p.sendMessage("§2§l$" + i + " tokens received!");
    }
 
    public static void takeSilver(Player p, int i) {
        Shop.config.set(p.getName() + ".Tokens",
                Shop.config.getInt(p.getName() + ".Tokens", 0) - i);
        Shop.saveFile();
        p.sendMessage("§c§l$" + i + " tokens taken!");
    }
 
    public static boolean hasEnough(Player p, int i) {
        if (Shop.config.getInt(p.getName() + ".Tokens") >= i)
            return true;
        return false;
    }
 
}
 

So my question is, in the MyAPI class how would I add another method so that you can give the money, and another one to check how much money you have

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

One tip for you: You should use a static HashMap to manage players money while they are on the server. This brings faster access times and the plugin doesn't need to access the config file everytime.

To your question: You already implemented giveSilver() and takeSilver()? So, where is the problem in adding just another method getSilver()?

 

Noxyro Can you help

Ya but I dont know how you would do that or to give silver

This is what I have for check how much silver

Code:java

public static boolean getSilver(Player p, int i) {
        Shop.config.getInt(p.getName() + ".Tokens");
        return false;

Think this will work

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

So, you just check if the player has true silver or false silver, but whatever you load from config it will always say false? ... interesting

 

Lol but will that work?

 

It was a hint that you messed up...
If you don't get what I meant with it, then you should overthink your Basic Bukkit API and Java knowledge.

 

The FileConfiguration object he is accessing is saved in memory

 

Oh, you're right ^^
I just thought about the config file ... shame on me >.>
But still, it's faster access and short code (in most cases)

 

OK so can you just tell me how to fix?

Im so confused!!!!!
Oh and how do I make it so you can give people tokens

How can I make a command to give them tokens using my original code and not getting rid of the config

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

I was bored, so I rewrote your complete MyAPI to a MoneyAPI.

PLEASE, don't just copy and paste it into your project without reading it or without the try of understanding what this API does at which point.


I've created the commentary for a reason!

Code:java

import java.util.HashMap;
import java.util.Map;
 
import org.bukkit.entity.Player;
 
/**
* @author Noxyro
* Written for XgXXSnipz as an answer to his topic in Bukkit forums.<br>
* [URL]http://forums.bukkit.org/threads/247334/[/URL]
*
* This class can handle simple money amounts of players.<br>
* Requires a valid FileConfiguration to work properly.
*
*/
public class MoneyAPI {
    private static Map<String, Integer> moneyMap;
 
    /* Private access methods */
 
    /**
    * Gets the map with all loaded player money values.
    * @return Map<String, Integer> moneyMap
    */
    private static Map<String, Integer> getMoneyMap() {
        // Checks if the money map exists
        if (moneyMap == null) {
            // Creates a new HashMap, because there is no existing money map
            setMoneyMap(new HashMap<String, Integer>());
        }
 
        return moneyMap;
    }
 
    /**
    * Sets and replaces the current map with all player money values.
    * @param Map<String, Integer> moneyMap
    */
    private static void setMoneyMap(Map<String, Integer> map) {
        moneyMap = map;
    }
 
    /* Direct access methods */
 
    /**
    * Gets the money of a specific player by his name.<br>
    * If the player is already in the money map it will get the players money out of the map.<br>
    * If the player is not in the money map it will load his money map from the FileConfiguration.<br>
    * <p>
    * Returns 0 if an error occurred or no saved money value was found.
    * @param String name
    * @return Integer money
    */
    public static int getMoney(String name) {
        // Checks if the name is already inside the money map
        if (getMoneyMap().containsKey(name)) {
            // Returns the money of the found player
            return getMoneyMap().get(name);
        // No entry was found
        } else {
            // Try and catch, because the FileConfiguration could be invalid or null
            try {
                // Checks if the FileConfiguration contains the given name
                if (Shop.config.getKeys(false).contains(name)) {
                    // Checks if the name section contains a "Tokens" section
                    if (Shop.config.getConfigurationSection(name).getKeys(false).contains("Tokens")) {
                        // Get the tokens as integer from the FileConfiguration
                        int tokens = Shop.config.getInt(name+".Tokens");
                        // Sets and therefore creates an entry with the given name and tokens inside the money map
                        setMoney(name, tokens);
                        return tokens;
                    // No "Tokens" section was found and therefore no tokens values is existent
                    } else {
                        // Sets and creates an entry with the given name and 0 tokens inside the money map
                        setMoney(name, 0);
                        // Creates the "Tokens" section inside the FileConfiguration
                        Shop.config.set(name+".Tokens", 0);
                        return 0;
                    }
                // No section with the given name was found
                } else {
                    // Sets and creates an entry with the given name and 0 tokens inside the money map
                    setMoney(name, 0);
                    // Creates the name and "Tokens" sections inside the FileConfiguration
                    Shop.config.set(name+".Tokens", 0);
                    return 0;
                }
            // Something went very wrong and the FileConfiguration or something else created an error
            } catch (Exception ex) {
                // Print error into console for debug reasons
                ex.printStackTrace();
                System.out.println("Invalid config data!");
                // Return 0 as last option
                return 0;
            }
        }
    }
 
    /**
    * Gets the money of a specific player.<br>
    * If the player is already in the money map it will get the players money out of the map.<br>
    * If the player is not in the money map it will load his money from the FileConfiguration and then put it into the money map.<br>
    * <p>
    * Returns 0 if an error occurred or no saved money value for the player was found inside the FileConfiguration.
    * @param Player player
    * @return Integer money
    */
    public static int getMoney(Player player) {
        return getMoney(player.getName());
    }
 
    /**
    * Sets the money of a specific player by his name.
    * @param String name
    * @param Integer amount
    */
    public static void setMoney(String name, int amount) {
        getMoneyMap().put(name, amount);
    }
 
    /**
    * Sets the money of a specific player.
    * @param Player player
    * @param Integer amount
    */
    public static void setMoney(Player player, int amount) {
        setMoney(player.getName(), amount);
    }
 
    /* Simple access methods */
 
    /**
    * Gives the specified player with the given name the given amount of money.
    * <p>
    * Automatically caps the money at Integer.MAX_VALUE.
    * @param String name
    * @param Integer amount
    */
    public static void giveMoney(String name, int amount) {
        int money = getMoney(name) + amount;
        setMoney(name, (money <= Integer.MAX_VALUE ? money : Integer.MAX_VALUE));
    }
 
    /**
    * Gives the specified player the given amount of money.
    * <p>
    * Automatically caps the money at Integer.MAX_VALUE.
    * @param Player player
    * @param Integer amount
    */
    public static void giveMoney(Player player, int amount) {
        int money = getMoney(player) + amount;
        setMoney(player, (money <= Integer.MAX_VALUE ? money : Integer.MAX_VALUE));
    }
 
    /**
    * Takes from the specified player with the given name the given amount of money.
    * <p>
    * Automatically caps the money at 0.
    * @param String name
    * @param Integer amount
    */
    public static void takeMoney(String name, int amount) {
        int money = getMoney(name) - amount;
        setMoney(name, (money >= 0 ? money : 0));
    }
 
    /**
    * Takes from the specified player the given amount of money.
    * <p>
    * Automatically caps the money at 0.
    * @param Player player
    * @param Integer amount
    */
    public static void takeMoney(Player player, int amount) {
        int money = getMoney(player) - amount;
        setMoney(player, (money >= 0 ? money : 0));
    }
}

Also, I don't guarantee that this is 100% flawless.

XgXXSnipz I forgot to add a method that actually saves the values from the map to the config.

Code:java

/**
    * Saves all money values from the money map to the FileConfiguration.
    */
    public static void saveMoneyValues() {
        for (String name : getMoneyMap().keySet()) {
            Shop.config.set(name+".Tokens", getMoney(name));
        }
    }

Add this somewhere to MoneyAPI.

Also, I'm writting an example for your command part at the moment.

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

Thx

Thanks so much! So this class file has the ability to give and check how many tokens right, and this will work with my other class files right?

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

Here's the command part you asked for, again with complete commentary:

Code:java

// This is inside the main plugin class
    public boolean onCommand(CommandSender sender, Command cmd, String label, String[] args) {
        // Check if sender is a player first
        if (sender instanceof Player) {
            // Cast sender to Player
            Player player = (Player) sender;
            // Check if the command was "tokens"
            if (cmd.getName().equalsIgnoreCase("tokens")) {
                // Check if no arguments are given
                if (args.length == 0) {
                    // Return current owned tokens
                    player.sendMessage("Your current tokens: " + MoneyAPI.getMoney(player));
                    return true;
                // Check if 1 argument is given
                } else if (args.length == 1) {
                    // Argument 1 is the name
                    String name = args[0];
                    // Get the player with the given name from server
                    Player target = Bukkit.getServer().getPlayer(name);
                    // Check if player is online
                    if (target != null) {
                        // Get the tokens of the player
                        player.sendMessage(target.getDisplayName() + "'s current tokens: " + MoneyAPI.getMoney(target));
                        return true;
                    // The player with the given name is not online that means target == null
                    } else {
                        // Return that the player is currently not online
                        player.sendMessage("The player " + name + " is currently not online!");
                        return true;
                    }
                // Check if 2 arguments are given
                } else if (args.length == 2) {
                    player.sendMessage("You have to specify the amount of money!");
                    return true;
                // Check if 3 arguments are given
                } else if (args.length >= 3) {
                    // Try and catch here, because parsing could always return an invalid result and therefore an error
                    try {
                        // Parse an integer from argument 3
                        int amount = Integer.parseInt(args[2]);
                        // Check if the amount is not negative
                        if (amount > 0) {
                            // Check if the player has enough money
                            if (MoneyAPI.getMoney(player) >= amount) {
                                // Argument 2 is the name
                                String name = args[1];
                                // Get the player with the given name from the server
                                Player target = Bukkit.getServer().getPlayer(name);
                                // Check if the player is online
                                if (target != null) {
                                    // Check if the sub-command "give" was used
                                    if (args[0].equalsIgnoreCase("give")) {
                                        // Take money from the player and give money to the target and send both a notification message
                                        MoneyAPI.takeMoney(player, amount);
                                        MoneyAPI.giveMoney(target, amount);
                                        player.sendMessage("You sent " + target.getName() + " an amount of " + amount + " tokens!");
                                        target.sendMessage("You received " + amount + " tokens from " + player.getName() + "!");
                                        return true;
                                    // Check if the sub-command "take" was used
                                    } else if (args[0].equalsIgnoreCase("take")) {
                                        // Check if the player has the permission to use this sub-command or is OP
                                        if (player.hasPermission("tokenshop.take") || player.isOp()) {
                                            // Take money from the target and give money to the player and send both a notification message
                                            MoneyAPI.giveMoney(player, amount);
                                            MoneyAPI.takeMoney(target, amount);
                                            player.sendMessage("You took" + amount + " tokens from " + player.getName() + "!");
                                            target.sendMessage(player.getName() + " took " + amount + " tokens from you!");
                                            return true;
                                        // The player has not the right permissions
                                        } else {
                                            target.sendMessage("You're missing the permission to take money from other!");
                                            return true;
                                        }
                                    }
                                // The player with the given name is not online that means target == null
                                } else {
                                    // Return that the player is currently not online
                                    player.sendMessage("The player " + name + " is currently not online!");
                                    return true;
                                }
                            // The player has not enough money
                            } else {
                                // Return that the player does not have enough money
                                player.sendMessage("You don't have enough money! You're missing: " + (amount-MoneyAPI.getMoney(player)) + " tokens.");
                                return true;
                            }
                        // The player typed in a negative amount or 0
                        } else {
                            // Return that the amount has to be higher than 0
                            player.sendMessage("The money amount has to be higher than 0!");
                            return true;
                        }
                    // The player typed in an invalid money amount
                    } catch (Exception ex) {
                        // Return that the money amount is invalid
                        player.sendMessage("Invalid money amount!");
                        return true;
                    }
                }
            }
        }
 
        // At this point the plugin just returns the command typed in into the chat, because something went pretty wrong!!!
        return false;
    }

Have fun with it, and even more important: LEARN FROM IT!

 

Thx so much

So I don't need MyAPI anymore?

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

No. I replaced it with MoneyAPI which I think is a more matching name for your needs.

 

Oh ok 1 more question (Wrong thread) on hypixels new mini game arena brawl how did he make floating blocks that didn't disappear and then add floating names to them?

 

Stick to simple plugins first, please.
But, he probably made FallingBlocks or custom Entities and modified them with NMS packets so that they have floating names above them.

 

Sorry to ask but whats the method for has money cause for my shop the player needs to have enough

 

Add this to MoneyAPI:

Code:java

/**
    * Checks if a player with the given name has the specified amount of money
    * @return Boolean hasMoney
    */
    public static boolean hasMoney(String name, int amount) {
        return (getMoney(name) >= amount);
    }
 
    /**
    * Checks if a player has the specified amount of money
    * @return Boolean hasMoney
    */
    public static boolean hasMoney(Player player, int amount) {
        return (getMoney(player) >= amount);
    }

Now you can use:

Code:java

MoneyAPI.hasMoney(player, 25);
// or
MoneyAPI.hasMoney(playerName, 12);

 

thank you, your a real help

OH AND ONE LAST THING WHAT WOULD BE THE COMMAND TO GIVE YOURSELF MONEY

I now just though why not use the send command, well I mean like to give yourself Coins(for the staff)

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

Replace:

Code:java

// Check if the sub-command "give" was used
                                    if (args[0].equalsIgnoreCase("give")) {
                                        // Take money from the player and give money to the target and send both a notification message
                                        MoneyAPI.takeMoney(player, amount);
                                        MoneyAPI.giveMoney(target, amount);
                                        player.sendMessage("You sent " + target.getName() + " an amount of " + amount + " tokens!");
                                        target.sendMessage("You received " + amount + " tokens from " + player.getName() + "!");
                                        return true;
                                    // Check if the sub-command "take" was used
                                    } else if (args[0].equalsIgnoreCase("take")) {
                                        // Check if the player has the permission to use this sub-command or is OP
                                        if (player.hasPermission("tokenshop.take") || player.isOp()) {
                                            // Take money from the target and give money to the player and send both a notification message
                                            MoneyAPI.giveMoney(player, amount);
                                            MoneyAPI.takeMoney(target, amount);
                                            player.sendMessage("You took " + amount + " tokens from " + player.getName() + "!");
                                            target.sendMessage(player.getName() + " took " + amount + " tokens from you!");
                                            return true;
                                        // The player has not the right permissions
                                        } else {
                                            target.sendMessage("You're missing the permission to take money from others!");
                                            return true;
                                        }
                                    }

With:

Code:java

// Check if the sub-command "give" was used
                                    if (args[0].equalsIgnoreCase("give")) {
                                        // Take money from the player and give money to the target and send both a notification message
                                        MoneyAPI.takeMoney(player, amount);
                                        MoneyAPI.giveMoney(target, amount);
                                        player.sendMessage("You sent " + target.getName() + " an amount of " + amount + " tokens!");
                                        target.sendMessage("You received " + amount + " tokens from " + player.getName() + "!");
                                        return true;
                                    // Check if the sub-command "take" was used
                                    } else if (args[0].equalsIgnoreCase("take")) {
                                        // Check if the player has the permission to use this sub-command or is OP
                                        if (player.hasPermission("tokenshop.take") || player.isOp()) {
                                            // Take money from the target and give money to the player and send both a notification message
                                            MoneyAPI.giveMoney(player, amount);
                                            MoneyAPI.takeMoney(target, amount);
                                            player.sendMessage("You took " + amount + " tokens from " + player.getName() + "!");
                                            target.sendMessage(player.getName() + " took " + amount + " tokens from you!");
                                            return true;
                                        // The player has not the right permissions
                                        } else {
                                            target.sendMessage("You're missing the permission to take money from others!");
                                            return true;
                                        }
                                    // Check if the sub-command "cheat" was used
                                    } else if (args[0].equalsIgnoreCase("cheat")) {
                                        // Check if the player has the permission to use this sub-command or is OP
                                        if (player.hasPermission("tokenshop.cheat") || player.isOp()) {
                                            // Give money to the player and send a notification message
                                            MoneyAPI.giveMoney(player, amount);
                                            // Check if the target is the player himself
                                            if (!target.getName().equalsIgnoreCase(player.getName())) {
                                                // Return a notification
                                                player.sendMessage("You cheated " + amount + " tokens for " + player.getName() + "!");
                                                return true;
                                            } else {
                                                // Return a notification
                                                player.sendMessage("You cheated " + amount + " tokens for yourself!");
                                                return true;
                                            }
                                        // The player has not the right permissions
                                        } else {
                                            target.sendMessage("You're missing the permission to cheat money!");
                                            return true;
                                        }
                                    // No valid sub-command was used
                                    } else {
                                        // Return that a valid sub-command must be used
                                        target.sendMessage("Please use a valid sub-command!");
                                        return true;
                                    }

Then you can use "/tokens cheat XgXXSipz 42".
Don't forget to change setup the command inside your plugins.yml

 

This is what I have will this work?

Code:java

    public boolean onCommand(CommandSender sender, Command cmd, String label, String[] args) {
        // Check if sender is a player first
        if (sender instanceof Player) {
            // Cast sender to Player
            Player player = (Player) sender;
            // Check if the command was "tokens"
            if (cmd.getName().equalsIgnoreCase("vt balance")) {
                // Check if no arguments are given
                if (args.length == 0) {
                    // Return current owned tokens
                    player.sendMessage("Your current tokens: " + MoneyAPI.getMoney(player));
                    return true;
                // Check if 1 argument is given
 
                    }
                // Check if 2 arguments are given
                } else if (args.length == 2) {
                    player.sendMessage("You have to specify the amount of money!");
                    return true;
                // Check if 3 arguments are given
                } else if (args.length >= 3) {
                    // Try and catch here, because parsing could always return an invalid result and therefore an error
                    try {
                        // Parse an integer from argument 3
                        int amount = Integer.parseInt(args[2]);
                        // Check if the amount is not negative
                        if (amount > 0) {
                            // Check if the player has enough money
                            if (MoneyAPI.getMoney(player) >= amount) {
                                // Argument 2 is the name
                                String name = args[1];
                                // Get the player with the given name from the server
                                Player target = Bukkit.getServer().getPlayer(name);
                                // Check if the player is online
                                if (target != null) {
                                    // Check if the sub-command "give" was used
                                    if (args[0].equalsIgnoreCase("give")) {
                                        // Take money from the player and give money to the target and send both a notification message
                                        MoneyAPI.takeMoney(player, amount);
                                        MoneyAPI.giveMoney(target, amount);
                                        player.sendMessage("You sent " + target.getName() + " an amount of " + amount + " tokens!");
                                        target.sendMessage("You received " + amount + " tokens from " + player.getName() + "!");
                                        return true;
                                    // Check if the sub-command "take" was used
                                    } else if (args[0].equalsIgnoreCase("vt take")) {
                                        // Check if the player has the permission to use this sub-command or is OP
                                        if (player.hasPermission("vt.take")) {
                                            // Take money from the target and give money to the player and send both a notification message
                                            MoneyAPI.giveMoney(player, amount);
                                            MoneyAPI.takeMoney(target, amount);
                                            player.sendMessage("You took" + amount + " tokens from " + player.getName() + "!");
                                            target.sendMessage(player.getName() + " took " + amount + " tokens from you!");
                                            return true;
                                        // The player has not the right permissions
                                        } else {
                                            target.sendMessage(ChatColor.RED + "Im sorry you do not have the correct permission to use this command if you belive this is an error please contact the" + ChatColor.GREEN + "the Devolper or the " + ChatColor.AQUA + "The owner of the server: Croffskin");
                                            return true;
                                        }
                                    }
                                // The player with the given name is not online that means target == null
                                } else {
                                    // Return that the player is currently not online
                                    player.sendMessage("The player " + name + " is currently not online!");
                                    return true;
                                }
                            // The player has not enough money
                            } else {
                                // Return that the player does not have enough money
                                player.sendMessage("You don't have enough money! You're missing: " + (amount-MoneyAPI.getMoney(player)) + " tokens.");
                                return true;
                            }
                        // The player typed in a negative amount or 0
                        } else {
                            // Return that the amount has to be higher than 0
                            player.sendMessage("The money amount has to be higher than 0!");
                            return true;
                        }
                    // The player typed in an invalid money amount
                    } catch (Exception ex) {
                        // Return that the money amount is invalid
                        player.sendMessage("Invalid money amount!");
                        return true;
                    }
                }
 
 
 
 
            int amount = Integer.parseInt(args[2]);
            // Check if the amount is not negative
            if (amount > 0) {
                // Check if the player has enough money
                if (MoneyAPI.getMoney(player) >= amount) {
                    // Argument 2 is the name
                    String name = args[1];
                    // Get the player with the given name from the server
                    Player target = Bukkit.getServer().getPlayer(name);
                    // Check if the player is online
                    if (target != null) {
 
                    }
              if (args[0].equalsIgnoreCase("vt give")) {
                  if (player.hasPermission("vt.give")) {
              }
                      MoneyAPI.giveMoney(target, amount);
                      target.sendMessage("You received " + amount + " tokens from " + player.getName() + "!");
              } else {
                  player.sendMessage(ChatColor.RED + "You do not have the right permission to give yourself tokens");
              }
 
 
                return true;
            }
 
    }
  }
        return false;
}
}

 

Please stick to the code I wrote just before and understand why I've created it that way.
Also, you can't use spaces inside your command and/or your arguments, because every space creates a new argument.

Here an example:

Input: /tokenshop take XgXXSnipz 42
Command: "tokenshop"
Arguments: [0]: "take", [1]: "XgXXSnipz", [2]: "42"

Input: /token shop vt take XgXXSnipz 42
Command: "token"
Arguments: [0]: "shop", [1]: "vt", [2]: "take", [3]: "XgXXSnipz", [4]: "42"

 

Im getting bracket errors on your code

 

Here's the complete onCommand() method again:

Code:java

 // This is inside the main plugin class
    public boolean onCommand(CommandSender sender, Command cmd, String label, String[] args) {
        // Check if sender is a player first
        if (sender instanceof Player) {
            // Cast sender to Player
            Player player = (Player) sender;
            // Check if the command was "tokens"
            if (cmd.getName().equalsIgnoreCase("tokens")) {
                // Check if no arguments are given
                if (args.length == 0) {
                    // Return current owned tokens
                    player.sendMessage("Your current tokens: " + MoneyAPI.getMoney(player));
                    return true;
                // Check if 1 argument is given
                } else if (args.length == 1) {
                    // Argument 1 is the name
                    String name = args[0];
                    // Get the player with the given name from server
                    Player target = Bukkit.getServer().getPlayer(name);
                    // Check if player is online
                    if (target != null) {
                        // Get the tokens of the player
                        player.sendMessage(target.getDisplayName() + "'s current tokens: " + MoneyAPI.getMoney(target));
                        return true;
                    // The player with the given name is not online that means target == null
                    } else {
                        // Return that the player is currently not online
                        player.sendMessage("The player " + name + " is currently not online!");
                        return true;
                    }
                // Check if 2 arguments are given
                } else if (args.length == 2) {
                    player.sendMessage("You have to specify the amount of money!");
                    return true;
                // Check if 3 arguments are given
                } else if (args.length >= 3) {
                    // Try and catch here, because parsing could always return an invalid result and therefore an error
                    try {
                        // Parse an integer from argument 3
                        int amount = Integer.parseInt(args[2]);
                        // Check if the amount is not negative
                        if (amount > 0) {
                            // Check if the player has enough money
                            if (MoneyAPI.getMoney(player) >= amount) {
                                // Argument 2 is the name
                                String name = args[1];
                                // Get the player with the given name from the server
                                Player target = Bukkit.getServer().getPlayer(name);
                                // Check if the player is online
                                if (target != null) {
                                    // Check if the sub-command "give" was used
                                    if (args[0].equalsIgnoreCase("give")) {
                                        // Take money from the player and give money to the target and send both a notification message
                                        MoneyAPI.takeMoney(player, amount);
                                        MoneyAPI.giveMoney(target, amount);
                                        player.sendMessage("You sent " + target.getName() + " an amount of " + amount + " tokens!");
                                        target.sendMessage("You received " + amount + " tokens from " + player.getName() + "!");
                                        return true;
                                    // Check if the sub-command "take" was used
                                    } else if (args[0].equalsIgnoreCase("take")) {
                                        // Check if the player has the permission to use this sub-command or is OP
                                        if (player.hasPermission("tokenshop.take") || player.isOp()) {
                                            // Take money from the target and give money to the player and send both a notification message
                                            MoneyAPI.takeMoney(target, amount);
                                            player.sendMessage("You took " + amount + " tokens from " + player.getName() + "!");
                                            target.sendMessage(player.getName() + " took " + amount + " tokens from you!");
                                            return true;
                                        // The player has not the right permissions
                                        } else {
                                            target.sendMessage("You're missing the permission to take money from others!");
                                            return true;
                                        }
                                    // Check if the sub-command "cheat" was used
                                    } else if (args[0].equalsIgnoreCase("cheat")) {
                                        // Check if the player has the permission to use this sub-command or is OP
                                        if (player.hasPermission("tokenshop.cheat") || player.isOp()) {
                                            // Give money to the player and send a notification message
                                            MoneyAPI.giveMoney(player, amount);
                                            // Check if the target is the player himself
                                            if (!target.getName().equalsIgnoreCase(player.getName())) {
                                                // Return a notification
                                                player.sendMessage("You cheated " + amount + " tokens for " + player.getName() + "!");
                                                return true;
                                            } else {
                                                // Return a notification
                                                player.sendMessage("You cheated " + amount + " tokens for yourself!");
                                                return true;
                                            }
                                        // The player has not the right permissions
                                        } else {
                                            target.sendMessage("You're missing the permission to cheat money!");
                                            return true;
                                        }
                                    // No valid sub-command was used
                                    } else {
                                        // Return that a valid sub-command must be used
                                        target.sendMessage("Please use a valid sub-command!");
                                        return true;
                                    }
                                // The player with the given name is not online that means target == null
                                } else {
                                    // Return that the player is currently not online
                                    player.sendMessage("The player " + name + " is currently not online!");
                                    return true;
                                }
                            // The player has not enough money
                            } else {
                                // Return that the player does not have enough money
                                player.sendMessage("You don't have enough money! You're missing: " + (amount-MoneyAPI.getMoney(player)) + " tokens.");
                                return true;
                            }
                        // The player typed in a negative amount or 0
                        } else {
                            // Return that the amount has to be higher than 0
                            player.sendMessage("The money amount has to be higher than 0!");
                            return true;
                        }
                    // The player typed in an invalid money amount
                    } catch (Exception ex) {
                        // Return that the money amount is invalid
                        player.sendMessage("Invalid money amount!");
                        return true;
                    }
                }
            }
        }
 
        // At this point the plugin just returns the command typed in into the chat, because something went pretty wrong!!!
        return false;
    }

And here as list of usage from I wrote to you:

MoneyAPI:
.getMoney(player) - Returns the money of a player
.setMoney(player) - Sets the money of a player
.takeMoney(player, amount) - Takes a specific amount of money from the player
.giveMoney(player, amount) - Gives a specific amount of money to the player
.hasMoney(player, amount) - Checks if the player has the specified amount of money
.saveMoneyValues() - IMPORTANT! Call this in your onDisable()!

Commands:
IMPORTANT! Setup "tokens" as command in your plugin.yml!
/tokens - Shows your current money
/tokens <name> - Show the money of the given player (only if he's onliney)
/tokens give <name> <amount> - Gives an amount of money that is taken from you to another player
/tokens take <name> <amount> - Takes an amount of money from a player (needs Permission or OP)
/tokens cheat <name> <amount> - Cheats an amount of money for a player

 

dude i am so mad i get freaking bracket errors please re-write this for me one more time, i am so sorry for this trouble

Code:java

package me.JoeyLangston.MCTokens;
 
import java.util.ArrayList;
 
import org.bukkit.Bukkit;
import org.bukkit.ChatColor;
import org.bukkit.Material;
import org.bukkit.command.Command;
import org.bukkit.command.CommandSender;
import org.bukkit.configuration.file.FileConfiguration;
import org.bukkit.entity.Player;
import org.bukkit.event.Listener;
import org.bukkit.inventory.Inventory;
import org.bukkit.inventory.ItemStack;
import org.bukkit.inventory.meta.ItemMeta;
import org.bukkit.plugin.java.JavaPlugin;
 
public class Shop extends JavaPlugin implements Listener {
 
 
//The class that stores prices and items
 
public static FileConfiguration config;
 
public static Shop plugin = null;
 
public void onEnable() {
getServer().getPluginManager().registerEvents(new EventHandlers(), this);
 
config = getConfig();
 
plugin = this;
}
 
public static void saveFile(){
plugin.saveConfig();
}
 
public ItemStack createItem(Material material, int amount, short shrt,
String displayname, String lore) {
ItemStack item = new ItemStack(material, amount, (short) shrt);
ItemMeta meta = item.getItemMeta();
meta.setDisplayName(displayname);
ArrayList<String> Lore = new ArrayList<String>();
Lore.add(lore);
meta.setLore(Lore);
 
item.setItemMeta(meta);
return item;
}
 
static Inventory Shop;
 
{
 
 
Shop = Bukkit.createInventory(null, 9, "§2§lVaultCraft Tokens");
 
Shop.setItem(0, createItem(Material.GOLDEN_APPLE, 1, (short) 0, "§3GodApple","§fPrice §62 §fTokens"));
 
 
}
}
 
 
public boolean onCommand(CommandSender sender, Command cmd, String label, String[] args) {
// Check if sender is a player first
if (sender instanceof Player) {
// Cast sender to Player
Player player = (Player) sender;
// Check if the command was "tokens"
if (cmd.getName().equalsIgnoreCase("tokens")) {
// Check if no arguments are given
if (args.length == 0) {
// Return current owned tokens
player.sendMessage("Your current tokens: " + MoneyAPI.getMoney(player));
return true;
// Check if 1 argument is given
} else if (args.length == 1) {
// Argument 1 is the name
String name = args[0];
// Get the player with the given name from server
Player target = Bukkit.getServer().getPlayer(name);
// Check if player is online
if (target != null) {
// Get the tokens of the player
player.sendMessage(target.getDisplayName() + "'s current tokens: " + MoneyAPI.getMoney(target));
return true;
// The player with the given name is not online that means target == null
} else {
// Return that the player is currently not online
player.sendMessage("The player " + name + " is currently not online!");
return true;
}
// Check if 2 arguments are given
} else if (args.length == 2) {
player.sendMessage("You have to specify the amount of money!");
return true;
// Check if 3 arguments are given
} else if (args.length >= 3) {
// Try and catch here, because parsing could always return an invalid result and therefore an error
try {
// Parse an integer from argument 3
int amount = Integer.parseInt(args[2]);
// Check if the amount is not negative
if (amount > 0) {
// Check if the player has enough money
if (MoneyAPI.getMoney(player) >= amount) {
// Argument 2 is the name
String name = args[1];
// Get the player with the given name from the server
Player target = Bukkit.getServer().getPlayer(name);
// Check if the player is online
if (target != null) {
// Check if the sub-command "give" was used
if (args[0].equalsIgnoreCase("send")) {
// Take money from the player and give money to the target and send both a notification message
MoneyAPI.takeMoney(player, amount);
MoneyAPI.giveMoney(target, amount);
player.sendMessage("You sent " + target.getName() + " an amount of " + amount + " tokens!");
target.sendMessage("You received " + amount + " tokens from " + player.getName() + "!");
return true;
// Check if the sub-command "take" was used
} else if (args[0].equalsIgnoreCase("take")) {
// Check if the player has the permission to use this sub-command or is OP
if (player.hasPermission("vt.take")) {
// Take money from the target and give money to the player and send both a notification message
MoneyAPI.giveMoney(player, amount);
MoneyAPI.takeMoney(target, amount);
player.sendMessage("You took " + amount + " tokens from " + player.getName() + "!");
target.sendMessage(player.getName() + " took " + amount + " tokens from you!");
return true;
// The player has not the right permissions
} else {
target.sendMessage("You're missing the permission to take money from others!");
return true;
}
// Check if the sub-command "cheat" was used
} else if (args[0].equalsIgnoreCase("give")) {
// Check if the player has the permission to use this sub-command or is OP
if (player.hasPermission("vt.give") || player.isOp()) {
// Give money to the player and send a notification message
MoneyAPI.giveMoney(player, amount);
// Check if the target is the player himself
if (!target.getName().equalsIgnoreCase(player.getName())) {
// Return a notification
player.sendMessage("You cheated " + amount + " tokens for " + player.getName() + "!");
return true;
} else {
// Return a notification
player.sendMessage("You gave " + amount + " tokens for yourself!");
return true;
}
// The player has not the right permissions
} else {
target.sendMessage("You're missing the permission to cheat money!");
return true;
}
// No valid sub-command was used
} else {
// Return that a valid sub-command must be used
target.sendMessage("Please use a valid sub-command!");
return true;
}
}
}
}
}
}
}
 
 
 

wait nvm

how would you do the plugin yml, i dont know how to do that when there is multiple commands

EDIT by Moderator: merged posts, please use the edit button instead of double posting.