Solved Time breakdown

Hi. I know this isn't strictly an API question, but it does relate to my plugin. I want a user to be able to pass a duration argument for a ban command. I figured I'd store it as current time in millis + ban duration. I don't want the user to have to input seconds though, I figured a format of ##d##h##m##s for days/hours/mins/secs would be nice. This is what I'm doing now:

Code:

  public Long banstop(Player p, String duration) {
      Long retval = 0l; String buffer = "";
      int[] multiplier = new int[116]; multiplier[100] = 86400; multiplier[104] = 3600; multiplier[109] = 60; multiplier[115] = 1;
      for (int x = 0; x < duration.length(); x++) {
          if ((int)duration.charAt(x) > 57) {
              retval += Long.parseLong(buffer) * multiplier[(int)duration.charAt(x)];
              buffer = "";
          } else {
              buffer += duration.substring(x, x+1);
          }
      }
      return retval;
  }

The reason for the multiplier int array is that I didn't want to have a big if/then or switch in the loop, I thought it'd be cleaner this way. True, I waste memory as I only use 4 positions in a 116 array but I didn't know a better way to handle that part.

That function works, but I was curious if there is a better way to do it? Thanks!

PS, I need to add some error handling because I just realized as it is now, it'll s**t itself if the user gives it malformed content lol.

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

Well take a look at SimpleDateFormat and how to parse strings to dates. However you could build a small method to use a different system such as "/ban <user> 20m" where m =minutes.
Specifically:
S= seconds
m=minutes
H= hours
D= days
W= weeks
M= months
Y= years

Minutes and months are case sensitive, but it will work

 

@Strahan @mine-care
My time to shine Don't know if my version is "better" though
It is a recursive parser, that accepts milliseconds, ticks, seconds, minutes hours and days. It will throw a RuntimeException if an error occurs and doesn't care about order or whatever in the message. As long as it follows the format it can be anything from "1s" to "1w 1s 99h 20w 5s 7S 6t" and so on.

The grammar is the following:
part -> number+
number -> NUMBER UNIT
NUMBER: 0-9+
UNIT: S | t | s | m | h | d

The ones in capital are only help constructs and no productions.

You can add new units by just extending UNIT. Just add some more else if statements at the bottom.

Code:java

 
    /**
     * Small recursive parser by I Al Istannen. Bug me about it, I know it is bad!
     * <p>
     * Format:
     * <br>"xxS" ==> milliseconds
     * <br>"xxt" ==> ticks
     * <br>"xxs" ==> seconds
     * <br>"xxm" ==> minutes
     * <br>"xxh" ==> hours
     * <br>"xxd" ==> days
     *
     * @param input The input string
     *
     * @return The time in milliseconds
     *
     * @throws RuntimeException If an error occurred while parsing.
     */
    public static long parseDurationToTicks(String input) throws RuntimeException {
        return parseDuration(input) / 50;
    }
 
    /**
     * Small recursive parser by I Al Istannen. Bug me about it, I know it is bad!
     * <p>
     * Format:
     * <br>"xxS" ==> milliseconds
     * <br>"xxt" ==> ticks
     * <br>"xxs" ==> seconds
     * <br>"xxm" ==> minutes
     * <br>"xxh" ==> hours
     * <br>"xxd" ==> days
     *
     * @param input The input string
     *
     * @return The time in milliseconds
     *
     * @throws RuntimeException If an error occurred while parsing.
     */
    public static long parseDuration(String input) throws RuntimeException {
        return new Object() {
 
            private int pos = -1, ch;
 
            /**
             * Goes to the next char
             */
            private void nextChar() {
                ch = ++pos < input.length() ? input.charAt(pos) : -1;
            }
 
            /**
             * Eats a char
             *
             * @param charToEat The chat to eat
             * @return True if the char was found and eaten
             */
            private boolean eat(int charToEat) {
                while (ch == ' ') {
                    nextChar();
                }
                if (ch == charToEat) {
                    nextChar();
                    return true;
                }
                return false;
            }
 
            public long parse() {
                nextChar();
                return parsePart();
            }
 
            private long parsePart() {
                long number = parseNumber();
                while (ch != -1) {
                    number += parseNumber();
                }
 
                return number;
            }
 
            private long parseNumber() {
                while (ch == ' ') {
                    nextChar();
                }
                long number;
                int start = pos;
                if (ch >= '0' && ch <= '9') {
                    while (ch >= '0' && ch <= '9') {
                        nextChar();
                    }
                    number = Long.parseLong(input.substring(start, pos));
 
                    if (eat('S')) {
                        // well, it is already in ms
                    }
                    else if (eat('s')) {
                        number *= 1000;
                    }
                    else if (eat('m')) {
                        number = TimeUnit.MINUTES.toMillis(number);
                    }
                    else if (eat('h')) {
                        number = TimeUnit.HOURS.toMillis(number);
                    }
                    else if (eat('d')) {
                        number = TimeUnit.DAYS.toMillis(number);
                    }
                    else if (eat('t')) {
                        number *= 50;
                    }
                    else {
                        throw new RuntimeException("No unit given near pos " + pos + " starting at " + start);
                    }
                }
                else {
                    throw new RuntimeException("Unexpected char at pos " + pos + " " + ch + " '" + (char) ch + "'");
                }
 
                return number;
            }
 
        }.parse();
    }

 

Thanks!

 

@Strahan
No problem. It is certainly not the most efficient way, but I think it works