Teleporting With Random Integers, Setting Locations

Hi, I have seemed to have stumbled on a problem. I have a random map rotation on my server by generating a random integer.

Code:java

 public static int getMapID(){
int rand = new Random().nextInt(2) + 1;
int index = 1;
if (rand == index){
return 1;
} else {
return 2;
}
}

After that, I set the random numbers as a new integer so I have the number that it returned.

Code:java

 public static int getMapID1(){
if(getMapID() == 1){
return 1;
}
return 1;
}
 
public static int getMapID2(){
if(getMapID() == 2){
return 2;
}
return 2;
}
 

So, on the respawn when they die, I check to see which number the getMapID() method has generated and set the respawn location to the appropriate locations on the said map.

Code:java

 if(Game.blue.contains(player.getName())){
if(Game.getMapID1() == 1){
event.setRespawnLocation(new Location(Bukkit.getWorld("world"), -2, 69, 386));
} else if(Game.getMapID2() == 2) {
event.setRespawnLocation(new Location(Bukkit.getWorld("world"), -26, 57, -456));
}
}
if(Game.red.contains(player.getName())){
if(Game.getMapID1() == 1){
event.setRespawnLocation(new Location(Bukkit.getWorld("world"), -2, 69, 254));
} else if(Game.getMapID2() == 2) {
event.setRespawnLocation(new Location(Bukkit.getWorld("world"), -160, 57, -456));
}
}

Now, the problem is that if the map #2 is picked, the players respawn in the map #1, but if map #1 is selected, then they spawn in map #1. I do not know what is happening or what is causing it to do this. Any help is appreciated, thanks!

chasechocolate I know you are online

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

BajanAmerican
You're going about Object Oriented Programming completely wrong!
Why don't you make a Map Object?
Define a new class:

Code:java

public class Map {
 
public Map(Location respawnLocation) {
this.respawnLocation = respawnLocation;
}
 
private Location respawnLocation;
 
private Location getRespawnLocation() {
return respawnLocation;
}
}

Now in your main code you could make an Array of Maps:

Code:java

Map[] mapList = {new Map(#respawnLocation#),
new Map(#respawnLocation#),
new Map(#respawnLocation#)};
 

And then in your code you'd get a random integer and set the current map to the one chose above

Code:java

public static int getRandomNumberInRange(int Max, int Min) {
return Min + (int)(Math.random() * ((Max - Min) + 1));
}
// [url]http://stackoverflow.com/questions/363681/generating-random-numbers-in-a-range-with-java[/url]
 

Code:

Map currentMap;
 
public void selectMap() {
currentMap = mapList[getRandomNumberInRange(0,mapList.length);
}
 
public void respawnPlayer(Player player) {
player.teleport(currentMap.getRespawnLocation());
}

Obviously, you would add WAY more information to each map, even make the Map get the data from the config when you give it a name.

Why do it this way?
Think about it,this code you could use ANYWHERE, You could make any plugin and use the Map class. (Depending on what else you implement)

The reason I said all of this is mainly because your method is so incredibly hard to understand, You set one method, then you set another method to set the respawn location, dude I just lost myself.

Simplicity is the answer!

 

TomFromCollege
This is great, but I do have to ask, what is wrong with my code? I do have another class in which I use different cases that the random number correlates with for locations. I would personally rather keep everything number-orientated if that's possible. I'd rather stay away from Objects as much as possible because my programming skills are not as good as yours or others. Thanks.

 

BajanAmerican
I completely understand what you're saying but experimentation leads to innovation and that'll deffinitely help you in the long run...
I don't understand all of your methods... Like really, I have no idea why you're sending one method, to another, which in turn is returning the exact same number...

Take the getRandomNumberInRange method from above

Things to note:

• You need to change the locations
• You need to call setMap(); when you start the game. (If you don't it will error)

Code:java

 
public Location respawnLocationBlue;
public Location respawnLocationRed;
 
public void setMap() {
    switch(getRandomNumberInRange(1,'MAXAMOUNTOFMAPS') {
        case 1:
            respawnLocationBlue = new Location(Bukkit.getWorld("world"), -2, 69, 386);
            respawnLocationRed = new Location(Bukkit.getWorld("world"), -2, 69, 386);
            break;
        case 2:
            respawnLocationBlue = new Location(Bukkit.getWorld("world"), -2, 69, 386);
            respawnLocationRed = new Location(Bukkit.getWorld("world"), -2, 69, 386);
            break;
    }
}
 
public Location getBlueRespawnLocation() {
    return respawnLocationBlue;
}
 
public Location getRedRespawnLocation() {
    return respawnLocationRed;
}

Now; This is your code transformed:

Code:java

if(Game.blue.contains(player.getName())){
    event.setRespawnLocation(getBlueRespawnLocation());
} else if(Game.red.contains(player.getName())){
    event.setRespawnLocation(getRedRespawnLocation());
}

 

TomFromCollege
Yes! That's what I am looking for! Thank you! Hopefully this will be a definite debug to my issue.. Thanks once again!

 

TomFromCollege
That method that you gave me that selects and random number from a range does not work. If I put the max and min like this:

Code:

Locations.teleportPlayers(plugin, getRandomNumberInRange(1, 2));

It will return the second map every time. But if I do this:

Code:

Locations.teleportPlayers(plugin, getRandomNumberInRange(1, 1));

It returns the first map. I don't know if I am getting this wrong or the method doesn't work. You said the second number is for the number of maps, but It doesn't appear to be ending up that way. Again, any help is appreciated, thanks!

 

I got the Max and Min mixed up My bad!
BajanAmerican

Code:

public static int getRandomNumberInRange(int Min, int Max) {
return Min + (int)(Math.random() * ((Max - Min) + 1));
}