TagAPI Help

Hey guys, so I am coding a private plugin for someone (for free) called BetterTags. What it is meant to do is when you type /tagpro, /tagmember or /tagadmin then your nametags switch to the one that you specified. However, when I type the commands, nothing happens. I think it is to do with the AsyncPlayerReceiveNameTagEvent because what I've done is created an three different ArrayLists, one for pro, member and admin and everytime a player does /tagpro, they get added and in the EventHandler, if it contains the player, then they get the nametag.

For some reason this doesn't seem to work...

Here is my code:

Code:java

package me.thesamster8.bettertags;
 
import java.util.ArrayList;
import java.util.List;
 
import org.bukkit.ChatColor;
import org.bukkit.command.Command;
import org.bukkit.command.CommandExecutor;
import org.bukkit.command.CommandSender;
import org.bukkit.entity.Player;
import org.bukkit.event.EventHandler;
import org.bukkit.event.Listener;
import org.bukkit.plugin.java.JavaPlugin;
import org.kitteh.tag.AsyncPlayerReceiveNameTagEvent;
 
public class Main extends JavaPlugin implements Listener, CommandExecutor {
 
    @Override
    public void onEnable() {
        getServer().getPluginManager().registerEvents(this, this);
        getServer().getPluginManager().registerEvents(new Member(), this);
        getCommand("tagpro").setExecutor(new Main());
        getCommand("tagadmin").setExecutor(new Main());
        getCommand("tagmember").setExecutor(new Main());
    }
 
    @Override
    public void onDisable() {
    }
 
    ArrayList<String> pros = new ArrayList<String>();
    ArrayList<String> admins = new ArrayList<String>();
    public static List<String> members = new ArrayList<String>();
 
    public boolean onCommand(CommandSender sender, Command cmd, String commandLabel, String[] args) {
        if(!(sender instanceof Player)) {
            sender.sendMessage("You must be a Player");
            return true;
        }
 
        Player p = (Player) sender;
 
        if(cmd.getName().equalsIgnoreCase("tagpro")) {
            if(p.hasPermission("tagcommand.pro")) {
                pros.add(p.getName());
                return true;
            }
 
            if(cmd.getName().equalsIgnoreCase("tagadmin")) {
                if(p.hasPermission("tagcommand.admin")) {
                    admins.add(p.getName());
                    return true;
                }
 
                if(cmd.getName().equalsIgnoreCase("tagmember")) {
                    if(p.hasPermission("tagcommand.member")) {
                        members.add(p.getName());
                        return true;
                    }
                }
            }
        }
        return true;
    }
 
    @EventHandler
    public void onTag(AsyncPlayerReceiveNameTagEvent event) {
        Player player = event.getNamedPlayer();
            if(pros.contains(player.getName())) {
            event.setTag(ChatColor.AQUA + player.getName());
            }
    }
 
 
 
    @EventHandler
    public void onNameTag(AsyncPlayerReceiveNameTagEvent event) {
        Player player = event.getNamedPlayer();
            if(admins.contains(player.getName())) {
                event.setTag(ChatColor.DARK_AQUA + player.getName());
            }
    }
}
 
 

Code:java

package me.thesamster8.bettertags;
 
import org.bukkit.ChatColor;
import org.bukkit.entity.Player;
import org.bukkit.event.EventHandler;
import org.bukkit.event.Listener;
import org.kitteh.tag.AsyncPlayerReceiveNameTagEvent;
 
public class Member implements Listener {
 
    @EventHandler
    public void onTagTag(AsyncPlayerReceiveNameTagEvent event) {
        Player player = event.getNamedPlayer();
            if(Main.members.contains(player.getName())) {
                event.setTag(ChatColor.BOLD.toString() + ChatColor.GRAY + player.getDisplayName());
            }
    }
}
 

Thanks

 

Remove line 22, 23 and 24 in your first code snippet. You cannot instantiate your main class.

 

RainoBoy97

Oh really? Then how do I register my commands?

 

It is on main class. You do not need to register this. Just remove.

 

Just no. What dafudge have you done. Ok remove the implements CommandExecutor you don't need that, if you are having the onCommand mehtod in your main class all you need to do is in your plugin.yml add this;
commands:
Command1:
description: Blah
Command2:
description: Blah2
As for the rest of your code I recommend learning the basics of the Bukkit API before trying to hook into another.

 

right do all above , then if you want the tags to update i would advise you would use a event that happens once every so offen (other whys players don't show if constant) and then put the following

Code:

for(Player t : Bukkit.getOnlinePlayers()){
  TagAPI.refreshPlayer(t);
  }

i use the noteblock play event @ZodiacTheories although i suppose you could do it in the command but i wouldn't recommend this

 

ahuby09

Thanks

 

glad to help did it work for you , if not please feel free to inbox me

 

ZodiacTheories
1. You don't need to register commands in the main class.
2. You cannot instantiate any main class of any plugin.

 

RainoBoy97

Thanks