[SOLVED]Remove Nearby Arrows

I'm attempting to remove arrows near a player that have stopped... How would I go about doing that? This is the code I have to check for arrows so far:

Code:java

 
/*
* To change this template, choose Tools | Templates
* and open the template in the editor.
*/
package arrowpickup;
 
import java.util.List;
import org.bukkit.Material;
import org.bukkit.entity.Arrow;
import org.bukkit.entity.Entity;
import org.bukkit.event.EventHandler;
import org.bukkit.event.Listener;
import org.bukkit.event.player.PlayerMoveEvent;
import org.bukkit.inventory.ItemStack;
import org.bukkit.inventory.PlayerInventory;
import org.bukkit.plugin.PluginManager;
import org.bukkit.plugin.java.JavaPlugin;
 
 
/**
*
* @author Ice_Sword
*/
public class Arrowclass extends JavaPlugin implements Listener
{
public static void main(String[] args)
{
}
 
 
@Override
public void onEnable()
{
getServer().getPluginManager().registerEvents(this, this);
}
 
@Override
public void onDisable()
{
}
 
 
public boolean hasArrows(List<Entity> list){
for(Entity entity: list){
if(entity instanceof Arrow) return true;
}
return false;
}
 
@EventHandler
public void onPlayerMove(PlayerMoveEvent event){
List<Entity> nears = event.getPlayer().getNearbyEntities(3,4,3);
//the (3,4,3) is the box to check for entities
if(hasArrows(nears))
{
 
Player player = event.getPlayer();
player.getName();
PlayerInventory inventory = player.getInventory();
ItemStack ar = new ItemStack(Material.ARROW, 1);
inventory.addItem(ar);
player.sendMessage("Test.");
 
}
}
 
 
 
 
}
 

I'm trying to simulate what happens when you pick up your own arrow, but with any arrow.

EDIT:
I've have to stamp out the bugs, but I just added "entity.remove();" before the first return statement. And of course edited the if statement to add brackets.

 

That event handler is going to put some serious load on a busy server. It gets called every time a player moves, even slightly, and getNearbyEntities() is not a cheap operation - it creates not one but two new ArrayLists every time it's called (plus a copy of one list to the other). You're just asking for "can't keep up!" messages there.

There's no ideal way to do this (regularly scanning for and removing entities is by its nature expensive), but I'd suggest two things:

1. Use a repeating task, and just scan periodically (maybe once a second, maybe make it configurable so server admins can adjust depending on their server horsepower). You'd need to use world.getPlayers() to scan all players, which is also not a cheap operation, but...
2. Look into using the low-level NMS calls to get and remove entities to avoid the object creation & array copying overhead of the Bukkit getNearbyEntities() (and getPlayers()) method. Perusing CraftEntity.java and CraftWorld.java from the craftbukkit source would be a good place to start.

 

I'm going to get it working, and I'll look into updating it with your suggestions. Thank you.