Snowball damage

Not the best thread name ever, but in absence of better ideas, it'll do.

I have this code:

Code:java

@SuppressWarnings("deprecation")
    @EventHandler
    public void onPlayerInteract(PlayerInteractEvent event) {
        if (event.getAction() == Action.RIGHT_CLICK_AIR){
        Player player = (Player) event.getPlayer();
        if (event.getPlayer().isSneaking()){
            if (event.getPlayer().getItemInHand().getType().equals(Material.IRON_AXE)){
                    ItemStack is = new ItemStack(Material.AIR,0);
                    player.setItemInHand(is);
                    Location loc = player.getEyeLocation();
                    Snowball ball = (Snowball)loc.getWorld().spawnEntity(loc, EntityType.SNOWBALL);             
                    ball.setShooter(player);
                    ball.setVelocity(player.getLocation().getDirection());
                    String string = ball.getUniqueId().toString();
                    map.put(string, 10);
            }
            }
 
        }
    }
    @SuppressWarnings("deprecation")
    @EventHandler
    public void onEntityDamageByEntityEvent(EntityDamageByEntityEvent event) {
        if (event.getDamager().getType().equals(EntityType.SNOWBALL)); {
            System.out.println("Worked so far");
            EntityDamageEvent hitEntity = (EntityDamageEvent) event.getEntity();
            String ball = (String) event.getDamager().getUniqueId().toString();
            Integer damage = (Integer) map.get(ball);
            hitEntity.setDamage(damage);
        }
 
    }

I basically want it to throw a snowball when you right click and iron axe while sneaking (throw it). That works fine. Then I'm trying to set the damage it will deal by getUniqueId, using it as a string for a hashmap and setting the value of it to the amount of damage I want it to deal.
In the next part, it's pretty clear what I want it to do, but it doesn't deal any damage and wont even print the debug message "Worked so far".
This is the error I get when the snowball hits an entity:

Can someone tell me what I'm doing wrong, please?

 

Anrza could you copy & paste line 53 of WeaponThrowing.java from your Workspace please?

 

Code:

EntityDamageEvent hitEntity = (EntityDamageEvent) event.getEntity();

You're casting EntityDamageEvent to an entity? That's the error I believe.
I think you mean:

Code:

Entity hitEntity = event.getEntity();

By the way, you're going to get a NullPointerException if the player has no item and they right click air as the item will be null. Make sure to check if event.getItem() != null first.
Also, don't use event.getPlayer().getItemInHand(), use event.getItem().

 

Joshuaknight1998 KingFaris11

Code:java

EntityDamageEvent hitEntity = (EntityDamageEvent) event.getEntity();

Ah, you both solved this in different ways
Yea, that was kinda improvised.
And thanks, now I know how to read error reports :3

So, how do you suggest I fix this?

 

I already posted the code of what you should have.

Suggestion: You should also check if the map contains the Snowball, as players shooting normal snowballs will get affected by this too.

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

KingFaris11
Yes, thank you for the code and the advice, but the code gives me the error "The method setDamage(Intiger) is undefined for the type Entity".
There's a quick fix "Add cast to 'hitEntity'", and while Eclipse doesn't complain about the code, I get this error message in the console:

Since it refers to line 58, which is:

Code:java

((EntityDamageEvent) hitEntity).setDamage(damage);

I suppose the problem has to do with that.

 

You're doing it again ;( ;(
You cannot cast EntityDamageEvent to an entity... You're meant to do:
event.setDamage(damage);
No "hitEntity" rubbish.

It seems you don't know the basics of Java, I suggest you learn that at least. You should know what you can and can't cast.

 

KingFaris11
Thanks... yea, I've been hearing that I should learn stuff lately. I guess I will. Thank you very much for helping me!