Solved Simpleranks help - How to keep Data after Relog

Scroll to my latest post.

Code:

package me.s1ant.simpleranks;

import org.bukkit.Bukkit;
import org.bukkit.ChatColor;
import org.bukkit.command.Command;
import org.bukkit.command.CommandSender;
import org.bukkit.entity.Player;
import org.bukkit.event.player.AsyncPlayerChatEvent;
import org.bukkit.plugin.java.JavaPlugin;


public class Main extends JavaPlugin{

    int level = 0;
 
    public void onChat(AsyncPlayerChatEvent e){
        e.setCancelled(true);
        if(level == 7){ 
        Bukkit.broadcastMessage(ChatColor.GRAY + "[" + ChatColor.DARK_RED + "Owner" + ChatColor.GRAY + "] " + ChatColor.DARK_RED + e.getPlayer().getCustomName() + ChatColor.GRAY + ": "
                + ChatColor.DARK_RED + e.getMessage().toString());
        }
        if(level == 6){ 
            Bukkit.broadcastMessage(ChatColor.GRAY + "[" + ChatColor.DARK_RED + "Developer" + ChatColor.GRAY + "] " + ChatColor.DARK_RED + e.getPlayer().getCustomName() + ChatColor.GRAY + ": "
                    + ChatColor.DARK_RED + e.getMessage().toString());
        }
        if(level == 5){ 
            Bukkit.broadcastMessage(ChatColor.GRAY + "[" + ChatColor.RED + "Admin" + ChatColor.GRAY + "] " + ChatColor.RED + e.getPlayer().getCustomName() + ChatColor.GRAY + ": "
                    + ChatColor.RED + e.getMessage().toString());
        }
        if(level == 4){ 
            Bukkit.broadcastMessage(ChatColor.GRAY + "[" + ChatColor.AQUA + "Moderator" + ChatColor.GRAY + "] " + ChatColor.AQUA + e.getPlayer().getCustomName() + ChatColor.GRAY + ": "
                    + ChatColor.AQUA + e.getMessage().toString());
        }
        if(level == 3){ 
            Bukkit.broadcastMessage(ChatColor.GRAY + "[" + ChatColor.GOLD + "Famous" + ChatColor.GRAY + "] " + ChatColor.GOLD + e.getPlayer().getCustomName() + ChatColor.GRAY + ": "
                    + ChatColor.GOLD + e.getMessage().toString());
        }
        if(level == 2){ 
            Bukkit.broadcastMessage(ChatColor.GRAY + "[" + ChatColor.YELLOW + "Donator" + ChatColor.GRAY + "] " + ChatColor.YELLOW + e.getPlayer().getCustomName() + ChatColor.GRAY + ": "
                    + ChatColor.YELLOW + e.getMessage().toString());
        }
        if(level == 1){ 
            Bukkit.broadcastMessage(ChatColor.GREEN + e.getPlayer().getCustomName() + ChatColor.GRAY + ": "
                    + ChatColor.GRAY + e.getMessage().toString());
        }
    }

    public void setRank(Player p, String s){
        if(s == "7" || s == "owner"){
        level = 7;
            sendMessage(p, "You are Have been added to the Rank Owner!");
        }
        if(s == "6" || s == "developer"){
            level = 6;
                sendMessage(p, "You are Have been added to the Rank Developer!");
            }
        if(s == "5" || s == "admin"){
            level = 5;
                sendMessage(p, "You are Have been added to the Rank Admin!");
            }
        if(s == "4" || s == "moderator"){
            level = 4;
                sendMessage(p, "You are Have been added to the Rank Moderator!");
            }
        if(s == "3" || s == "famous"){
            level = 3;
                sendMessage(p, "You are Have been added to the Rank Famous!");
            }
        if(s == "2" || s == "donator"){
            level = 2;
                sendMessage(p, "You are Have been added to the Rank Donator!");
            }
        if(s == "1" || s == "player"){
            level = 1;
                sendMessage(p, "You are Have been added to the Rank Player!");
            }
    }
 
    public void sendMessage(Player p, String s){
        p.sendMessage(ChatColor.GRAY + "[" + ChatColor.AQUA + "SimpleRanks" + ChatColor.GRAY + "] " + ChatColor.AQUA + s);
    }
 
public boolean onCommand(CommandSender sender, Command cmd, String label, String[] args){
 
            if(label.equalsIgnoreCase("rank")){
                if(sender instanceof Player){
                    Player p = (Player) sender;
                    if(p.isOp()){
                        if(args.length == 0){
                            sendMessage(p, "/rank list");
                            sendMessage(p, "/rank set <player> <rank>");
                        }else if(args.length == 1){
                            if(args[0].equalsIgnoreCase("list")){
                                sendMessage(p, "Ranks:");
                                sendMessage(p, ChatColor.DARK_RED + "Owner(7)");
                                sendMessage(p, ChatColor.DARK_RED + "Developer(6)");
                                sendMessage(p, ChatColor.RED + "Admin(5)");
                                sendMessage(p, ChatColor.AQUA + "Moderator(4)");
                                sendMessage(p, ChatColor.GOLD + "Famous(3)");
                                sendMessage(p, ChatColor.YELLOW + "Donator(2)");
                                sendMessage(p, ChatColor.GREEN + "Player(1)");
                            }else if(args[0].equalsIgnoreCase("set")){
                             
                             
                                Player t = (Player) Bukkit.getPlayer(args[1]);
                                if(t == null){
                                    sendMessage(p, ChatColor.DARK_RED + "Player not Found.");
                                }else {
                                    if(args[2].equalsIgnoreCase("owner") || args[2].equalsIgnoreCase("7")){
                                        sendMessage(p, "Sucessfully add " + t.getCustomName() + " to Owner");
                                        sendMessage(t, "You are now: " + ChatColor.DARK_RED + "OWNER");
                                        setRank(t, "owner");
                                    }
                                 
                                    if(args[2].equalsIgnoreCase("owner") || args[2].equalsIgnoreCase("6")){
                                        sendMessage(p, "Sucessfully add " + t.getCustomName() + " to Owner");
                                        sendMessage(t, "You are now: " + ChatColor.DARK_RED + "OWNER");
                                        setRank(t, "owner");
                                    }
                                 
                                    if(args[2].equalsIgnoreCase("developer") || args[2].equalsIgnoreCase("5")){
                                        sendMessage(p, "Sucessfully added " + t.getCustomName() + " to Developer");
                                        sendMessage(t, "You are now: " + ChatColor.DARK_RED + "DEVELOPER");
                                        setRank(t, "developer");
                                    }
                                 
                                    if(args[2].equalsIgnoreCase("admin") || args[2].equalsIgnoreCase("4")){
                                        sendMessage(p, "Sucessfully add " + t.getCustomName() + " to Admin");
                                        sendMessage(t, "You are now: " + ChatColor.RED + "ADMIN");
                                        setRank(t, "admin");
                                    }
                             
                                    if(args[2].equalsIgnoreCase("moderator") || args[2].equalsIgnoreCase("3")){
                                        sendMessage(p, "Sucessfully add " + t.getCustomName() + " to Moderator");
                                        sendMessage(t, "You are now: " + ChatColor.AQUA + "MODERATOR");
                                        setRank(t, "moderator");
                                    }
                                 
                                    if(args[2].equalsIgnoreCase("famous") || args[2].equalsIgnoreCase("2")){
                                        sendMessage(p, "Sucessfully add " + t.getCustomName() + " to Famous");
                                        sendMessage(t, "You are now: " + ChatColor.GOLD + "FAMOUS");
                                        setRank(t, "famous");
                                    }
                             
                                    if(args[2].equalsIgnoreCase("player") || args[2].equalsIgnoreCase("1")){
                                        sendMessage(p, "Sucessfully add " + t.getCustomName() + " to Player");
                                        sendMessage(t, "You are now: " + ChatColor.GREEN + "PLAYER");
                                        setRank(t, "player");
                                    }
                                }
                             
                                }else {
                                    sendMessage(p, ChatColor.DARK_RED + "/rank set <player> <rank>");
                                }
                            }
                         
                         
                        }
                     
                     
                    }else {
                        Player p = (Player) sender;
                        sendMessage(p, ChatColor.DARK_RED + "Server Operators Only!");
                    }
                }else {
                    sender.sendMessage(ChatColor.DARK_RED + "Players only");
                }
             
             
             
         
 
 
return true; 
}
}

P.S. Will Someone tell me how to make that code into bukkit code?


Ok So now I need to get the online player that have their level set to 7 6 5 4 and 3

 

@S1ant

1. /rank set <name> won't work because you are checking if it is Only has 1 arg, but that has 2 args in it. What you want to do is check if the length is greater than or equal to 1.
2. /rank set won't work because you are getting the second arg, even though there is no second arg. You need to make sure there are two args before getting the "t".

 

@Zombie_Striker Thanks! You are a boss, but do you know why the chat part isn't working possibly?

Does anyone also have a solution for saving the Players Rank/level?

 

@S1ant
You forgot the @EventHandler tag. Events need that in order for bukkit to find them.

 

@Zombie_Striker omg, that always gets me xD

@Zombie_Striker How can I get people out of all Online people that have their levels set to: 7, 6, 5, 4, and 3?

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

@S1ant

1. Create a List of Players.
   
2. For loop through all the players online.
3. For each player, check if they have a level between 3 and 7.
   
4. If so, add them to the List.

 

@Zombie_Striker I tried to do that, but I don't know exactly how to get the player to add to list.

Code:

if(label.equalsIgnoreCase("list")){
                if(sender instanceof Player){
                   
                    List<String> player = new ArrayList<String>();
                           
                   
                   
                    for(Bukkit.getOnlinePlayers(); level >= 3; player.add()){
                       
                       
                       
                    }
                   
                   
                   
                }else {sender.sendMessage(ChatColor.DARK_RED + "PLAYERS ONLY!");}
               
               
            }

Gosh, I still have so much to learn...

 

@S1ant
How long have you been writing in Java? I would recommend you take some time to fully understand Java before you continue to write plugins (If you do not have any, you can find tutorials here).

More specific to your code, I think you need to learn how For loops work. I recommend reading this page:
https://docs.oracle.com/javase/tutorial/java/nutsandbolts/for.html
[The example at the bottom of the page is what you need]

After that, set up an if statement check if the player's level(Do you mean XP level?) is greater than 3. If so, add them to the list. You can add objects to lists using List#add(Object), where List is the list's instance (i.e "player"), and Object is the thing you want to add (The player from the for loop).

 

You could get a for loop going through all players with

Code:

for(Player p : Bukkit.getOnlinePlayers()){
    //do something with
    getConfig().get("player."+p.getName()+".rank");
}

This might not be the most efficent code for checking everytime the message has been stored, but you could do something with Lists and do p.getName() as a key and getConfig().get("player."+p.getName()+".rank"); as the value!

This would only work if you've set your config file like following:

Code:

player:
    MGlolenstine:
        rank: 7

I hope that I helped you at least in the slighest!

 

@MGlolenstine and
@Zombie_Striker
I have this down, so What I'm doing is making it where in the configuration it is like:

Code:

CraftPlayer{name=S1ant}: 7

So I have it down, just for anyone who'd be copying my code, make it where it just does the display name, because at the minute if you set someone to owner everyone talks with the owner prefix. So I don't know if it is just the chat or the rank that is getting messed up, about to look more into it now!

 

youre defining an instance variable, meaning once you set it, it'll be for that instance of the class. no matter who chats, the value of that variable will be fetched and worked with.

thus, use a map to assign each player a specific 'level' for their rank.

Code:

Map<UUID, Integer> ranks = new HashMap<>();

//getters & setters

onChatEvent:
     if (ranks.get(event.getPlayer().getUniqueId()) == 1) {
          //etc
     }
}

//store each hashmap key +value in a config when plugin disables, load each rank back when that players joins.

i would highly suggest using an enum to organize this better.

Code:

//really no need for these 'levels' i believe
public enum Ranks {

     DEFAULT(1, ChatColor.GRAY + "DEFAULT"),
     ADMIN(2, ChatColor.RED + "ADMIN");
  
     private int level;
     private String prefix;

     Ranks(int level, String prefix) {
           this.level = level;
           this.prefix = prefix;
      }

      //getters setters
}

public class Chat {

     onChatEvent {
          setFormat(ranks.get(playerUUID).getPrefix());
      }
}

 

This is like the third time editing it, since this is at night and Bukkit Isn't very active at night. Well, anyways, when I reload and join, I notice that the chat is perfect! Then the tablist is the thing that messes, me up. It is completely normal!

EDIT: Now using Scoreboard Teams for Prefixes in Tablist!

Code:java

 
package me.s1ant.simpleranks;
 
 
import org.bukkit.Bukkit;
import org.bukkit.ChatColor;
import org.bukkit.command.Command;
import org.bukkit.command.CommandSender;
import org.bukkit.entity.Player;
import org.bukkit.event.EventHandler;
import org.bukkit.event.Listener;
import org.bukkit.event.player.AsyncPlayerChatEvent;
import org.bukkit.event.player.PlayerJoinEvent;
import org.bukkit.event.player.PlayerQuitEvent;
import org.bukkit.plugin.java.JavaPlugin;
import org.bukkit.scoreboard.Scoreboard;
import org.bukkit.scoreboard.ScoreboardManager;
import org.bukkit.scoreboard.Team;
 
 
 
public class Main extends JavaPlugin implements Listener{
 
    public void onEnable(){
        getServer().getPluginManager().registerEvents( this, this);
        owner.setPrefix(ChatColor.DARK_GRAY + "[" + ChatColor.DARK_RED + "Owner" + ChatColor.DARK_GRAY + "] ");
        developer.setPrefix(ChatColor.DARK_GRAY + "[" + ChatColor.DARK_RED + "Dev" + ChatColor.DARK_GRAY + "] " + ChatColor.DARK_RED);
        admin.setPrefix(ChatColor.DARK_GRAY + "[" + ChatColor.RED + "Admin" + ChatColor.DARK_GRAY + "] " + ChatColor.RED);
        moderator.setPrefix(ChatColor.DARK_GRAY + "[" + ChatColor.AQUA + "Mod" + ChatColor.DARK_GRAY + "] " + ChatColor.AQUA);
        famous.setPrefix(ChatColor.DARK_GRAY + "[" + ChatColor.GOLD + "Famous" + ChatColor.DARK_GRAY + "] " + ChatColor.GOLD);
        donator.setPrefix(ChatColor.DARK_GRAY + "[" + ChatColor.YELLOW + "Donator" + ChatColor.DARK_GRAY + "] " + ChatColor.YELLOW);
        player.setPrefix(ChatColor.GRAY + "");
 
    }
 
    public void onJoin(PlayerJoinEvent e){
    if(getConfig().contains(e.getPlayer().getName())){
        String rank = (String) getConfig().get(e.getPlayer().getName());
        setRank(e.getPlayer(), rank, e.getPlayer());
    }else {
        getConfig().set(e.getPlayer().getName(), "player");
        setRank(e.getPlayer(), "player", e.getPlayer());
    }
    saveConfig();
    }      
 
    public void onQuit(PlayerQuitEvent e){
        Player p = (Player) e.getPlayer();
        getConfig().set(e.getPlayer().getName(), getRank(p));
        saveConfig();
    }
 
    @EventHandler
    public void onChat(AsyncPlayerChatEvent e){
        String rank = getRank(e.getPlayer());
        if(rank.equalsIgnoreCase("owner")){
            e.setCancelled(true);
            Bukkit.broadcastMessage(ChatColor.DARK_GRAY + "[" + ChatColor.DARK_RED + "Owner" + ChatColor.DARK_GRAY + "] " + ChatColor.DARK_RED + e.getPlayer().getName() + ChatColor.DARK_GRAY + ": " + ChatColor.DARK_RED + e.getMessage());
        }
        if(rank.equalsIgnoreCase("developer")){
            e.setCancelled(true);
            Bukkit.broadcastMessage(ChatColor.DARK_GRAY + "[" + ChatColor.DARK_RED + "Developer" + ChatColor.DARK_GRAY + "] " + ChatColor.DARK_RED + e.getPlayer().getName() + ChatColor.DARK_GRAY + ": " + ChatColor.DARK_RED + e.getMessage());
        }
        if(rank.equalsIgnoreCase("admin")){
            e.setCancelled(true);
            Bukkit.broadcastMessage(ChatColor.DARK_GRAY + "[" + ChatColor.RED + "Admin" + ChatColor.DARK_GRAY + "] " + ChatColor.RED + e.getPlayer().getName() + ChatColor.DARK_GRAY + ": " + ChatColor.RED + e.getMessage());
        }
        if(rank.equalsIgnoreCase("moderator")){
            e.setCancelled(true);
            Bukkit.broadcastMessage(ChatColor.DARK_GRAY + "[" + ChatColor.AQUA + "Moderator" + ChatColor.DARK_GRAY + "] " + ChatColor.AQUA + e.getPlayer().getName() + ChatColor.DARK_GRAY + ": " + ChatColor.AQUA + e.getMessage());
        }
        if(rank.equalsIgnoreCase("famous")){
            e.setCancelled(true);
            Bukkit.broadcastMessage(ChatColor.DARK_GRAY + "[" + ChatColor.GOLD + "Famous" + ChatColor.DARK_GRAY + "] " + ChatColor.GOLD + e.getPlayer().getName() + ChatColor.DARK_GRAY + ": " + ChatColor.GOLD + e.getMessage());
        }
        if(rank.equalsIgnoreCase("donator")){
            e.setCancelled(true);
            Bukkit.broadcastMessage(ChatColor.DARK_GRAY + "[" + ChatColor.YELLOW + "Donator" + ChatColor.DARK_GRAY + "] " + ChatColor.YELLOW + e.getPlayer().getName() + ChatColor.DARK_GRAY + ": " + ChatColor.YELLOW + e.getMessage());
        }
        if(rank.equalsIgnoreCase("player")){
            e.setCancelled(true);
            Bukkit.broadcastMessage(ChatColor.GRAY + e.getPlayer().getName() + ChatColor.DARK_GRAY + ": " + ChatColor.GRAY + e.getMessage());
        }
    }
 
 
    ScoreboardManager manager = Bukkit.getScoreboardManager();
    Scoreboard board = manager.getNewScoreboard();
    Team owner = board.registerNewTeam("owner");
    Team developer = board.registerNewTeam("developer");
    Team admin = board.registerNewTeam("admin");
    Team moderator = board.registerNewTeam("moderator");
    Team famous = board.registerNewTeam("famous");
    Team donator = board.registerNewTeam("donator");
    Team player = board.registerNewTeam("player");
 
 
 
    public void setRank(Player p, String s, CommandSender sender){
        getConfig().set(p.getName(), s);
        saveConfig();
        if(s.equalsIgnoreCase("owner")){
            owner.addPlayer(p);
            sendMessage(p, sender.getName() + " has set you to Rank: " + ChatColor.DARK_RED + s);
        }
        if(s.equalsIgnoreCase("developer")){
            developer.addPlayer(p);
            sendMessage(p, sender.getName() + " has set you to Rank: " + ChatColor.DARK_RED + s);
        }
        if(s.equalsIgnoreCase("admin")){
            admin.addPlayer(p);
            sendMessage(p, sender.getName() + " has set you to Rank: " + ChatColor.DARK_RED + s);
        }
        if(s.equalsIgnoreCase("moderator")){
            moderator.addPlayer(p);
            sendMessage(p, sender.getName() + " has set you to Rank: " + ChatColor.DARK_RED + s);
        }
        if(s.equalsIgnoreCase("famous")){
            famous.addPlayer(p);
            sendMessage(p, sender.getName() + " has set you to Rank: " + ChatColor.DARK_RED + s);
        }
        if(s.equalsIgnoreCase("donator")){
            donator.addPlayer(p);
            sendMessage(p, sender.getName() + " has set you to Rank: " + ChatColor.DARK_RED + s);
        }
        if(s.equalsIgnoreCase("player")){
            player.addPlayer(p);
            p.setPlayerListName(p.getName());
        }
    }
    public String getRank(Player p){
        String rank = getConfig().getString(p.getName());
        return rank;
    }
 
    public void sendMessage(Player p, String s){
        p.sendMessage(ChatColor.GRAY + "[" + ChatColor.AQUA + "SimpleRanks" + ChatColor.GRAY + "] " + ChatColor.AQUA + s);
    }
 
    public boolean onCommand(CommandSender sender, Command cmd, String label, String[] args){
 
        if(cmd.getName().equalsIgnoreCase("rank")){
            if(sender instanceof Player){
                Player p = (Player) sender;
                if(p.isOp()){
                    if(args.length == 0){
                        sendMessage(p, "/rank list");
                        sendMessage(p, "/rank set <player> <rank>");
                    }else if(args.length >= 1){
                        if(args[0].equalsIgnoreCase("list")){
                            sendMessage(p, "Ranks:");
                            sendMessage(p, ChatColor.DARK_RED + "Owner(7)");
                            sendMessage(p, ChatColor.DARK_RED + "Developer(6)");
                            sendMessage(p, ChatColor.RED + "Admin(5)");
                            sendMessage(p, ChatColor.AQUA + "Moderator(4)");
                            sendMessage(p, ChatColor.GOLD + "Famous(3)");
                            sendMessage(p, ChatColor.YELLOW + "Donator(2)");
                            sendMessage(p, ChatColor.GREEN + "Player(1)");
                        }else if(args[0].equalsIgnoreCase("set")){
                            if(args.length == 3){
 
                            Player t = (Player) Bukkit.getPlayer(args[1]);
                            if(t == null){
                                sendMessage(p, ChatColor.DARK_RED + "Player not Found.");
                            }else {
                                if(args[2].equalsIgnoreCase("owner") || args[2].equalsIgnoreCase("7")){
                                    sendMessage(p, "Sucessfully added " + t.getName() + " to Owner");
                                    sendMessage(t, "You are now: " + ChatColor.DARK_RED + "OWNER");
                                    setRank(t, "owner", p);
                                }
 
 
                                if(args[2].equalsIgnoreCase("developer") || args[2].equalsIgnoreCase("6")){
                                    sendMessage(p, "Sucessfully added " + t.getName() + " to Developer");
                                    sendMessage(t, "You are now: " + ChatColor.DARK_RED + "DEVELOPER");
                                    setRank(t, "developer", p);
 
                                }
 
                                if(args[2].equalsIgnoreCase("admin") || args[2].equalsIgnoreCase("5")){
                                    sendMessage(p, "Sucessfully add " + t.getCustomName() + " to Admin");
                                    sendMessage(t, "You are now: " + ChatColor.RED + "ADMIN");
                                    setRank(t, "admin", p);
                                }
 
                                if(args[2].equalsIgnoreCase("moderator") || args[2].equalsIgnoreCase("4")){
                                    sendMessage(p, "Sucessfully add " + t.getCustomName() + " to Moderator");
                                    sendMessage(t, "You are now: " + ChatColor.AQUA + "MODERATOR");
                                    setRank(t, "moderator", p);
                                }
 
                                if(args[2].equalsIgnoreCase("famous") || args[2].equalsIgnoreCase("3")){
                                    sendMessage(p, "Sucessfully add " + t.getCustomName() + " to Famous");
                                    sendMessage(t, "You are now: " + ChatColor.GOLD + "FAMOUS");
                                    setRank(t, "famous", p);
                                }
 
                                if(args[2].equalsIgnoreCase("donator") || args[2].equalsIgnoreCase("2")){
                                    sendMessage(p, "Sucessfully add " + t.getCustomName() + " to Donator");
                                    sendMessage(t, "You are now: " + ChatColor.YELLOW + "DONATOR");
                                    setRank(t, "donator", p);
                                }
 
                                if(args[2].equalsIgnoreCase("player") || args[2].equalsIgnoreCase("1")){
                                    sendMessage(p, "Sucessfully add " + t.getCustomName() + " to Player");
                                    sendMessage(t, "You are now: " + ChatColor.GREEN + "PLAYER");
                                    setRank(t, "player", p);
                                }
                            }
 
                            }else {
                                sendMessage(p, ChatColor.DARK_RED + "/rank set <player> <rank>");
                            }
                        }
 
 
                    }
 
                }else {
                    if(sender instanceof Player && label.equalsIgnoreCase("rank")){
                    sendMessage(p, ChatColor.DARK_RED + "Server Operators Only!");
                }else {sender.sendMessage(ChatColor.RED + "players only");}
                }
            }
            }else {
                sender.sendMessage(ChatColor.DARK_RED + "Players only");
            }
 
 
 
 
return true;  
}
}
 
 
 

Ummm Can anyone Help?

Bump

EDIT by Moderator: merged posts, please use the edit button instead of double posting.