Simple Currency - Saving Hashmaps

I have worked on some code set a players currency. I've setup a hashmap, and players are added to that hashmap on the PlayerJoinEvent, as shown below. I'm wondering what would be the simplest way to save this hashmap to the config file every time someone joins and when the currency is modified in anyway. Here is the code so far:

Code:java

HashMap<String, Integer> money = new HashMap<String, Integer>();
 
    @EventHandler
    public void onJoin(PlayerJoinEvent event){
 
        Player player = event.getPlayer();
        if(!money.containsKey(player.getName())){
 
            money.put(player.getName(), 100);
 
            if(money.containsKey(player.getName())){
 
                player.sendMessage("Added to the HashMap!");
 
            }
 
        }
 
    }

^PlayerJoinEvent, setting player to hashmap^

Code:java

@EventHandler
    public void onHit(EntityDamageByEntityEvent event){
 
        Player damager = (Player)event.getEntity();
 
        if(money.containsKey(damager.getName())){
 
            money.put(damager.getName(), money.get(damager.getName()) + 5);
 
        }
 
        Player player = (Player)event.getEntity();
 
        if(money.containsKey(player.getName())){
 
            money.put(player.getName(), money.get(damager.getName()) - 5);
 
        }
 
    }

^Simple change in the hashmap, modifying the players currency^

Thanks! Doooogs

 

Doooogle
You can set the map to the config.

Code:java

getConfig().set("money", money);

Not sure for loading the money, but I think you get it using getConfig().get("money") and cast it to a map.

 

Minecrell

Would I put this in the playerjoinevent?

 

You need to add before saving the configuration using saveConfig(), so if you want to update the configuration in the join event you need to add it there.

 

Getting an error after putting it under the PlayerJoinEvent;

Code:

[SEVERE] Could not pass event PlayerJoinEvent to HungerInfinity v1.0
org.bukkit.event.EventException
    at org.bukkit.plugin.java.JavaPluginLoader$1.execute(JavaPluginLoader.java:427)
    at org.bukkit.plugin.RegisteredListener.callEvent(RegisteredListener.java:62)
    at org.bukkit.plugin.TimedRegisteredListener.callEvent(TimedRegisteredListener.java:30)
    at org.bukkit.plugin.SimplePluginManager.fireEvent(SimplePluginManager.java:478)
    at org.bukkit.plugin.SimplePluginManager.callEvent(SimplePluginManager.java:463)
    at net.minecraft.server.v1_6_R3.PlayerList.c(PlayerList.java:209)
    at net.minecraft.server.v1_6_R3.PlayerList.a(PlayerList.java:105)
    at net.minecraft.server.v1_6_R3.PendingConnection.e(PendingConnection.java:188)
    at net.minecraft.server.v1_6_R3.PendingConnection.d(PendingConnection.java:52)
    at org.spigotmc.netty.NettyServerConnection.b(NettyServerConnection.java:138)
    at net.minecraft.server.v1_6_R3.MinecraftServer.t(MinecraftServer.java:604)
    at net.minecraft.server.v1_6_R3.DedicatedServer.t(DedicatedServer.java:240)
    at net.minecraft.server.v1_6_R3.MinecraftServer.s(MinecraftServer.java:493)
    at net.minecraft.server.v1_6_R3.MinecraftServer.run(MinecraftServer.java:425)
    at net.minecraft.server.v1_6_R3.ThreadServerApplication.run(SourceFile:583)
Caused by: java.lang.IllegalArgumentException: File cannot be null
    at org.apache.commons.lang.Validate.notNull(Validate.java:192)
    at org.bukkit.configuration.file.YamlConfiguration.loadConfiguration(YamlConfiguration.java:170)
    at org.bukkit.plugin.java.JavaPlugin.reloadConfig(JavaPlugin.java:117)
    at org.bukkit.plugin.java.JavaPlugin.getConfig(JavaPlugin.java:111)
    at HungerInfinity.Doooogle.me.HungerCurrency.onJoin(HungerCurrency.java:29)
    at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
    at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source)
    at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source)
    at java.lang.reflect.Method.invoke(Unknown Source)
    at org.bukkit.plugin.java.JavaPluginLoader$1.execute(JavaPluginLoader.java:425)
    ... 14 more

Dunno if the error message is any help, but before I added in the getConfig().set stuff, it showed the player a message when they were added to the hashmap, just to make sure that they were added. After I added the getConfig, it isn't working :/

 

Looks like there's something wrong with your plugin class... Can you post the complete plugin class here?

 

http://pastebin.com/RQwtJWzj here is the plugin class for that. The core class that has the onEnable stuff is in a different class, if you need that, ask.

 

Don't make your listener / command class extend JavaPlugin. Instead pass the instance to a constructor and use it to load and save the configuration.

 

http://pastebin.com/HW1y4haU
HungerCore is the main class with the onEnabe; once I added the part you said to add into the HungerCurrency (current class) it gave errors to the registerEvents in the main class (HungerCore). The whole thing still isn't working, but there's no error now, I have a feeling it may be due to the lack of registering events.

 

Now you need to register the events and commands in the main plugin class. (Make sure passing your plugin instance when creating the class!)

Code:java

HungerCurrency currency = new HungerCurrency(this);
getServer().getPluginManager().registerEvents(currency, this);
// And for the command

 

Works now, registering the events and stuff. The config would be found under the plugin folder in the plugin directory, right? If so, I opened this, and there is no changes to the config file, it's still empty as usual. Thanks for your help man! Really appreciated!

 

You need to save the configuration to the file system after changing it. Just call plugin.saveConfig() after setting the map and it should work.

 

ONE last thing when I load the config with plugin.getconfig().get("money"), do I put that in the main class under the onEnable() or in the HungerCurrency under something else, and what is that something else if that is where you put it (PlayerJoinevent, etc.)? Thanks a ton.

 

You can add it in the constructor of your listener class. Something like:

Code:java

money = (Map<String, Integer>) plugin.getConfig().get("money");

That should work, but it would be good if you test it first because I don't know exactly..

 

Code:java

public class HungerCurrency implements Listener, CommandExecutor{
 
    public HungerCore plugin;
    public HungerCurrency(HungerCore plugin){
 
        this.plugin = plugin;
 
    }
 
    HashMap<String, Integer> money = new HashMap<String, Integer>();
    money = (Map<String, Integer>) plugin.getConfig().get("money");

Like this? When I do it, the ; after the HashMap part has a syntax error.

 

Doooogle
No, add it in your constructor (after you set the plugin). ^^

 

Minecrell

Code:java

 public HungerCurrency(HungerCore plugin){
 
this.plugin = plugin;
 
}

If you mean in there (just new to Bukkit/java atm, still have a lot to learn, I think that's the constructor), it gives me an error when I put the money = (Map<String, Integer>) part in there.

 

Doooogle
Yes, that's the constructor.
What exactly does it say? (Post something like the error message)

 

Minecrell
The error is "Map<String, Integer> cannot be resolved to a type".

 

Oh, try using (HashMap<String, Integer>) instead.

 

Minecrell
Got an error when I reloaded the plugin this time. Changed it to HashMap, this is what it's like in the class: http://puu.sh/6h6at.png
Error message on plugin reload;

Code:

[SEVERE] Error occurred while enabling HungerInfinity v1.0 (Is it up to date?)
java.lang.ClassCastException: org.bukkit.configuration.MemorySection cannot be cast to java.util.HashMap
    at HungerInfinity.Doooogle.me.HungerCurrency.<init>(HungerCurrency.java:23)
    at HungerInfinity.Doooogle.me.HungerCore.onEnable(HungerCore.java:10)
    at org.bukkit.plugin.java.JavaPlugin.setEnabled(JavaPlugin.java:217)
    at org.bukkit.plugin.java.JavaPluginLoader.enablePlugin(JavaPluginLoader.java:457)
    at org.bukkit.plugin.SimplePluginManager.enablePlugin(SimplePluginManager.java:382)
    at org.bukkit.craftbukkit.v1_6_R3.CraftServer.loadPlugin(CraftServer.java:288)
    at org.bukkit.craftbukkit.v1_6_R3.CraftServer.enablePlugins(CraftServer.java:270)
    at org.bukkit.craftbukkit.v1_6_R3.CraftServer.reload(CraftServer.java:618)
    at org.bukkit.Bukkit.reload(Bukkit.java:277)
    at org.bukkit.command.defaults.ReloadCommand.execute(ReloadCommand.java:24)
    at org.bukkit.command.SimpleCommandMap.dispatch(SimpleCommandMap.java:192)
    at org.bukkit.craftbukkit.v1_6_R3.CraftServer.dispatchCommand(CraftServer.java:532)
    at net.minecraft.server.v1_6_R3.PlayerConnection.handleCommand(PlayerConnection.java:986)
    at net.minecraft.server.v1_6_R3.PlayerConnection.chat(PlayerConnection.java:897)
    at net.minecraft.server.v1_6_R3.PlayerConnection.a(PlayerConnection.java:838)
    at net.minecraft.server.v1_6_R3.Packet3Chat.handle(Packet3Chat.java:47)
    at org.spigotmc.netty.NettyNetworkManager.b(NettyNetworkManager.java:237)
    at net.minecraft.server.v1_6_R3.PlayerConnection.e(PlayerConnection.java:117)
    at net.minecraft.server.v1_6_R3.ServerConnection.b(SourceFile:37)
    at org.spigotmc.netty.NettyServerConnection.b(NettyServerConnection.java:131)
    at net.minecraft.server.v1_6_R3.MinecraftServer.t(MinecraftServer.java:604)
    at net.minecraft.server.v1_6_R3.DedicatedServer.t(DedicatedServer.java:240)
    at net.minecraft.server.v1_6_R3.MinecraftServer.s(MinecraftServer.java:493)
    at net.minecraft.server.v1_6_R3.MinecraftServer.run(MinecraftServer.java:425)
    at net.minecraft.server.v1_6_R3.ThreadServerApplication.run(SourceFile:583)

 

Doooogle
Hmm, too bad it's not working. I'm going to test it myself, can you post the generated configuration here?

Doooogle
Ok, I think I got it working. Replace this line:

Code:java

HashMap<String, Integer> money = new HashMap<String, Integer>();

With this one:

Code:java

Map<String, Integer> money;

And now load it like this:

Code:java

ConfigurationSection moneySection = this.getConfig().getConfigurationSection("money");
// Create the money section in the configuration if there is none
if (moneySection == null) moneySection = this.getConfig().createSection("money");
// Load the map
money = (Map) moneySection.getValues(false);

Make sure importing Map, so you don't get the unknown type error again.
(That's probably not the best way of doing this, but I can't think of another way at the moment..)

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

Minecrell
Still having an issue with the "money = (Map) moneySection.getValues(false);". The error is "The expression of type Map needs unchecked conversion to conform to Map<String, Integer>".

 

That should be only a warning, not a real compiler error. You can try adding the annotation before that line so it won't be displayed:

Code:java

@SupressWarnings("unchecked")