Filled SaveMyItems

Discussion in 'Plugin Requests' started by MacMasterMac, Jan 7, 2020.

Thread Status:
Not open for further replies.
  1. Offline

    MacMasterMac

    Minecraft version: 1.8.8 (I know yall hate this)

    Suggested name: SaveMyItems

    What I want:
    1) By any death, a chest spawns at your deathlocation.
    2) In this chest it contains all the items you had in your inventory+armor you were wearing
    3) I'd like to be it a doublechest in case the chest is full. BUT -> is it possible to right click a single chest and show a double chest GUI? Whatever is easier for you.
    4) Be able to break the chest & drop the loot
    5) Up on death, a (private?) message is being sent to the player with XYZ coords of the chest
    6) Could the message be:
    Example (open)
    upload_2020-1-7_21-22-8.png


    No holograms
    No signs
    No timeouts

    DeathChests does not work
    DeathChest does not work
    DeathTpPlus does not work
    BasicDeathChest does not work
    SavageDeathchest does not work
    PRO DeathChest does not work
    VanillaDeathchest does not work

    So here I am ...

    Ideas for commands:
    I believe none

    Ideas for permissions:
    savemyitems.chest

    When I'd like it by: I've been trying and looking for ages, I'm happy if anyone can just make it whenever.

    Thank you?!
    Much much much appreciated
     
  2. Offline

    dbaum102

    Ill give it a try
    Edit: Wait you want it in 1.8 Okay!
     
    Last edited: Jan 7, 2020
    MacMasterMac likes this.
  3. Offline

    MacMasterMac

    Mad respect

    Yeah! Sorry! Community server on 1.8 !
     
    dbaum102 likes this.
  4. Offline

    dbaum102

    I just finished with it no worries was pretty easy :) ill get the download link in a second!

    https://dev.bukkit.org/projects/savemyitems
     
    Last edited: Jan 7, 2020
    MacMasterMac likes this.
  5. Offline

    MacMasterMac

  6. Offline

    dbaum102

    They are in the process of reviewing it.. will be <30 minutes before they approve sorry!
     
    MacMasterMac likes this.
  7. Offline

    MacMasterMac

    Oh I see, I didn't know that was a thing! I'll wait for a bit then. I'll edit my message when I know more :)
    Thank you in advance

    @dbaum102
    Dying with a full inventory gives me the following error:
    Code:
    [23:14:39 ERROR]: Could not pass event PlayerDeathEvent to SaveMyItems v1.0
    org.bukkit.event.EventException
            at com.massivecraft.massivelag.inject.event.MassiveLagEventExecutor.exec
    ute(MassiveLagEventExecutor.java:77) ~[?:?]
            at org.bukkit.plugin.RegisteredListener.callEvent(RegisteredListener.jav
    a:62) ~[spigot-1.8.8.jar:git-Spigot-21fe707-e1ebe52]
            at org.bukkit.plugin.SimplePluginManager.fireEvent(SimplePluginManager.j
    ava:502) [spigot-1.8.8.jar:git-Spigot-21fe707-e1ebe52]
            at org.bukkit.plugin.SimplePluginManager.callEvent(SimplePluginManager.j
    ava:487) [spigot-1.8.8.jar:git-Spigot-21fe707-e1ebe52]
            at org.bukkit.craftbukkit.v1_8_R3.event.CraftEventFactory.callPlayerDeat
    hEvent(CraftEventFactory.java:396) [spigot-1.8.8.jar:git-Spigot-21fe707-e1ebe52]
    
            at net.minecraft.server.v1_8_R3.EntityPlayer.die(EntityPlayer.java:417)
    [spigot-1.8.8.jar:git-Spigot-21fe707-e1ebe52]
            at net.minecraft.server.v1_8_R3.EntityLiving.damageEntity(EntityLiving.j
    ava:812) [spigot-1.8.8.jar:git-Spigot-21fe707-e1ebe52]
            at net.minecraft.server.v1_8_R3.EntityHuman.damageEntity(EntityHuman.jav
    a:800) [spigot-1.8.8.jar:git-Spigot-21fe707-e1ebe52]
            at net.minecraft.server.v1_8_R3.EntityPlayer.damageEntity(EntityPlayer.j
    ava:496) [spigot-1.8.8.jar:git-Spigot-21fe707-e1ebe52]
            at org.bukkit.craftbukkit.v1_8_R3.entity.CraftLivingEntity.damage(CraftL
    ivingEntity.java:241) [spigot-1.8.8.jar:git-Spigot-21fe707-e1ebe52]
            at org.bukkit.craftbukkit.v1_8_R3.entity.CraftLivingEntity.damage(CraftL
    ivingEntity.java:229) [spigot-1.8.8.jar:git-Spigot-21fe707-e1ebe52]
            at com.earth2me.essentials.commands.Commandsuicide.run(Commandsuicide.ja
    va:21) [Essentials-2.x-SNAPSHOT.jar:?]
            at com.earth2me.essentials.commands.EssentialsCommand.run(EssentialsComm
    and.java:180) [Essentials-2.x-SNAPSHOT.jar:?]
            at com.earth2me.essentials.Essentials.onCommandEssentials(Essentials.jav
    a:527) [Essentials-2.x-SNAPSHOT.jar:?]
            at com.earth2me.essentials.Essentials.onCommand(Essentials.java:402) [Es
    sentials-2.x-SNAPSHOT.jar:?]
            at org.bukkit.command.PluginCommand.execute(PluginCommand.java:44) [spig
    ot-1.8.8.jar:git-Spigot-21fe707-e1ebe52]
            at com.massivecraft.massivelag.inject.command.MassiveLagCommandMap.dispa
    tch(MassiveLagCommandMap.java:91) [MassiveLag.jar:?]
            at org.bukkit.craftbukkit.v1_8_R3.CraftServer.dispatchCommand(CraftServe
    r.java:641) [spigot-1.8.8.jar:git-Spigot-21fe707-e1ebe52]
            at net.minecraft.server.v1_8_R3.PlayerConnection.handleCommand(PlayerCon
    nection.java:1162) [spigot-1.8.8.jar:git-Spigot-21fe707-e1ebe52]
            at net.minecraft.server.v1_8_R3.PlayerConnection.a(PlayerConnection.java
    :997) [spigot-1.8.8.jar:git-Spigot-21fe707-e1ebe52]
            at net.minecraft.server.v1_8_R3.PacketPlayInChat.a(PacketPlayInChat.java
    :45) [spigot-1.8.8.jar:git-Spigot-21fe707-e1ebe52]
            at net.minecraft.server.v1_8_R3.PacketPlayInChat.a(PacketPlayInChat.java
    :1) [spigot-1.8.8.jar:git-Spigot-21fe707-e1ebe52]
            at net.minecraft.server.v1_8_R3.PlayerConnectionUtils$1.run(SourceFile:1
    3) [spigot-1.8.8.jar:git-Spigot-21fe707-e1ebe52]
            at java.util.concurrent.Executors$RunnableAdapter.call(Unknown Source) [
    ?:1.8.0_231]
            at java.util.concurrent.FutureTask.run(Unknown Source) [?:1.8.0_231]
            at net.minecraft.server.v1_8_R3.SystemUtils.a(SourceFile:44) [spigot-1.8
    .8.jar:git-Spigot-21fe707-e1ebe52]
            at net.minecraft.server.v1_8_R3.MinecraftServer.B(MinecraftServer.java:7
    15) [spigot-1.8.8.jar:git-Spigot-21fe707-e1ebe52]
            at net.minecraft.server.v1_8_R3.DedicatedServer.B(DedicatedServer.java:3
    74) [spigot-1.8.8.jar:git-Spigot-21fe707-e1ebe52]
            at net.minecraft.server.v1_8_R3.MinecraftServer.A(MinecraftServer.java:6
    54) [spigot-1.8.8.jar:git-Spigot-21fe707-e1ebe52]
            at net.minecraft.server.v1_8_R3.MinecraftServer.run(MinecraftServer.java
    :557) [spigot-1.8.8.jar:git-Spigot-21fe707-e1ebe52]
            at java.lang.Thread.run(Unknown Source) [?:1.8.0_231]
    Caused by: java.lang.IllegalArgumentException: Invalid inventory size; expected
    27 or less
            at org.bukkit.craftbukkit.v1_8_R3.inventory.CraftInventory.setContents(C
    raftInventory.java:64) ~[spigot-1.8.8.jar:git-Spigot-21fe707-e1ebe52]
            at dbaum.saveItems.main.Main.onDeath(Main.java:45) ~[?:?]
            at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) ~[?:1.8.0
    _231]
            at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source) ~[?:1.8.0
    _231]
            at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source) ~[?:1
    .8.0_231]
            at java.lang.reflect.Method.invoke(Unknown Source) ~[?:1.8.0_231]
            at com.massivecraft.massivelag.inject.event.MassiveLagEventExecutor.exec
    ute(MassiveLagEventExecutor.java:67) ~[?:?]
            ... 30 more
    1) The items do not go in the chest if you receive this error
    2) Dying from a Creeper does not create a chest
    3) Is it possible to change the message in a config?
    Like change colorcode & add spaces between the coords? (it's very long now xD)
    4) Possible to round it to zero digits?
    MSG (open)
    upload_2020-1-7_23-25-0.png

    Thank you btw, this has been working better than all those other plugins already!
    I believe in you
     
    Last edited: Jan 7, 2020
  8. Offline

    dbaum102


    Oops i did not have a lotta time to bug test Ill fix and let you know when i update it. Let me know if anything else doesnt work properly

    EDIT: Fixed its in the process of verifying:
    https://dev.bukkit.org/projects/savemyitems
     
    Last edited: Jan 7, 2020
    MacMasterMac likes this.
  9. Offline

    MacMasterMac

    Hey sorry I was at work, I just got home!
    1) The error is gone thankfully :)
    2) Full inventory works now!
    3) Unfortunately it always generates 3 chests now? Lol
    upload_2020-1-9_0-32-25.png

    4) Can you create a config or prefer not?

    5) Mind telling me what you have in mind?
    Is it standart 1 chest and expands to a double chest in case needed?
    Or is it always a double chest?
    Or something else?
     
  10. Offline

    dbaum102


    What would you like it to be?
    Also I didnt notice the 3 chests popping up when I tested I'll look into it thanks!
    What kind of things would u want in the config?

    EDIT:
    It was supposed to be just a double chest every time but I could make it a single if inventory is less I was just lazy I'll do that now I have some free time :)

    Posting update Now:
    I am quite surprised at how many bugs I have overlooked throughout this super simple plugin. I was probably just rushing it because I wanted to do a bunch but what good is a bunch of broken plugins xD So, if you need anything further whether an update for this or fix just let me know or any future ideas thanks :p
     
    Last edited: Jan 8, 2020
  11. Offline

    MacMasterMac

    It would be nice if I was able to change the deathmessage in the config!
    Flashback (open)
    upload_2020-1-9_0-49-48.png


    I like that! But seems a lot of work for you...
    Is it possible/easier to show a doublechest GUI while opening a 1 block chest? Then you don't need a double chest!

    Thank you :)
     

    Attached Files:

  12. Offline

    dbaum102

    Oh yah I also didnt like that I left decimals in there I changed that already but forgot to mention. The simplest way for this to work was the double chest spawning if inventory is more full than the single chest capacity as well as prioritize air over blocks for the second chest.

    EDIT:
    Approved: https://dev.bukkit.org/projects/savemyitems
     
    Last edited: Jan 8, 2020
    MacMasterMac likes this.
  13. Offline

    MacMasterMac

    Yay it's working great now :)
    But I noticed a chest doesn't generate when a creeper kills you. Could you just make it so this chest can't explode? That should probably fix it!

    I tested every other death possible and it works great :)

    EDIT: If you can't/don't/want to add a config, could you then just remove the message? Thanks
     
    Last edited: Jan 8, 2020
  14. Offline

    dbaum102

    Sorry for late response took a break but I added the config and fixed the creeper explosion! Not sure when they will approve the file but great job on doing bug testing and being thorough with the request!
     
  15. Offline

    MacMasterMac

    Hey! I tested it again. It's great! Thank you so much for the config :D
    Also a chest DOES generate this time after a creeper kills you which is awesome
    Unfortunately, I don't know why, but the error is back D:
    Code:
    [19:47:48 WARN]: [SaveMyItems] Task #1013 for SaveMyItems v1.0 generated an exce
    ption
    java.lang.IllegalArgumentException: Invalid inventory size; expected 27 or less
            at org.bukkit.craftbukkit.v1_8_R3.inventory.CraftInventory.setContents(C
    raftInventory.java:64) ~[spigot-1.8.8.jar:git-Spigot-21fe707-e1ebe52]
            at dbaum.saveItems.main.Main$1.run(Main.java:79) ~[?:?]
            at com.massivecraft.massivelag.inject.task.MassiveLagRunnable.run(Massiv
    eLagRunnable.java:54) ~[?:?]
            at org.bukkit.craftbukkit.v1_8_R3.scheduler.CraftTask.run(CraftTask.java
    :71) ~[spigot-1.8.8.jar:git-Spigot-21fe707-e1ebe52]
            at org.bukkit.craftbukkit.v1_8_R3.scheduler.CraftScheduler.mainThreadHea
    rtbeat(CraftScheduler.java:350) [spigot-1.8.8.jar:git-Spigot-21fe707-e1ebe52]
            at net.minecraft.server.v1_8_R3.MinecraftServer.B(MinecraftServer.java:7
    23) [spigot-1.8.8.jar:git-Spigot-21fe707-e1ebe52]
            at net.minecraft.server.v1_8_R3.DedicatedServer.B(DedicatedServer.java:3
    74) [spigot-1.8.8.jar:git-Spigot-21fe707-e1ebe52]
            at net.minecraft.server.v1_8_R3.MinecraftServer.A(MinecraftServer.java:6
    54) [spigot-1.8.8.jar:git-Spigot-21fe707-e1ebe52]
            at net.minecraft.server.v1_8_R3.MinecraftServer.run(MinecraftServer.java
    :557) [spigot-1.8.8.jar:git-Spigot-21fe707-e1ebe52]
            at java.lang.Thread.run(Unknown Source) [?:1.8.0_231]
    I have no idea what the error code means, but I can tell you what I saw.
    You only receive this error once you die with a full inventory, there is no double chest being generated and the items are gone as well. Luckily the default 1 block chest without a full inventory still works!

    Sorry to be a pain in the ass, but is it possible for you to put spaces between the coords?
    It's hard to tell what are the exact coords now since there are so many comma's xD upload_2020-1-9_20-2-39.png
     
  16. Offline

    MacMasterMac

    Like is it -5011968 245 406
    or -50 119 68245406
    or -50119 68 256406
    ?
     
  17. Offline

    dbaum102

    I got you gimme a few I am not sure about the other error ill look into it.

    EDIT: Fixed pushing an update for you :p i swear it worked before but I guess I did not retest past bugs oh well fixed now as well as the commas.
     
    Last edited: Jan 10, 2020
  18. Offline

    MacMasterMac

    Have you uploaded it yet? :eek:
    The most recent one I can find is the creeper bug fix
    Also you kinda got a lot of downloads already :eek:
    Unless that is you re-downloading it everytime XD
     
  19. Online

    timtower Moderator Moderator

    @MacMasterMac Don't forget that the fill aproval takes time.
     
  20. Offline

    MacMasterMac

    Yeah but usually that's <30 mins, not 17 hours :eek:?
     
  21. Online

    timtower Moderator Moderator

    It is weekend
     
    MacMasterMac likes this.
  22. Offline

    MacMasterMac

    Still no update :(

    Edit: Finally an update!

    Thank you so much @dbaum102 for all your work. It's 100% working now just how I wanted to. You're the best and I appreciate u
     
    Last edited: Jan 13, 2020
Thread Status:
Not open for further replies.

Share This Page