[RPG/MECH] mcMMO v1.2.07 - RPG Addiction Redefined! Multi-Lingual! [1337][1549]

Discussion in 'Inactive/Unsupported Plugins' started by nossr50, Feb 5, 2011.

Thread Status:
Not open for further replies.
  1. Offline

    nossr50

  2. Offline

    nossr50

    @Joy Are you doing that threading yourself, or is bukkit doing some wizardy? mcMMO doesn't have multi-threading at the moment.

    A lot of code changes happened with 1.0.17, I'll have to look really closely at everything again to try to find this leak. Everything should be getting collected properly with 1.0.20 however, so I'm puzzled as to where this leak is happening in my own code.

    Can anyone else confirm the leak besides Joy?

    Regardless, I'll give my newly changed code another once over and try to see if I did anything stupid.
     
  3. Offline

    Joy

    And here is a top view on mcMMO 1.0.16: http://i.imgur.com/lIvN9.png

    And realize that the one I posted from 1.0.20 is at it's lowest pretty much, that 2nd thread spikes up a lot and fast.
     
  4. Offline

    Darcion

    we got massive laags only with 3 players on 1.0.20, wihtout it the server runs fine with lots of plugins and lots of players.
     
  5. Offline

    Joy

    Threading myself? I wouldn't even know what why, I haven't modifyed mcMMO at all. It's also not a memory leak as such, more of a CPU leak.

    Are you sure you don't have threads? Otherwise I don't see why you can get this error at all:

    Code:
    2011-06-17 10:21:33 [SEVERE] Exception in thread "Timer-2"
    2011-06-17 10:21:33 [SEVERE] java.lang.NullPointerException
    2011-06-17 10:21:33 [SEVERE]    at com.gmail.nossr50.mcPermissions.permission(mcPermissions.java:31)
    2011-06-17 10:21:33 [SEVERE]    at com.gmail.nossr50.mcPermissions.herbalismAbility(mcPermissions.java:56)
    2011-06-17 10:21:33 [SEVERE]    at com.gmail.nossr50.skills.Skills.monitorSkills(Skills.java:154)
    2011-06-17 10:21:33 [SEVERE]    at com.gmail.nossr50.mcTimer.run(mcTimer.java:33)
    2011-06-17 10:21:33 [SEVERE]    at java.util.TimerThread.mainLoop(Timer.java:555)
    2011-06-17 10:21:33 [SEVERE]    at java.util.TimerThread.run(Timer.java:505)
    At least I figured that's a Timer thread...
     
  6. Offline

    sintri

    Well now there's no way to disabled commands with the yml without permissions. Before you could just use special characters for the commands, now they don't parse properly.
     
  7. Offline

    Joy

  8. Offline

    sintri

    Neither essentials nor that is stopping the commands, both the actual commands nor the rebinded command usage. Bit annoying. It does seem to stop other plugins so.

    Not even overriding the commands with essentials then disabling them works. Is pretty annoying. Anyone have a copy of 1.0.16?
     
  9. Offline

    Nori_Silverrage

    Thankyou!! I upgraded, saw all kinds of errors and I was bumming out then I saw you already updated to fix it! You are awesome!
     
  10. Offline

    gekomees

    How do I disable party systems, group chat systems and other commands?
     
  11. Offline

    Zaoshi

    It seems players cannot use Super Breaker (mining ability), but all other seem to work, however with '*' permission it works for me. Here's my default permissions for players:
     
  12. Offline

    gekomees

    Also, I don't gain experience in my server. What could be wrong?

    Edit: On testing I found that MINING doesn't get any experience while Acrobatics, Excavation and Woodcutting do.

    Now that others have seemingly activated. The only problem is left with Mining skill, which does not gain experience from stone mining but does from ores. I have itemcraft plugin with mo'creatures enabled. What could cause this?
     
  13. Offline

    yuckfoooo

    Below is a list of bugs I've confirmed on version 1.0.17+:

    Mining does not gain experience.
    Setting Fire_Rate_Limiter to false does not work.

    Nossr50, really nice work on the plugin :D I hope you don't mind but I'm going through the source to find the cause of these errors. I noticed this is causing some problems in LoadProperties.java:

    Code:
    enableCobbleToMossy = readBoolean("MySQL.Enabled");
    archeryFireRateLimit = readBoolean("MySQL.Enabled");
    Looks like just a c/p error :D

    If I find anything else I'll let you know.

    edit:

    P.S. wasn't able to reproduce memory leak problem others are experiencing with < 20 players on my server.

    Also:

    Code:
    mstone = readInteger("XP.Mining.Sand");
     
  14. Offline

    RugRats

    Your welcome because I instantly reported the error :D
     
  15. Offline

    Vittek

    @Nossr

    There seems be a clash between MCM and McMMO that has borked some stuff in the later MCM versions. And someone posted this.
    Anyway anything can be done about it? Never had a problem running MCMMO and MCM together, and problem (Mainly broken obsidian catcher block) started showing up in the latest MCM versions.
     
  16. Offline

    Zaoshi

    Sorry for quoting myself, but just extra information.
    It appears players do get Mining, Excavation and Unarmed experience, but rightclicking doesn't activate the skill. On other hand, rightclicking with axe DOES activate skill.
    Anyone knows how to fix this?
    Thank you.

    P.S. If I grant all permissions, it works, so probably there's some hidden permissions?
     
  17. Offline

    Nachocuban

    Is there a way to limit item usage to require a certain skill level? Say, you can only use a wooden pickaxe until mining 10, a stone until 50, etc...

    If not, would it be possible for another plugin to read the mcMMO skill levels, and use them for itself?
     
  18. Offline

    TehJammers

    Change mcmmo.ability to mcmmo.ability.*

    As for woodcutting, it's always been a bit shitty and buggy with the activation messages. It doesn't work if you don't have the permissions, but it shows the activation messages anyway if you have the permission for the skill. It's a bit confusing , I must say :p
     
  19. Offline

    Darcion

    after a few hours and 20-30 players without your plugin our server runs great... no laags no problems and i am build lots of big things with worldedit and we dont get any probs.

    sorry for that sarcasm but all my server problems comes from mcmmo one of the best plugins ever, but if this dont get better i will drop it and take another rpg plugin.
     
  20. Offline

    wassilij

    I have no longer problems with mcMMO, THX :)
     
  21. Offline

    Pasukaru

    @nossr50

    I found a bug inside your LoadProperties class (v1.0.20)

    Line 237:
    mstone = readInteger("XP.Mining.Sand");

    Is it really supposed to read Sand instead of Stone?
    Because thats why no one is getting exp from mining stone on my server.
    I added the configuration node XP.Mining.Sand to my config to fix this error for now..
    I suggest everyone else to do the same if you want to get experience from mining stone.

    I hope you can fix this soon ;)
     
  22. Offline

    yaitsbilly

    People can one hit blocks with fist. Need help.
     
  23. Offline

    gekomees

    Can you teach how to do this or PM me the modified file or what you meant by config file.
     
  24. Offline

    yuckfoooo

    In config.yml, add

    Code:
            Sand: 3
    under the XP -> Mining section right below "Stone: 3". Make sure you use spaces instead of tabs.
     
  25. Offline

    mooman219

    I went on mySQL, Looked at all my skills for mooman219, added them up with a calculator (Including Taming) Got 1092, went on my bukkit server and typed /stats, and it said my power level was 1092. Sorry if i didn't help you in my other post, but in version 1.0.20, There is no issue with Taming and powerlevel.
     
  26. Offline

    Lead2Life

    Hello
    I maybe found a bug. I activated giga drill breaker with a shovel and it lasts for 15 real time seconds like the description with /excavation says but then I saw the skull splitter from axes skill and the description says that it would last for 44 seconds now and that's wrong. It maybe lasts for 7~10 seconds.
     
  27. Offline

    nossr50

    It's true, this is how mcMMO checks blocks for being placed by the player or not as default vanilla MC doesn't use the byte data of many blocks. I've been meaning to replace it with a better system. I could put in a toggle to stop it from happening.

    Whats your axes skill at? It shouldn't last for 44 seconds unless your skill is incredibly high.

    I'll fix it, thanks for pointing it out :3

    Dohoho, thats not good...

    I'll get the reported problems fixed soon.
     
  28. Offline

    Vittek


    That be awesome!
     
  29. Offline

    nossr50

    I'll put it in soon, this update is a hotfix

    Derp, I forgot something crucial in the config file, going to patch that now...
    Dropbox link down temporarily.

    Version 1.0.21
    • Fixed Skull Splitter length in /axes displaying incorrectly
    • Fire rate limiter now correctly uses the value in the config file
    • Stone XP now correctly uses the value in the config file
    • Cobble -> Mossy now correctly uses the value in the config file
    • Removed setmyspawn from config file as it serves no purpose
    • All commands now have an 'Enabled' node in the config file that when set to false disables the command completely
    • Fixed color scheme inconsistency for Mining in /whois results
     
    sintri likes this.
  30. Offline

    RugRats

    What about no swords exp when using the special ability against ghasts or slimes?
     
  31. Offline

    nossr50

    Version 1.0.22
    • Added 'Name' nodes to commands for renaming them
    Must've missed that bug report, I'll fix it next patch.

    Those updating from older versions need to either delete config.yml to generate a new one or modify the 'Commands' part of config.yml to look like this

    Code:
    Commands:
        mctop:
            Name: mctop
            Enabled: true
        addxp:
            Name: addxp
            Enabled: true
        mcability:
            Name: mcability
            Enabled: true
        mcrefresh:
            Name: mcrefresh
            Enabled: true
        mcmmo:
            Name: mcmmo
            Enabled: true
        mcc:
            Name: mcc
            Enabled: true
        mcgod:
            Name: mcgod
            Enabled: true
        stats:
            Name: stats
            Enabled: true
        mmoedit:
            Name: mmoedit
            Enabled: true
        ptp:
            Name: ptp
            Enabled: true
        party:
            Name: party
            Enabled: true
        myspawn:
            Name: myspawn
            Enabled: true
        whois:
            Name: whois
            Enabled: true
        invite:
            Name: invite
            Enabled: true
        accept:
            Name: accept
            Enabled: true
        clearmyspawn:
            Name: clearmyspawn
            Enabled: true
     
Thread Status:
Not open for further replies.

Share This Page