Solved Remove @Override annotation?

Hey Guys,
If i want to do a onCommand method, i cant.
I thought we need to set the @Override annotation on top of the method?
So i did it, and the hole public boolean onCommand became red?
If you want my code, ask it.
Anyways, Thanks for your help.
iAmGuus

 

That's exactly the purpose of the @Override. It only will make your method produce an error if you've not overriden anything So be happy that the compiler protected you

Possible reasons: Your Plugin-Class needs to extend JavaPlugin. The method signature of your onCommand needs to match the one defined in the Plugin-Interface.

 

iAmGuus What's the error your IDE is telling you if you hover over your onCommand method?

Another thing, that @Override annotation isn't anything you have to have in order for it work, all @Override does is tell the compiler to actually check you're properly overriding the method from the implemented interface, in this case CommandExecutor. In that case it'll show errors if your method is, as an example, misspelled. It also just makes it easier for other developers to read your code and see what's being overwritten. (Hope I explained that well )

 

Azubuso It says : "The method onCommand(Command, CommandSender, String, String[]) of type Main must override a superclass method"

and by the way, here is my code:

Code:java

package com.cookiedeveloped.main;
 
import java.util.ArrayList;
import java.util.Arrays;
 
import org.bukkit.ChatColor;
import org.bukkit.Material;
import org.bukkit.command.Command;
import org.bukkit.command.CommandSender;
import org.bukkit.enchantments.Enchantment;
import org.bukkit.entity.Player;
import org.bukkit.event.Listener;
import org.bukkit.inventory.Inventory;
import org.bukkit.inventory.ItemStack;
import org.bukkit.inventory.meta.ItemMeta;
import org.bukkit.plugin.java.JavaPlugin;
 
public class Main extends JavaPlugin implements Listener{
 
@Override
public void onEnable() {
getLogger().info("xKits has been enabled!");
getCommand("pvp").setExecutor(this);
getCommand("archer").setExecutor(this);
}
 
@Override
public void onDisable() {
getLogger().info("xKits has been disabled!");
}
ArrayList<String> pvp = new ArrayList<String>();
ArrayList<String> archer = new ArrayList<String>();
 
 
 
@Override
public boolean onCommand(Command cmd, CommandSender sender, String label, String[] args) {
//PVP KIT
if(cmd.getName().equalsIgnoreCase("pvp")) {
if(sender instanceof Player) {
Player p = (Player) sender;
if(!pvp.contains(p.getName())) {
pvp.add(p.getName());
} else {
p.sendMessage("" + ChatColor.GRAY + ChatColor.BOLD + "eXperiencePvP>" + ChatColor.GREEN + ChatColor.BOLD + "You already have this kit!");
}
ItemStack soup = new ItemStack(Material.MUSHROOM_SOUP);
 
Inventory inv = p.getInventory();
inv.addItem(new ItemStack(Material.STONE_SWORD));
inv.addItem(soup);
inv.addItem(soup);
inv.addItem(soup);
inv.addItem(soup);
inv.addItem(soup);
inv.addItem(soup);
inv.addItem(soup);
inv.addItem(soup);
 
inv.addItem(soup);
inv.addItem(soup);
inv.addItem(soup);
inv.addItem(soup);
inv.addItem(soup);
inv.addItem(soup);
inv.addItem(soup);
inv.addItem(soup);
inv.addItem(soup);
 
inv.addItem(soup);
inv.addItem(soup);
inv.addItem(soup);
inv.addItem(soup);
inv.addItem(soup);
inv.addItem(soup);
inv.addItem(soup);
inv.addItem(soup);
inv.addItem(soup);
 
inv.addItem(soup);
inv.addItem(soup);
inv.addItem(soup);
inv.addItem(soup);
inv.addItem(soup);
inv.addItem(soup);
inv.addItem(soup);
inv.addItem(soup);
inv.addItem(soup);
 
p.sendMessage("" + ChatColor.GRAY + ChatColor.BOLD + "eXperiencePvP>" + ChatColor.GREEN + ChatColor.BOLD + "You have recieved the PvP kit!");
 
}
}
//END PVP KIT
 
//ARCHER KIT
if(cmd.getName().equalsIgnoreCase("archer")) {
if(sender instanceof Player) {
Player p = (Player) sender;
if(!archer.contains(p.getName())) {
archer.add(p.getName());
} else {
p.sendMessage("" + ChatColor.GRAY + ChatColor.BOLD + "eXperiencePvP>" + ChatColor.GREEN + ChatColor.BOLD + "You already have this kit!");
}
ItemStack soup = new ItemStack(Material.MUSHROOM_SOUP);
ItemStack bow = new ItemStack(Material.BOW);
ItemMeta bowmeta = bow.getItemMeta();
bowmeta.setDisplayName("" + ChatColor.BOLD + ChatColor.DARK_BLUE + "Archer Bow!");
bowmeta.setLore(Arrays.asList("" + ChatColor.BOLD + ChatColor.DARK_BLUE + "This is the archer bow!"));
bow.setItemMeta(bowmeta);
bow.addEnchantment(Enchantment.ARROW_INFINITE, 1);
bow.addEnchantment(Enchantment.ARROW_KNOCKBACK, 1);
 
Inventory inv = p.getInventory();
inv.addItem(new ItemStack(Material.STONE_SWORD));
inv.addItem(soup);
inv.addItem(soup);
inv.addItem(soup);
inv.addItem(soup);
inv.addItem(soup);
inv.addItem(soup);
inv.addItem(soup);
inv.addItem(bow);
 
inv.addItem(soup);
inv.addItem(soup);
inv.addItem(soup);
inv.addItem(soup);
inv.addItem(soup);
inv.addItem(soup);
inv.addItem(soup);
inv.addItem(soup);
inv.addItem(new ItemStack(Material.ARROW));
 
inv.addItem(soup);
inv.addItem(soup);
inv.addItem(soup);
inv.addItem(soup);
inv.addItem(soup);
inv.addItem(soup);
inv.addItem(soup);
inv.addItem(soup);
inv.addItem(soup);
 
inv.addItem(soup);
inv.addItem(soup);
inv.addItem(soup);
inv.addItem(soup);
inv.addItem(soup);
inv.addItem(soup);
inv.addItem(soup);
inv.addItem(soup);
inv.addItem(soup);
 
p.sendMessage("" + ChatColor.GRAY + ChatColor.BOLD + "eXperiencePvP>" + ChatColor.GREEN + ChatColor.BOLD + "You have recieved the Archer! kit!");
}
}
//END ARCHER
 
return false;
}
 
}
 

And DxDy, its in my main class which already extends JavaPlugin

 

iAmGuus
It's onCommand(CommandSender, Command, ...) not onCommand(Command, CommandSender, ...)

A little sidenote: Lines 51-88 can be written in 2 lines using a loop

 

iAmGuus Ah I see, that's becuase your onCommand method is "Command cmd, CommandSender sender, String label, String[] args) ..." instead of "CommandSender sender, Command cmd, String label, String[] args) ..." Change that and you should be good to go.

Also, you might wanna do something about the way you're giving that "soup" itemstack...why aren't you using a loop?

EDIT: God dangit ninjad

 

You can use a loop, although I believe loops require calling player.updateInventory() too.

 

iAmGuus
You can shorten the "inv.addItem(soup) * 5000000" by making a for loop, and looping however many times you want to add the soup. This makes 40+ lines into about 5 at most.

Edit: Ninja'd by KingFaris11 Just realized that DxDy said that a while ago

It's also strange your are getting that error.. what version of Bukkit are you building against?
Azubuso found your error, never mind.

 

DxDy & Azubuso Thanks guys, Could someone make an example like KingFaris10 said.

 

iAmGuus
Basic for loop:

Code:java

for (int i = 1; int <= 50; i++) {
    inv.addItem(soup);
    // p.updateInventory();?
}

 

Azubuso Thanks, i got it. I was trying to make my own KitPvP plugin for my server, so if i need anymore help. I'll come back here.
Thanks for all your support!
iAmGuus