Remove an item from a dispenser on item dispense

At the moment I've got some simple code so if an item being dispensed is coal then set it to redstone.

Code:java

 
    @EventHandler
    public void onDispenseItem(BlockDispenseEvent event) {
      ItemStack coal = new ItemStack(Material.COAL);
 
      if(event.getItem().equals(coal)) {
          event.setItem(new ItemStack(Material.REDSTONE));
          }
      }
 

I have a dispenser with a redstone clock so that it gets the coal in there and shoots it out as redstone every second.

The problem I'm having is that the coal that's in there isn't disappearing once it's been shot out as redstone. So for example: I place 5 coal inside the dispenser > the dispenser shoots out an unlimited amount of redstone and the 5 coal is still in the dispenser.

Is there a way to remove a coal every time a redstone is shot out or just to make it normal?

Thanks in advance!

 

ThunderWaffeMC
On BlockDispenseEvent, get the block (which in this case is dispenser), check if block is dispenser, get the block inventory, check if it contains atleast 1 coal, if yes, then remove 1 coal from it. Check the javadocs for correct methods on how to do this.

 

I got this from the javadocs and there's nothing for removing items from the block. Any idea?

 

ThunderWaffeMC

Code:java

if(event.getBlock() instanceof Dispenser) {
    Dispenser dispenser = (Dispenser) event.getBlock(); //.getState() ?
    Inventory inventory = dispenser.getInventory(); // You might have to use BlockInventory instead.
 
    if(inventory.containsAtleast(new ItemStack(Material.COAL, 1))) {
        inventory.removeItem(new ItemStack(Material.COAL, 1));
    }
}

Put that inside your getItem() check.

By the way, I wrote this on my phone, so something might not be correct, but you should get the idea.

 

Okay I'll try that now. And also would it have anything to do with: ItemStack coal = new ItemStack(Material.COAL);? Does it matter if it has new ItemStack (hopefully that isn't the reason why it's creating more items)

Okay I've got:

Code:java

 
    @EventHandler
    public void onDispenseItem(BlockDispenseEvent event) {
      ItemStack coal = new ItemStack(Material.COAL);
 
      if(event.getItem().equals(coal)) {
          if(event.getBlock() instanceof Dropper) {
              Dropper dropper = (Dropper) event.getBlock().getState();
              Inventory inventory = dropper.getInventory();
 
                  if(inventory.contains(new ItemStack(Material.COAL))) {
                      event.setItem(new ItemStack(Material.REDSTONE));
                      inventory.removeItem(new ItemStack(Material.COAL, 1));
                      }
                }
              }
      }
 

And it just dispenses coal.

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

ThunderWaffeMC
Debug your code.

 

It stops working at:

Code:java

 
if(event.getBlock() instanceof Dropper) {
 

What's wrong with it?

 

Is the item going through a dropper? I see nothing wrong in your code, that should work just fine.

 

Yeah. I have it so a player drops the coal into some water which takes it to a hopper which leads into a dropper.



I've got a redstone clock connected to the dropper so it should dispense the coal as redstone (remove the coal and dispense a redstone) every second.

Assist

I changed it again to:

Code:java

 
    @EventHandler
    public void onDispenseItem(BlockDispenseEvent event) {
      ItemStack coal = new ItemStack(Material.COAL);
 
      if(event.getItem().equals(coal)) {
          Bukkit.broadcastMessage("1");
          if(event.getBlock().equals(Material.DROPPER));
          Bukkit.broadcastMessage("2");
              Dropper dropper = (Dropper) event.getBlock();
              Bukkit.broadcastMessage("3");
              Inventory inventory = dropper.getInventory();
              Bukkit.broadcastMessage("4");
                  if(inventory.contains(new ItemStack(Material.COAL))) {
                      Bukkit.broadcastMessage("5");
                      event.setItem(new ItemStack(Material.REDSTONE));
                    Bukkit.broadcastMessage("6");
                      inventory.removeItem(new ItemStack(Material.COAL, 1));
                      Bukkit.broadcastMessage("7");
                }
              }
      }
 

and now it doesn't do 3 which is: Dropper dropper = (Dropper) event.getBlock();

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

ThunderWaffeMC

Code:java

 Dropper dropper = (Dropper) event.getBlock().getState();

 

Thanks for all your help. But it stops again after the forth test on: if(inventory.containsAtLeast(new ItemStack(Material.COAL), 1)) {

 

Looks like you have a bracket mistake. Use this

Code:java

if(inventory.containsAtLeast(new ItemStack(Material.COAL, 1) {

 

I've got this and it goes all the way to 7 but it doesn't remove the coal... I have no idea?

Code:java

 
    @EventHandler
    public void onDispenseItem(BlockDispenseEvent event) {
      ItemStack coal = new ItemStack(Material.COAL);
 
      if(event.getItem().equals(coal)) {
          Bukkit.broadcastMessage("1");
          if(event.getBlock().equals(Material.DROPPER));
          Bukkit.broadcastMessage("2");
                Dropper dropper = (Dropper) event.getBlock().getState();
              Bukkit.broadcastMessage("3");
              Inventory inventory = dropper.getInventory();
              Bukkit.broadcastMessage("4");
                      event.setItem(new ItemStack(Material.REDSTONE));
                    Bukkit.broadcastMessage("6");
                      inventory.removeItem(new ItemStack(Material.COAL, 1));
                      Bukkit.broadcastMessage("7");
                }
              }
 

 

ThunderWaffeMC
Try updating the inventory after you remove an item from it.

Also,

Code:java

if(event.getBlock().equals(Material.DROPPER));

is wrong. You might want to fix that.

 

What is wrong when getting the dropper? Getting the instanceof the dropper doesn't work.

Also, how can I update the dropper inventory? This wont work? inventory.updateInventory();

 

Code:

if(event.getBlock().equals(Material.DROPPER)) {
    // code here
}

Your 'if' statement ended to a semicolon.

 

Oh I didn't see that. Thanks! But how can I update the inventory for a dropper?

 

ThunderWaffeMC I don't know if this would work, but you could update the block state with:

Code:

dropper.update();

 

I'm not sure if that works but I don't think it's got to do with updating the inventory because it still sends more redstone out then there is in the dropper and usually when the inventory hasn't been updated it will just have an unusable image of the icon so when you click it or try using it it disappears.

What I need is a way to turn the coal into redstone on dispense or remove the coal on dispense.

 

Assist Compressions Any update or any ideas?

 

ThunderWaffeMC
I'll write my own code later, and see how it turns out.

 

Thanks. I guess bukkit just came back up since it was down.