So the other day I got a new modem. Ever since then I can not get anyone else to connect to my server (external IP) I can connect (localhost) I'v tried all i knew.. disabling firewalls, re port forwarding, trying to port forward directly on the new MODEM. I still have the same router (netgear) I checked if my IPv4 changed it didn't. What else can I try?
you are of course using the correct external ip - as a new modem connection is almost certainly going to change the ip. Check really carefully on the ipv4 for a subtlety... a router might use a slightly different ipv4 gateway, you may have had a 192.168.0.xxx ip before, but now actually have 192.168.1.xxx and your xxx may be the same but you overlooked the 3rd position change.