Solved Poison Water?

Hey, I would like to know how make poison water. By that I mean, if a player is in water, then wait a second, then do damage.

I've tried with the PlayerMoveEvent, but they are always moving which makes them constantly get hurt.

Make sense? If so, please help. If not, please ask for clarification.

 

I have no idea if this would work but, you could try to for loop through all online players, get their locations, get the block in the location, if that block equals water, then do whatever


Sent from my iPad using Tapatalk

 

You were right in using the on player move event. Test if the block they moved to was water, then either give them the poison effect, or schedule a sync repeating task. If you need any more help tahg me

 

@CreeperFace0777

I tried that, I don't know how to use a sync repeating task (nevertheless know what it does.)

I used a delayed task, but that continuously dealt damage after 2 seconds.

 

I'd create a HashMap that contains the player and a time value of how long they've been in the water. Then, in your onEnable(), have a repeating task

Code:

onEnable() {
    new BukkitRunnable() {
        @Override
        public void run() {
            //increment time in hashmap using a for-loop of all online players, checking if they're in the water, if they are increasing it, if they're not removing them.
        }
    }.runTaskTimer(this, 0L, 20L); //Repeats what's in the middle every second (20 ticks = 1 second)
}

Such as that which is provided above. In the middle of that, after increasing it, check if their time in the water is past a threshold, then damage them.

Note: whether the player is in water could be determined by the block's type being water at their location of their feet.

 

Sync Repeated Task is very similar to a delayed one:

Code:

Bukkit.getScheduler().scheduleSyncRepeatingTask(plugin, runnable, time between repeats in ticks. I suggest 5 as the player move event is called every 5 ticks 

So when the player moves, check if the block below them is type water. If it is run the task
I'm the runnable, check if the block below the player is still water and if it is set their health to their current health minus whatever you want [/CODE]

 

@CreeperFace0777

Would this do it?

Code:java

 
@EventHandler
    public void waterDamage(PlayerMoveEvent e){
        Player p = e.getPlayer();
        Material m = p.getLocation().getBlock().getType();
        if(p.getWorld().getName().equals("MurderMystery-1")){
       if (m == Material.STATIONARY_WATER || m == Material.WATER) {
          Bukkit.getScheduler().scheduleSyncRepeatingTask(main, new Runnable(){
                public void run(){
                    if(e.getTo().getBlock().getType() == Material.WATER || e.getTo().getBlock().getType() == Material.STATIONARY_WATER){
                    p.damage(1);
                    }
                }
            }, 40, 5);
    }
    }
    }
 

It still does the same thing.

 

Hmm I see. Put the players into a map/hashmap. So you put the player into a hashmap once the runnable starts. And then test if the player is in the hashmap. If they are then return.

 

Don't use PlayerMoveEvent.

It's much simpler and efficient to create a repeating task (only create one in onEnable) that runs every 20 ticks (=1 second), loop through all players, check if the block at their locations is water, then damage the player using .damage(amount).

 

@FisheyLP

How exactly would I do this? I can't get the online players into a loop.

EDIT: Would this work:

Code:java

 
public void onEnable(){
        Bukkit.getScheduler().scheduleSyncRepeatingTask(main, new Runnable(){
            public void run(){
                String[] players = (String[]) Bukkit.getOnlinePlayers().toArray();
                int playersInt = Bukkit.getOnlinePlayers().size();
                for(int i = 0; i <= playersInt; i++){
                    Player p = Bukkit.getPlayerExact(players"["i"]");  //Bukkit.org italicized everything
                    if(p.getLocation().getBlock().getType() == Material.WATER || p.getLocation().getBlock().getType() == Material.STATIONARY_WATER){
                        Bukkit.getScheduler().scheduleSyncDelayedTask(main, new Runnable(){
                            public void run(){
                                p.damage(1);
                            }
                        }, 20);
                    }
                }
            }
        }, 20, 0);
    }
 

Because.. Well... It's not working.

 

@timtower

So what do I do?

 

Loop through online players in a repeating task set at 20ticks. 1 tick is equal to 1/20 of a second.

if(!understood){
google.search();
}

 

Code:

for (Player player : Bukkit.getOnlinePlayers()) {

Keep in mind that this is basic java and if you're having problems with such things, it won't be as fun/fast to develop plugins...

 

@FisheyLP @Protophite @timtower

This still isn't working (probably some stupid mistake):

Code:java

 
@EventHandler
    public void onEnable(){
        Bukkit.getScheduler().scheduleSyncRepeatingTask(main, new Runnable(){
            public void run(){
                for(Player p : Bukkit.getOnlinePlayers()){
                    if(p.getLocation().getBlock().getType() == Material.WATER || p.getLocation().getBlock().getType() == Material.STATIONARY_WATER){
                        Bukkit.getScheduler().scheduleSyncDelayedTask(main, new Runnable(){
                            public void run(){
                                p.damage(1);
                            }
                        }, 20);
                    }
                }
            }
        }, 20, 0);
    }
}
 

 

Maybe because there is an event handler annotation above your on enable?

Edit: this could also be as the player loop should be inside the runnable

 

@GRocksMc

}, 20, 0); you are running ur scheduler every 0 ticks. replace it by 20.

Why there's an @eventHandler if it's your onEnable method ?

 

@timtower @Caderape2 @CreeperFace0777

I've changed my code to:

Code:java

 
@Override
    public void run() {
        for(Player p : Bukkit.getOnlinePlayers()){
            if(p.getLocation().getBlock().getType() == Material.WATER || p.getLocation().getBlock().getType() == Material.STATIONARY_WATER){
                Bukkit.getScheduler().scheduleSyncDelayedTask(main, new Runnable(){
                    public void run(){
                        p.damage(1);
                    }
                }, 20);
            }
        }
 
    }
 

Main:

Code:java

 
@SuppressWarnings("unused")
    @Override
    public void onEnable(){
            BukkitTask TaskName = new poisonWater(this).runTaskTimer(this, 20, 20);
    }
}
 

Still isn't doing damage to the player. It is actually running the task now though.

Oh, and when using a repeating task, what are the 2 numbers at the end?

 

@GRocksMc What is not working ? show your two full class.

 

@timtower @CreeperFace0777 @Caderape2

Main class is setup perfectly, go to my other threads to see.

Only other thing in the poison water class is that it extends BukkitRunnable and sets anew instance for the main class.

 

@GRocksMc

Can I see your plugin.yml? Is your plugin being enabled?

Also, instead of doing your runnable like that, I prefer doing this way:

Code:

/**
* don't forget to extend JavaPlugin
*/

    @Override
    public void onEnable(){

        new BukkitRunnable() {

         int time = 0;

           public void run() {

             if (time >= 5) { //a self cancel implement if wanted - 5 seconds
                 this.cancel();

             } else {

               player.damage(1);
               time++;
                }
            }.runTaskTimer(this, 20L);

 

@mehboss

The plugin is being enable, the poison water is not the only part. Everything else is working fine.

EDIT: Welp, I don't know what was wrong, but it just started working. (I didn't use your way @mehboss )

 

Try that