Solved Plugin Half Working... Need help.

So I'm developing a PVP type plugin where you have to use commands to do stuff (e.g. join the lobby, choose your class, etc) and the join portion works as for now but what is bugging me is the class choosing. I've got it set up so it uses command arguments so you do /class (classname) and if you just do /class, it provides you with a list of the available classes to you. Now, thats all fine.... When I go to type /class and then the class name, it says what its meant to (telling you that you've successfully chosen the class) but before hand, it shows me the list of the classes. I am not sure why and I cannot figure out how to prevent this. Any help with be greatly appreciated!

Source Code So Far:

Code:java

package com.omegagamers.rf2minecraft.PVPBattle;
import org.bukkit.ChatColor;
import org.bukkit.command.Command;
import org.bukkit.command.CommandSender;
import org.bukkit.plugin.java.JavaPlugin;
 
public final class PVPBattle extends JavaPlugin {
    public void onEnable() {
        getLogger().info("PVPBattle by RobloxianFire2 has been enabled!");
    }
    public void onDisable() {
        getLogger().info("PVPBattle by RobloxianFire2 has been disabled!");
    }
 
    public boolean onCommand(CommandSender sender, Command cmd, String label, String[] args) {
        if(cmd.getName().equalsIgnoreCase("join")) {
            sender.sendMessage(ChatColor.RED + "" + ChatColor.ITALIC + "" + "Please choose your class.");
        }
        if(cmd.getName().equalsIgnoreCase("class")) {
            sender.sendMessage(ChatColor.RED + "" + "Please choose your class:");
            sender.sendMessage(ChatColor.RED + "" + "Warrior: /class warrior");
            sender.sendMessage(ChatColor.RED + "" + "Archer: /class archer");
            if (args[0].equalsIgnoreCase("warrior")) {
                sender.sendMessage(ChatColor.GREEN + "You have chosen:" + "" + ChatColor.GOLD + "Warrior.");
            } else
            if(args[0].equalsIgnoreCase("archer")) {
                sender.sendMessage(ChatColor.GREEN + "You have chosen:" + "" + ChatColor.GOLD + "Archer.");
            }
        return true;
    }
        return false;
  }
}

 

It's because you don't have a closing bracket after your class if statement.

Code:

if(cmd.getName().equalsIgnoreCase("class")) { <---
            sender.sendMessage(ChatColor.RED + "" + "Please choose your class:");
            sender.sendMessage(ChatColor.RED + "" + "Warrior: /class warrior");
            sender.sendMessage(ChatColor.RED + "" + "Archer: /class archer");
            if (args[0].equalsIgnoreCase("warrior")) { <---
                sender.sendMessage(ChatColor.GREEN + "You have chosen:" + "" + ChatColor.GOLD + "Warrior.");
            } else
            if(args[0].equalsIgnoreCase("archer")) {
                sender.sendMessage(ChatColor.GREEN + "You have chosen:" + "" + ChatColor.GOLD + "Archer.");
            }

So the code will go all the way through.
Try something like:

Code:

if(cmd.getName().equalsIgnoreCase("class")) {
            sender.sendMessage(ChatColor.RED + "" + "Please choose your class:");
            sender.sendMessage(ChatColor.RED + "" + "Warrior: /class warrior");
            sender.sendMessage(ChatColor.RED + "" + "Archer: /class archer");
}
            if (args[0].equalsIgnoreCase("warrior")) {
                sender.sendMessage(ChatColor.GREEN + "You have chosen:" + "" + ChatColor.GOLD + "Warrior.");
            } else
            if(args[0].equalsIgnoreCase("archer")) {
                sender.sendMessage(ChatColor.GREEN + "You have chosen:" + "" + ChatColor.GOLD + "Archer.");
            }

 

You're not checking how many arguments you recieve. With your code, it'll display the arguments and then move onto the class if statements. Fixed/Prettied up a bit:

Code:java

if(cmd.getName().equalsIgnoreCase("class")) {
        if (args.length==0) {
            sender.sendMessage(ChatColor.RED + "" + "Please choose your class:");
            sender.sendMessage(ChatColor.RED + "" + "Warrior: /class warrior");
            sender.sendMessage(ChatColor.RED + "" + "Archer: /class archer");
        }else if (args.length==1){
            if (args[0].equalsIgnoreCase("warrior")) {
                sender.sendMessage(ChatColor.GREEN + "You have chosen:" + "" + ChatColor.GOLD + "Warrior.");
            } else
            if(args[0].equalsIgnoreCase("archer")) {
                sender.sendMessage(ChatColor.GREEN + "You have chosen:" + "" + ChatColor.GOLD + "Archer.");
            }else{
                sender.sendMessage(ChatColor.RED+"That is not a valid class!");
            }
        }else{
            sender.sendMessage(ChatColor.RED+"Correct usage: /class [class]");
        }
        return true;
}

 

Cheers guys. Plugin is working fine now.