[?] Plugin giving no messages or stack traces.

I am currently coding a plugin, and two of the commands are not only not sending the player any messages as they are supposed to, but there are also absolutely no stack traces. Help would be very appreciated!

Command 1 : TakeBadges, give no stacktrace and no messages, and I can't find my logic flaw.

Code:java

public boolean onCommand(CommandSender s, Command cc, String cl, String[] args) {
        Player p = (Player) s;
        if (cl.equalsIgnoreCase("takebagdes")){
 
            if (args[0].equals(null)){p.sendMessage(Badges + "You cannot take away " + ChatColor.DARK_PURPLE + "null" + ChatColor.LIGHT_PURPLE + "'s badges!");}
            List<Player> playerList = p.getWorld().getPlayers();
            Player[] players = p.getWorld().getPlayers().toArray(new Player[playerList.size()]);
            boolean playerNameIsGood = false;
            Player takeBadgesFrom = null;
 
            for (int i = 0; i > players.length; i++){
                if (args[0].equalsIgnoreCase(players[i].getName())){
                    playerNameIsGood = true;
                    takeBadgesFrom = players[i];
                    break;
                }
            }
 
            if (p.hasPermission("badges.kanto.elitefour")){
 
                if (playerNameIsGood){
                    int total = 0;
                    List<String> a = this.getConfig().getStringList("DATA.BADGEDATA.KANTO.PEWTER");
                    List<String> b = this.getConfig().getStringList("DATA.BADGEDATA.KANTO.CERULEAN");
                    List<String> c = this.getConfig().getStringList("DATA.BADGEDATA.KANTO.VERMILION");
                    List<String> d = this.getConfig().getStringList("DATA.BADGEDATA.KANTO.CELADON");
                    List<String> e = this.getConfig().getStringList("DATA.BADGEDATA.KANTO.FUSHCIA");
                    List<String> f = this.getConfig().getStringList("DATA.BADGEDATA.KANTO.SAFFRON");
                    List<String> g = this.getConfig().getStringList("DATA.BADGEDATA.KANTO.CINNABAR");
                    List<String> h = this.getConfig().getStringList("DATA.BADGEDATA.KANTO.VIRIDIAN");
                    if (a.contains(takeBadgesFrom.getName())){total++;}
                    if (c.contains(takeBadgesFrom.getName())){total++;}
                    if (c.contains(takeBadgesFrom.getName())){total++;}
                    if (d.contains(takeBadgesFrom.getName())){total++;}
                    if (e.contains(takeBadgesFrom.getName())){total++;}
                    if (f.contains(takeBadgesFrom.getName())){total++;}
                    if (g.contains(takeBadgesFrom.getName())){total++;}
                    if (h.contains(takeBadgesFrom.getName())){total++;}
                    if (total != 8){
                        p.sendMessage(Badges + "The player doesn't have all eight badges! Why are you trying to take them?");
                    } else {
                        a.remove(takeBadgesFrom.getName());
                        b.remove(takeBadgesFrom.getName());
                        c.remove(takeBadgesFrom.getName());
                        d.remove(takeBadgesFrom.getName());
                        e.remove(takeBadgesFrom.getName());
                        f.remove(takeBadgesFrom.getName());
                        g.remove(takeBadgesFrom.getName());
                        h.remove(takeBadgesFrom.getName());
                        this.getConfig().set("DATA.BADGEDATA.KANTO.PEWTER", a);
                        this.getConfig().set("DATA.BADGEDATA.KANTO.CERULEAN", b);
                        this.getConfig().set("DATA.BADGEDATA.KANTO.VERMILION", c);
                        this.getConfig().set("DATA.BADGEDATA.KANTO.CELADON", d);
                        this.getConfig().set("DATA.BADGEDATA.KANTO.FUCHSIA", e);
                        this.getConfig().set("DATA.BADGEDATA.KANTO.SAFFRON", f);
                        this.getConfig().set("DATA.BADGEDATA.KANTO.CINNABAR", g);
                        this.getConfig().set("DATA.BADGEDATA.KANTO.VIRIDIAN", h);
                        this.saveConfig();
                        p.sendMessage(Badges + "You took away " + ChatColor.DARK_PURPLE + p.getName() + ChatColor.LIGHT_PURPLE + "'s eight Kanto badges. Let the match begin!");
                        takeBadgesFrom.sendMessage(Badges + "Elite Four " + ChatColor.DARK_PURPLE + p.getName() + ChatColor.LIGHT_PURPLE + " took away your eight Kanto badges. Let the match begin!");
                    }
                } else {
                    p.sendMessage(Badges + "The player " + ChatColor.DARK_PURPLE + args[0] + ChatColor.LIGHT_PURPLE + " is not on the server.");
                }
            }[/i][/i]

<Skipping duplicate of the above code for Johto and the code for the command that works>

Command 3: givebadge, gives no stacktraces or messages, can't find my logic flaw

Code:java

else if (cl.equalsIgnoreCase("givebadge")){
 
            //Checking if the player to give a badge to is actually on the server
            if (args[0].equals(null)){
                p.sendMessage(Badges + "You cannot give a badge to " + ChatColor.DARK_PURPLE + "null");
            } List<Player> playerList = p.getWorld().getPlayers();
            Player[] players = p.getWorld().getPlayers().toArray(new Player[playerList.size()]);
            boolean playerNameIsGood = false;
            Player giveBadgeTo = null;
            for (int i = 0; i > players.length; i++){
                if (args[0].equalsIgnoreCase(players[i].getName())){
                    playerNameIsGood = true;
                    giveBadgeTo = players[i];
                    break;
                }
            }
 
            if (playerNameIsGood){
                if (p.hasPermission("badges.kanto.pewter")){
                    p.sendMessage(Badges + "You gave the " + ChatColor.GRAY + "Boulder Badge" + "to" + ChatColor.DARK_PURPLE + giveBadgeTo.getName());
                    giveBadgeTo.sendMessage(Badges + "You were given the " + ChatColor.GRAY + "Boulder Badge" + "by" + ChatColor.DARK_PURPLE + "Gym Leader " + p.getName());
                    List<String> badgeList = this.getConfig().getStringList("DATA.BADGEDATA.KANTO.PEWTER");
                    if (badgeList.contains(giveBadgeTo.getName())){
                        giveBadgeTo.sendMessage(Badges + "But wait! You already have that badge!");
                        giveBadgeTo.sendMessage(Badges + "You return the badge to the gym leader.");
                        p.sendMessage(Badges + "But wait! That player already has that badge!");
                        p.sendMessage(Badges + "The player returns the badge to you.");
                    } else {
                        badgeList.add(giveBadgeTo.getName());
                        this.getConfig().set("DATA.BADGEDATA.KANTO.PEWTER", badgeList);
                        this.saveConfig();
                    }
                } else if (p.hasPermission("badges.kanto.cerulean")){
                    p.sendMessage(Badges + "You gave the " + ChatColor.BLUE + "Cascade Badge" + "to" + ChatColor.DARK_PURPLE + giveBadgeTo.getName());
                    giveBadgeTo.sendMessage(Badges + "You were given the " + ChatColor.BLUE + "Cascade Badge" + "by" + ChatColor.DARK_PURPLE + "Gym Leader " + p.getName());
                    List<String> badgeList = this.getConfig().getStringList("DATA.BADGEDATA.KANTO.CERULEAN");
                    if (badgeList.contains(giveBadgeTo.getName())){
                        giveBadgeTo.sendMessage(Badges + "But wait! You already have that badge!");
                        giveBadgeTo.sendMessage(Badges + "You return the badge to the gym leader.");
                        p.sendMessage(Badges + "But wait! That player already has that badge!");
                        p.sendMessage(Badges + "The player returns the badge to you.");
                    } else {
                        badgeList.add(giveBadgeTo.getName());
                        this.getConfig().set("DATA.BADGEDATA.KANTO.CERULEAN", badgeList);
                        this.saveConfig();
                    }
                }
[/i][/i]

<more duplicate code of the above>

Any help would be very appreciated!

 

I guess you didn't register the commands with plugin.getCommand("givebadge").setExecutor(yourExecutor);

Also I found some other problems:

> Player p = (Player) s;
Will throw an error if the command is run from the console. Check s instanceof Player first.

> if (args[0].equals(null)){
Will throw an error if no arguments are given, and will never evaluate to true. Check args.length >= 1 first (or == 1 if you only expect one argument)

Also you can replace this whole chunk of code:

Code:java

List<Player> playerList = p.getWorld().getPlayers();
Player[] players = p.getWorld().getPlayers().toArray(new Player[playerList.size()]);
boolean playerNameIsGood = false;
Player takeBadgesFrom = null;
 
for (int i = 0; i > players.length; i++){
if (args[0].equalsIgnoreCase(players[i].getName())){
playerNameIsGood = true;
takeBadgesFrom = players[i];
break;
}
}[/i][/i]

with this line:

Code:java

Player takeBadgesFrom = Bukkit.getPlayerExact(args[0]);

and instead of playerNameIsGood use takeBadgesFrom != null.

 

Njol what is "plugin.getCommand("givebadge").setExecutor(yourExecutor);" and how do I use it?

THANK YOU!! Because of your helps up top, I got the plugin working