PlayerInteractEvent Signs...

Hello, I was testing out the sign feature for a kitpvp plugin im making. And I have to use the PlayerInteractEvent to know when a player interacts with a sign. So I tried and looked up videos and stuff and it would work. The SignChangeEvent works but not the Interact with signs for me here my code if you could tell me what I did wrong

Code:java

package me.chibbey.signtest;
 
import org.bukkit.Bukkit;
import org.bukkit.ChatColor;
import org.bukkit.Material;
import org.bukkit.block.Sign;
import org.bukkit.event.EventHandler;
import org.bukkit.event.Listener;
import org.bukkit.event.block.Action;
import org.bukkit.event.player.PlayerInteractEvent;
import org.bukkit.inventory.ItemStack;
import org.bukkit.plugin.java.JavaPlugin;
 
public class SignInteract extends JavaPlugin implements Listener {
 
    @EventHandler
    public void onSignInteract(PlayerInteractEvent e) {
              if (!(e.getAction() == Action.RIGHT_CLICK_BLOCK)) return;
                if (!(e.getClickedBlock().getType() == Material.SIGN_POST) && !(e.getClickedBlock().getType() == Material.WALL_SIGN)) return;
                Sign s = (Sign) e.getClickedBlock().getState();
                if (s.getLine(0).equalsIgnoreCase("[i]")) {
                    e.getPlayer().getInventory().addItem(new ItemStack(Material.DIAMOND, 1));
                    e.getPlayer().sendMessage(ChatColor.DARK_GREEN + "You got a Diamond!");
 
            }
        }
 
 
    public void onEnable() {
        Bukkit.getServer().getPluginManager().registerEvents(new SignChange(), this);
    }
 
}
[/i]

Also I tried this

Code:java

package me.chibbey.signtest;
 
import org.bukkit.Bukkit;
import org.bukkit.ChatColor;
import org.bukkit.Material;
import org.bukkit.block.Sign;
import org.bukkit.event.EventHandler;
import org.bukkit.event.Listener;
import org.bukkit.event.block.Action;
import org.bukkit.event.player.PlayerInteractEvent;
import org.bukkit.inventory.ItemStack;
import org.bukkit.plugin.java.JavaPlugin;
 
public class SignInteract extends JavaPlugin implements Listener {
 
    @EventHandler
    public void onSignInteract(PlayerInteractEvent e) {
              if (!(e.getAction() == Action.RIGHT_CLICK_BLOCK)) return;
                if (!(e.getClickedBlock().getState() instanceof Sign) {
                      Sign s = (Sign) e.getClickedBlock().getState();
                       if (s.getLine(0).equalsIgnoreCase("[i]")) {
                               e.getPlayer().getInventory().addItem(new ItemStack(Material.DIAMOND, 1));
                               e.getPlayer().sendMessage(ChatColor.DARK_GREEN + "You got a Diamond!");
                 }
            }
        }
 
 
    public void onEnable() {
        Bukkit.getServer().getPluginManager().registerEvents(new SignChange(), this);
    }
 
}
[/i]

 

Chibbey are you saying in your code if the action doesn't equal with the ! In there?

Code:java

 
    public void onSignInteract(PlayerInteractEvent e) {
              if (!(e.getAction() == Action.RIGHT_CLICK_BLOCK)) return;
                if (!(e.getClickedBlock().getState() instanceof Sign) {
 

Should be:

Code:java

 
    public void onSignInteract(PlayerInteractEvent e) {
              if (e.getAction() == Action.RIGHT_CLICK_BLOCK) {
                if (e.getClickedBlock().getState() instanceof Sign) {
                    //do stuff for sign here
 

So now your code reads: If action is right click on the block, and the clicked block is an instance of a sign. Then do something.

 

Yeah those !'s after the if statements are not supposed to be there i assume.

 

Mathias Eklund wizzinangel

I tried its not working

 

add

Code:java

getServer().getPluginManager().registerEvents(this, this);

 

Mathias Eklund Did you even look through my code...

 

Chibbey Yes i did, if i am not mistaken you are only registering an event in a different class.

 

Mathias Eklund
Wow, you don't know much, Im registering the events in my other class and this class...

 

Chibbey be nicer to people, we don't have to help you you know.

Anyway, by telling us "I tried its not working" doesn't help us in any way. What doesn't work? What does the console output?

 

lolwut. Why are you creating a new instance of your main class? Just registerEvents(this, this);

 

Anyways I figured it out I did need to put the ! before the Action and I registered the other class because I got 2 classes, It worked because the register events wasn't before the event it was after so I put the onEnable() on top and it worked