Player drinks potion and bottle disappears.

@nverdier I'm really sorry, but could you give an example? It would help a lot.

 

@mrdude123 Sorry, I don't spoon feed. Just check if PlayerItemConsumeEvent#getItem()#getType returns Material.POTION.

 

@nverdier As far I know the "water bottle" it's a Material.POTION aswell.

@mrdude123 To my knowledge a water bottle always has a data value of 0, you can compare this with #getDurability or #getData, anyway, I also believe plugins have the power to apply potion effects without modifying the actual data value, this is something with the ItemMeta.

 

@Konato_K Hmmm... perhaps. Probably, actually.

 

@Konato_K So do you know how I would change it, then?
Writing the code isn't the problem, it's just where do I put it.

 

@mrdude123 Writing the code should include where you put it, yes? So writing the code is in fact the problem?

 

@mrdude123 Well, after you run the logic of removing the item it's too late don't you think?

 

@nverdier I know what to write, just not where to put it. So sure, I guess.

 

You would use the "instanceof" in an if statement. then compare the item in their hand and if it is instanceof potion, whether you do that with itemstacks, or materials.

 

@mrdude123 You still haven't registered the events...

 

@Tyler Christensen An ItemStack will never be an instance of Potion

 

Well i ment if the itemstack instanceof a itemstack with material potion .-.

 

@Tyler Christensen I don't know what you mean, but an ItemStack will always be an instance of an ItemStack, so an instanceof check won't do anything.

 

@Konato_K

Code:

package npb;

import org.bukkit.GameMode;
import org.bukkit.Material;
import org.bukkit.event.EventHandler;
import org.bukkit.event.Listener;
import org.bukkit.event.player.PlayerItemConsumeEvent;
import org.bukkit.inventory.ItemStack;
import org.bukkit.plugin.java.JavaPlugin;
import org.bukkit.potion.PotionType;

public class Main extends JavaPlugin
  implements Listener
  {

  @EventHandler
  public void consume(final PlayerItemConsumeEvent e) {
    ItemStack item = e.getItem();
    if (item.getType().equals(Material.POTION))
      getServer().getScheduler().runTaskLater(this, new Runnable() {
        public void run() {
            Potion potion = new Potion.fromItemStack(event.getCurrentItem());
            if (potion == PotionType.SPEED && potion == PotionType.INSTANT_HEAL)
        }
      }
      , 2L);
  }
}

How's this? wait forgot something

 

@mrdude123 A PotionType will never be equal to a Potion. Also

 

@Konato_K I've got only one bug before my plugin is done.
Syntax error, insert "AssignmentOperator Expression" to complete Expression

What can I put in to fix?

Code:

(e.getPlayer().getInventory().setItemInHand(Material.AIR)//Error is right here.;

 

@mrdude123 Check your syntax

 

You do the itemstack instanceof k where k = new ItemStack(Material.Potion) or whatever .-.

 

• You need to register the events in onEnable.
• Check if the material equals Material.POTION and the data value is not 0

 

@mrdude123

• Don't name your main class "Main."
• You need to register your events preferably when the plugin enables.

 

@Tyler Christensen That doesn't work at all, and I don't even think it's valid syntax.

 

Code:

  @EventHandler
  public void onPlayerItemConsume(final PlayerItemConsumeEvent e)
  {
    if (e.getItem().getType().equals(Material.POTION))
      getServer().getScheduler().scheduleSyncDelayedTask(this, new Runnable()
      {
        public void run() {
          if (e.getPlayer().getItemInHand().getType().equals(Material.GLASS_BOTTLE))
            e.getPlayer().getInventory().setItemInHand(null);
        }
      }
      , 0L);
  }

 

Code:

@EventHandler
public void onPlayerItemConsume(final PlayerItemConsumeEvent {
  if (e.getItem().getType().equals(Material.POTION) && e.getItem().getItemMeta().getDurability() != 0)
    getServer().getScheduler().scheduleSyncDelayedTask(this, new Runnable()
    {
      public void run() {
        if (e.getPlayer().getItemInHand().getType().equals(Material.GLASS_BOTTLE))
          e.getPlayer().getInventory().setItemInHand(null);
      }
    }
    , 0L);
}

That exempts water bottles by checking if the durability is 0.