'placing' blocks on glass

zeeveener It's a problem with getAction, putting a debug under Player p = ect..

Events are registered. I know they are. because I have like 3 events in the class that work. So I'm stumped :/

 

sgavster

Can you give us the full class with the listener inside?

 

Code:java

public class KitDemo implements Listener
{
    private final Main plugin;
    public KitDemo(Main plugin)
    {
        this.plugin = plugin;
    }
 
    private List<Location> plate = new ArrayList<Location>();
 
    @EventHandler
    public void onInteract(PlayerInteractEvent e)
    {
        Player p = e.getPlayer();
        if(e.getAction().equals(Action.RIGHT_CLICK_AIR) || e.getAction().equals(Action.RIGHT_CLICK_BLOCK))
        {
            if(p.getItemInHand().getType().equals(Material.FIREBALL))
            {
                if(plugin.getDemo().contains(p.getName()))
                {
                    e.setCancelled(true);
                    final Item i = p.getLocation().getWorld().dropItemNaturally(p.getLocation(), new ItemStack(Material.FIREBALL));
                    i.setVelocity(new Vector(p.getVelocity().getX(), p.getVelocity().getY() + 4, p.getVelocity().getZ()));
                    i.setVelocity(p.getLocation().getDirection());
                    i.setPickupDelay(100000);
                    if(p.getItemInHand().getAmount() == 1)
                    {
                        p.setItemInHand(null);
                    }
                    else
                    {
                        p.getItemInHand().setAmount(p.getItemInHand().getAmount() - 1);
                    }
                    Bukkit.getScheduler().runTaskLater(plugin, new Runnable()
                    {
                        public void run()
                        {
                            i.getWorld().createExplosion(i.getLocation(), 2, false);
                            i.remove();
                        }
                    }, 100L);
                }
            }
        }
        else if(e.getAction().equals(Action.PHYSICAL))
        {
            if(e.getClickedBlock().getType().equals(Material.STONE_PLATE))
            {
                if(plate.contains(e.getClickedBlock().getLocation()))
                {
                    if(!(plugin.getDemo().contains(p.getName())))
                    {
                        e.getClickedBlock().setType(Material.AIR);
                        plate.remove(e.getClickedBlock().getLocation());
                        e.getClickedBlock().getWorld().createExplosion(e.getClickedBlock().getLocation(), 2, false);
                    }
                }
            }
        }
    }
    @EventHandler
    public void onCreate(PlayerInteractEvent e)
    {
        Player p = e.getPlayer();
        Bukkit.broadcastMessage("0");
        if(e.getAction().equals(Action.RIGHT_CLICK_BLOCK))
        {
            Bukkit.broadcastMessage("1");
            if(p.getItemInHand().getType().equals(Material.STONE_PLATE))
            {
                Bukkit.broadcastMessage("2");
                if(plugin.getDemo().contains(p.getName()))
                {
                    Bukkit.broadcastMessage("3");
                    if(e.getClickedBlock() != null && e.getClickedBlock().getType() != null)
                    {
                        Bukkit.broadcastMessage("4");
                        Location u = new Location(e.getClickedBlock().getWorld(), e.getClickedBlock().getLocation().getX(), e.getClickedBlock().getLocation().getY() + 1, e.getClickedBlock().getLocation().getZ());
                        plate.add(u);
                        u.getBlock().setType(Material.STONE_PLATE);
                        if(p.getItemInHand().getAmount() == 1)
                        {
                            p.setItemInHand(null);
                        }
                        else
                        {
                            p.getItemInHand().setAmount(p.getItemInHand().getAmount() - 1);
                        }
                        p.sendMessage("You create a land mine! Punch it to remove it!");
                    }
                }
            }
        }
    }
    @EventHandler
    public void onPlace(BlockPlaceEvent e)
    {
        Player p = e.getPlayer();
        Block b = e.getBlock();
        if(b.getType().equals(Material.STONE_PLATE))
        {
            if(plugin.getDemo().contains(p.getName()))
            {
                plate.add(b.getLocation());
                p.sendMessage("You create a land mine! Punch it to remove it!");
            }
        }
    }
    @EventHandler
    public void onDe(BlockDamageEvent e)
    {
        Player p = e.getPlayer();
        Block b = e.getBlock();
        if(b.getType().equals(Material.STONE_PLATE))
        {
            if(plate.contains(e.getBlock().getLocation()))
            {
                if(plugin.getDemo().contains(p.getName()))
                {
                    e.getBlock().setType(Material.AIR);
                    plate.remove(e.getBlock().getLocation());
                    p.sendMessage("You removed a land mine!");
                    p.getInventory().addItem(setNameAndLore(Material.STONE_PLATE, 1, "&bLand Mine", Enchantment.WATER_WORKER, 10));
                }
            }
        }
    }
    public ItemStack setNameAndLore(Material material, int amount, String name, Enchantment enchant, int enchantamount, String... lore)
    {
        ItemStack item = new ItemStack(material, amount);
        item.addUnsafeEnchantment(enchant, enchantamount);
        ItemMeta meta = item.getItemMeta();
        meta.setDisplayName(ChatColor.translateAlternateColorCodes('&', name));
        ArrayList<String> lorez = new ArrayList<String>();
        for(String mylores : lore)
        {
            lorez.add(ChatColor.translateAlternateColorCodes('&', mylores));
        }
        meta.setLore(lorez);
        item.setItemMeta(meta);
        return item;
    }
}

 

sgavster

You're class is still using the problem setup with the if/else statements. Action.PHYSICAL, I have no idea what that is or when it's called.

Try checking what is in the hand FIRST, and then determine what to do.

Code:java

if(itemInHand == Stick){
    if(action = block){}
}else if(itemInHand == Fireball){
    if(action == block || action == air){}
}

 

zeeveener ...
The event I'm having problems with is the onCreate().

I don't see how that is causing anything, it's a different event. Action.PHYSICAL is when you stand on pressureplates and such. Everything works but this 1 event.

 

sgavster

I keep getting lost lol. I'm sorry, finals week has my brain running on fumes.
I don't know what is wrong with it. I would try the following though:

Using if(getAction() == Action.RIGHT_CLICK_BLOCK) instead of if(getAction().equals(Action.RIGHT_CLICK_BLOCK)

Other than that, I am not sure, sorry.

 

zeeveener Still doesn't work :/

 

sgavster

The final advice I can give is try merging the two PlayerInteractEvents. I doubt that'll do anything, but who knows.

 

Why create a new location when you can get the clicked location and add 1 to the y?

 

ZeusAllMighty11 I had it like that before. I will change it back once I can figure out why it's not checking right_click_block :/

sgavster ZeusAllMighty11 It works.. Sorta.. It's still counting as null. (the block) and now my grenade wont work.

Code:java

 @EventHandler
public void onInteract(PlayerInteractEvent e)
{
Player p = e.getPlayer();
if(e.getAction().equals(Action.RIGHT_CLICK_AIR))
{
Bukkit.broadcastMessage("1");
if(p.getItemInHand().getType().equals(Material.STONE_PLATE))
{
Bukkit.broadcastMessage("2");
if(plugin.getDemo().contains(p.getName()))
{
Bukkit.broadcastMessage("3");
if(e.getClickedBlock() != null && e.getClickedBlock().getType() != null)
{
Bukkit.broadcastMessage("4");
Location l = e.getClickedBlock().getLocation();
plate.add(l.add(0, 1, 0));
l.add(0, 1, 0).getBlock().setType(Material.STONE_PLATE);
if(p.getItemInHand().getAmount() == 1)
{
p.setItemInHand(null);
}
else
{
p.getItemInHand().setAmount(p.getItemInHand().getAmount() - 1);
}
}
}
}
}
else if(e.getAction().equals(Action.RIGHT_CLICK_AIR))
{
if(p.getItemInHand().getType().equals(Material.FIREBALL))
{
if(plugin.getDemo().contains(p.getName()))
{
e.setCancelled(true);
final Item i = p.getLocation().getWorld().dropItemNaturally(p.getLocation(), new ItemStack(Material.FIREBALL));
i.setVelocity(new Vector(p.getVelocity().getX(), p.getVelocity().getY() + 4, p.getVelocity().getZ()));
i.setVelocity(p.getLocation().getDirection());
i.setPickupDelay(100000);
if(p.getItemInHand().getAmount() == 1)
{
p.setItemInHand(null);
}
else
{
p.getItemInHand().setAmount(p.getItemInHand().getAmount() - 1);
}
Bukkit.getScheduler().runTaskLater(plugin, new Runnable()
{
public void run()
{
i.getWorld().createExplosion(i.getLocation(), 2, false);
i.remove();
}
}, 100L);
}
}
}
else if(e.getAction().equals(Action.PHYSICAL))
{
if(e.getClickedBlock().getType().equals(Material.STONE_PLATE))
{
if(plate.contains(e.getClickedBlock().getLocation()))
{
if(!(plugin.getDemo().contains(p.getName())))
{
e.getClickedBlock().setType(Material.AIR);
plate.remove(e.getClickedBlock().getLocation());
e.getClickedBlock().getWorld().createExplosion(e.getClickedBlock().getLocation(), 2, false);
}
}
}
}
}

I'm really stumped. :/

I have no idea what to do.. Any ideas? :/

EDIT: never mind.. For some reason RIGHT_CLICK_BLOCK will not work.. At all. The code above was just both RIGHT_CLICK_AIR. I changed it to block, and it doesn't work.. at all..

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

Code:java

 
if(e.getAction().equals(Action.RIGHT_CLICK_AIR)){
    //Called if right clicked air
}else else if(e.getAction().equals(Action.RIGHT_CLICK_AIR)){
    //Never called
}else if(e.getAction().equals(Action.PHYSICAL)){
    //Called if stood on.
}
 

Change it to:

Code:java

 
if(e.getAction().equals(Action.RIGHT_CLICK_BLOCK)){
    //Called if right clicked block (won't be null)
}else else if(e.getAction().equals(Action.RIGHT_CLICK_AIR)){
    //Called if right clicked air (grenade)
}else if(e.getAction().equals(Action.PHYSICAL)){
    //Called if stood on.
}
 

 

zeeveener How would I fix then? I have
RIGHT_CLICK_BLOCK
RIGHT_CLICK_AIR
PHYSICAL

Physical and right_click_air works, not right_click_block, and they ARE in the order I just stated.

 

Perhaps RIGHT_CLICK_BLOCK is deprecated?

sgavster

I just copied over your text into a test plugin. It works properly for me. I'll give you the code so you can see for yourself. http://pastebin.com/Pcbv5Sfz

I removed the references to the getDemo() method. See if that is causing problems. Otherwise, you can create a new plugin and throw this in and it will work fine.

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

zeeveener



Ignore the lag, crapooter.

I had a video, but youtube hates me and failed to process.
With the code:

Code:java

@EventHandler
    public void onInteract(PlayerInteractEvent e)
    {
        Player p = e.getPlayer();
        if(e.getAction().equals(Action.RIGHT_CLICK_BLOCK))
        {
            Bukkit.broadcastMessage("§6§lThe action was RIGHT_CLICK_BLOCK!");
            if(p.getItemInHand().getType().equals(Material.STONE_PLATE))
            {
                Bukkit.broadcastMessage("§6§lYou have a STONE_PLATE in your hands!");
                if(plugin.getDemo().contains(p.getName()))
                {
                    Bukkit.broadcastMessage("§6§lYou're a demo!");
                    if(e.getClickedBlock() != null && e.getClickedBlock().getType() != null)
                    {
                        Bukkit.broadcastMessage("§6§lIt's not null!");
                        Location l = e.getClickedBlock().getLocation();
                        plate.add(l.add(0, 1, 0));
                        l.add(0, 1, 0).getBlock().setType(Material.STONE_PLATE);
                        if(p.getItemInHand().getAmount() == 1)
                        {
                            p.setItemInHand(null);
                        }
                        else
                        {
                            p.getItemInHand().setAmount(p.getItemInHand().getAmount() - 1);
                        }
                        p.sendMessage("§3[§fGhost§6Squadron§3]§6 You create a land mine! Punch it to remove it!");
                    }
                }
            }
        }
        else if(e.getAction().equals(Action.RIGHT_CLICK_AIR))
        {
            Bukkit.broadcastMessage("§6§lThe action was RIGHT_CLICK_AIR!");
            if(p.getItemInHand().getType().equals(Material.FIREBALL))
            {
                Bukkit.broadcastMessage("§6§lYou have a FIREBALL in your hands!");
                if(plugin.getDemo().contains(p.getName()))
                {
                    Bukkit.broadcastMessage("§6§lYou're a demo!");
                    e.setCancelled(true);
                    final Item i = p.getLocation().getWorld().dropItemNaturally(p.getLocation(), new ItemStack(Material.FIREBALL));
                    i.setVelocity(new Vector(p.getVelocity().getX(), p.getVelocity().getY() + 4, p.getVelocity().getZ()));
                    i.setVelocity(p.getLocation().getDirection());
                    i.setPickupDelay(100000);
                    if(p.getItemInHand().getAmount() == 1)
                    {
                        p.setItemInHand(null);
                    }
                    else
                    {
                        p.getItemInHand().setAmount(p.getItemInHand().getAmount() - 1);
                    }
                    Bukkit.getScheduler().runTaskLater(plugin, new Runnable()
                    {
                        public void run()
                        {
                            i.getWorld().createExplosion(i.getLocation(), 2, false);
                            i.remove();
                        }
                    }, 100L);
                }
            }
        }
        else if(e.getAction().equals(Action.PHYSICAL))
        {
            if(e.getClickedBlock().getType().equals(Material.STONE_PLATE))
            {
                if(plate.contains(e.getClickedBlock().getLocation()))
                {
                    if(!(plugin.getDemo().contains(p.getName())))
                    {
                        e.getClickedBlock().setType(Material.AIR);
                        plate.remove(e.getClickedBlock().getLocation());
                        e.getClickedBlock().getWorld().createExplosion(e.getClickedBlock().getLocation(), 2, false);
                    }
                }
            }
        }
    }

For some reason it was saying the action was RIGHT_CLICK_AIR when I had a pressure plate in my hand.. And I was clicking a block..

zeeveener I tried your code.. I added the getDemo(), and right_click_block wont work. But right_click_air does.
But, right_click_block isn't called. "1" is never said in chat.

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

sgavster

Then it is a problem with the rest of your plugin. Make sure you properly registered it. Even if you know so, just make sure. Something else is causing problems because it works fine on my machine.

Try this jar: https://dl.dropboxusercontent.com/u/263832/Test-0.0.1-SNAPSHOT.jar
It is my build.

At this point, I would start branching out.

What happens when you make a BRAND NEW plugin JUST using the class I gave you?
What version of Bukkit are you using? Is it the most up to date version?
What JDK are you compiling against? Is it 1.6 or 1.7?
What JRE are you running Minecraft and the server in? Is it JRE6 or JRE7?

 

zeeveener Okay, now I'm confused:

I'm clicking the ground with Air and it's saying '1'

Then, I hold StonePlate and it doesn't say 1.. I'm really confused (I removed the demo check..)

 

sgavster

I edited my post.

 

zeeveener

1. it works, but a pressure plate drops when I place it
2. #2942
3. 1.7.2
4. MC: JRE7, server: not sure, dedicated host

 

sgavster

The pressure plate dropping is just a side effect. You can handle that when you figure out what is hanging up the plugin in he first place.

There is no reason why your plugin shouldn't work using my version of the code. I would suggest you take the time to go through your code as if it was starting on the server and envision what happens when you click a block. Perhaps by tracing the code, you will find a bug or inconsistency.

 

zeeveener I changed my code.. I'm having troubles though.. Here is a thread:
https://forums.bukkit.org/threads/cant-get-the-players-location.205156/Can't seem to get it to work. :/

 

It should be impossible to place a pressure plate on glass. I don't think forcing it to be placed on glass, through code will actually allow it to be placed. That might just be the issue at hand here. At this point, I've never seen a pressure plate placed on glass in minecraft so idk. sgavster

 

maxben34 That's not my problem, my problem is this post:
https://forums.bukkit.org/threads/cant-get-the-players-location.205156/