Per-Player Inventory

I'm trying to make an inventory for everyone. For example, I'm making a kitpvp plugin. If the player doesn't have permission to a certain kit, change the kit's item to a barrier. I have that working and it works great. I also tried to make the per-player inventory. As long as the player who doesn't have permission opens the gui and clicks on a kit that he doesn't have access to before another layer opens the gui, the other player won't see the barrier block. However if another player opens the gui and then the person without the permission, he clicks on a kit that he doesn't have access to and it changes on the other players screen and on the person who doesn't have the permission. Here is my code:

Code:

public Menu(Plugin p, Player player) {
        inv = Bukkit.getServer().createInventory(player, 54, "Kits");

        c = Archer(ChatColor.RED + "Archer");
        s = Fighter(ChatColor.GREEN + "Fighter");
        a = Warrior(ChatColor.RED + "Warrior");
        m = Mage(ChatColor.BLUE + "Mage");
        v = Viking(ChatColor.BOLD + "" + ChatColor.RED + "Viking");
        t = Tank(ChatColor.GOLD + "Tank");
        paperf = PaperF(ChatColor.GOLD + "Free Kits");
        paperd = PaperD(ChatColor.GOLD + "Donator Kits");
        barrier = Barrier(ChatColor.RED + "No Access");

        glass = Glass("");

        inv.setItem(10, paperf);
        inv.setItem(12, c);
        inv.setItem(13, s);
}

Establishing new inventory and variables

Code:

    private ItemStack Archer(String name) {
        ItemStack i = new ItemStack(Material.BOW);
        ItemMeta im = i.getItemMeta();
        im.setDisplayName(name);
        im.setLore(Arrays.asList(ChatColor.GREEN + "A very skilled and quick archer", ChatColor.GREEN + "that has a range of over a mile!"));
        i.setItemMeta(im);
        return i;
    }

Setting Archer kit

Code:

if (e.getCurrentItem().getItemMeta().getDisplayName().contains("Archer")) {

            if(player.hasPermission("archer.use")) {
                e.setCancelled(true);

                ItemStack bow = new ItemStack(Material.BOW, 1);
                bow.addEnchantment(Enchantment.ARROW_INFINITE, 1);

                player.getInventory().addItem(bow);
                player.getInventory().setHelmet(new ItemStack(Material.CHAINMAIL_HELMET, 1));
                player.getInventory().setChestplate(new ItemStack(Material.CHAINMAIL_CHESTPLATE, 1));
                player.getInventory().setLeggings(new ItemStack(Material.CHAINMAIL_LEGGINGS, 1));
                player.getInventory().setBoots(new ItemStack(Material.CHAINMAIL_BOOTS, 1));
                player.getInventory().addItem(new ItemStack(Material.IRON_SWORD, 1));
                player.getInventory().addItem(new ItemStack(Material.ARROW, 1));

                e.getWhoClicked().closeInventory();

                // Times are in ticks
                Title title = new Title(kitpvp,ChatColor.GREEN + "Kit successfully redeemed!",15,200,15);
                title.setTitleColor(title.getTitleColor());
                title.setSubtitleColor(title.getSubtitleColor());
                title.setTimingsToTicks();

                title.send(player);

                kit.put(player, false);

            } else {
                player.sendMessage(ChatColor.RED + "You do not have access to this kit!");
                inv.removeItem(new ItemStack(Material.BOW));
                inv.setItem(12, barrier);
                e.setCancelled(true);
                return;
            }
        } 

On inventory click event

Code:

package me.plisov.kitpvp;
import org.bukkit.Bukkit;
import org.bukkit.command.Command;
import org.bukkit.command.CommandSender;
import org.bukkit.entity.Player;
import org.bukkit.event.EventHandler;
import org.bukkit.event.Listener;
import org.bukkit.plugin.java.JavaPlugin;
public class MenuInv extends JavaPlugin implements Listener {
        private Menu menu;
       
        public void onEnable() {
                Bukkit.getServer().getPluginManager().registerEvents(this, this);
                Bukkit.getServer().getPluginManager().registerEvents(new PlayerJoin(), this);
                Bukkit.getServer().getPluginManager().registerEvents(new Signs(), this);
        }
      
        @EventHandler
        public boolean onCommand(CommandSender sender, Command cmd, String commandLabel, String[] args) {

            Player player = (Player) sender;
            menu = new Menu(this, player);
           
            if (cmd.getName().equalsIgnoreCase("guit")) {
                menu.show(player);
            }
            return false;
        }
}

Class that extends Java Plugin

 

This is your problem. For what you want, you can't just use one inventory. For this, make sure each player has their own inventory when they are viewing it.

 

Where player was, there was null. Doesn't null make it a public inventory and player makes it per-player? I don't know any other way of making an inventory for every person. Have any ideas?

 

@plisov
No. The InventoryHolder only dictates the owner of the inventory, not who sees it.

 

How would I make an inventory for every player? I assume I would need to put something in the PlayerJoinEvent however I don't know what to put.

 

@plisov
It should not be that hard. Every time you want for a player to open your kit inventory, create a new inventory with all the items in it and show it to the player.

 

Isn't that what I'm doing? I have a method called menu, and each time the player runs /guit it opens creates a new inventory.

Ok. I took the Menu and I placed it into the command. So when the command is run, the menu is created. If I open the gui first and then another person opens it second, then if I click on a kit I dont have access to, it says I don't have permission for it but the barrier is set for the second person and not me. Here is the updated code.

Code:

package me.plisov.kitpvp;
import java.util.Arrays;
import java.util.HashMap;

import org.bukkit.Bukkit;
import org.bukkit.ChatColor;
import org.bukkit.DyeColor;
import org.bukkit.Material;
import org.bukkit.command.Command;
import org.bukkit.command.CommandSender;
import org.bukkit.enchantments.Enchantment;
import org.bukkit.entity.Player;
import org.bukkit.event.EventHandler;
import org.bukkit.event.Listener;
import org.bukkit.event.entity.PlayerDeathEvent;
import org.bukkit.event.inventory.InventoryClickEvent;
import org.bukkit.inventory.Inventory;
import org.bukkit.inventory.ItemStack;
import org.bukkit.inventory.meta.ItemMeta;
import org.bukkit.plugin.java.JavaPlugin;
import org.bukkit.potion.Potion;
import org.bukkit.potion.PotionType;
public class MenuInv extends JavaPlugin implements Listener {
        //private Menu menu;
        private Inventory inv;
        private ItemStack c, s, a, glass, m, v, t, paperf, paperd, barrier;
        String kitpvp = ChatColor.DARK_GRAY + "[" + ChatColor.GREEN + "KitPVP" + ChatColor.DARK_GRAY + "] ";
       
        public void onEnable() {
                Bukkit.getServer().getPluginManager().registerEvents(this, this);
                Bukkit.getServer().getPluginManager().registerEvents(new PlayerJoin(), this);
                Bukkit.getServer().getPluginManager().registerEvents(new Signs(), this);
        }
      
        @EventHandler
        public boolean onCommand(CommandSender sender, Command cmd, String commandLabel, String[] args) {

            Player player = (Player) sender;
            //menu = new Menu(this, player);
           
            if (cmd.getName().equalsIgnoreCase("guit")) {
                inv = Bukkit.getServer().createInventory(null, 54, "Kits");

                c = Archer(ChatColor.RED + "Archer");
                s = Fighter(ChatColor.GREEN + "Fighter");
                a = Warrior(ChatColor.RED + "Warrior");
                m = Mage(ChatColor.BLUE + "Mage");
                v = Viking(ChatColor.BOLD + "" + ChatColor.RED + "Viking");
                t = Tank(ChatColor.GOLD + "Tank");
                paperf = PaperF(ChatColor.GOLD + "Free Kits");
                paperd = PaperD(ChatColor.GOLD + "Donator Kits");
                barrier = Barrier(ChatColor.RED + "No Access");

                glass = Glass("");

                inv.setItem(10, paperf);
                inv.setItem(12, c);
                inv.setItem(13, s);
               
                inv.setItem(28, paperd);
                inv.setItem(30, m);
                inv.setItem(31, v);
                inv.setItem(32, a);
                inv.setItem(33, t);

                //GLASS
                inv.setItem(0, glass);
                inv.setItem(1, glass);
                inv.setItem(2, glass);
                inv.setItem(3, glass);
                inv.setItem(4, glass);
                inv.setItem(5, glass);
                inv.setItem(6, glass);
                inv.setItem(7, glass);
                inv.setItem(8, glass);
                inv.setItem(9, glass);
                inv.setItem(17, glass);
                inv.setItem(18, glass);
                inv.setItem(26, glass);
                inv.setItem(27, glass);
                inv.setItem(35, glass);
                inv.setItem(36, glass);
                inv.setItem(44, glass);
                inv.setItem(45, glass);
                inv.setItem(46, glass);
                inv.setItem(47, glass);
                inv.setItem(48, glass);
                inv.setItem(49, glass);
                inv.setItem(50, glass);
                inv.setItem(51, glass);
                inv.setItem(52, glass);
                inv.setItem(53, glass);

                //Glass Ends

                player.openInventory(inv);
               
            }
            return false;
        }
       
        public String kitpvp1 = ChatColor.DARK_GRAY + "[" + ChatColor.GOLD + "KitPVP" + ChatColor.DARK_GRAY + "] ";
       
        private ItemStack Barrier(String name) {
            ItemStack i = new ItemStack(Material.BARRIER);
            ItemMeta im = i.getItemMeta();
            im.setDisplayName(name);
            im.setLore(Arrays.asList(kitpvp1 + ChatColor.RED + "Donate at " + ChatColor.GOLD + "shop.ezbze.com", ChatColor.RED + "To get access to these kits."));
            i.setItemMeta(im);
            return i;
        }
       
        private ItemStack Archer(String name) {
            ItemStack i = new ItemStack(Material.BOW);
            ItemMeta im = i.getItemMeta();
            im.setDisplayName(name);
            im.setLore(Arrays.asList(ChatColor.GREEN + "A very skilled and quick archer", ChatColor.GREEN + "that has a range of over a mile!"));
            i.setItemMeta(im);
            return i;
        }
       
        private ItemStack PaperF(String name) {
            ItemStack i = new ItemStack(Material.COAL);
            ItemMeta im = i.getItemMeta();
            im.setDisplayName(name);
            im.setLore(Arrays.asList(ChatColor.GREEN + "Everyone has access to these kits!"));
            i.setItemMeta(im);
            return i;
        }
       
        private ItemStack PaperD(String name) {
            ItemStack i = new ItemStack(Material.DIAMOND);
            ItemMeta im = i.getItemMeta();
            im.setDisplayName(name);
            im.setLore(Arrays.asList(kitpvp + ChatColor.RED + "Donate at " + ChatColor.GOLD + "shop.ezbze.com", ChatColor.RED + "to get access to these kits."));
            i.setItemMeta(im);
            return i;
        }

        public static ItemStack Mage(String name) {
            ItemStack i = new ItemStack(Material.SPLASH_POTION);
            ItemMeta im = i.getItemMeta();
            im.setDisplayName(name);
            im.setLore(Arrays.asList(ChatColor.GREEN + "A master chemist who only uses potions"));
            i.setItemMeta(im);
            return i;
        }

        private ItemStack Viking(String name) {
            ItemStack i = new ItemStack(Material.IRON_AXE);
            ItemMeta im = i.getItemMeta();
            im.setDisplayName(name);
            im.setLore(Arrays.asList(ChatColor.GREEN + "A master axeman who", ChatColor.GREEN + "isn't afraid of anything."));
            i.setItemMeta(im);
            return i;
        }

        private ItemStack Tank(String name) {
            ItemStack i = new ItemStack(Material.IRON_SWORD);
            ItemMeta im = i.getItemMeta();
            im.setDisplayName(name);
            im.setLore(Arrays.asList(ChatColor.GREEN + "A superb kit that will", ChatColor.GREEN + "certainly win every battle"));
            i.setItemMeta(im);
            return i;
        }

        private ItemStack Fighter(String name) {
            ItemStack i = new ItemStack(Material.DIAMOND_SWORD);
            ItemMeta im = i.getItemMeta();
            im.setDisplayName(name);
            im.setLore(Arrays.asList(ChatColor.GREEN + "A very tough kit what will ", ChatColor.GREEN + "definately be tough to kill."));
            i.setItemMeta(im);
            return i;
        }

        private ItemStack Warrior(String name) {
            ItemStack i = new ItemStack(Material.GOLD_SWORD);
            ItemMeta im = i.getItemMeta();
            im.setDisplayName(name);
            im.setLore(Arrays.asList(ChatColor.GREEN + "A light-weight, quick kit that will defend",
                    ChatColor.GREEN + "you reliably and allow you to", ChatColor.GREEN + "escape danger."));
            i.setItemMeta(im);
            return i;
        }

        private ItemStack Glass(String name) {
            ItemStack i = new ItemStack(Material.STAINED_GLASS_PANE, 1, DyeColor.BLUE.getData());
            ItemMeta im = i.getItemMeta();
            im.setDisplayName(" ");
            im.setLore(Arrays.asList(" "));
            i.setItemMeta(im);
            return i;
        }

        public static HashMap<Player, Boolean> kit = new HashMap<Player, Boolean>();

        @EventHandler
        public void onDeath(PlayerDeathEvent event) {

            Player player = (Player) event.getEntity();

            kit.put(player, true);

            if(player.isDead()) {
                event.getDrops().clear();
            }

        }
       
        @EventHandler
        public void onInventoryClick(InventoryClickEvent e) {

            Player player = (Player) e.getWhoClicked();

            if(e.getCurrentItem().getItemMeta().getDisplayName().contains("Free Kits") ||e.getCurrentItem().getItemMeta().getDisplayName().contains("Donator Kits") ||e.getCurrentItem().getItemMeta().getDisplayName().contains("No Access") ) {
                    e.setCancelled(true);
                    return;
                }
           
            if(e.getCurrentItem().getItemMeta().getDisplayName().contains("Tank") ||e.getCurrentItem().getItemMeta().getDisplayName().contains("Viking") ||e.getCurrentItem().getItemMeta().getDisplayName().contains("Mage") ||e.getCurrentItem().getItemMeta().getDisplayName().contains("Archer") || e.getCurrentItem().getItemMeta().getDisplayName().contains("Warrior") || e.getCurrentItem().getItemMeta().getDisplayName().contains("Fighter")) {
                if(kit.get(player) == Boolean.FALSE) {
                    //player.sendMessage(kitpvp + ChatColor.RED + "You have already used a kit.");

                    // Times are in ticks
                    Title title = new Title(kitpvp,ChatColor.RED + "You have already used a kit!",15,200,15);
                    title.setTitleColor(title.getTitleColor());
                    title.setSubtitleColor(title.getSubtitleColor());
                    title.setTimingsToTicks();

                    title.send(player);

                    e.setCancelled(true);
                    return;
                }
            }
            if (!e.getInventory().getName().equalsIgnoreCase(inv.getName())) return;
            if (e.getCurrentItem().getItemMeta() == null) return;

            if (e.getCurrentItem().getItemMeta().getDisplayName().contains("Archer")) {

                if(player.hasPermission("archer.use")) {
                    e.setCancelled(true);

                    ItemStack bow = new ItemStack(Material.BOW, 1);
                    bow.addEnchantment(Enchantment.ARROW_INFINITE, 1);

                    player.getInventory().addItem(bow);
                    player.getInventory().setHelmet(new ItemStack(Material.CHAINMAIL_HELMET, 1));
                    player.getInventory().setChestplate(new ItemStack(Material.CHAINMAIL_CHESTPLATE, 1));
                    player.getInventory().setLeggings(new ItemStack(Material.CHAINMAIL_LEGGINGS, 1));
                    player.getInventory().setBoots(new ItemStack(Material.CHAINMAIL_BOOTS, 1));
                    player.getInventory().addItem(new ItemStack(Material.IRON_SWORD, 1));
                    player.getInventory().addItem(new ItemStack(Material.ARROW, 1));

                    e.getWhoClicked().closeInventory();

                    // Times are in ticks
                    Title title = new Title(kitpvp,ChatColor.GREEN + "Kit successfully redeemed!",15,200,15);
                    title.setTitleColor(title.getTitleColor());
                    title.setSubtitleColor(title.getSubtitleColor());
                    title.setTimingsToTicks();

                    title.send(player);

                    kit.put(player, false);

                } else {
                    player.sendMessage(ChatColor.RED + "You do not have access to this kit!");
                    inv.removeItem(new ItemStack(Material.BOW));
                    inv.setItem(12, barrier);
                    e.setCancelled(true);
                    return;
                }
            }

            if (e.getCurrentItem().getItemMeta().getDisplayName().contains("Mage")) {

                if(player.hasPermission("mage.use")) {
                    e.setCancelled(true);

                    Potion damage = new Potion(PotionType.INSTANT_DAMAGE, 1);
                    damage.setSplash(true);
                    ItemStack damagep = damage.toItemStack(64);
                    player.getInventory().setHelmet(new ItemStack(Material.LEATHER_HELMET, 1));
                    player.getInventory().setChestplate(new ItemStack(Material.LEATHER_CHESTPLATE, 1));
                    player.getInventory().setLeggings(new ItemStack(Material.LEATHER_LEGGINGS, 1));
                    player.getInventory().setBoots(new ItemStack(Material.LEATHER_BOOTS, 1));

                    player.getInventory().addItem(damagep);


                    e.getWhoClicked().closeInventory();

                    // Times are in ticks
                    Title title = new Title(kitpvp,ChatColor.GREEN + "Kit successfully redeemed!",15,200,15);
                    title.setTitleColor(title.getTitleColor());
                    title.setSubtitleColor(title.getSubtitleColor());
                    title.setTimingsToTicks();

                    title.send(player);

                    kit.put(player, false);

                } else {
                    player.sendMessage(ChatColor.RED + "You do not have access to this kit!");
                    inv.removeItem(new ItemStack(Material.SPLASH_POTION));
                    inv.setItem(30, barrier);
                    e.setCancelled(true);
                    return;
                }
            }

            if (e.getCurrentItem().getItemMeta().getDisplayName().contains("Viking")) {

                if(player.hasPermission("viking.use")) {
                    e.setCancelled(true);

                    player.getInventory().setHelmet(new ItemStack(Material.CHAINMAIL_HELMET, 1));
                    player.getInventory().setChestplate(new ItemStack(Material.CHAINMAIL_CHESTPLATE, 1));
                    player.getInventory().setLeggings(new ItemStack(Material.IRON_LEGGINGS, 1));
                    player.getInventory().setBoots(new ItemStack(Material.IRON_BOOTS, 1));
                    player.getInventory().addItem(new ItemStack(Material.IRON_AXE, 1));

                    e.getWhoClicked().closeInventory();

                    // Times are in ticks
                    Title title = new Title(kitpvp,ChatColor.GREEN + "Kit successfully redeemed!",15,200,15);
                    title.setTitleColor(title.getTitleColor());
                    title.setSubtitleColor(title.getSubtitleColor());
                    title.setTimingsToTicks();

                    title.send(player);

                    kit.put(player, false);

                } else {
                    player.sendMessage(ChatColor.RED + "You do not have access to this kit!");
                    inv.removeItem(new ItemStack(Material.IRON_AXE));
                    inv.setItem(31, barrier);
                    e.setCancelled(true);
                    return;
                }
            }

            if (e.getCurrentItem().getItemMeta().getDisplayName().contains("Tank")) {

                if(player.hasPermission("tank.use")) {

                    e.setCancelled(true);

                    player.getInventory().addItem(new ItemStack(Material.IRON_SWORD, 1));
                    player.getInventory().setHelmet(new ItemStack(Material.DIAMOND_HELMET, 1));
                    player.getInventory().setChestplate(new ItemStack(Material.DIAMOND_CHESTPLATE, 1));
                    player.getInventory().setLeggings(new ItemStack(Material.DIAMOND_LEGGINGS, 1));
                    player.getInventory().setBoots(new ItemStack(Material.DIAMOND_BOOTS, 1));

                    e.getWhoClicked().closeInventory();

                    // Times are in ticks
                    Title title = new Title(kitpvp,ChatColor.GREEN + "Kit successfully redeemed!",15,200,15);
                    title.setTitleColor(title.getTitleColor());
                    title.setSubtitleColor(title.getSubtitleColor());
                    title.setTimingsToTicks();

                    title.send(player);

                    kit.put(player, false);

                } else {
                    player.sendMessage(ChatColor.RED + "You do not have access to this kit!");
                    inv.removeItem(new ItemStack(Material.IRON_SWORD));
                    inv.setItem(33, barrier);
                    e.setCancelled(true);
                    return;
                }
            }

            if (e.getCurrentItem().getItemMeta().getDisplayName().contains("Fighter")) {
                if(player.hasPermission("fighter.use")) {
                    e.setCancelled(true);

                    ItemStack sword = new ItemStack(Material.IRON_SWORD, 1);
                    sword.addEnchantment(Enchantment.DAMAGE_ALL, 1);

                    ItemStack leatherhelmet = new ItemStack(Material.LEATHER_HELMET, 1);
                    leatherhelmet.addEnchantment(Enchantment.PROTECTION_ENVIRONMENTAL, 2);

                    ItemStack leatherchestplate = new ItemStack(Material.LEATHER_CHESTPLATE, 1);
                    leatherchestplate.addEnchantment(Enchantment.PROTECTION_ENVIRONMENTAL, 2);

                    player.getInventory().addItem(sword);
                    player.getInventory().setHelmet(leatherhelmet);
                    player.getInventory().setChestplate(leatherchestplate);
                    player.getInventory().setLeggings(new ItemStack(Material.IRON_LEGGINGS, 1));
                    player.getInventory().setBoots(new ItemStack(Material.IRON_BOOTS, 1));
                    player.getInventory().addItem(new ItemStack(Material.COOKED_BEEF, 15));

                    e.getWhoClicked().closeInventory();

                    // Times are in ticks
                    Title title = new Title(kitpvp,ChatColor.GREEN + "Kit successfully redeemed!",15,200,15);
                    title.setTitleColor(title.getTitleColor());
                    title.setSubtitleColor(title.getSubtitleColor());
                    title.setTimingsToTicks();

                    title.send(player);

                    kit.put(player, false);

                } else {
                    player.sendMessage(ChatColor.RED + "You do not have access to this kit!");
                    inv.removeItem(new ItemStack(Material.DIAMOND_SWORD));
                    inv.setItem(13, barrier);
                    e.setCancelled(true);
                    return;
                }
            }

            if (e.getCurrentItem().getItemMeta().getDisplayName().contains("Warrior")) {
                if(player.hasPermission("warrior.use")) {
                    e.setCancelled(true);

                    ItemStack sword = new ItemStack(Material.IRON_SWORD, 1);
                    sword.addEnchantment(Enchantment.DAMAGE_ALL, 1);

                    ItemStack bow = new ItemStack(Material.BOW, 1);
                    bow.addEnchantment(Enchantment.ARROW_INFINITE, 1);

                    player.getInventory().addItem(sword);
                    player.getInventory().setHelmet(new ItemStack(Material.CHAINMAIL_HELMET, 1));
                    player.getInventory().setChestplate(new ItemStack(Material.IRON_CHESTPLATE, 1));
                    player.getInventory().setLeggings(new ItemStack(Material.IRON_LEGGINGS, 1));
                    player.getInventory().setBoots(new ItemStack(Material.CHAINMAIL_BOOTS, 1));
                    player.getInventory().addItem(bow);
                    player.getInventory().addItem(new ItemStack(Material.ARROW, 1));

                    e.getWhoClicked().closeInventory();

                    // Times are in ticks
                    Title title = new Title(kitpvp,ChatColor.GREEN + "Kit successfully redeemed!",15,200,15);
                    title.setTitleColor(title.getTitleColor());
                    title.setSubtitleColor(title.getSubtitleColor());
                    title.setTimingsToTicks();

                    title.send(player);

                    kit.put(player, false);

                } else {
                    player.sendMessage(ChatColor.RED + "You do not have access to this kit!");
                    inv.removeItem(new ItemStack(Material.GOLD_SWORD));
                    inv.setItem(32, barrier);
                    e.setCancelled(true);
                    return;
                }
            }
            if (e.getCurrentItem().getItemMeta().getDisplayName().equals(" ")) {
                e.setCancelled(true);
            }  

            if (e.getCurrentItem().equals(Material.AIR)) {
                e.setCancelled(true);
            }  
        }

        String archer = ChatColor.DARK_GRAY + "[" + ChatColor.GREEN + "Archer" + ChatColor.DARK_GRAY + "] ";

}