Solved OP CMDS AND ISSUES HELP!!!!!!

Ok, heres my problem. I am trying to update and work on my plugin but i found an issue i cant seem to fix, i am new to bukkit coding and i know a little bit of java but this issue keeps being a problem to me no matter what i do. What happends is that when i test the plugin out, i try /web and it says i dont have permission to use /vur but shows the link in the config anyways (also i am op ingame, i am trying to make it say i dont have permission when im not op and when i dont have the permission node and not say the msg if i dont have permission.) But in /vur it says i dont have permission to do /web but this time it DOESNT show its own set message, which is not set in config.yml also the same for /cred but it says i dont have permission to use /web aswell but im also trying to make it work just fine and say its messages as /op without any permission denied thing or when players can normally use it as long as they have the permission node.

The codes of the commands are here: http://pastebin.com/ADdg3Gy5

I didnt see it to be necessary to copy and paste every bit of code, only the commands.

 

put return true where the no perm messages are

 

before: let me try that hold on
(just now: it says that its unreachable code so i dont know how exactly where i need to put it, you didnt really sound that descriptive)

 

@LukeZurg22
I do mine like this:

Code:

            }
            if (cmd.getName().equalsIgnoreCase("test") {
              if (!sender.hasPermission("test.perms")) {
                sender.sendMessage(ChatColor.YELLOW + "You are lacking permission");
                return false;
            }
              sender.sendMessage(ChatColor.YELLOW + "Nice you have the permissions!");
              return true;
      }

for your code, try this if the returns didn't work, which they should. Here is one example:

Code:

    public boolean onCommand(CommandSender sender, Command cmd, String label, String[] args) {

        if (cmd.getName().equalsIgnoreCase("web")&& !sender.hasPermission("linkdis.perm.web")){
              //send player message here
              //make sure it doesn't return
     }
              //send player message here
             //make it return
            }
}

 

This is useless. The only way you can even get to this point is if the sender does have the permission (since you checked for it before). Remove this if statement.

This is far more than an "example". This is writing his plugin for him. In the future, if you want to post an example, make sure the member can't just copy in paste the code without making any modifications.

 

i want ops to be able to use the command with or without the permission node thats not/is given to them but the "you do not have permission" message shouldnt show up for ops and the commands to be used by default players who MUST HAVE the permission node

 

OPs have every permission node.

 

well OPs cant use the /vur, and /cred when they do /web it says they dont have permission like the other commands but still shows the message anyways

 

@LukeZurg22

Are you still using that code at the way beginning?
Send me the code and the config so we can examine it.

Sorry, didn't think he would copy and paste it

Spoon feeding is bad!

 

@mehboss
And don't return false just because he has no permission. This will send the usage which is totally useless. Return false only if the arguments of the command were mismached.

Personally I NEVER return false but send the message myself (or let my system send it), as it can be coloured this way.

EDIT: Code snippet:

Code:

              if (!sender.hasPermission("test.perms")) {
                sender.sendMessage(ChatColor.YELLOW + "You are lacking permission");
                return false;

 

@I Al Istannen

is anyone seriously trying to help my current situation? i posted on the forums for a reason :/

 

@LukeZurg22
I have honestly no idea what your problem is. Your off post is very confusing.

But you have a few logic errors in that (unformatted, Press Ctrl+Shift+F in eclipse) code.

Code:java

    public boolean onCommand(CommandSender sender, Command cmd, String label, String[] args) {
 
        if (cmd.getName().equalsIgnoreCase("web") && sender.hasPermission("linkdis.perm.web")) {
            sender.sendMessage(getConfig().getString("WebCommandMsg"));
            // web executed, we can return here
        } else { // this will fire for all commands, if the sender doesn't have the permission for web
            sender.sendMessage(ChatColor.DARK_RED + "You don't have permission to do /web!");
            return true;
        }
        if (cmd.getName().equalsIgnoreCase("cred")) {
            // no permission check here?
            sender.sendMessage(ChatColor.YELLOW + "Credit Goes To" + ChatColor.GOLD + " LukeZurg22");
            return true;
        }
        if (cmd.getName().equalsIgnoreCase("vur") && sender.hasPermission("linkdis.perm.vur")) {
            sender.sendMessage(ChatColor.YELLOW + "Version: 1.5");
        } else {   // this will fire for all commands, if the player doesn't have permission for vur or entered an unknwown command.
            sender.sendMessage(ChatColor.DARK_RED + "You don't have permission to do /vur!");
            return true;
        }
        return false;
    }

You need to restructure that.
Use this structure:

Code:text

if( command name equals wb) {
    if(has permission) {
        execute web
        return true;
    }
    else {
        send no permission message
        return true;
    }
}
else if( command name equals cred) {
    execute cred
    return true;
}
else if( command name equals vur) {
    if(has permission) {
        execute vur
        return true;
    }
    else {
        send no permission message
        return true;
    }
}
else {
    return false;
}

 

@I Al Istannen
That is a bit confusing but here is a recording of what actually happends so you get a better idea of what my problem is.

 

@LukeZurg22
No one will download anything here. If it's code or from a txt file, post it using the [code.][/code] tags.

 

What? i simply made a video that shows the problem! Ill just post on youtube and give the link, is that fine?

Youtube video of problem:

It clearly shows what happends ingame when the commands are executed. The structure I AI ISTANNEN recommended confuses doesnt help much.
Also, www.google.com in the video is what is entered in the config.yml, but that is of no importance.

 

Your structure is probably way off if stuff like that is happening, make sure your { } are in tact.
Also, I'd suggest learning more Java as this is simple stuff. What I would recommend is reading Java for dummies 6th edition, it helped me a lot and the author (Barry Burd) makes it entertaining and fun.

 

where do i find a proper guide? not youtube videos but like the actual guide? ive read this https://docs.google.com/document/d/1RABwEM8FNPHwREOtH3AjTKsPt0jNsvGqb0okPn5-5TY/edit#
and it helped me find out how to make a plugin etc. but sofar my problem hasnt been resolved and im still waiting for help with it instead of being told "its simple" when if its that simple, it should be THAT simple to give a direct, and clear answer on what i need to do to fix it.

 

You can find tutorials HERE.

The reason this is happening is because of bad code structure. This is what the last few posts have been discussing.

Lets discuss what this says:

1. Check if the command is "web" and if the sender has permission. If so, send the string from config.
2. If either of those two cases are not met, just say it did not work and stop reading the rest of the command.

If the command if not "web", you will receive the permission error. So that means the command "/vur" will never be checked for.

How to solve: Use @I Al Istannen 's format. Here's another (hopefully better) explanation:

Code:

if(the command is "web"){
  if(player has perm){
     //Do what you want if they have the perms
  }else{
   ///Do what you want if they DONT have perms
  }
} else if (command is "vur"){
  if(player has perm){
     //Do what you want if they have the perms
  }else{
   ///Do what you want if they DONT have perms
  }
}

 

ok THAT makes a ton more sense! thank you! also /cred isnt supposed to have a permission node, its meant to be used by any player.

 

@LukeZurg22
In which case, you do not need to add the perm checks.

If your problem has been solved, mark this thread as solved.

 

ok