Solved No fall damage on command?

I'm creating a plugin where the player types /rocket and they gets launched into the air.
How would i cancel the falldamage when the player lands again?

I already have this:

Code:java

    public void onFallDamage(EntityDamageEvent event){
    if(event.getEntity() instanceof Player && event.getCause() == DamageCause.FALL)
    event.setCancelled(true);
    }

 

When the command fires add them to a list; when they land, remove them. Don't forget to check if they exist on the list in your conditional statement.

 

I think that's the right idea- you'd probably want to store the player's name in a hashset when they launch, and check/remove them on fall damage, so they're only protected one time after using /rocket.

I do something similar in my "fling" spell- I also track when the player used the command, and don't prevent fall damage if it was more than 5 seconds ago. This prevents accidental protection later on if they use the command but don't actually fall far enough to cause damage.

EDIT: Ninja'd! Well hopefully my additional comments about having the protection time out are helpful

 

Put this in one of your classes

Code:

public ArrayList<String> rocket = new ArrayList<String>();

then, when a player performs the command, put this in:

Code:

if(rocket.contains(p.getName()) return true;

rocket.add(p.getName());

// launch player and other stuff

then on a fall damage, put this in:

Code:

@EventHandler
public void onFallDamage(EntityDamageEvent event){
if(event.getEntity() instanceof Player && event.getCause() == DamageCause.FALL) {
Player p = (Player) e.getEntity();
if(rocket.contains(p.getName()) {
event.setCancelled(true);
rocket.remove(p.getName());
}
}
}

 

beastman3226 NathanWolf Never really did something using lists, how would i do this?

 

make a ArrayList
when you do the Command Add the player to the ArrayList
Then check if the player in the list
and then disable the Event
and remove the player from the List

 

GreatMinerZ

Code:java

List<String> fall = new ArrayList<String>();
//to check if they are in it
if(fall.contains(player.getName()) {
//code
}
//to add
fall.add(player.getName());
//to remove
fall.remove(player.getName());

 

I'd make a couple of small-ish changes to this-

Set<String> fall = new HashSet<String>(); // same interface, more efficient

if (fall.contains(...)) // typo fix

 

NathanWolf ^^ do that, and not an arraylist, his is much more efficient

 

sgavster NathanWolf i'm a bit confused now, how would that look?

 

Take sgvaster's code - you can use my replacements if you want, the only real important one is fixing the call to "contains"

Those are the pieces you can worth with, you need to stick them in the right places in your command handler and damage listener.

 

Don't forget the @EventHandler above your event!

 

Tupay NathanWolf sgavster DeStickyOne Player cannot be resolved. How would i fix this?

Code:

Code:java

    @EventHandler
    public void onFallDamage(EntityDamageEvent event) {
        if(fall.contains(player.getName() && event.getCause() == DamageCause.FALL)) {
            //code
            }
    event.setCancelled(true);
    }

 

what about actually creating the variable player?

 

L33m4n123 Can't use Player player = event.getPlayer on EntityDamageEvent

 

GreatMinerZ

Since you don't get all these clever correct people (And because i'm really bored) i just made it for you...

Code:java

 
    ArrayList<Player> noFall = new ArrayList<>();
 
    public void onEnable() {
        getServer().getPluginManager().registerEvents(this, this);
    }
 
    public boolean onCommand(CommandSender sender, Command command,
            String label, String[] args) {
        if (command.getName().equalsIgnoreCase("rocket")) {
            if (sender instanceof Player) {
                Player player = (Player) sender;
                player.setVelocity(new Vector(0, 10, 0));
                noFall.add(player);
            }
        }
        return false;
    }
 
    @EventHandler
    public void onPlayerDamage(EntityDamageEvent event) {
        if (event.getEntity() instanceof Player) {
            if (event.getCause().equals(DamageCause.FALL)) {
                if (noFall.contains((Player) event.getEntity())) {
                    event.setCancelled(true);
                    noFall.remove((Player) event.getEntity());
                }
            }
        }
    }

 

Yes. You only can do getEntity. However check if that is instanceof Player and cast it to player then

 

GreatMinerZ
Maybe what others have been saying (listening for an event) may be more efficient than what I do. But what I have done in my plugin PlayerLauncher is I set their velocity, direction, and so on, and when they are launched, I set their fall distance to -1000 so they won't be damaged if they fall less than or equal to 1000 blocks for that specific launch.

 

qlimax5000 No. Don't EVER add a player to an arraylist. Add their name. GreatMinerZ Learn java and bukkit.

 

DeStickyOne qlimax5000

To reiterate what sgavster said.
Never, ever store / add players to arraylists. This is because it WILL result in massive memory leaks. Always save the player name if you have to add a player, but not the player itself.

 

AoH_Ruthless
sgavster

I did not know this, thanks guys, i'll fix that in later codes

 

Code:java

 
Player player = (Player) event.getEntity();
// Although i'm not sure if you can just do event.getEntity().getPlayer(); or it might be for PlayerDeathEvent //only.

 

Tupay Tried this, works now but gives me errors in the console because of other entity's.

Code:java

 @EventHandler
public void onFallDamage(EntityDamageEvent event) {
Player player = (Player) event.getEntity();
Entity entity = event.getEntity();
 
if(fall.contains(player.getName())) {
if(entity instanceof Player) {
if(event.getCause() == DamageCause.FALL) {
//code
}
}
event.setCancelled(true);
//to remove
fall.remove(player.getName());
}
}

Any way to fix this?

 

Can you post your console log here?

 

Tupay i'll do it tomorrow. Pretty busy sorry

 

kk

 

Check first if it is a player before casting it to Player. Otherwise if a Zombie hits a Skeleton or any other entity hits another entity it gives you errors. Most likely you got those

 

L33m4n123 Tupay The problem is indeed the Entity hitting other Entity's what's giving me the error. Tried this but still won't work. How would i check if the entity who's using it is a player?

Code:java

    @EventHandler
    public void onFallDamage(EntityDamageEvent event) {
        Player player = (Player) event.getEntity();
        Entity entity = event.getEntity();
 
        if (entity.getType() == EntityType.PLAYER) {
        if(fall.contains(player.getName())) {
            if(entity instanceof Player) {
            if(event.getCause() == DamageCause.FALL) {
            //code
            }
            }
    event.setCancelled(true);
    //to remove
    fall.remove(player.getName());
    }
    }
    }

 

Before doing

Player player =(Player) event.getEntity();

you need to check if it is an instanceof Player

 

L33m4n123 won't give me any errors anymore but it looks like the entity's cannot hit me anymore..

Code:java

    @EventHandler
    public void onFallDamage(EntityDamageEvent event) {
        Entity entity = event.getEntity();
        if(entity instanceof Player) {
        Player player = (Player) event.getEntity();
 
        if (entity.getType() == EntityType.PLAYER) {
        if(fall.contains(player.getName())) {
            if(event.getCause() == DamageCause.FALL) {
            //code
            }
            }
    event.setCancelled(true);
    //to remove
    fall.remove(player.getName());
    }
    }
    }