Solved Need help with item drop chance.

So, I'm a bit new to developing with Java so I'm sorry if this seems a bit newbieish. I need to have a chance of items to drop from mobs, so I use Math.Random() to calculate the chance. For some reason it drops all but the diamond sword type. Why is this?

The EntityDeathEvent that calls the Calculation event.

Code:java

 
@EventHandler
public void onEntityDeath(EntityDeathEvent e) {
Entity entity = e.getEntity();
 
if (entity instanceof Monster) {
createSword();
 
if(item == "DIAMOND_SWORD")
e.getDrops().add(diamondSword);
 
if(item == "GOLD_SWORD")
e.getDrops().add(goldSword);
 
if(item == "IRON_SWORD")
e.getDrops().add(ironSword);
 
if(item == "STONE_SWORD")
e.getDrops().add(stoneSword);
 
if(item == "WOOD_SWORD")
e.getDrops().add(woodSword);
 
 
}
}

The calculation method.

Code:java

 
if (Math.random() < 0.45)
item = "WOOD_SWORD";
else if (Math.random() < 0.30)
item = "STONE_SWORD";
else if (Math.random() < 0.15)
item = "IRON_SWORD";
else if (Math.random() < 0.10)
item = "GOLD_SWORD";
else if (Math.random() < 0.5)
item = "DIAMOND_SWORD";

 

I think you want 0.05 and not 0.5

Also, in that first snippet of code, you need to use the .equals() method to compare strings, == won't work.

 

NathanWolf

I wrote:
if(item == "WOOD_SWORD);

instead of

if(item == "WOOD_SWORD){

I'm an idiot -.-
====================
Solved, stupid syntax error.

 

Ok, but the 0.05 thing and using == on Strings will still be a problem! Just be advised

 

NathanWolf
How so? I've just tested and they are all being dropped at different rates with my current code.

 

Better practice
Plus, you could do equalsIgnoreCase(ChatColor.stripColor("string here"));

 

calebbfmv
Really? Didn't know that thanks for the info.

 

Well... I guess I dunno how it's working then XD

I mean, assuming item is a String ... looking again at your code I was wrong about the 0.05/0.5 thing, but for strings you definitely need to use .equals().