Need help making a custom event

I looked at the custom event tutorial but its not really making sense, could someone help with this?

The events class:

Code:java

 
public class TransferMoneyEvent extends Event
{
 
private static final HandlerList handlers = new HandlerList();
private Economy economy;
private Player player = economy.player;
 
@Override
public HandlerList getHandlers()
{
return handlers;
}
 
public static HandlerList getHandlerList()
{
return handlers;
}
 
public int getAmountTransferred()
{
return economy.getTransferedAmount();
}
 
public void setAmountTransferred(int amount)
{
economy.setTransferredAmount(amount);
}
 
public Player getPlayer()
{
return this.player;
}
}

i tested it and it didnt fire, obviously :3 but i dont understand how to get it to work :/

 

Can you post your listener code and the event caller's code as well?

 

What about the code catching and throwing the event? Also, I feel like there should be a constructor, as economy is not initialized...
EDIT: Ninja'd...

 

i guess i havent made a caller :3

how/where do i make it?

just fixed that

Code:java

    private static Basic plugin;
    public TransferMoneyEvent(Basic instance){
        plugin = instance;
    }
private Economy economy = plugin.getEconomyAPI();

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

http://wiki.bukkit.org/Introduction_to_the_New_Event_System#Calling_a_Custom_Event

 

that doesnt help at all, it doesnt say where that goes, do i put that where ever money is being transferred? cause that makes sense (To me)

 

That seems a bit better. =P You call it whenever you want the event to be fired. Bukkit.getServer().getPluginManager().callEvent(new TransferMoneyEvent(plugin));

 

ill try that thanks

i gotta go, ill post later tonight if this works, (i really hope this does D: )

im getting an NPE on

pm.callEvent(event);

heres my event

Code:java

public class TransferMoneyEvent extends Event
{
    public static Basic plugin;
    public TransferMoneyEvent(Basic instance)
    {
        plugin = instance;
    }
 
    private static final HandlerList handlers = new HandlerList();
    private Economy economy = new Economy();
    private Player player = economy.player;
    private int amount = economy.transferedMoney;
 
    @Override
    public HandlerList getHandlers()
    {
        return handlers;
    }
 
    public static HandlerList getHandlerList()
    {
        return handlers;
    }
 
    public int getAmountTransferred()
    {
        return this.amount;
    }
 
    public void setAmountTransferred(int amount)
    {
        economy.setTransferredAmount(amount);
    }
 
    public Player getPlayer()
    {
        return this.player;
    }
}

heres where the event is being called

Code:java

    public void transferMoney(Player givingPlayer, Player receivingPlayer, int value){
        TransferMoneyEvent event = new TransferMoneyEvent(plugin);
        PluginManager pm = plugin.getServer().getPluginManager();
        this.player = givingPlayer;
        EconomyInfo info = plugin.getEconomyInfo();
        if(this.transferedMoney == 0){
        this.transferedMoney = value;
            if(givingPlayer == null || receivingPlayer == null)return;
            if(info.getMoney().getInt(givingPlayer.getName() + ".Balance") - value < 0){
                return;
            }
            this.subtractMoney(givingPlayer, value);
            this.addMoney(receivingPlayer, value);
        }else{
            value = this.transferedMoney;
            if(givingPlayer == null || receivingPlayer == null)return;
            if(info.getMoney().getInt(givingPlayer.getName() + ".Balance") - value < 0){
                return;
            }
            this.subtractMoney(givingPlayer, value);
            this.addMoney(receivingPlayer, value);
        }
        pm.callEvent(event);
    }

and heres my test listener

Code:java

    @EventHandler
    public void onTransfer(TransferMoneyEvent event)
    {
        Player player = event.getPlayer();
        plugin.getLogger().info("test");
        player.sendMessage("rawr: ");
    }

:/

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

Your error log would be nice.

 

Uhm, ive never played around with custom events or anything, but uhm,

shouldnt you be passing more info into the event than you are? ...and vice versa? from what im seeing, no matter what you do to the event in the listener, it wouldnt affect any of your outcome. Plus, your event fires AFTER all of your code executes :x

 

Code:

21:30:11 [INFO] [Basic] test
21:30:11 [SEVERE] Could not pass event TransferMoneyEvent to Basic
org.bukkit.event.EventException
        at org.bukkit.plugin.java.JavaPluginLoader$1.execute(JavaPluginLoader.ja
va:303)
        at org.bukkit.plugin.RegisteredListener.callEvent(RegisteredListener.jav
a:62)
        at org.bukkit.plugin.SimplePluginManager.callEvent(SimplePluginManager.j
ava:459)
        at com.github.Sabersamus.Basic.Economy.API.Economy.transferMoney(Economy
.java:94)
        at com.github.Sabersamus.Basic.Economy.Wallet.onCommand(Wallet.java:64)
        at org.bukkit.command.PluginCommand.execute(PluginCommand.java:40)
        at org.bukkit.command.SimpleCommandMap.dispatch(SimpleCommandMap.java:16
6)
        at org.bukkit.craftbukkit.CraftServer.dispatchCommand(CraftServer.java:4
73)
        at net.minecraft.server.NetServerHandler.handleCommand(NetServerHandler.
java:821)
        at net.minecraft.server.NetServerHandler.chat(NetServerHandler.java:781)

        at net.minecraft.server.NetServerHandler.a(NetServerHandler.java:764)
        at net.minecraft.server.Packet3Chat.handle(Packet3Chat.java:33)
        at net.minecraft.server.NetworkManager.b(NetworkManager.java:229)
        at net.minecraft.server.NetServerHandler.a(NetServerHandler.java:113)
        at net.minecraft.server.NetworkListenThread.a(NetworkListenThread.java:7
8)
        at net.minecraft.server.MinecraftServer.w(MinecraftServer.java:554)
        at net.minecraft.server.MinecraftServer.run(MinecraftServer.java:452)
        at net.minecraft.server.ThreadServerApplication.run(SourceFile:490)
Caused by: java.lang.NullPointerException
        at com.github.Sabersamus.Basic.Listeners.Test.onTransfer(Test.java:24)
        at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
        at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source)
        at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source)
        at java.lang.reflect.Method.invoke(Unknown Source)
        at org.bukkit.plugin.java.JavaPluginLoader$1.execute(JavaPluginLoader.ja
va:301)
        ... 17 more

if you see in there it says [Basic] test

which means the event is firing (good) its just event.getPlayer(); is null apparently (im just now seeing the [Basic] test for the first time)

what do you mean?

edit: i haven't really added much to the event right now i just need to make sure its working

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

well... i dont know exactly what economy is, nor have a dealt with it, but im assuming that it doesnt contain the specific player you need, considering that its a new object you just created. Therefore, the player field in economy would be null, logically, i have no idea how it would know which player to point at.

 

in the transferMoney() method, i set

this.player = givingPlayer;
givingPlayer is the player thats giving money,

so it *shouldn't* be null :/

Code:java

 
protected Player player;
 
    public void transferMoney(Player givingPlayer, Player receivingPlayer, int value){
        TransferMoneyEvent event = new TransferMoneyEvent(plugin);
        PluginManager pm = plugin.getServer().getPluginManager();
        pm.callEvent(event);
        this.player = givingPlayer;
//more code
 
 

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

yeah but theyre completly different objects

edit: i get it! pass the economy object into the event as a parameter

 

not sure what you mean :3

but in the Event class it pulls that for getPlayer();

Code:java

 
private Player player = economy.player;
 
public Player getPlayer(){
return this.player;
}
 

 

er.. okay, lets see.. where is this economy object originating from? i wanna go look at the api for it

 

i changed it to

Code:java

private Economy economy = plugin.getEconomyAPI();

main class >>

Code:java

        public Economy getEconomyAPI(){
            return new Economy(this);
        }

eh, that made everything return null and wont even fire the event D:

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

Okay dont worry. Do me a favor, and tell me what the economy object youre using is called, in the code (not the event)

 

what do you mean? :/

edit: i found why everything broke, if i do this

Code:java

private Economy economy = new Economy();

its fine but if i do

Code:java

private Economy economy = new Economy(plugin);

it breaks D:

 

where is the api for this economy thing? lemme take a look at it.

 

not sure if this is what you mean, but all the things are stored in Economy.java

Code:java

package com.github.Sabersamus.Basic.Economy.API;
 
import org.bukkit.OfflinePlayer;
import org.bukkit.entity.Player;
import org.bukkit.plugin.PluginManager;
 
import com.github.Sabersamus.Basic.Basic;
import com.github.Sabersamus.Basic.EconomyInfo;
 
/**
 * Methods to manage the economy
 */
public class Economy 
{
    public static Basic plugin;
    public Economy(Basic instance){
        plugin = instance;
    }
 
    public Economy()
    {
 
    }
 
    private boolean hasEnough;
    protected int transferedMoney = 0;
    protected Player player;
 
    public boolean hasEnough(){
        if(hasEnough){
            return true;
        }else{
            return false;
        }
    }
 
    /**
     * Gets the balance of a player
     * @param - player the player chosen
     * @return - the players balance
     */
    public int getBalance(Player player){
        EconomyInfo info = plugin.getEconomyInfo();
        if(info.getMoney().contains(player.getName())){
            return info.getMoney().getInt(player.getName() + ".Balance");
        }
        return 0;
    }
 
    /**
     * Gets the balance of an offline player
     * @param player - the offline player whose balance to be checked
     * @return - the amount of money they have
     */
    public int getBalance(OfflinePlayer player)
    {
        EconomyInfo info = plugin.getEconomyInfo();
        if(player != null)
        {
            return info.getMoney().getInt(player.getName() + ".Balance");
        }else{
        return 0;
        }
    }
 
    /**
     * Transfers money from one player to another
     * @param givingPlayer - the player to give the money
     * @param receivingPlayer - the player to get the money
     * @param value - the amount of money to be transferred
     */
    public void transferMoney(Player givingPlayer, Player receivingPlayer, int value){
        TransferMoneyEvent event = new TransferMoneyEvent(plugin);
        PluginManager pm = plugin.getServer().getPluginManager();
        this.player = givingPlayer;
        EconomyInfo info = plugin.getEconomyInfo();
        if(this.transferedMoney == 0){
        this.transferedMoney = value;
            if(givingPlayer == null || receivingPlayer == null)return;
            if(info.getMoney().getInt(givingPlayer.getName() + ".Balance") - value < 0){
                return;
            }
            this.subtractMoney(givingPlayer, value);
            this.addMoney(receivingPlayer, value);
        }else{
            value = this.transferedMoney;
            if(givingPlayer == null || receivingPlayer == null)return;
            if(info.getMoney().getInt(givingPlayer.getName() + ".Balance") - value < 0){
                return;
            }
            this.subtractMoney(givingPlayer, value);
            this.addMoney(receivingPlayer, value);
        }
        pm.callEvent(event);
    }
 
    /**
     * Transfers money between an online player and an offline player
     * @param givingPlayer - the player giving the money
     * @param receivingPlayer - the offline player getting money
     * @param amount - the amount of money to be transferred
     */
    public void transferMoney(Player givingPlayer, OfflinePlayer receivingPlayer, int amount)
    {
        this.player = givingPlayer;
        EconomyInfo info = plugin.getEconomyInfo();
            if(this.transferedMoney == 0)
            {
                this.transferedMoney = amount;
                if(givingPlayer == null || receivingPlayer == null)return;
                if(info.getMoney().getInt(givingPlayer.getName() + ".Balance") - amount < 0)return;
                this.subtractMoney(givingPlayer, amount);
                this.addMoney(receivingPlayer, amount);
            }else{
                amount = this.transferedMoney;
                if(givingPlayer == null || receivingPlayer == null)return;
                if(info.getMoney().getInt(givingPlayer.getName() + ".Balance") - amount < 0)return;
                this.subtractMoney(givingPlayer, amount);
                this.addMoney(givingPlayer, amount);
            }
    }
 
    /**
     * Sets the amount of money transferred
     * @param amount - the amount of money to be set
     */
    public void setTransferredAmount(int amount)
    {
        this.transferedMoney = amount;
    }
 
    /**
     * Gets the amount of money transferred
     * @return if a transaction has been set, returns the amount, else 0
     */
    public int getTransferedAmount()
    {
        if(this.transferedMoney > 0)
        {
        return this.transferedMoney;
        }
        return 0;
    }
 
    /**
     * Adds money to a players balance
     * @param - player the player selected
     * @param - amount the amount to be added
     */
    public void addMoney(Player player, int amount){
        EconomyInfo info = plugin.getEconomyInfo();
        this.player = player;
        if(this.transferedMoney == 0){
        this.transferedMoney = amount;
        if(info.getMoney().contains(player.getName())){
            info.getMoney().set(player.getName() + ".Balance", plugin.getEconomyInfo().getMoney().getInt(player.getName() + ".Balance") + amount);
            info.saveMoney();
        }else{
        info.getMoney().set(player.getName() + ".Balance", amount);
        info.saveMoney();
            }
        }else{
            amount = this.transferedMoney;
            if(info.getMoney().contains(player.getName())){
                info.getMoney().set(player.getName() + ".Balance", plugin.getEconomyInfo().getMoney().getInt(player.getName() + ".Balance") + amount);
                info.saveMoney();
            }else{
            info.getMoney().set(player.getName() + ".Balance", amount);
            info.saveMoney();
            }
        }
    }
 
    /**
     * Adds money to an offline players balance
     * @param player - the offline player to get money
     * @param amount - the amount of money to receive
     */
    public void addMoney(OfflinePlayer player, int amount)
    {
        EconomyInfo info = plugin.getEconomyInfo();
        if(player == null)return;
        info.getMoney().set(player.getName() + ".Balance", info.getMoney().getInt(player.getName() + ".Balance") + amount);
        info.saveMoney();
    }
 
    /**
     * Subtracts money from a players balance
     * @param player - the player chosen
     * @param amount - the money to be removed, can not make a players balance less than 0
     */
    public void subtractMoney(Player player, int amount){
        this.player = player;
        EconomyInfo settings = plugin.getEconomyInfo();
        if(this.transferedMoney == 0){
        this.transferedMoney = amount;
        if(settings.getMoney().contains(player.getName())){
            if(settings.getMoney().getInt(player.getName() + ".Balance") - amount < 0){
                this.hasEnough = false;
                return;
            }else{
            this.hasEnough = true;
            settings.getMoney().set(player.getName() + ".Balance", settings.getMoney().getInt(player.getName() + ".Balance") - amount);
            settings.saveMoney();
            this.transferedMoney = amount;
                }
            }
        }else{
            if(settings.getMoney().contains(player.getName())){
                if(settings.getMoney().getInt(player.getName() + ".Balance") - amount < 0){
                    this.hasEnough = false;
                    return;
                }else{
                this.hasEnough = true;
                settings.getMoney().set(player.getName() + ".Balance", settings.getMoney().getInt(player.getName() + ".Balance") - amount);
                settings.saveMoney();
                this.transferedMoney = amount;
                    }
                }
        }
    }
 
    /**
     * Subtracts money from an offline player
     * @param player - the offline player
     * @param value - the amount of money to be subtracted
     */
    public void subtractMoney(OfflinePlayer player, int value)
    {
        EconomyInfo info = plugin.getEconomyInfo();
        if(player == null)return;
        if(info.getMoney().getInt(player.getName() + ".Balance") - value < 0)return;
        info.getMoney().set((player.getName() + ".Balance"), info.getMoney().getInt(player.getName() + ".Balance") - value);
        info.saveMoney();
    }
 
    /**
     * Sets a players balance
     * @param player - the player
     * @param amount - the amount to be set, can not be less than 0
     */
    public void setBalance(Player player, int amount){
        this.player = player;
        EconomyInfo settings = plugin.getEconomyInfo();
        if(amount < 0){
            return;
        }else{
        settings.getMoney().set(player.getName() + ".Balance", amount);
        settings.saveMoney();
        this.transferedMoney = amount;
        }
    }
 
    /**
     * Sets an offline players balance
     * @param player - the offline player
     * @param amount - the amount of money to be set
     */
    public void setBalance(OfflinePlayer player, int amount)
    {
        EconomyInfo info = plugin.getEconomyInfo();
        if(amount < 0)return;
        info.getMoney().set(player.getName() + ".Balance", amount);
        info.saveMoney();
        this.transferedMoney = amount;
    }
}
 

theres a method in the main class to access it

public Economy getEconomyAPI(){
return new Economy(this);
}

 

Knew it. Your player is uninitialized, look at line 27. Youre creating a brand new object of this class, and the player isnt initialized. instead of creating a new instance of Economy, have your event:

Code:

public static Basic plugin;
Economy economy;
public TransferMoneyEvent(Basic instance, Economy economy)
{
plugin = instance;
this.economy = economy;
}

as your constructor (and declared variables)

and for your event creation, add "this" to the constructor parameters.

 

ok i added that,

and now i get this

Code:

22:26:38 [SEVERE] null
org.bukkit.command.CommandException: Unhandled exception executing command 'wall
et' in plugin Basic v0.7
        at org.bukkit.command.PluginCommand.execute(PluginCommand.java:42)
        at org.bukkit.command.SimpleCommandMap.dispatch(SimpleCommandMap.java:16
6)
        at org.bukkit.craftbukkit.CraftServer.dispatchCommand(CraftServer.java:4
73)
        at net.minecraft.server.NetServerHandler.handleCommand(NetServerHandler.
java:821)
        at net.minecraft.server.NetServerHandler.chat(NetServerHandler.java:781)

        at net.minecraft.server.NetServerHandler.a(NetServerHandler.java:764)
        at net.minecraft.server.Packet3Chat.handle(Packet3Chat.java:33)
        at net.minecraft.server.NetworkManager.b(NetworkManager.java:229)
        at net.minecraft.server.NetServerHandler.a(NetServerHandler.java:113)
        at net.minecraft.server.NetworkListenThread.a(NetworkListenThread.java:7
8)
        at net.minecraft.server.MinecraftServer.w(MinecraftServer.java:554)
        at net.minecraft.server.MinecraftServer.run(MinecraftServer.java:452)
        at net.minecraft.server.ThreadServerApplication.run(SourceFile:490)
Caused by: java.lang.NullPointerException
        at com.github.Sabersamus.Basic.Economy.API.TransferMoneyEvent.<init>(Tra
nsferMoneyEvent.java:20)
        at com.github.Sabersamus.Basic.Economy.API.Economy.transferMoney(Economy
.java:73)
        at com.github.Sabersamus.Basic.Economy.Wallet.onCommand(Wallet.java:64)
        at org.bukkit.command.PluginCommand.execute(PluginCommand.java:40)
        ... 12 more

73 of Economy: TransferMoneyEvent event = new TransferMoneyEvent(plugin, this);

20 of TransferMoneyEvent: private Player player = economy.player;

 

did the player get the message?

 

Your forgetting something here. You declared a variable "player" as a Player entity. Then you checking the Player getPlayer(){return this.player} shouldn't it be

Code:java

 
Public player getPlayer(){
return this.player
}
 

or am I mistaken?

 

nope Sabersamus is correct. First it's public (lower case p) and the return type is Player since the class is names like that.

BTW: dsmyth1915 your code wouldn't even compile.

 

Thanks you, I'm on my phone at the moment and it like to make weird capitalizations for no apparent reason.

 

ok so i got it working, but i have a temporary work around :/ and its not fun

Code:java

    public Player getPlayer()
    {
        return this.player;
    }
 
    protected void setPlayer(Player player)
    {
        this.player = player;
    }

thats in the event, and RIGHT before i call the event,

Code:java

 
        TransferMoneyEvent event = new TransferMoneyEvent(plugin);
        PluginManager pm = plugin.getServer().getPluginManager();
        event.setPlayer(givingPlayer);
        pm.callEvent(event);

this works, my test listener is the same as before,

Code:java

 
public void onTransfer(TransferMoneyEvent event){
Player player = event.getPlayer();
plugin.getLogger().info("test");
player.sendMessage("rawr: ");
}

it displays both messages, but i dont wanna have to use protected void setPlayer(Player player){ :/

 

use pakage protected setPlayer(), then its not incuded at the java doc by default

 

then... pass the player in through the event constructor..