Need a new pair of eyes

Please have a look at my code what could i make different? What could i improve?

DeepStorageHandler.java (open) DeepStorageHandler.java (close)

DeepStorageHandler.java

Code:java

package me.jantuck.JCraftMain.DeepStorage;
 
import me.jantuck.JCraftMain.JCraftInitializer;
import me.jantuck.JCraftMain.Money.MoneyHandler;
import me.jantuck.JCraftMain.TokenStorage.Token;
import org.bukkit.Bukkit;
import org.bukkit.ChatColor;
import org.bukkit.Material;
import org.bukkit.entity.Player;
import org.bukkit.inventory.Inventory;
import org.bukkit.inventory.ItemStack;
import org.bukkit.inventory.meta.ItemMeta;
 
import java.util.ArrayList;
import java.util.Arrays;
import java.util.List;
 
/**
* Created by Jan on 1/15/2017.
*/
public class DeepStorageHandler {
 
    private ItemStack[] listToArray(ArrayList<ItemStack> list) {
        return list.toArray(new ItemStack[list.size()]);
    }
 
    private static DeepStorageHandler instance = null;
    private JCraftInitializer plugin = null;
 
    public static DeepStorageHandler getDeepStoragehandler() {
        return instance;
    }
 
    public void onEnable() {
        plugin = JCraftInitializer.getJCraftInitalizer();
        plugin.moduleStartup("DeepStorage handler", "Loaded.");
        plugin.getServer().getPluginManager().registerEvents(new DeepStorageEvents(), plugin);
        instance = this;
    }
    public ItemStack createItem(Material material, int amount , byte data, String displayName, List<String> lore)
    {
        ItemStack itemStack = new ItemStack(material, amount, data);
        ItemMeta itemMeta = itemStack.getItemMeta();
        itemMeta.setDisplayName(displayName);
        itemMeta.setLore(lore);
        itemStack.setItemMeta(itemMeta);
        return itemStack;
    }
    private final ItemStack BUY_ITEM = createItem(Material.STAINED_GLASS_PANE, 1, (byte) 5, ChatColor.GREEN+"Buy a Deepstorage Container.", Arrays.asList(ChatColor.GOLD+"Costs:"+ ChatColor.GREEN +" 3000$"));
    private final ItemStack SELL_ITEM = createItem(Material.STAINED_GLASS_PANE, 1, (byte) 14, ChatColor.RED+"Sell a Deepstorage Container.", Arrays.asList(ChatColor.GOLD+"Return:"+ ChatColor.GREEN +" 1500$", ChatColor.GOLD+"Click this!"));
    public void popUp(Player player)
    {
        Inventory inventory = Bukkit.createInventory(null, 54, ChatColor.GREEN + "DeepStorage");
        inventory.setItem(50,SELL_ITEM);
        inventory.setItem(48,BUY_ITEM);
        Token token = new Token("DeepStoragesList."+player.getUniqueId().toString(), "deepstorage", "data");
        if (token.hasData())
        {
            List<String> stringList = (List<String>) token.getData();
            for (int i = 0; i < stringList.size(); i++)
            {
                inventory.setItem(i, createItem(Material.STAINED_GLASS, 1, (byte) 11, ChatColor.BLUE+"DeepStorage: " + stringList.get(i), Arrays.asList(" ")));
            }
        }
        else
        {
            token.setData(Arrays.asList("Default"));
            inventory.setItem(0, createItem(Material.STAINED_GLASS, 1, (byte) 11, ChatColor.BLUE+"DeepStorage: Default", Arrays.asList(" ")));
            token.save();
        }
        player.openInventory(inventory);
    }
 
    public void openDeepStorage(Player player, String name)
    {
        Inventory inventory = Bukkit.createInventory(null, 54, ChatColor.BLUE + "DeepStorage: " + name);
        Token token = new Token("DeepStorages."+player.getUniqueId().toString()+"."+name, "deepstorage", "data");
        if (token.hasData())
        {
            ArrayList<ItemStack> contentList = (ArrayList<ItemStack>) token.getData();
            ItemStack[] contents = listToArray(contentList);
            inventory.setContents(contents);
        }
        player.openInventory(inventory);
    }
 
    public void sellDeepstorage(Player player, String name)
    {
        MoneyHandler.getMoneyHandler().give(player, 1500.0);
        Token token = new Token("DeepStoragesList."+player.getUniqueId().toString(), "deepstorage", "data");
        if (token.hasData())
        {
            List<String> stringList = (List<String>) token.getData();
            stringList.remove(name);
        }
        token.save();
        token = new Token("DeepStorages."+player.getUniqueId().toString()+"."+name, "deepstorage", "data");
        token.setData(null);
        token.save();
    }
}
 

DeepStorageEvents.java (open) DeepStorageEvents.java (close)

Code:java

package me.jantuck.JCraftMain.DeepStorage;
 
import me.jantuck.JCraftMain.Commands.Executors.DeepStorage;
import me.jantuck.JCraftMain.Money.MoneyHandler;
import me.jantuck.JCraftMain.TokenStorage.Token;
import me.jantuck.JCraftMain.Utils.Playerutils;
import org.bukkit.ChatColor;
import org.bukkit.Material;
import org.bukkit.entity.Player;
import org.bukkit.event.EventHandler;
import org.bukkit.event.Listener;
import org.bukkit.event.inventory.InventoryClickEvent;
import org.bukkit.event.inventory.InventoryCloseEvent;
import org.bukkit.inventory.Inventory;
import org.bukkit.inventory.ItemStack;
 
import java.util.*;
 
/**
* Created by Jan on 1/15/2017.
*/
public class DeepStorageEvents implements Listener {
 
    List<UUID> sell = new ArrayList<UUID>();
 
    @EventHandler
    public void onInventoryClick(InventoryClickEvent event)
    {
        Player player = (Player) event.getWhoClicked();
        Inventory inventory = event.getInventory();
        String inventoryTitle = inventory.getTitle();
        if (inventoryTitle.equals(ChatColor.GREEN + "DeepStorage"))
        {
            ItemStack item = event.getCurrentItem();
            if (item != null && item.hasItemMeta() && item.getItemMeta().hasDisplayName())
            {
                String displayName = item.getItemMeta().getDisplayName();
                if (displayName.startsWith(ChatColor.BLUE+"DeepStorage: "))
                {
                    String deepstorageName = displayName.replace(ChatColor.BLUE + "DeepStorage: ", "");
                    if (sell.contains(player.getUniqueId()))
                    {
                        DeepStorageHandler.getDeepStoragehandler().sellDeepstorage(player, deepstorageName);
                        inventory.remove(item);
                        Playerutils.notify(player, "You have sold the deepstorage unit &a"+deepstorageName);
                        sell.remove(player.getUniqueId());
                        inventory.setItem(50, DeepStorageHandler.getDeepStoragehandler().createItem(Material.STAINED_GLASS_PANE, 1, (byte) 14, ChatColor.RED+"Sell a Deepstorage Container.", Arrays.asList(ChatColor.GOLD+"Return:"+ ChatColor.GREEN +" 1500$", ChatColor.GOLD+"Click this!")));
                    }
                    else {
                        DeepStorageHandler.getDeepStoragehandler().openDeepStorage(player, deepstorageName);
                    }
                }
                else if (displayName.equalsIgnoreCase(ChatColor.GREEN+"Buy a Deepstorage Container."))
                {
                    boolean purchase = MoneyHandler.getMoneyHandler().purchase(player, 3000);
                    if (purchase)
                    {
                        Token token = new Token("DeepStoragesList."+player.getUniqueId().toString(), "deepstorage", "data");
                        if (token.hasData())
                        {
                            List<String> stringList = (List<String>) token.getData();
                            if (stringList.size()<45) {
                                Playerutils.notify(player, "You have bought another deepstorage container.");
                                stringList.add("N" + (stringList.size()));
                                token.setData(stringList);
                                token.save();
                                DeepStorageHandler.getDeepStoragehandler().popUp(player);
                            }
                            else
                            {
                                Playerutils.notify(player, "You have the max amount of deepstorages available.");
                            }
                        }
                    }
                    else
                    {
                        Playerutils.notify(player, "You do not have enough money to buy another deepstorage. Your Money: &a" + MoneyHandler.getMoneyHandler().getMoney(player) + "$&6 Cost:&a 3000$");
                    }
                }
                else if (displayName.equalsIgnoreCase(ChatColor.RED+"Sell a Deepstorage Container."))
                {
                    if (!sell.contains(player.getUniqueId())) {
                        inventory.setItem(50, DeepStorageHandler.getDeepStoragehandler().createItem(Material.STAINED_GLASS_PANE, 1, (byte) 14, ChatColor.RED + "Sell a Deepstorage Container.", Arrays.asList(ChatColor.GOLD + "Return:" + ChatColor.GREEN + " 1500$", ChatColor.GOLD + "Click the DeepStorage to sell!", ChatColor.GOLD + "All items will get deleted!",ChatColor.GOLD + "Click again to cancel.")));
                        sell.add(player.getUniqueId());
                    }
                    else
                    {
                        inventory.setItem(50, DeepStorageHandler.getDeepStoragehandler().createItem(Material.STAINED_GLASS_PANE, 1, (byte) 14, ChatColor.RED+"Sell a Deepstorage Container.", Arrays.asList(ChatColor.GOLD+"Return:"+ ChatColor.GREEN +" 1500$", ChatColor.GOLD+"Click this!")));
                        sell.remove(player.getUniqueId());
                    }
                }
            }
            event.setCancelled(true);
        }
    }
 
    @EventHandler
    public void onInventoryClose(InventoryCloseEvent event)
    {
        Player player = (Player) event.getPlayer();
        Inventory inventory = event.getInventory();
        String inventoryTitle = inventory.getTitle();
        if (ChatColor.stripColor(inventoryTitle).startsWith("DeepStorage: "))
        {
            String deepstorageName = ChatColor.stripColor(inventoryTitle).replace("DeepStorage: ","");
            Token token = new Token("DeepStorages."+player.getUniqueId().toString()+"."+deepstorageName, "deepstorage", "data");
            token.setData(inventory.getContents());
            token.save();
            if (sell.contains(player.getUniqueId()))
            {
                sell.remove(player.getUniqueId());
            }
        }
    }
}
 

Deepstorage.java (open) Deepstorage.java (close)

Code:java

package me.jantuck.JCraftMain.Commands.Executors;
 
import me.jantuck.JCraftMain.DeepStorage.DeepStorageHandler;
import org.bukkit.command.Command;
import org.bukkit.command.CommandExecutor;
import org.bukkit.command.CommandSender;
import org.bukkit.entity.Player;
 
/**
* Created by Jan on 1/15/2017.
*/
public class DeepStorage implements CommandExecutor {
    @Override
    public boolean onCommand(CommandSender commandSender, Command command, String s, String[] args) {
        if (!(commandSender instanceof Player)) return false;
        Player player = (Player) commandSender;
        DeepStorageHandler.getDeepStoragehandler().popUp(player);
        return true;
    }
}
 

 

There is not anything that stands out. Here are just a few pointers.

Since this is not a main class, I would recommend calling this method "init".

Also, why are you using Allman's style instead of K&R?

BTW: What are you creating? It looks like a shop system, but I don't fully understand what you are doing.

 

Well intellij does this automatic when i ask it to reformat code.

Im just creating stuff to test my knowledge.

The init part is actually helpful. I just didnt think much about naming conventions.

Pretty much a whole bunch of stuff compiled on eachother.

 

@JanTuck for the sell arraylist I recommend using hashsets

 

@kameronn

Done thx, whats so special about hashsets?

Code:java

 
HashSet<UUID> sell = new HashSet<UUID>();
 
 

 

@JanTuck
It doesnt allow duplicates so you cant add the same UUID twice, plus in my opinion its better for objects

 

@JanTuck
Choosing the right collection can be tricky sometimes. I find this chart handy when picking the type of collection you need:
http://stackoverflow.com/questions/21974361/what-java-collection-should-i-use/21974362#21974362

 

@AlvinB
This is actually really useful thx.