My Project, do you have tips?

Hello,

I'm making a 'mini-game' plugin, I've looked quite some tutorials, and I have messed arrount with coding. I'm not a pro in coding.

Mini-Game Idea
A simple PvP mini-game, you join the server, and got in the lobby. You'll have 60 to ready yourself (With walking arount). There are 2 teams, a blue one and a red one. If the countdown (60 seconds) is done, you'll automatic go in a team, and get a kit of items (Autostart with 2 players online).
The team with the most kills wins, and gets points, with points can you buy later items (Like swords/armor).

Main class:

Code:java

package me.Shadow48402.scoreboard;
 
import java.util.logging.Logger;
 
import org.bukkit.Bukkit;
import org.bukkit.ChatColor;
import org.bukkit.entity.Player;
import org.bukkit.event.Listener;
import org.bukkit.plugin.java.JavaPlugin;
import org.bukkit.scoreboard.DisplaySlot;
import org.bukkit.scoreboard.Objective;
import org.bukkit.scoreboard.Score;
import org.bukkit.scoreboard.Scoreboard;
import org.bukkit.scoreboard.ScoreboardManager;
import org.bukkit.scoreboard.Team;
 
public class Main extends JavaPlugin implements Listener {
    public final Logger logger = Logger.getLogger("Minecraft");
 
 
    @Override
    public void onDisable() {
        this.logger.info("Has Been Disabled!");
 
    }
 
    public void onEnable() {
        getServer().getPluginManager().registerEvents(this, this);
        getServer().getPluginManager().registerEvents(new JoinEvent(), this);
 
        ScoreboardManager sbManager = Bukkit.getScoreboardManager();
        Scoreboard sBoard = sbManager.getNewScoreboard();
 
        Team red = sBoard.registerNewTeam("red");
        Team blue = sBoard.registerNewTeam("blue");
 
        red.setPrefix(ChatColor.RED + "");
        blue.setPrefix(ChatColor.BLUE + "");
 
        red.setDisplayName(ChatColor.RED + getName());
        blue.setDisplayName(ChatColor.BLUE + getName());
 
        red.setAllowFriendlyFire(false);
        blue.setAllowFriendlyFire(false);
 
        Objective obj = sBoard.registerNewObjective("Kill lists", "Kills");
 
        obj.setDisplaySlot(DisplaySlot.SIDEBAR);
        obj.setDisplayName("Kills");
 
        Score score = obj.getScore(Bukkit.getOfflinePlayer("Total kills"));
        score.setScore(0);
 
        for(Player player : Bukkit.getOnlinePlayers()){
            player.setScoreboard(sBoard);
            player.setScoreboard(sbManager.getNewScoreboard());
        }
 
        Scoreboard pHealt = sbManager.getNewScoreboard();
        Objective Healt = pHealt.registerNewObjective("PlayerNameHealt", "Healt");
        Healt.setDisplaySlot(DisplaySlot.BELOW_NAME);
        Healt.setDisplayName(" Hearts");
 
        for(Player player : Bukkit.getOnlinePlayers()) {
            player.setScoreboard(pHealt);
        }
    }
}
 

in this class is the ScoreBoard, and this class contains the onDisable/onEnable.

JoinEvent:

Code:java

package me.Shadow48402.scoreboard;
 
import net.minecraft.server.v1_6_R2.Item;
import net.minecraft.server.v1_6_R2.ItemAxe;
 
import org.bukkit.Bukkit;
import org.bukkit.ChatColor;
import org.bukkit.Location;
import org.bukkit.Material;
import org.bukkit.entity.Player;
import org.bukkit.event.EventHandler;
import org.bukkit.event.Listener;
import org.bukkit.event.player.PlayerJoinEvent;
import org.bukkit.inventory.ItemStack;
import org.bukkit.inventory.PlayerInventory;
import org.bukkit.plugin.Plugin;
import org.fusesource.jansi.Ansi.Color;
 
public class JoinEvent implements Listener{
 
    @EventHandler
    public void onPlayerJoinEvent(PlayerJoinEvent event) {
        Player player = event.getPlayer();
        player.sendMessage(ChatColor.AQUA + "Welkom in Lomeus Team-PvP");
 
        Location Lobby = new Location(Bukkit.getWorld("World"), 1,1, 0); //TODO : Set spawn
 
        player.teleport(Lobby);
 
        final int Countdown;
        final Player player1 = event.getPlayer();
        Countdown = Bukkit.getScheduler().scheduleSyncDelayedTask((Plugin) this, new Runnable() {
            public void run() {
                int count = 6;
                if(count !=0){
                    if(Bukkit.getOnlinePlayers().length == 2); {
 
 
                        Location SpawnRed = new Location(Bukkit.getWorld("World"), 1,1, 0); //TODO : Set spawn
                        Location SpawnBlue = new Location(Bukkit.getWorld("World"), 1,1, 0); //TODO : Set spawn
 
                        player1.teleport(SpawnBlue);
 
                        ItemStack HelmBlue = new ItemStack(Material.LEATHER_HELMET, 1);
                        ItemStack ChestPlateBlue = new ItemStack(Material.LEATHER_CHESTPLATE, 1);
                        ItemStack LeggingsBlue = new ItemStack(Material.LEATHER_LEGGINGS, 1);
                        ItemStack BootsBlue = new ItemStack(Material.LEATHER_BOOTS, 1);
 
                        ItemStack HelmRed = new ItemStack(Material.LEATHER_HELMET, 1);
                        ItemStack ChestPlateRed = new ItemStack(Material.LEATHER_CHESTPLATE, 1);
                        ItemStack LeggingsRed = new ItemStack(Material.LEATHER_LEGGINGS, 1);
                        ItemStack BootsRed = new ItemStack(Material.LEATHER_BOOTS, 1);
 
                        ItemStack SwordRed = new ItemStack(Material.DIAMOND_SWORD, 1);
                        ItemStack SwordBlue = new ItemStack(Material.DIAMOND_SWORD, 1);
 
                        SwordRed.getItemMeta().setDisplayName(Color.RED + "RedTeam Sword");
                        SwordBlue.getItemMeta().setDisplayName(Color.BLUE + "BlueTeam Sword");
 
 
                        PlayerInventory inv = player1.getInventory();
 
                        inv.setHelmet(HelmBlue);
                        inv.setChestplate(ChestPlateBlue);
                        inv.setLeggings(LeggingsBlue);
                        inv.setBoots(BootsBlue);
                        inv.addItem(SwordBlue);
                    }
                }
            }
        }
    }
}

This class contains the spawns and the countdown, this class will set you also in the teams.

This what I have so far, I started as a test for the scoreboard (That's why the JavaProject is called ScoreBoard), tips are welcome, and if you can explain something what is not in the classes should I appreciate that.

Thank you for reading, and sorry for my bad English.

I've to make a HashMap I know that btw.

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

HungerCraftNL Why are you using "getDescription()" in the onDisable() method? There is no countdown somewhere, correct? If you need to add a countdown then just make a repeating task that repeats itself every 20 ticks (20 ticks = 1 second) and then do countdown--;.

 

The 'GetDescription()' was just a little fould, and about the countdown:

Code:java

        int cooldown = 60;//TODO : fix
        int maxcooldown = 60;//TODO : fix
        final Player p = event.getPlayer();
        if(cooldown < maxcooldown)
        {
            p.setExp(cooldown/maxcooldown);
        }
        else
        {
            //TODO : Autoselect to teams
        }
    }

will not work?

 

HungerCraftNL Nope.

 

Any suggests, or options for a countdown?

 

HungerCraftNL take a look at scheduler programming, there's a good tutorial on the bukkit wiki.

 

I've worked on the Join listener, but I used the void 'run' and ofcourse he don't understand the 'join' anymore, so the event has changed :/ ( No event player) Can someone help, or give a tip for a new countdown?

Updated codes.

EDIT by Moderator: merged posts, please use the edit button instead of double posting.