MY first ever plugin (Uploaded to dev.bukkit!)

Discussion in 'Bukkit Discussion' started by MemeplexOwner, Feb 1, 2017.

  1. Offline

    MemeplexOwner

  2. @MemeplexOwner Few things to improve on

    1: You made a public and unused variable in "MainClass", remove it
    2. You should not call your main class "Main", "MainClass" and things like that, it should be your project name.
    3. Do you own p250.com? If not remove it from the package, it's not your domain. Use me.<username>.<project>
    4. How come you make a string to append to StringBuilder? Simply make that
    Code:java
    1. renameMessage.append(args[x]).append(" ");

    5. You use Player#getItemInHand() which is deprecated now, so if you support the latest versions you should change that to Inventory#getItemInMainHand()
     
    Last edited: Feb 8, 2017
  3. Offline

    MemeplexOwner

    I will improve on those things, so an update is coming out specifically just for the com.p250 thing.

    Apart from that, what should I work on next?
     
  4. Offline

    PhantomUnicorns

    I would add stuff like changing the lore, adding enchantments, removing enchantments! For the display name and lore you should do something in the configuration that is like:
    WaterMark:
    Ps: It's a space so it would begin with a space, so players cannot imitate a special name from a plugin! So another variation of the configuration could be:
    WaterMark:&oMan Made&r&d
    Leaving it blank would do nothing :p
     

Share This Page