Mob-Spawning Prevention Not Working

Hey everyone! So, what the code below is supposed to do is prevent hostile mobs from spawning if a value is set to false in a .yml file. However, this doesn't seem to be working at all. What did I do wrong? Thanks in advance for the help

Code:java

    @EventHandler
    public void onSpawn(CreatureSpawnEvent e){
        File worlds = new File(Main.getInstance().getDataFolder(), "worlds.yml");
        FileConfiguration c = YamlConfiguration.loadConfiguration(worlds);
 
        if (!(c.getBoolean(e.getEntity().getWorld().getName() + ".allow hostile mobs"))){
            System.out.println("false");
            if (e.getEntity() instanceof Monster){
                System.out.println("monster");
                if (e.getSpawnReason() == SpawnReason.NATURAL || e.getSpawnReason() == SpawnReason.SPAWNER_EGG || e.getSpawnReason() == SpawnReason.SPAWNER_EGG){
                    System.out.println("reason");
                    e.getEntity().remove();
                    System.out.println("[WorldManager] Prevented the spawning of a " + e.getEntity().getType());
                }
            }   
        }else{
            System.out.println("true");
        }

worlds.yml

Code:

world:
  weather: true
  allow pvp: false
  allow hostile mobs: false
  allow passive mobs: true
  allow hunger: false
  allow health regeneration: true

 

The Gaming Grunts
I will look more into this and get back to you but my initial thought without doing any research or handling spawning before is that instead of using e.getEntity().remove() use e.setCancelled(true);

 

Did you get an error? If so, can you post the stack trace?
Try adding some debug messages, with

Code:

System.out.println(the value you want to check);

 

pyropyro78
e.setCancelled() for entity spawning causes memory leaks

swampshark19
Did you not see the ones I put? None of them even displayed

 

The Gaming Grunts I would highly recommend you read through this before progressing through your code. Removing the entity will still cause the problems canceling the event does.

 

The Gaming Grunts Put the e.getEntity().remove() inside a scheduled event 1 tick later. That will run after the entity has fully spawned, and will get rid of it.

 

The Gaming Grunts
Oh wow, sorry, I didn't even look at the code. Haha.
Check if the FileConfiguration instance is being made properly, try reading another value from it and output it to the console.
Make a debug message above the first if statement, with this we can see if the event is even being called.

 

Maurdekye
The rest of the code isn't even running, so how would that even work?

 

The Gaming Grunts How are you spawning them? Look at your code for checking the SpawnReason, you check SPAWNER_EGG twice, I think the 3rd one should be something else?

 

xTigerRebornx swampshark19 Maurdekye pyropyro78
Got it figured out. There was another part of my plugin that was interfering with it. Once I removed that it started to work. Thanks for the help though

 

The Gaming Grunts It's definitely a problem with your file configuration. I suggest you either use the default config file, or use this class I created specifically for hosting multiple config files. It's basically the same as using a normal config file, but you have to assign the files you create to a variable, and use that variable to call config file methods. Like so;

Code:java

CustomConfig config1 = new CustomConfig(this, "config1.yml");
config1.getConfig().options().copyDefaults(true);
config1.saveConfig();

Edit: Nevermind, then..

 

Whoops didn't even notice that. One of them was supposed to be SPAWNER. Thanks for the catch

 

The Gaming Grunts

Your server will eventually run out of heap space leaking memory. The only safe way is to remove the mobs from getMobsFor in ChunkProviderServer (or ChunkServerProvider, forgot) before returning it.

 

xTrollxDudex
Will it? I have the boolean for hostile mob spawning set to false (prevents mobs from spawning), the time set to night, and dispencers with fast clocks running trying to spawn creepers. So far, there has been almost no increase in RAM usage. Here's the code I'm running:

Code:java

    @EventHandler
    public void onSpawn(CreatureSpawnEvent e){
        File worlds = new File(Main.getInstance().getDataFolder(), "worlds.yml");
        FileConfiguration c = YamlConfiguration.loadConfiguration(worlds);
 
        if (c.getBoolean(e.getEntity().getWorld().getName() + ".allow hostile mobs") == false){
            if (e.getEntity() instanceof Monster){
                if (e.getSpawnReason() == SpawnReason.NATURAL || e.getSpawnReason() == SpawnReason.SPAWNER || e.getSpawnReason() == SpawnReason.SPAWNER_EGG){
                    e.getEntity().remove();
                    System.out.println("[WorldManager] Prevented the spawning of a " + e.getEntity().getType());
                }
            }   
        }else{
            System.out.println("true");
        }

 

The Gaming Grunts The increase in RAM usage is when you cancel the event. Right now you're just removing the entity, which, if it's working for you, go ahead and continue using it.

 

The Gaming Grunts
You should look at your TPS.

 

xTrollxDudex
At 20tps

 

The Gaming Grunts
Well, looks like Bukkit may have fixed it. Or your observation period may have been too short.

 

xTrollxDudex
I'll try running it for longer with more spawners & dispensers going. It is entirely possible that Bukkit fixed it, but I think the garbage collection helps out a bunch