Making Iron Doors open and close without redstone

I had an idea to make it possible to open iron doors with a lever in your hand, other then having to run redstone everywhere.
Problem is, I cant get the door to open or close

Here's my player listener:

Code:java

public class listener extends PlayerListener {
		public void onPlayerInteract (PlayerInteractEvent event) {
			ItemStack held = event.getPlayer().getItemInHand();
			Action action = event.getAction();
			Block clicked = event.getClickedBlock();
			if (clicked.getType() == Material.IRON_DOOR_BLOCK) {
				Player player = event.getPlayer();
				player.sendMessage("Its an iron Door");
		    	if (action == Action.RIGHT_CLICK_BLOCK) {
		    		player.sendMessage("You right clocked it");
		    		if (held.getType() == Material.LEVER) {
		    			player.sendMessage("and your holding a lever");
		    			Door door = (Door) clicked.getState().getData();
		    			if (door.isTopHalf() == true || door.isTopHalf() ==false) {
		    				if (door.isOpen() == false) {
							player.sendMessage("Doors closed. Data is: " + door);
							door.setOpen(true);
		    				}
		    				else {
							player.sendMessage("Doors open. Data is: " + door);
							door.setOpen(false);
		    				}
		    			}
		    		}
		    	}
			}
		}
	}

Side note: Please excuse all the debug messages I added in. They all work, it runs through all the if's and sends me the data, but will not open the door :/

 

This condition:

PHP:

if (door.isTopHalf() == true || door.isTopHalf() == false) {

is pointless. It will always return true. You should start by removing it. Also, try updating the block state.

 

I threw that in there randomly while trying to get it to work to see if it would do anything (It didn't, as you know lol) Already been taken out. And okay, will give that a try thank you

Updating did not work. To make sure I did it the way you meant, here's the new playerlistener

Code:java

public class listener extends PlayerListener {
		public void onPlayerInteract (PlayerInteractEvent event) {
			Player player = event.getPlayer();
			ItemStack held = player.getItemInHand();
			Action action = event.getAction();
			Block clicked = event.getClickedBlock();
			if (clicked.getType() == Material.IRON_DOOR_BLOCK) {
				player.sendMessage("Its an iron Door");
		    	if (action == Action.RIGHT_CLICK_BLOCK) {
		    		player.sendMessage("You right clocked it");
		    		if (held.getType() == Material.LEVER) {
		    			clicked.getState();
		    			player.sendMessage("and your holding a lever");
		    			Door door = (Door) clicked.getState().getData();
		    			if (door.isOpen() == false) {
							player.sendMessage("Doors closed. Data is: " + door);
							door.setOpen(true);
							clicked.getState().update();
		    			}
		    			else {
							player.sendMessage("Doors open. Data is: " + door);
							door.setOpen(false);
		    			}
		    		}
		    	}
			}
		}
	}

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

You shouldn't get a new BlockState and update that, that does nothing. You should update the BlockState you already have (door). Do door.update().

Edit: Kidding. You'll need to save the state before getting the data. Then you change the data, then update the state.

 

How do I go about saving it? In a hashmap or arraylist or something?

 

No, just store it in a variable.

Code:

public class listener extends PlayerListener {
    public void onPlayerInteract (PlayerInteractEvent event) {
        Player player = event.getPlayer();
        ItemStack held = player.getItemInHand();
        Action action = event.getAction();
        Block clicked = event.getClickedBlock();
        if (clicked.getType() == Material.IRON_DOOR_BLOCK) {
            player.sendMessage("Its an iron Door");
            if (action == Action.RIGHT_CLICK_BLOCK) {
                player.sendMessage("You right clocked it");
                if (held.getType() == Material.LEVER) {
                    player.sendMessage("and your holding a lever");
                    BlockState state = clicked.getState();
                    Door door = (Door) state.getData();
                    if (door.isOpen() == false) {
                        player.sendMessage("Doors closed. Data is: " + door);
                        door.setOpen(true);
                    }
                    else {
                        player.sendMessage("Doors open. Data is: " + door);
                        door.setOpen(false);
                    }
                    state.update();
                }
            }
        }
    }
}

 

AH thank you Works ... kinda Opens like a split door, i.e Click top, top opens, bottom stays closed, and vice versa. I'm sure it won't be hard to also update the above or bellow block