Solved Making crafting recipes. Crafting Matrix contains Custom Named Items

So for a while now, I've been trying to get crafting with custom items to work. I've seen threads on this subject before, but they didn't meet my situation and weren't very helpful. So my crafting recipe looks like this:



All of the iron trapped doors lining the top are NOT regular trapped doors, they're custom named like this:



So CraftBukkit doesn't allow you to to include ItemMeta for recipe ingredients, so I first made a crafting recipe that includes all of the items:

Code:java

 
public void MolecularExtractorRecipe() {
 
ItemStack res = new ItemStack(Material.PISTON_BASE, 1);
 
ItemMeta resItemMeta = res.getItemMeta();
resItemMeta.setDisplayName(ChatColor.WHITE + "Molecular Extractor");
res.setItemMeta(resItemMeta);
 
ShapedRecipe resRec = new ShapedRecipe(res);
resRec.shape(
 
"###",
"@?@",
"@/@");
 
resRec.setIngredient('#', Material.IRON_TRAPDOOR);
resRec.setIngredient('@', Material.IRON_INGOT);
resRec.setIngredient('?', Material.FURNACE);
resRec.setIngredient('/', Material.WORKBENCH);
Bukkit.getServer().addRecipe(resRec);
}
 

By the way, just in case this caused confusion, the product of the recipe is named Molecular Extractor, this shouldn't affect what I'm trying to solve though.

But if I do this, I'm able to use any type of iron trapped door to craft it, no matter what the ItemMeta is, so I made another Listener class and made a PrepareItemCraftEvent, which looks like this:

Code:java

 
@EventHandler
 
public void MolecularExtractor(PrepareItemCraftEvent event) {
 
String result = ChatColor.WHITE + "Molecular Extractor";
String indFilter = ChatColor.WHITE + "Industrial Filter";
 
if (event.getRecipe().getResult().hasItemMeta() && result.equals(event.getRecipe().getResult().getItemMeta().getDisplayName())) {
for (ItemStack item : event.getInventory().getMatrix()) {
if (item != null && item.hasItemMeta()) {
if (item.getType().equals(Material.IRON_TRAPDOOR)) {
if(item.getItemMeta().getDisplayName() == indFilter){
 
found1 = true;
 
}
}
}
}
if (!found1) {
event.getInventory().setResult(null);
}
}
}
 

But when I do this, I can't craft it at all, industrial filters, regular iron trapdoors, both combined, nothing.

Please help me with this! I've been trying to squash this bug for a while now. If you have any questions, I'd be more than happy to answer them. Thanks!

 

@Bamco665
Your problem is you are comparing string using ==. That compares memory space, not the values of the string. Use == only when you need to see if the instance is the same. If all you care about is the values (like strings), use .equals

btw, after crafting it once, found will always be true. Set it to false when the event is called, or, better yet, make found a local variable.

 

Ok, I set it to this:

Code:java

 
@EventHandlerpublic void MolecularExtractor(PrepareItemCraftEvent event) {
 
boolean found1 = false;
 
String result = ChatColor.WHITE + "Molecular Extractor";
String indFilter = ChatColor.WHITE + "Industrial Filter";
 
if (event.getRecipe().getResult().hasItemMeta() && result.equals(event.getRecipe().getResult().getItemMeta().getDisplayName())) {
 
for (ItemStack item : event.getInventory().getMatrix()) {
if (item != null && item.hasItemMeta()) {
if (item.getType().equals(Material.IRON_TRAPDOOR)) {
if(item.getItemMeta().getDisplayName().equals(indFilter)){
 
found1 = true;
 
}
}
}
}
if (!found1) {
event.getInventory().setResult(null);
}
}
}
 

I can craft the item now, but now there's a new problem...

It seems that the code is only checking if at least ONE of the trapdoors are named "Industrial Filter". I want it to check if ALL of the trapdoors are custom named, because now, as long as I have one trapdoor named "Industrial Filter" out of the three, it can craft the Molecular Extractor.

 

@Bamco6657

1. Change found1 to an int. Let it be equal to 0
2. Every time a trap door withb the display name is found, add +1 to the found (or, just use "found++;")
3. If the found is equal to 3, then there are three trap doors with the display name.

 

@Zombie_Striker It works now! Thanks!