Solved Make an Inventory with a skull per player

Hey there!


Currently i'm working on a reportmenu-plugin. By rightclicking on an item, an inventory shall open with a playerskull per player. By clicking on a player, he'll be reported but this is yet to come.
So atm i've just made two classes.

In this class i define the inventory and i have some methods to use it:

Code:java

public class Inv {
 
 
    public static Inventory reportMenu;
 
    public static void createInventory() {
        double online = Bukkit.getServer().getOnlinePlayers().length;
        int felder = (int) Math.ceil(online / 9);
        reportMenu = Bukkit.createInventory(null, felder);
 
        int counter = 0;
        for (Player op : Bukkit.getServer().getOnlinePlayers()) {
            ItemStack item = makeItem(op.getName());
            reportMenu.setItem(counter, item);
            counter++;
        }
        counter = 0;
 
    }
 
    public static ItemStack makeItem(String playerName) {
        ItemStack item = new ItemStack(Material.SKULL);
        ItemMeta im = item.getItemMeta();
        im.setDisplayName(playerName);
        item.setItemMeta(im);
        return item;
    }
 
    public static void openInventory(Player player) {
        player.openInventory(reportMenu);
    }
}

And in the second one here i've just made a little command to try the inventory out:

Code:java

    public boolean onCommand(CommandSender sender, Command cmd,    String label, String[] args) {
        if (label.equalsIgnoreCase("report")) {
            if (!(sender instanceof Player)) {
                sender.sendMessage(ChatColor.RED + "This command cannot be enetered in console.");
                return true;
            }
 
            Player p = (Player) sender;
            Inv.openInventory(p);
        }
        return true;
    }

But unfortunately i get this error when perfoming the command. Ingame i just get this nice lil "internal error occured" message.

Main:53 is this:

Code:java

Inv.openInventory(p);

And Inv:39 this:

Code:java

player.openInventory(reportMenu);

So the bothes refer to an other method but i don't quite know where my mistake is at...



Thanks for your help :3

 

Just to be sure, is there a line 185 by any chance?

 

No, the longest class (the one with the command) is 60 lines long. HeadGam3z

 

Where are you getting "Inv" from on line 53/9? Only place where I see that is the class name, but then again, I am on my phone lol

 

openInventory() is a method in the class called Inv, and it's static. HeadGam3z

 

Robin Bi
Make an object called ReportMenu and inside that have an open function where it fetches the inventory and such. I would not recommend using static calls like this.
An example:

Code:java

ReportMenu menu = new ReportMenu(plugin);
menu.open(player);

 

MCForger Well, i appreciate your advice, but it hasn't solved my problem.... Any ideas left?

 

Robin Bi
Do you ever call the createInventory function??

 

The one problem I notice with this Is in the way Java does math, in your felder variable specifically. Try ciel ((double) online/9.0) for the correct result, because right now it can be zero if its less than 9 players online.

 

mythbusterma It should never be 0 because it ceils the value and doesn't floor it, should it?

MCForger Yes, i didn't, nice point ^^

I've now made this in my Inv-class:

Code:java

public class Inv {
 
 
    public Inventory reportMenu;
 
    public void createInventory() {
        int felder = calcPlayers();
        reportMenu = Bukkit.createInventory(null, felder);
 
        int counter = 0;
        for (Player op : Bukkit.getServer().getOnlinePlayers()) {
            ItemStack item = makeItem(op.getName());
            reportMenu.setItem(counter, item);
            counter++;
        }
        counter = 0;
 
    }
 
    public ItemStack makeItem(String playerName) {
        ItemStack item = new ItemStack(Material.SKULL);
        ItemMeta im = item.getItemMeta();
        im.setDisplayName(playerName);
        item.setItemMeta(im);
        return item;
    }
 
    public void openInventory(Player player) {
        player.openInventory(reportMenu);
    }
 
    public int calcPlayers() {
        double online = Bukkit.getServer().getOnlinePlayers().length;
        int felder = (int) (Math.ceil(online / 9) * 9);
 
        if (felder < 9) felder = 9;
        return felder;
    }
}

So i've added something to prevent the inventory to be less than 9, as you said, mythbusterma.



Thanks quite a bunch!

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

Due to the way Java does math, an integer divided by an integer will give you a rounded (or floored maybe?) Integer. So lets say online players is 4, 4/9 is less than .5 and as such will evaluate to 0, which in your code, is then cast to a double, and then ceilinged, ceil (0) is still 0.

TL;DR change to ciel((double)online / 9.0)