Solved Login/Logout messages

Hello, I was trying to make a plugin in which I could customize Login/logout messages. This is what I tried:

Code:java

    @EventHandler
    public void onPlayerJoin(PlayerJoinEvent event){
        Player player = event.getPlayer();
        event.setJoinMessage(getConfig().getString("OnJoin").replace("%p", player.getName()).replace("&", "§"));
    }
 
    @EventHandler
    public void onPlayerQuit(PlayerQuitEvent event){
        Player player = event.getPlayer();
        event.setQuitMessage(getConfig().getString("OnLeave").replace("%p", player.getName()).replace("&", "§"));
    }

For some reason, it isn't working. How can I make this work? Also, how can I make this replace the yellow "<name> Joined/left the game!" Messages? Thanks for the help

 

Add to your mainclass onEnable:

getServer().getPluginManager().registerEvents(new JOIN/QUIT_CLASSNAME(), this);

 

random_username
Did you register the event?

EDIT: Ninja'd by TheEyeMonster

 

what do you mean with register? Sorry, Im really new to plugin development.

 

Ninja. xD

 

You need to go into your onEnable() and add this line of code
Well if your event is in the same class do this

Code:java

 
getServer().getPluginManager().registerEvents(this, this);
 

If your event is in a separate class do this

Code:java

 
getServer().getPluginManager().registerEvents(new EventClass(), this);
 

 

So it would be like this?

Code:java

 @Override
public void onDisable() {
PluginDescriptionFile pdfFile = this.getDescription();
this.logger.info(pdfFile.getName() + " Version " + pdfFile.getVersion() + " Has been Disabled.");
}
 
@Override
public void onEnable() {
PluginDescriptionFile pdfFile = this.getDescription();
getServer().getPluginManager().registerEvents((Listener) this, this);
this.logger.info(pdfFile.getName() + " Version " + pdfFile.getVersion() + " Has been Enabled.");
getConfig().options().copyDefaults(true);
this.saveDefaultConfig();
}
 
@EventHandler
public void onPlayerJoin(PlayerJoinEvent event){
Player player = event.getPlayer();
event.setJoinMessage(getConfig().getString("OnJoin").replace("%p", player.getName()).replace("&", "§"));
}
 
@EventHandler
public void onPlayerQuit(PlayerQuitEvent event){
Player player = event.getPlayer();
event.setQuitMessage(getConfig().getString("OnLeave").replace("%p", player.getName()).replace("&", "§"));
}

 

random_username
Oh and to fix your problem with the replacement thing, do this

Code:java

 
event.setJoinMessage(getConfig().getString("OnJoin").replaceAll("%p", player.getName()).replaceAll("&", "\u00A7");
 

The first replaceAll() will replace %p with the player's name and the second replaceAll() will replace all color codes.

 

My main class looks like this:

Code:

package com.yourname.plugin;
 
import java.util.logging.Logger;
 
import org.bukkit.plugin.java.JavaPlugin;
 
public final class Main extends JavaPlugin {
    public final Logger logger = Logger.getLogger("Minecraft");
    public static Main plugin;
   
    @Override
    public void onEnable() {
    getLogger().info("Has been enabled! Developed by TheEyeMonster!");
    getServer().getPluginManager().registerEvents(new EVENT CLASSNAME HERE(), this);
    }
    @Override
    public void onDisable() {
        getLogger().info("Has been disabled! Developed by TheEyeMonster!");
    }
 
}

 

random_username
Try it, if it gives an error post it here. I haven't worked with events for a very long time.

TheEyeMonster
He has his events in his main class, so the way you did it wont work for him.

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

Okay, I tried:

Code:java

    @Override
    public void onDisable() {
        PluginDescriptionFile pdfFile = this.getDescription();
        this.logger.info(pdfFile.getName() + " Version " + pdfFile.getVersion() + " Has been Disabled.");
    }
 
    @Override
    public void onEnable() {
        PluginDescriptionFile pdfFile = this.getDescription();
        getServer().getPluginManager().registerEvents((Listener) this, this);
        this.logger.info(pdfFile.getName() + " Version " + pdfFile.getVersion() + " Has been Enabled.");
        getConfig().options().copyDefaults(true);       
        this.saveDefaultConfig();
    }
 
    @EventHandler
    public void onPlayerJoin(PlayerJoinEvent event){
        Player player = event.getPlayer();
        event.setJoinMessage(getConfig().getString("OnJoin").replace("%p", player.getName()).replace("&", "§"));
    }
 
    @EventHandler
    public void onPlayerQuit(PlayerQuitEvent event){
        Player player = event.getPlayer();
        event.setQuitMessage(getConfig().getString("OnLeave").replace("%p", player.getName()).replace("&", "§"));
    }

And now I am getting this error on the console:

Code:

java.lang.ClassCastException: me.Kait18.EnstopiaCore.EnstopiaCore cannot be cast
to org.bukkit.event.Listener
        at me.Kait18.EnstopiaCore.EnstopiaCore.onEnable(EnstopiaCore.java:31)
        at org.bukkit.plugin.java.JavaPlugin.setEnabled(JavaPlugin.java:217)
        at org.bukkit.plugin.java.JavaPluginLoader.enablePlugin(JavaPluginLoader
.java:457)
        at org.bukkit.plugin.SimplePluginManager.enablePlugin(SimplePluginManage
r.java:382)
        at org.bukkit.craftbukkit.v1_6_R3.CraftServer.loadPlugin(CraftServer.jav
a:286)
        at org.bukkit.craftbukkit.v1_6_R3.CraftServer.enablePlugins(CraftServer.
java:268)
        at net.minecraft.server.v1_6_R3.MinecraftServer.l(MinecraftServer.java:3
21)
        at net.minecraft.server.v1_6_R3.MinecraftServer.f(MinecraftServer.java:2
98)
        at net.minecraft.server.v1_6_R3.MinecraftServer.a(MinecraftServer.java:2
58)
        at net.minecraft.server.v1_6_R3.DedicatedServer.init(DedicatedServer.jav
a:165)
        at net.minecraft.server.v1_6_R3.MinecraftServer.run(MinecraftServer.java
:399)
        at net.minecraft.server.v1_6_R3.ThreadServerApplication.run(SourceFile:5
83)
15:56:51 [INFORMACI╙N] [GroupManager] Enabling GroupManager v2.0 (2.11.1) (Phoen
ix)

How can I fix this?

 

random_username
On line 31 of your Main class, there's an error (probably the code I gave you xD). (in your onEnable() method).

 

yup, it is that line, what can i do to fix it?

 

random_username
try replacing that line with this

Code:java

 
Bukkit.getServer().getPluginManager().registerEvents(this, this);
 

 

You should only use replaceAll() if you're using regular expressions. Otherwise just use replace().

 

nisovin
Why? Whenever I do replace() and I have more than one variable that needs to be replaced, it never works. replaceAll() always works for me. Or I should say used to. I've taken a much more advanced route lately.

 

should I let the plugin implement listener or cast it to listener? (thats what eclipse says, as there is an error in "registerEvents")

 

The replace() method works fine. Using replaceAll() will do a regex replace, which can be slower and is unnecessary when you just need a simple text replacement.

If your plugin class is also your listener, then it should implement Listener, yes.

 

@nisovin
@MrSparkzz
Thanks so much, its working now!