Is it possible to get auto-approval?

Discussion in 'BukkitDev Information and Feedback' started by Hubarz, May 18, 2012.

Thread Status:
Not open for further replies.
  1. Offline

    Hubarz

    Hi,
    every single file I submit needs an approval.
    It nerves because this takes many hours.
    So is there a way to skip it?

    LG
     
  2. Offline

    TnT Retired Staff

    No, we check over every file for malicious code. No way to avoid this at this time.
     
  3. Offline

    Hubarz

    Means that you decompile every plugin?
     
  4. Offline

    Gravity Retired Staff

    Yes. We decompile and manually review every file so that users of BukkitDev know they are downloading a safe file.
     
  5. Offline

    Jozeth

    Wow, imagine checking Essentials... Or a big plugin with lots of .class files...
     
  6. Offline

    Gravity Retired Staff

    Gotta love small plugins ;)
     
    McLuke500, limdingwen and Jozeth like this.
  7. Offline

    mze9412

    Then I wonder how my MM fork get's approved at all ;) Or do you just look for specific suspicious code?
     
  8. Offline

    Gravity Retired Staff

    Being mostly all plugin developers ourselves, we can typically pick out code from the project that could be problematic, but that doesn't mean we don't still review the entire file.
     
  9. Offline

    mze9412

    Nice, I like that! I didn't know such in depth reviews are done and I really appreciate the extra layer of security it brings for server admins and users! :)
     
    McLuke500 and h31ix like this.
  10. Offline

    theguynextdoor

    I think if i had to do that, i would be tempted to change a lot to fit my coding style ... I'm not a fan of reading other peoples code if it's different to how i would do it.
     
  11. Offline

    Orcem12

    Wouldn't it be easier to include the source? I'd imagine how much more easy that would be for you guys... I'll start doing this haha.

    EDIT: O wait, I could just fudge the source... Never mind.
     
  12. Offline

    pyraetos

    It's fun; you can really tell when someone is used to C# or C++ when we review files.

    Orcem12 No, since decompilers are fast!
     
  13. Offline

    Orcem12

    @pyraetos
    Right. I'm assuming the right to 'decompiler for staff' is included in that huge disclaimer I didn't read, haha.

    @theguynextdoor
    Coding is an art, and like most art, it's hard to understand unless you carefully examine it. I guarantee you if you really know what you are looking at you can start to make connections between yours and your targets code.
     
  14. Offline

    pyraetos

    Whatever you say! *inconspicuously hides standard-edition decompiler from Google*
     
  15. Offline

    Orcem12

    Haha, guess no one reads it xD; Hey, I mean if it's to keep me and my users safe I'm all for it!

    @Hubarz
    We all have to go through this system, especially if you unleash plugins constantly. Auto Approval defeats the whole purpose of Bukkit.dev. Bukkit.dev was opened for 3 reasons; to keep users safe from malicious plugins, to provide developers the easiest and most efficient way to handle their projects, and finally to provide a comprehensive system of informing about, reporting, fixing and patching plugins. Lets face it the old system was terrible. I've been here for nearly a year and I still remember how sketch it was to download a plugin from a developer that I just had to assume was good.
    The Bukkit team made one of their best decisions opening Bukkit.dev. Ever. Period.

    EDIT by Moderator: merged posts, please use the edit button instead of double posting.
     
    Last edited by a moderator: May 25, 2016
    pyraetos likes this.
  16. Offline

    mze9412

    Like me for example ;) My Java code at the moment is so strange because I have to use C#.Net at work all the time.


    Thanks to the Bukkit Dev staff for all their work!
     
Thread Status:
Not open for further replies.

Share This Page