Solved Inventory not opening

the_merciless
Command works but not right clicking custom book.

the_merciless
This error pops up

Code:

2013-11-21 17:01:08 [SEVERE] Could not pass event PlayerInteractEvent to CustomInv v1.0
org.bukkit.event.EventException
    at org.bukkit.plugin.java.JavaPluginLoader$1.execute(JavaPluginLoader.java:427)
    at org.bukkit.plugin.RegisteredListener.callEvent(RegisteredListener.java:62)
    at org.bukkit.plugin.SimplePluginManager.fireEvent(SimplePluginManager.java:477)
    at org.bukkit.plugin.SimplePluginManager.callEvent(SimplePluginManager.java:462)
    at org.bukkit.craftbukkit.v1_6_R3.event.CraftEventFactory.callPlayerInteractEvent(CraftEventFactory.java:190)
    at org.bukkit.craftbukkit.v1_6_R3.event.CraftEventFactory.callPlayerInteractEvent(CraftEventFactory.java:160)
    at net.minecraft.server.v1_6_R3.PlayerConnection.a(PlayerConnection.java:1008)
    at net.minecraft.server.v1_6_R3.Packet18ArmAnimation.handle(SourceFile:41)
    at net.minecraft.server.v1_6_R3.NetworkManager.b(NetworkManager.java:296)
    at net.minecraft.server.v1_6_R3.PlayerConnection.e(PlayerConnection.java:116)
    at net.minecraft.server.v1_6_R3.ServerConnection.b(SourceFile:37)
    at net.minecraft.server.v1_6_R3.DedicatedServerConnection.b(SourceFile:30)
    at net.minecraft.server.v1_6_R3.MinecraftServer.t(MinecraftServer.java:592)
    at net.minecraft.server.v1_6_R3.DedicatedServer.t(DedicatedServer.java:227)
    at net.minecraft.server.v1_6_R3.MinecraftServer.s(MinecraftServer.java:488)
    at net.minecraft.server.v1_6_R3.MinecraftServer.run(MinecraftServer.java:421)
    at net.minecraft.server.v1_6_R3.ThreadServerApplication.run(SourceFile:583)
Caused by: java.lang.NullPointerException
    at me.pieman.custominventory.CustomInventory.onPlayerInteract(CustomInventory.java:112)
    at sun.reflect.GeneratedMethodAccessor5.invoke(Unknown Source)
    at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source)
    at java.lang.reflect.Method.invoke(Unknown Source)
    at org.bukkit.plugin.java.JavaPluginLoader$1.execute(JavaPluginLoader.java:425)
    ... 16 more

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

Caused by: java.lang.NullPointerException
at me.pieman.custominventory.CustomInventory.onPlayerInteract(CustomInventory.java:112)

What do you have on line 112?

Are you trying to open the inventory if the player is holding the book and clicking?

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

I replaced

Code:java

if (e.getClickedBlock().hasMetadata("Worlds")) return;

to

Code:java

if (!(e.getClickedBlock().hasMetadata(ChatColor.BLUE + "" + ChatColor.BOLD + "Worlds")))

There is no error but it still does not work.

 

show me your whole interact event

 

Code:java

@EventHandler
    public void onPlayerInteract(PlayerInteractEvent e) {
        if (!(e.getAction() == Action.LEFT_CLICK_AIR)
                && !(e.getAction() == Action.LEFT_CLICK_BLOCK))
            return;
        if (!(e.getClickedBlock().hasMetadata(ChatColor.BLUE + "" + ChatColor.BOLD + "Worlds")))
            return;
        if (e.getClickedBlock().hasMetadata("Worlds")) {
            openCustomInventory(e.getPlayer());
        }
    }

 

the_merciless
Yes

 

Code:

    @EventHandler
    public void onPlayerInteract(PlayerInteractEvent e) {
       
        if (e.getAction() == Action.RIGHT_CLICK_AIR){
            if (e.getPlayer().getItemInHand().getItemMeta().getDisplayName().equalsIgnoreCase("Worlds")){
                openCustomInventory(e.getPlayer());
            }
        }   
    }

 

the_merciless
Ok so I have this but it still does not work.

Code:java

@EventHandler
    public void onPlayerInteract(PlayerInteractEvent e) {
        if(e.getPlayer().getItemInHand() == null) return;
        if(e.getPlayer().getItemInHand() != new ItemStack(Material.ENCHANTED_BOOK)) return;
        if(e.getAction() == Action.RIGHT_CLICK_AIR && e.getAction() == Action.RIGHT_CLICK_BLOCK){
            if(e.getPlayer().getItemInHand().getItemMeta().getDisplayName().equalsIgnoreCase("World Teleporter")){
                openCustomInventory(e.getPlayer());
            }
        }
    }

 

PieMan456 You are cancelling out of the event when the player right clicks

Code:java

@EventHandler
public void onPlayerInteract(PlayerInteractEvent e) {
if (!(e.getAction() == Action.LEFT_CLICK_AIR)
&& !(e.getAction() == Action.LEFT_CLICK_BLOCK))
return;

If you want to make it right-click only it should be like this

Code:java

@EventHandler
public void onPlayerInteract(PlayerInteractEvent e) {
if (e.getAction() == Action.LEFT_CLICK_AIR || e.getAction() == Action.LEFT_CLICK_BLOCK)
return;

EDIT: Now you are checking to see the the player is right clicking air and a block. replace the && with || in the check

 

JRL1004
This is what I have will this work?

Code:java

@EventHandler
    public void onPlayerInteract(PlayerInteractEvent e) {
        if(e.getPlayer().getItemInHand() == null) return;
        if(e.getPlayer().getItemInHand() != new ItemStack(Material.ENCHANTED_BOOK)) return;
        if(e.getAction() == Action.RIGHT_CLICK_AIR || e.getAction() == Action.RIGHT_CLICK_BLOCK){
            if(e.getPlayer().getItemInHand().getItemMeta().getDisplayName().equalsIgnoreCase("World Teleporter")){
                openCustomInventory(e.getPlayer());
            }
        }
    }

 

PieMan456 That should work assuming the player is holding an enchanted book named "World Teleporter" but keep in mind that if you anvil the object the name becomes italicized and it may not work

 

JRL1004
Does it matter if the DisplayName is blue and bold or do I have to put that in so it recongnizes it because it will not work.

Edit: I tried it putting in the bold and blue and it still does not work.

 

PieMan456 The DisplayName is very sensitive. If you plan to have the item using a colored name you will have to use the colored name (as a string) in the method. For example if the item were Purple_Pickaxe, you would have to check for "§5Purple_Pickaxe" since § plus another character creates a color.

 

JRL1004
Can I use the ChatColor.Blue thing or does that nor work?

 

PieMan456 I have not tried to use ChatColor in names so I could not tell you that. Maybe the_merciless knows.

 

JRL1004
When I try and put the weird thing in it comes up red

 

PieMan456 The weird thing? I assume you are referring to the "§" and that you mean the you are most likely not using it in the name of the item as a string. The § symbol is not different from any other (for the most part) and should be treated as all other symbols (like a, b, c, etc...) in a string.

 

JRL1004
It still does not work. What am I doing wrong?
Whole Class:

Code:java

package me.pieman.custominventory;
 
import java.util.ArrayList;
 
import org.bukkit.Bukkit;
import org.bukkit.ChatColor;
import org.bukkit.Location;
import org.bukkit.Material;
import org.bukkit.command.Command;
import org.bukkit.command.CommandSender;
import org.bukkit.entity.Player;
import org.bukkit.event.EventHandler;
import org.bukkit.event.Listener;
import org.bukkit.event.block.Action;
import org.bukkit.event.inventory.InventoryClickEvent;
import org.bukkit.event.player.PlayerInteractEvent;
import org.bukkit.event.player.PlayerJoinEvent;
import org.bukkit.inventory.Inventory;
import org.bukkit.inventory.ItemStack;
import org.bukkit.inventory.meta.ItemMeta;
import org.bukkit.plugin.java.JavaPlugin;
 
public class CustomInventory extends JavaPlugin implements Listener {
    public void onEnable() {
        Bukkit.getServer().getPluginManager().registerEvents(this, this);
        Bukkit.getServer().getPluginManager().registerEvents(this, this);
        Bukkit.getServer().getPluginManager().registerEvents(this, this);
    }
 
    public void onDisable() {
 
    }
 
    @SuppressWarnings("deprecation")
    public void openCustomInventory(Player p) {
        Inventory CustomInv = Bukkit.createInventory(null, 9, "Worlds");
 
        ItemStack pvp = new ItemStack(Material.DIAMOND_SWORD);
        ItemMeta pvpMeta = pvp.getItemMeta();
        ArrayList<String> pworld = new ArrayList<String>();
        pvpMeta.setDisplayName(ChatColor.GREEN + "" + ChatColor.BOLD
                + "PVPArena World");
        pworld.add(ChatColor.DARK_PURPLE
                + "Click this to teleport to the PVPArena World!");
        pvpMeta.setLore(pworld);
        pvp.setItemMeta(pvpMeta);
 
        ItemStack survival = new ItemStack(Material.GRASS);
        ItemMeta survivalMeta = survival.getItemMeta();
        ArrayList<String> sworld = new ArrayList<String>();
        survivalMeta.setDisplayName(ChatColor.GREEN + "" + ChatColor.BOLD
                + "Survival World");
        sworld.add(ChatColor.DARK_PURPLE
                + "Click this to teleport to the Survival World!");
        survivalMeta.setLore(sworld);
        survival.setItemMeta(survivalMeta);
 
        ItemStack mg = new ItemStack(Material.REDSTONE_BLOCK);
        ItemMeta mgMeta = mg.getItemMeta();
        ArrayList<String> mgworld = new ArrayList<String>();
        mgMeta.setDisplayName(ChatColor.GREEN + "" + ChatColor.BOLD
                + "Minigame World");
        mgworld.add(ChatColor.DARK_PURPLE
                + "Click this to teleport to the Minigame World!");
        mgMeta.setLore(mgworld);
        mg.setItemMeta(mgMeta);
 
        CustomInv.clear();
        CustomInv.setItem(1, new ItemStack(pvp));
        CustomInv.setItem(4, new ItemStack(mg));
        CustomInv.setItem(7, new ItemStack(survival));
 
        p.openInventory(CustomInv);
 
        p.updateInventory();
    }
 
    public boolean onCommand(CommandSender sender, Command cmd, String label, String[] args){
        if(!(sender instanceof Player)) return true;
        Player p = (Player) sender;
        if(label.equalsIgnoreCase("worldtp")){
            if(p.hasPermission("ci.open")){
                openCustomInventory(p);
            }
        }
 
        return true;
    }
 
    @EventHandler
    public void onPlayerJoin(PlayerJoinEvent e) {
        ItemStack book = new ItemStack(Material.ENCHANTED_BOOK);
        ItemMeta bookMeta = book.getItemMeta();
        ArrayList<String> book1 = new ArrayList<String>();
        book1.add(ChatColor.RED + "Click this to open the world teleporter!");
        bookMeta.setLore(book1);
        bookMeta.setDisplayName("§1" + "§l" + "World Teleporter");
        book.setItemMeta(bookMeta);
        if (e.getPlayer().getInventory().firstEmpty() == -1) {
            return;
        } else {
            Player p = (Player) e.getPlayer();
            p.getInventory().setItem(8, new ItemStack(book));
        }
    }
 
    @EventHandler
    public void onPlayerInteract(PlayerInteractEvent e) {
        if(e.getPlayer().getItemInHand() == null) return;
        if(e.getPlayer().getItemInHand() != new ItemStack(Material.ENCHANTED_BOOK)) return;
        if(e.getAction() == Action.RIGHT_CLICK_AIR || e.getAction() == Action.RIGHT_CLICK_BLOCK){
            if(e.getPlayer().getItemInHand().getItemMeta().getDisplayName().equalsIgnoreCase("§1" + "§l" + "World Teleporter")){
                openCustomInventory(e.getPlayer());
            }
        }
    }
 
    @EventHandler
    public void onInventoryClick(InventoryClickEvent e) {
        if (!(e.getInventory().getName().equalsIgnoreCase("World Teleporter")))
            return;
        if (e.getCurrentItem().getItemMeta().getDisplayName()
                .contains("PVPArena World")) {
            e.setCancelled(true);
            e.getWhoClicked().teleport(
                    new Location(Bukkit.getWorld("world"), 49, 88, -206));
        }
        if (e.getCurrentItem().getItemMeta().getDisplayName()
                .contains("Survival World")) {
            e.setCancelled(true);
            e.getWhoClicked().teleport(
                    new Location(Bukkit.getWorld("Hub"), 0, 66, 0));
        }
        if (e.getCurrentItem().getItemMeta().getDisplayName()
                .contains("Minigame World")) {
            e.setCancelled(true);
            e.getWhoClicked().teleport(
                    new Location(Bukkit.getWorld("minigames"), -0.5, 66, -6.5));
        }
    }
}
 

 

PieMan456 You are making an inventory with the name of "Worlds" and checking if it's name matches "World Teleporter"

 

JRL1004
Yeah I fixed that but it still does not open.

 

PieMan456 Give me a moment while I start Eclipse since reading the code:java boxes is a pain. I'll edit this in a moment.

Edit here is your class after I cut it down to the base problem and how I went about doing it:

Code:java

public class CustomInventory extends JavaPlugin implements Listener {
    String title = "World Teleporter";
    Inventory CustomInv = Bukkit.createInventory(null, 9, title);
 
    // Defined the inventory and its name early //
 
    public void onEnable() {
    Bukkit.getServer().getPluginManager().registerEvents(this, this);
    // Removed unnecessary registerEvents //
    }
 
    public void openCustomInventory(Player p) {
    CustomInv = Bukkit.createInventory(null, 9, "Worlds");
    // Cropped method down to just remaking the inventory //
    }
 
    // Removed onCommand as it was not the problem //
 
    // Removed PlayerJoinEvent as it was not the problem //
 
    // Removed PlayerInteractEvent as it was not the problem //
 
    @EventHandler
    public void onInventoryClick(InventoryClickEvent e) {
    if (!(e.getInventory().getName().equalsIgnoreCase(CustomInv.getName())))
        return;
    // Changed check so it does not have to have a string input but instead
    // will call the inventory //
    }
}
 

This is just barebones. I am not by any means asking you to delete your entire class

 

JRL1004
The command works fine but the book does not open at all.

 

PieMan456 I wasn't aware of the book issue. I'll go and look into that as well. I also posted a few changes (some may not be needed) that could help you as an edit to my last post.

PieMan456 Okay, I've gone through your inventory method and I couldn't fine much that would cause a problem. Here is what I have done to (I forgot what I changed so I can't explain the edits):

Code:java

 
@EventHandler
public void onPlayerInteract(PlayerInteractEvent e) {
Player p = e.getPlayer();
if(p.getItemInHand() == null) return;
if(p.getItemInHand() != new ItemStack(Material.ENCHANTED_BOOK)) return;
if(e.getAction() == Action.RIGHT_CLICK_AIR || e.getAction() == Action.RIGHT_CLICK_BLOCK){
if(p.getItemInHand().getItemMeta().getDisplayName().equalsIgnoreCase("§1§lWorld Teleporter")){
// Player right clicked with an Enchanted Book called "World Teleporter" (the name will be bold and blue)
// Do stuff
}
}
}

EDIT: I'm was being an idiot and tahg'd myself, whoops

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

JRL1004
Well it still does not work. Man what the heck do I need to do?

 

PieMan456 Backtrack trough the code. If the code wants an enchanted book, you have to make sure that is what you are holding. If the book is named (with or without colors) you need to make sure the names match exactly. I would recommend adding a few debug lines to tell you what is or is not calling then removing or commenting them out once you have isolated the issue.

 

JRL1004
Ok so I have this:

Code:java

@EventHandler
    public void onPlayerInteract(PlayerInteractEvent e) {
        Player p = e.getPlayer();
        if(p.getItemInHand() == null) return;
        System.out.println("Works");
        if(p.getItemInHand() != new ItemStack(Material.ENCHANTED_BOOK)) return;
        System.out.println("Working");
        if(e.getAction() == Action.RIGHT_CLICK_AIR || e.getAction() == Action.RIGHT_CLICK_BLOCK){
            System.out.println("Still Working");
            if(p.getItemInHand().getItemMeta().getDisplayName().equalsIgnoreCase("§1§lWorld Teleporter")){
                System.out.println("Works!");
                openCustomInventory(e.getPlayer());
            }
        }
    }

And in the console it prints out "Works" 3 times which is weird.

 

PieMan456 If it works all three times that means your openCustomInventory method is the issue. Also, I would change this: if(p.getItemInHand()!=new ItemStack(Material.ENCHANTED_BOOK))return;
to be this: if(p.getItemInHand().getType()!=Material.ENCHANTED_BOOK)return; so that it supports stacks of enchant books.

 

JRL1004
No. It prints out the first Works 3 times. Not the first 3. Just Works 3 times.

 

PieMan456 That would be because you are registering the event three times so your going to get three times the output...