if statement is not working 100% correct.

Hi Bukkit,
I've found a glitch in my code, but I can't find out whats making it glitching :l This is what I've:

Code:java

if (kitManager.getPlayerKit(pl) != null) {
                        if (!canChange.contains(name)) {
                            pl.sendMessage(prefix + "§cYou already choose a kit! Click again to change.");
                            canChange.add(name);
 
                            Bukkit.getServer().getScheduler().scheduleSyncDelayedTask(plugin,
                                new Runnable() {
 
                                    @Override
                                    public void run() {
                                        if (canChange.contains(name)) {
                                            canChange.remove(name);
                                        }
                                    }
                            }, 80L);
                            return;
                        }
 
                        canChange.remove(name);
                        kitManager.getPlayerKit().remove(name);
                        pl.sendMessage(prefix + "§aYou can select a new kit again!");
                        return;
                    }
 
                    pl.sendMessage(prefix + "§aYou have selected §2" + line[1] + "§a.");

And this is the output if you click like a retard on the kit sign:
https://www.dropbox.com/s/uv88fhrpzlj2ncl/Schermafdruk 2014-11-04 17.04.42.png?dl=0

And before people are telling me that I've waited 4 seconds before I clicked again, No I didn't! So does anyone know how to solve this?

Thnx!

 

bennie3211
What is the problem?
Like, what was supposed to happen?

Secondly, post full code.

 

bennie3211 I saw you are dutch . (me too). I saw some spelling faults but okay.
and now ON Topic.
please send us the code of the Bukkit Runnable of the Delay thingy

 

Funergy haha yup
On topic:

This is the class that contains the interactevent:

Code:java

package sign;
 
import java.util.ArrayList;
 
import kit.Kit;
import kit.KitManager;
import kitpvp.KitPvP;
 
import org.bukkit.Bukkit;
import org.bukkit.ChatColor;
import org.bukkit.Effect;
import org.bukkit.Location;
import org.bukkit.Material;
import org.bukkit.block.Sign;
import org.bukkit.entity.Player;
import org.bukkit.event.EventHandler;
import org.bukkit.event.Listener;
import org.bukkit.event.block.Action;
import org.bukkit.event.player.PlayerInteractEvent;
 
 
public class SignManager implements Listener {
 
public KitPvP plugin;
public KitManager kitManager = new KitManager(plugin);
private ArrayList<String> canChange = new ArrayList<String>();
 
private String prefix = "§a[§1KitPvP+§a]§f ";
 
public SignManager(KitPvP plugin) {
this.plugin = plugin;
}
 
@EventHandler
public void clickSign(PlayerInteractEvent event) {
 
Player pl = event.getPlayer();
final String name = pl.getName();
 
if ((!event.getAction().equals(Action.RIGHT_CLICK_BLOCK)) || (!event.getAction().equals(Action.LEFT_CLICK_BLOCK))) {
 
if (event.getClickedBlock() != null) {
 
if (event.getClickedBlock().getState() instanceof Sign) {
 
Location loc = event.getClickedBlock().getLocation();
Sign sign = (Sign) event.getClickedBlock().getState();
String[] line = sign.getLines();
 
if (!ChatColor.stripColor(line[0]).equalsIgnoreCase("[KitPvP]"))
return;
 
if (kitManager.getKitByName(ChatColor.stripColor(line[1])) == null) {
pl.playEffect(loc, Effect.STEP_SOUND, Material.REDSTONE_BLOCK);
pl.sendMessage(prefix + "§cKit §4" + line[1] + "§c doesn't exists!");
return;
}
 
Kit k = kitManager.getKitByName(ChatColor.stripColor(line[1]));
 
if (!pl.isOp() || !pl.hasPermission(k.getPermission()) || !pl.hasPermission("kitpvp.kit.*")) {
pl.sendMessage(prefix + "§cYou don't have the permission for this kit!");
return;
}
 
 
if (kitManager.getPlayerKit(pl) != null) {
if (!canChange.contains(name)) {
pl.sendMessage(prefix + "§cYou already choose a kit! Click again to change.");
canChange.add(name);
 
Bukkit.getServer().getScheduler().scheduleSyncDelayedTask(plugin,
new Runnable() {
 
@Override
public void run() {
if (canChange.contains(name)) {
canChange.remove(name);
}
}
}, 80L);
return;
}
 
canChange.remove(name);
kitManager.getPlayerKit().remove(name);
pl.sendMessage(prefix + "§aYou can select a new kit again!");
return;
}
 
pl.sendMessage(prefix + "§aYou have selected §2" + line[1] + "§a.");
loc.getWorld().playEffect(loc, Effect.STEP_SOUND, Material.EMERALD_BLOCK);
 
kitManager.giveKit(pl, k);
kitManager.getPlayerKit().put(name, k);
}
}
}
}
}
 

And here is the KitManager class:

Code:java

package kit;
 
import java.util.ArrayList;
import java.util.HashMap;
 
import org.bukkit.ChatColor;
import org.bukkit.Color;
import org.bukkit.Material;
import org.bukkit.configuration.file.FileConfiguration;
import org.bukkit.enchantments.Enchantment;
import org.bukkit.entity.Player;
import org.bukkit.inventory.ItemStack;
import org.bukkit.inventory.meta.ItemMeta;
import org.bukkit.inventory.meta.LeatherArmorMeta;
import org.bukkit.plugin.Plugin;
import org.bukkit.potion.PotionEffect;
import org.bukkit.potion.PotionEffectType;
 
public class KitManager {
 
public KitManager(KitPvP plugin) {
this.plugin = plugin;
}
 
public KitPvP plugin;
 
private static ArrayList<Kit> kits = new ArrayList<Kit>();
public HashMap<String, Kit> playerKit = new HashMap<String, Kit>();
 
public ArrayList<Kit> getKit() {
return kits;
}
 
public HashMap<String, Kit> getPlayerKit() {
return this.playerKit;
}
 
public void addKit(Kit k) {
kits.add(k);
}
 
public Kit getKitByName(String name) {
for (Kit k : kits) {
if (k.getName().equalsIgnoreCase(name)) {
return k;
}
}
return null;
}
 
public Kit getPlayerKit(Player pl) {
if (playerKit.containsKey(pl.getName())) {
return playerKit.get(pl.getName());
}
return null;
}
 
@SuppressWarnings("deprecation")
public void giveKit(Player pl, Kit kit) {
if (kit == null)
return;
 
for (ItemStack i : kit.getItems()) {
pl.getInventory().addItem(i);
}
 
for (String potion : kit.getPotions()) {
 
if (!isNumber(potion.split("\\.")[1]))
continue;
 
PotionEffectType type = getPotion(potion);
 
pl.addPotionEffect(new PotionEffect(type, Integer.MAX_VALUE, Integer.parseInt(potion.split("\\.")[1])));
}
 
for (ItemStack i : kit.getArmor()) {
 
if (isHelmet(i.getType()))
pl.getInventory().setHelmet(i);
 
if (isChestplate(i.getType()))
pl.getInventory().setChestplate(i);
 
if (isLegging(i.getType()))
pl.getInventory().setLeggings(i);
 
if (isBoots(i.getType()))
pl.getInventory().setBoots(i);
}
 
pl.updateInventory();
}
}

Everything works correctly on the part inside the PlayerInteractEvent isn't working correctly :l

EDIT:

If I remove the BukkitRunnable from the PlayerInteractEvent, the glitch is gone! Can someone explain me why?

 

Here:

1. Code:Java

   if ((!event.getAction().equals(Action.RIGHT_CLICK_BLOCK)) || (!event.getAction().equals(Action.LEFT_CLICK_BLOCK))) {

   
   Are you sure about this part?

 

ColonelHedgehog What do you mean? It works correctly for me, no errors show up and it executes when it has to.

 

Of course no error is going to show up, but why don't you just check if it actually is a right-click/left-click block? Then you wouldn't have to check if it's null.

 

ColonelHedgehog I will change it. But do you know why the if statement doesn't work correctly?

 

It's difficult to tell, could you elaborate on where the code seems to derail?

 

ColonelHedgehog I think it goes wrong after checking the permission, this part:

Code:java

 
if (kitManager.getPlayerKit(pl) != null) {
if (!canChange.contains(name)) {
pl.sendMessage(prefix + "§cYou already choose a kit! Click again to change.");
canChange.add(name);
 
Bukkit.getServer().getScheduler().scheduleSyncDelayedTask(plugin,
new Runnable() {
 
@Override
public void run() {
if (canChange.contains(name)) {
canChange.remove(name);
}
}
}, 80L);
return;
}
 
canChange.remove(name);
kitManager.getPlayerKit().remove(name);
pl.sendMessage(prefix + "§aYou can select a new kit again!");
return;
}

How it should work: if a player selects a kit for the first time and clicks again on the sign, it will ask the player if he wants to change his kit. If so, the player should click again on the sign and it will remove the player from a hashmap. After this the player can select a new kit.
But I don't want that the name stays in the arraylist so I've added a runnable that removes the name from the arraylist after 4 seconds.

Now the problem is that when a player spams his mouse button, it will send the question 2 times to the player, while it shouldn't.

When I remove the runnable, the problem is gone but I still want to remove the name after 4 seconds from the arraylist. So any idea how to do this?

 

Create debug messages

 

Use a map for delays instead

Also, look at line 19 of your original snippet.

 

Barinade why use a map for delays?

 

It's tidier and I would imagine less load