How to get onDisable to wait for my runnable to finish before continueing to shut down.

Dang. long title....lol. Any rate, i need the server to wait on shutdown till my runnable is done, which wont take more than a couple secs.

 

Is your task running sync or async? The server won't shut down as long as it's executing your code.

 

Simple question. You can't. What are you trying to do anyways.

 

The_Doctor_123 Conarnar

Its Sync. My plugin is using items to create a custom aura effect by spawning items randomly around the player in a 1 block radius, each tick. So 20 items per second. I prevent the items from stacking by randomly naming them with a random number generator. I prevent players from picking them up by adding lore that reads "NO". Right after the items are created, it sets their velocity just enough to barely shoot up, then 1 sec later, it removes them with a runtasklater.

It all works fine except for the fact that if a players aura is turned on when the server shuts down, the items will be laying on the ground when its restarted.

I know after 5 mins they will despawn. But I dont want them hanging around after the fact.

 

Put all the items in a list and onDisable run through the list and set each item to ItemStack(Material.AIR);.

 

you can.

park main thread and do what you want, then unpark thread, this is JVM feature.

in case of cleanup, there are shutdown hooks in java for this.

 

The server can still shut-down. My way would work better.

 

server can't shutdown with main thread parked.

 

I believe they can.

Plus, my way would work if the server crashed.

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

Your method wont work on crash, nothing will.

 

Yup, even I know that, if the server crashes, nothing is executing at all.

 

it will as it deletes the items in the ArrayList; if there are no items in the ArrayList then there will be no items spawned.

 

DrMedia

It wont, the server is no longer running if it crashes. So there is no code to execute.

RawCode

What about getServer().getScheduler().getPendingTasks()?

If it does what I read it does, in my onDisable() I could add something like....

while(getPendingTask()){
//do nothing here
}

it looks like the simplest way to go.

 

Paxination
Once shutdown starts, you may not access any of the API. I'm not exactly sure if there's a way around your problem except listening for the "stop" command.

 

http://jd.bukkit.org/rb/doxygen/de/...Entity.html#a3bd947ac9fb072f9a6b2a5ce68ad9fae

On the item, set that to (5 * 60 * 20) - the ticks you want it to be alive and it will despawn in that time. I'm pretty sure that will make the server despawn it regardless. Also use setpickupdelay to prevent people from picking it up.

 

Yeah that idea didnt work. It just hung on in the WHILE loop.

Garris0n That isnt working either.

I am assuming its because I am randomly naming them so they dont stack up.

I guess i'll try thedocs or drmedias ways.

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

What part of it isn't working? setPickupDelay won't stop them from stacking, you still have to randomly name them. Everything else should work though...

 

To make it crash safe place the items in array list; on enable (in case server crashes) then check that list.. If its empty, find all entities in the location of the items and remove them.

 

A lot of these posts are misleading...

@OP

If you handle your own tasks, and keep a list of them, then you can manually cancel them without interrupting on shutdown. I have such a system here:

https://github.com/1Rogue/PlayTime/...ue/playtime/executables/ExecutiveManager.java
https://github.com/1Rogue/PlayTime/blob/master/src/main/java/com/rogue/playtime/Playtime.java#L181

 

It would work because the a api is always available until the plugin disables, the server shutdown can be cancelled and delayed because Bukkit waits for the on disable in the plugin to finish before fully shouting downs, if you couldn't access the api on disable then it would make the method useless

You can

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

breezeyboy
At least part of the API, if I recall correctly.

 

The op dont want to cancel the tasks

I dont see what part would

This should work

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

breezeyboy
Could be wrong.. haven't really fooled around with plugins in a long time. The only reason I know the part of the API I do is from all the repetitive questions/answers.

Also, you could've condensed those 3(EDIT: 4) replies above into 1..

 

Yea but im on my phone and its hard to edit

 

breezeyboy
I know how that is.. I'm on an iPad right now. You could quote all the people at once and you'll have all the quotes down in the reply box.

 

[quotoThe_Doctor_123, post: 2093034, member: 90859177"]breezeyboy
I know how that is.. I'm on an iPad right now. You could quote all the people at once and you'll have all the quotes down in the reply box.[/quote]
You dont know, half way though typing it starts putting the letters in the quote

 

breezeyboy
I do know. It's not fun being on a forum with a mobile device.

 

From what I understand he doesn't want to interrupt the tasks. If .onDisable() is being called because bukkit is shutting down you can't continue running the tasks after the entire program terminates.

And if he wanted to handle reloads he just simply doesn't have to have it called in .onDisable(). So I still fail to see where my previous post was incorrect.

 

The getPendingTask didnt work, it just hung in the WHILE loop. Nothing else worked. I eventually added the entities to a list and in onDisable, I iterate through it and remove them my self. The only other thing i did try was parking the main thread which sounded more complicated than i wanted.

I didnt want to cancel the task, as there is no point since the server is shutting down. I dont bother handling reloads as all my admins/ops have been instructed not to use /reload as most plugins dont handle them properly and things get messy when using it.

Any rate, its working. Thanks for the debate!

Garris0n

setTicksLived is whats not working. Like I said I am assuming it was because I named them. Named entities do not despawn.

Also you edited that after I read it, I didnt see the setpickupdelay. That could help instead of using an event to check each items lore and canceling.

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

Named LivingEntities*, the items would despawn just fine.