How do I implement the new PLAYER_COMMAND_PREPROCESS event?

Hey,

It's been some time since I developed a plugin and I noticed that the PLAYER_COMMAND has been removed and replaced with PLAYER_COMMAND_PREPROCESS. But somehow I can't get it to work.

Also I read somewhere on this forum that I need to add stuff into my plugin.yml file in order to get them to work.

Is there a 'up to date' tutorial on how to do that?

Thanks in advance.

 

Override onCommand on the main file (the one that extends JavaPlugin)
OR

Code:

 public void onEnable() {
getCommand("bounty").setExecutor(new sdBountyHunterCmds(this));
}

and than make a class implementing CommandExecutor

Code:

public class sdBountyHunterCmds implements CommandExecutor

 

Never mind I already found it.

public void onPlayerCommandPreprocess(PlayerChatEvent e)
{
//Process the command here
//No need to change anything in the plugin.yml to get it workin
//Make sure to call e.setCancelled(true); if you are responding to this command to remove the Unknown command error
}

 

You found it, but that's not the best way to make cmds
in Java docs about onPlayerCommandPreprocess:
"Called early in the command handling process.
This event is only for very exceptional cases and you should not normally use it."

 

Thanks Sammy I'll implement my commands the right way than.

 

No problem

 

I rather dislike this wording (which is not your fault, obviously). The JavaDocs are supposed to explain what something does and typically the motivations and contractual obligations of that class, field, or method. It's quite bad when better than 50% of the description text explains that the reader should not be using it.
It would be infinitely better to remove both of these lines and explain enough about this method and how the corresponding event is raised that the reader can postulate, "This is complicated or dangerous and it probably doesn't do what I would like."
Sorry. I'm feeling pedantic this afternoon.

 

I completely agree with you, that's why so many ppl ask what it does...
Still, I'm almost 99% sure that he doesn't need to use PLAYER_COMMAND_PREPROCESS
And you could be messing with he's head with your "pedantic feelings" ^^

In other words: If you aren't sure use OnCommand ^^

 

Exactly. Developers knowing what they're doing will get that the preprocess is not something evil and it can be freely used and it'S just not wise to do so every time.
Those who do not understand that by themselves are better off thinking it's evil, thus the javadocs wording

 

I agree. I'm fairly certain this is unnecessary in the vast majority of cases.

It was off the cuff and random. Sorry. One of my pet peeves is poorly written or inaccurate JavaDocs documentation.

I respectfully decline to agree.

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

Wauw big conversation here!

I've got just one big problem with using the Command Executor,
How am I going to get the player who executed the command? Both the Command and CommandSender classes have no information on this at all in the docs.

 

The Player class implements CommandSender, so you can cast like this:

Code:

if(commandSender instanceof Player)
{
   Player player = (Player)commandSender
   //some player-related code goes here
}
else
{
   //console may be issuing the command
}

 

Thank you Edward Hand!

 

How can the console issue the command ? that could be useful for me in the future

The big problem is that making new coders understand how the pre process works is difficult so making it look like a binary code Satan is easier ^^

 

Well...you just type it in

like you can type 'give Sammy 46 64' in console and it would give you a stack of TNT

 

Hmmm

Code:

this.getCommand("skill").setExecutor(new SkillCommandExecutor(this));

Gives me the error

The SkillCommandExecutor implements the CommandExecutor as noted above.
Am I missing something here?

 

That would suggest that it can't find a command called "skill"
you did register it in your plugin.yml didn't you?

 

No I didn't .
Could you please give me the syntax

 

Code:

name: YourPlugin
main: com.yourname.ClassFile
version: 0.1
commands:
  skill:
    description: does some skills stuff
    usage:

something like that

 

Yay it's working! Thank you for all the help.

 

I'm so dumb sometimes
I thought that commands from plugin could only be used on the chat console... silly me

 

Doesn't matter Sammy were all humans and we can all make mistakes.