How can I make loading from a string into a location work?

What I want is to load a location from a string in a hashmap. Here's what i've got.

Code:java

package org.awesomecraft.plugins.orphanage;
 
import java.util.HashMap;
import java.util.Map;
import org.bukkit.ChatColor;
import org.bukkit.Location;
import org.bukkit.command.Command;
import org.bukkit.command.CommandExecutor;
import org.bukkit.command.CommandSender;
import org.bukkit.entity.Player;
import org.bukkit.plugin.java.JavaPlugin;
 
public class Orphanage extends JavaPlugin {
    /*
    * Thanks to
    *
    *
    */
    public Map<String, String> orphanage = new HashMap<String, String>(); //<World, Orphanage Location>
    public Map<String, String> mothers = new HashMap<String, String>(); //<Mother, Orphan>
    public Map<String, Boolean> isOrphan = new HashMap<String, Boolean>(); //<Orphan, isOrphan>
    public void onDisable() {
        System.out.println(this + " is now disabled!");
        try {
            SLAPI.save(mothers, "mothers.bin");
        } catch (Exception ex) {
            ex.printStackTrace();
        }
        try {
            SLAPI.save(isOrphan, "orphans.bin");
        } catch (Exception ex) {
            ex.printStackTrace();
        }
        try {
            SLAPI.save(orphanage, "orphanage.bin");
        }
        catch(Exception ex) {
            ex.printStackTrace();
        }
    }
 
    public void onEnable() {
        getCommand("adopt").setExecutor(new CommandExecutor() {
 
            public boolean onCommand(CommandSender cs, Command cmnd, String alias, String[] args) {
                if(args.length == 1) {
                    if(cs instanceof Player) {
                        try {
                    Player target = getServer().getPlayer(args[0]);
                    Player sender = (Player) cs;
                    sender.sendMessage(ChatColor.GREEN + "You are now the parent of " + target.getDisplayName() + "!");
                    target.sendMessage(ChatColor.GREEN + "You have been adopted by " + sender.getDisplayName() + "!");
                    mothers.put(sender.toString(), target.toString());
                    isOrphan.put(target.toString(), Boolean.FALSE);
                        }
                        catch(NullPointerException npe) {
                            cs.sendMessage(ChatColor.RED + "Player not found.");
                        }
                    }
                    else{
                        cs.sendMessage(ChatColor.RED + "You must be ingame to use this command.");
                    }
                }
                return true;
            }
        });
        getCommand("abandon").setExecutor(new CommandExecutor() {
 
            public boolean onCommand(CommandSender cs, Command cmnd, String alias, String[] args) {
                if(cs instanceof Player) {
                Player target = getServer().getPlayer(args[0]);
                Player sender = (Player) cs;
                if(mothers.containsValue(target.toString()) && mothers.containsKey(sender.toString())) {
                    mothers.put(null, null);
                    isOrphan.put(target.toString(), true);
                    target.sendMessage(ChatColor.RED + "You are an orphan again.");
                    sender.sendMessage(ChatColor.RED + "You abandoned your orphan on the streets.");
                } else {
                sender.sendMessage(ChatColor.RED + "You aren't the parent of that person!");
                }
                }
                return true;
        }});
        getCommand("setorphanage").setExecutor(new CommandExecutor() {
 
            public boolean onCommand(CommandSender cs, Command cmnd, String alias, String[] args) {
                if(cs instanceof Player) {
                    Player sender = (Player) cs;
                    orphanage.put(sender.getWorld().toString(), sender.getLocation().toString()); //Error here
                    sender.sendMessage(ChatColor.GREEN + "Set an orphanage at your current location.");
                }
                else {
                    cs.sendMessage(ChatColor.RED + "You must be ingame to use this command.");
                }
                return true;
            }
        });
        getCommand("orphanage").setExecutor(new CommandExecutor() {
 
            public boolean onCommand(CommandSender cs, Command cmnd, String alias, String[] args) {
                if(cs instanceof Player) {
                    Player sender = (Player) cs;
                    if(orphanage.get(sender.getWorld().toString()) != null) {
                        Location tele = orphanage.get(sender.getWorld().toString());
                        sender.teleport(tele);
                    }
                    else {
                        sender.sendMessage(ChatColor.RED + "An orphanage hasn't been set yet.");
                    }
                }
                else {
                  cs.sendMessage(ChatColor.RED + "You must be ingame to use this command.");
                }
                return true;
            }
        });
        try {
            mothers = (Map<String, String>)SLAPI.load("mothers.bin");
        } catch (Exception ex) {
            ex.printStackTrace();
        }
        try {
            isOrphan = (Map<String, Boolean>)SLAPI.load("orphans.bin");
        } catch (Exception ex) {
            ex.printStackTrace();
        }
        try {
            orphanage = (Map<String, String>)SLAPI.load("orphanage.bin");
        }
        catch(Exception ex) {
            ex.printStackTrace();
        }
 
        System.out.println(this + " is now enabled!");
    }
}
 

 

Firstly, scrap the isOrphan HashMap, use a Set and check if the user is in the set.

Secondly, you'll want to get the plugin's data directory, something like this:

Code:

getDataFolder() + File.separator + "filename"

Thirdly, just a pet peeve - Why does everyone serialise their HashMaps instead of spending a bit of time and putting them into a config file - It's much easier on the end user, as it allows them to edit the saved data if they need to.

 

You could store the location as x;y;z in your String. Then use String.split() or StringTokenizer to split up the String and Float.valueOf() to convert the coordinates to floats.

If you want multi-world support you also have to store the world name.