How can i do like players can't send command to himself?

Hello!

I am creating a plugin and i need little help...

I dont want like players can "hug" himself... I My command its /kram and players will "kram" others but not "kram" himself. Exempel: My ing name its gurraplurra01 so i will not be allowed to do /kram gurraplurra01 but i will be allowed to do /kram notch or /kram jeb_

Whats the code?

 

Code:java

 public boolean onCommand(CommandSender sender, Command cmd, String CommandLabel, String[] args)
{
Player p = (Player)sender;
 
if ((cmd.getName().equalsIgnoreCase("kram")) && (p.hasPermission("kram.use")) &&
(args.length == 1){
Player target = getServer().getPlayer(args[0]);
if (target == p){
//You cannto hug yourself
}
else if (target != p)
 //Hug someone
}
}

GorguZ

Check if the player target of args[0] (in your case) is the command sender. If target and sender are identical do something.

 

1º wtf is kram? this word a actually dont exist in the google translate so i cant know what it is.

something like dat, watch some tutorials in youtube about hugs i dont know nothing about this...

Code:java

public boolean Comand(CommandSender sender, Command cmd, String str, String[] args){
if(sender instanceof Player){
Player s = (Player) sender;
if(cmd.getName().equalsIgnoreCase("kram")){//(i dont know wtf is dat)
if(args[] !== s.getName()){
//CAN "KRAM" (i dont know wtf is dat) AND MAKE LOVE
}else{s.sendMessage(ChatColor.PURPLE + "U cant kram(i dont know wtf is dat) urself");}
}else{return;}
}
return false;
}

 

CynutsBR

Swedish to English: more detail...

1. kram:
   
   • caress
     
     ​
     ; hug
     
     ​
     ; embrace
     
     ​
     ; cuddle
     
     ​
     ; fondling
     
     ​
     ; embrasure
     
     ​

 

Hmm... when i try to "kram" me i dont get a message that i have "kram" me but i get a message that i have been "kram" but me... Would i send the code?

 

GorguZ Yes please send the code. That was meant to be an Example

 

Here is the code, so far...

Code:java

package me.gustavleithe.Kram;
 
 
import org.bukkit.ChatColor;
import org.bukkit.command.Command;
import org.bukkit.command.CommandSender;
import org.bukkit.entity.Player;
import org.bukkit.plugin.java.JavaPlugin;
 
 
    public class Kram extends JavaPlugin{
 
 
 
 
        public void onEnable(){
            System.out.println("Kram onEnable");}
 
        public void onDisable(){
            System.out.println("Kram onDisable");}
 
 
 
        @SuppressWarnings("deprecation")
        public boolean onCommand(CommandSender sender, Command cmd, String label, String[] args){
            Player player = (Player) sender;
            if(player.hasPermission("kram.sendkram")){
            }else{
                player.sendMessage(ChatColor.RED + ("Denna funktion är fortfarnde i BETA"));
                if(cmd.getName().equalsIgnoreCase("kram")){
 
                }
 
                    if(args.length == 0){
                        //kram = 0 args //kram gurraplurra01 = 1 args
                      sender.sendMessage(ChatColor.RED + ("För få argument! Andvänd: /kram spelarnamn för korrekt andvändning!"));
                    }else if (args.length == 1){
                        Player target = getServer().getPlayer(args[0]);
                    if (target == player){}
 
 
                    else if (target != player)
 
            sender.sendMessage(ChatColor.GREEN + ("Du har kramat"  + ChatColor.YELLOW  + player.getName()  + ChatColor.GREEN + "!"));
            player.sendMessage(ChatColor.GREEN + ("Du har blivit kramad av"  + ChatColor.YELLOW  +  sender.getName() + ChatColor.GREEN + "!"));
        }else{
            player.sendMessage(ChatColor.RED + ("Spelaren är inte online!"));
 
 
 
        }
 
            if (args.length > 2) {
                sender.sendMessage(ChatColor.RED + ("För många argument! Andvänd: /kram spelarnamn för korrekt andvändning!"));
 
 
 
 
 
 
            }
 
 
                }
            return true;
            }{
 
 
        }{
 
 
 
 
 
    }}
 
 

 

GorguZ
Check the player names instead of player instances. Get the sender's name, then the targets's name (using args[1]) then use an if statement with those two variables.

 

Can you please send a exempel?

 

MoeMix Thats exactly what i said before xD

 

GorguZ
if (sender.getName().equals(Bukkit.getServer().getPlayer(args[0]).getName()) {

Something like this. Ofcourse check if that player isnt null first.

 

Where should i put in this?

 

fefe2008
LOL. I don't read the previous conversation xD

GorguZ
I don't have access to a computer atm. However, this should be fairly simple.
Get the sender's name..
Then use an if statement that looks something like if(playername.equals(args[1]){ blah blah blah}

What do you mean? it's an if statement so put it where you want to check before running a piece of code.

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

Dont work... Same like i say before and now when i try to "kram" a offline player i get i message that i have "kram" myself... Did you want to see that the code again with the code you give me?

 

GorguZ
yes please

 

Code:java

package me.gustavleithe.Kram;
 
import org.bukkit.Bukkit;
import org.bukkit.ChatColor;
import org.bukkit.command.Command;
import org.bukkit.command.CommandSender;
import org.bukkit.entity.Player;
import org.bukkit.plugin.java.JavaPlugin;
 
 
    public class Kram extends JavaPlugin{
 
 
 
 
        public void onEnable(){
            System.out.println("Kram onEnable");}
 
        public void onDisable(){
            System.out.println("Kram onDisable");}
 
 
 
        @SuppressWarnings("deprecation")
        public boolean onCommand(CommandSender sender, Command cmd, String label, String[] args){
            Player player = (Player) sender;
            if(player.hasPermission("kram.sendkram")){
            }else{
                player.sendMessage(ChatColor.RED + ("Denna funktion är fortfarnde i BETA"));
                if(cmd.getName().equalsIgnoreCase("kram")){
 
                }
 
                    if(args.length == 0){
                        //kram = 0 args //kram gurraplurra01 = 1 args
                      sender.sendMessage(ChatColor.RED + ("För få argument! Andvänd: /kram spelarnamn för korrekt andvändning!"));
                    }else if (args.length == 1){
                        Player target = getServer().getPlayer(args[0]);
                    if (target == player){}
 
 
                    else if (target != player)
 
            sender.sendMessage(ChatColor.GREEN + ("Du har kramat"  + ChatColor.YELLOW  + player.getName()  + ChatColor.GREEN + "!"));
            player.sendMessage(ChatColor.GREEN + ("Du har blivit kramad av"  + ChatColor.YELLOW  +  sender.getName() + ChatColor.GREEN + "!"));
        }else{
            player.sendMessage(ChatColor.RED + ("Spelaren är inte online!"));
 
            if (sender.getName().equals(Bukkit.getServer().getPlayer(args[0]).getName())) {
 
        }
 
            if (args.length > 2) {
                sender.sendMessage(ChatColor.RED + ("För många argument! Andvänd: /kram spelarnamn för korrekt andvändning!"));
 
 
 
 
 
 
            }
 
 
                }
 
            }{
 
 
        }{
 
 
 
 
 
    }
        return true;}}
 
 

 

GorguZ
No, in line 49 just do: if(sender.getName().equals(args[1]){ }
This will check if the sender is trying to hug himself

 

Dosent help... Same problem should i post the new code?

 

GorguZ
add me on skype: sudani_moe
I don't want this thread to grow outrageously large over this topic.

 

Uhm i only have skype on ipad so its would be hard to send files... Maybe can we use the PM function on bukkit?

 

Or just speak here, because taking it private is pointless.

 

yeah ok

 

GorguZ You should fromat your code a bit. Its hard to read with the brackets set up like that

 

GorguZ
I'm home now just send me your code and I'll edit it to what it should be.

GorguZ
Ok, final code. This should work:

Code:java

package me.gustavleithe.Kram;
 
import org.bukkit.Bukkit;
import org.bukkit.ChatColor;
import org.bukkit.command.Command;
import org.bukkit.command.CommandSender;
import org.bukkit.entity.Player;
import org.bukkit.plugin.java.JavaPlugin;
 
 
    public class Kram extends JavaPlugin{
 
 
 
 
        public void onEnable(){
            System.out.println("Kram onEnable");}
 
        public void onDisable(){
            System.out.println("Kram onDisable");}
 
 
 
        @SuppressWarnings("deprecation")
        public boolean onCommand(CommandSender sender, Command cmd, String label, String[] args){
            Player player = (Player) sender;
            if(player.hasPermission("kram.sendkram")){
            }else{
                player.sendMessage(ChatColor.RED + ("Denna funktion är fortfarnde i BETA"));
                if(cmd.getName().equalsIgnoreCase("kram")){
 
                }
 
                    if(args.length == 0){
                        //kram = 0 args //kram gurraplurra01 = 1 args
                      sender.sendMessage(ChatColor.RED + ("För få argument! Andvänd: /kram spelarnamn för korrekt andvändning!"));
                    }
                    else if(args.length == 1){
                    if (args[1].equals(player.getName())){}
            if(Bukkit.getPlayer(args[1]).isOnline()){
            Bukkit.getPlayer(args[1]).sendMessage(ChatColor.GREEN + ("Du har kramat "  + ChatColor.YELLOW  + player.getName()  + ChatColor.GREEN + "!"));
            player.sendMessage(ChatColor.GREEN + ("Du har blivit kramad av"  + ChatColor.YELLOW  +  sender.getName() + ChatColor.GREEN + "!"));
            }
            else{
                player.sendMessage("Spelaren är inte online!");
            }
        }
 
            if (args.length > 2) {
                sender.sendMessage(ChatColor.RED + ("För många argument! Andvänd: /kram spelarnamn för korrekt andvändning!"));
 
 
 
 
 
 
            }
 
 
                }
            return true;
 
            }{
 
 
        }{
 
 
 
 
 
    }{}}
 

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

MoeMix you seem to need to learn Java before trying to code, as your brackets are extremely off, you open and close them for no reason, your if checks are also problematic, as you make a blank if check, then do the code in the else when you could reverse the if, and you try to access args[1] when you made sure it wouldn't exist since args length is 1.

 

Necrodoom
Trust me, if I rewrote this plugin for him, I would have been much more organized. You, however, are jumping to conclusions. I simply took his code and edited what needed to be fixed. He didn't ask for a complete formatting. I simply fixed his issue. And what do you mean my if checks are problematic? I am checking if the player is online then using an else statement if the player is not online. Also, args[1] does exist. there is an if statement checking if args.length = 1.

 

MoeMix args[1] does not exist, as that would be the 2nd argument. args[0] is the first argument.
You also shouldn't just go around and "edit" in what needs to be fixed. Generally follows the same idea of Spoon-feeding, the person whos code you fix won't learn anything and expect that someone will always come and "edit" their code on here for them. This helps nobody, only makes OP more confused and irritates others when the OP comes with another post asking for code rather then asking for help.
Edit: Your ifs are problematic because you simply have this blank if statement, and do everything in the else. Necrodoom is saying that you should reverse the if statement rather then use a blank if and then do everything in the else, makes the code look better and leads to better coding habits.

 

xTigerRebornx
the second argument is exactly what I'm talking about since the first argument is "kram"
the command is /kram playername therefore playername is args[1]. Is there something I missed? kram would be args[0] and playername would be args[1]

 

MoeMix Yes, you may be referring to the 2nd argument, but you do a check if the args length is 1, not 2, then try to access args[1] even though you've already determined that there is only 1 argument, not 2.

 

xTigerRebornx
As for the problematic ifs I just edited the code I wasn't trying to make it perfect. Simply made it do what he wanted it to do from the OP. And I tried showing him how to do it but he wouldn't understand so I wrote it out for him hoping he would understand