Horse teleportation Long distance

I have coded a horse teleport plugin which works just fine if it is over a short distance but when i try to teleport the horse a long distance everything in the code works i get the noise my messages all work but the horse never moves. i am using this to move the horse:

Code:

horse.teleport((Entity)player)

horse is an entity variable which the horse is stored as.

is there a way of getting the horse to teleport long distances?

 

NoLiver92

What exactly do you mean?

1) You are near/next to the horse and you teleport somewhere far away, and the horse doesn't follow
2) You are quite a bit away ( < 250 blocks) from the horse, and teleport it to you
3) You are extremely far away (over 250 blocks) and teleport it to you

Which of those are you referencing by saying the horse won't teleport over long distances.

 

ERROR372 Sorry i thought it was clear, umm i would say number 1.

this is the orser of what i do:

1. eject player from horse
2. teleport player to new location over 250 blocks away
3. teleport the horse to the same place

the horse never gets to the new location, it doesnt even move from where it was

 

NoLiver92

I mean, I did a plugin just like this, so I'll post it here (pretty short) and you can take a look and see if you can find out what's going on in yours. Granted mine is specific to my server based on the commands players can use to teleport around the worlds

Code:java

public class HorseTeleport implements Listener
{
    @EventHandler
    public void onHorseTP(PlayerCommandPreprocessEvent event)
    {
        String input = event.getMessage();
        if(input.startsWith("/tp") || input.startsWith("/warp") || input.startsWith("/home") || input.startsWith("/spawn"))
        {
            Player p = event.getPlayer();
            if(p.isInsideVehicle() && p.getVehicle().getType() == EntityType.HORSE)
            {
                Horse h = (Horse) p.getVehicle();
                if(h.isTamed())
                {
                    p.leaveVehicle();
                    String message = event.getMessage().substring(1);
                    p.performCommand(message);
                    h.teleport(p);
                    event.setCancelled(true);
                    return;
                }
                return;
            }
        }
        return;
    }
 
}
 
 

You can post your code if you want, that'd help us see what might be going wrong.

 

ERROR372

So you cancel the command? So the player isn't teleported. Then teleport the horse to the player. When the horse. Is underneath the player already?

 

ShadowDog007

Nope, the event.setCancelled(true) prevents the command they typed from executing, which I handled with the player.performCommand(message).

The player does teleport, and the horse is teleported to the player.

 

ERROR372

Why not just listen for a teleport event. You don't even have know if the player has permission to use the command.

 

ShadowDog007

Because when you are riding a vehicle, and you do a command that teleports you, you don't get teleported, so the event won't fire. Go ahead and try it yourself. Get on a horse and do "/tp <yourname> 0 100 0". I promise you won't go anywhere =P

 

ERROR372

I know that. Its not hard to get around though. Just set a boolean in the listener to ignore the next teleport event. Easy.

 

ShadowDog007

Not sure that I see what the problem is really... my code works, and executes just fine. If you are saying, don't use player.performCommand(message), I ask then how will you teleport the horse after the command gets executed. PlayerCommandPreprocessEvent does things before the command executes.

I suppose you could set the horse teleport task to run 1 second later, but why do the extra code when it's just as easy and simple to do player.performCommand(message) and then cancel the event?

 

ERROR372

You didn't read what I said. PlayerTeleportEvent - > If the player is on a horse set a field in the listener and have the listener ignore Teleport events when the field is set to true.

Much better way to do it. Else you have to include every command which teleports players. Which is much harder and less efficient to do..

 

ShadowDog007

You cannot use PlayerTeleportEvent for this... Go ahead and try, it won't work, I already have.

 

Yes you can. I have done it. And it works fine. IF you do what I said. Q_Q

 

ShadowDog007

So you solely use PlayerTeleportEvent to do this?

 

Yes. Please read what I said earlier. You obviously misunderstood.

 

ShadowDog007

Unless I'm still misunderstanding... you said to (psuedocode):

Code:

PlayerTeleportEvent
{
    if(player is on horse)
    {
        //do stuff here
    }
}

I have tried doing such things, but if the player does not get teleported, this event won't throw. If the player is in a vehicle, they won't be teleported... It will say "<name> teleported to <x> <y> <z>", but it won't actually teleport them

 

ERROR372

Code:

private boolean teleporting = false;
 
@EventHandler
public void onPlayerTeleport(PlayerTeleportEvent event)
{
    if (teleporting)
        return;
 
    if (/* player is on horse */)
    {
        teleporting = true;
        // Do stuff
        teleporting = false;
    }
}

 

ShadowDog007

Doesn't work.

Proof:

My code just for testing:

Code:java

private boolean teleporting = false;
 
    @EventHandler
    public void onPlayerTeleport(PlayerTeleportEvent event)
    {
        if (teleporting)
            return;
 
        if(event.getPlayer().isInsideVehicle() && event.getPlayer().getVehicle() instanceof Horse)
        {
            teleporting = true;
            System.out.println("hi");
            teleporting = false;
        }
    }

Console log (should output "hi" when teleport event fires, it does when you mount a horse):

Code:

00:45:43 [INFO] ERROR372 issued server command: /tp ERROR372 0 67 0
00:45:43 [INFO] ERROR372: Teleported ERROR372 to 0.50, 67.50, 0.50

Photo evidence:

http://i1322.photobucket.com/albums/u572/ERROR372/2013-07-20_004548_zps05584646.png

Notice I didn't teleport to 0,67,0 (current coords at the top of the screen).