Getting blocks of a chunk

So, I wanna get all blocks(locations) of a chunk, to get them, I have this method:

Code:java

ArrayList<Location> locations = new ArrayList<Location>();
        Integer x = chunk.getX() * 16;
        Integer z = chunk.getZ() * 16;
        Integer y = 0;
        Boolean keepOnDoingShit = true;
        while (keepOnDoingShit) {
            Location location = new Location(chunk.getWorld(), x, y, z);
            locations.add(location);
            if (x < 15) {
                x = x + 1;
            } else if (z < 15) {
                x = 0;
                z = z + 1;
            } else {
                x = 0;
                z = 0;
                y = y + 1;
                if (y == chunk.getWorld().getMaxHeight() + 1) {
                    keepOnDoingShit = false;
                }
            }
        }

I haven't tried it, but I think it should work.
Can anyone see any obvious flaws, or do you perhaps know a better/more efficient/cooler way of doing this?

 

Personally I'd use the Chunk.getBlock() method. It gives you a block location relative to that chunk, so you could make the code as simple as this:

Code:

for(int x=0; x<=15; x++) {
  for(int y=0; y<=maxHeight; y++) {
    for(int z=0; z<=15; x++) {

      locations.add(chunk.getBlock(x,y,z).getLocation());
    }
  }
}

Haven't checked it but you get the idea.

 

adam753 Oh... yea... looks very simple... I'll try it out, thanks!