GetNBTData for Blocks

I am trying to edit the WorldEdit schematic save function so that it could be used mostly outside of the WorldEdit API mainly because I cannot figure out how to create the objects the WorldEdit save method has as parameters.
The original WorldEdit save method takes the following parameters:
save(CuboidClipboard clipboard, File file)
Saves the data from the specified CuboidClipboard to the given file, overwriting any existing data in the file

For the life of me, I cannot create a CuboidClipboard object with two Locations (max and min), so instead, I am trying to edit the WorldEdit schematic save method to take the following parameters:

Code:java

public void save(int width, int height, int length, Location origin, File file) throws IOException, DataException {}

The CuboidClipboard object was able to retrieve the width, height, length, and origin with WorldEdits vectors, but I have all of those values on-hand easily.
I am able to convert the method for the most part except for retrieving the blocks NBTId and NBTData for the TileEntityBlocks.
WorldEdit has its own constructor classes for Minecraft blocks which has a method for getting the NBT values, but there are only interfaces of those methods in the source. I cannot find it.
So I am using Bukkits Block class and need to retrieve the NBT values.

Below is what I am working with. I have commented all the original WorldEdit code which has been changed and show what I changed it too.

Code:java

public void save(int width, int height, int length, Location origin, File file) throws IOException, DataException {
        //  Do not need to initialize the dimension values as they are now the parameters
        //int width = clipboard.getWidth();
        //int height = clipboard.getHeight();
        //int length = clipboard.getLength();
 
        if (width > (Short.MAX_VALUE - Short.MIN_VALUE)) {
            throw new DataException("Width of region too large for a .schematic");
        }
        if (height > (Short.MAX_VALUE - Short.MIN_VALUE)) {
            throw new DataException("Height of region too large for a .schematic");
        }
        if (length > (Short.MAX_VALUE - Short.MIN_VALUE)) {
            throw new DataException("Length of region too large for a .schematic");
        }
 
        HashMap<String, Tag> schematic = new HashMap<String, Tag>();
        schematic.put("Width", new ShortTag("Width", (short) width));
        schematic.put("Length", new ShortTag("Length", (short) length));
        schematic.put("Height", new ShortTag("Height", (short) height));
        schematic.put("Materials", new StringTag("Materials", "Alpha"));
 
        //I changed this to get the int x, y, and z values from the Bukkit Location
        schematic.put("WEOriginX", new IntTag("WEOriginX", origin.getBlockX()));  //clipboard.getOrigin().getBlockX()));
        schematic.put("WEOriginY", new IntTag("WEOriginY", origin.getBlockY()));  //clipboard.getOrigin().getBlockY()));
        schematic.put("WEOriginZ", new IntTag("WEOriginZ", origin.getBlockZ()));  //clipboard.getOrigin().getBlockZ()));
        //I do not need an offset so I just set this to 0
        schematic.put("WEOffsetX", new IntTag("WEOffsetX", 0));  //clipboard.getOffset().getBlockX()));
        schematic.put("WEOffsetY", new IntTag("WEOffsetY", 0));  //clipboard.getOffset().getBlockY()));
        schematic.put("WEOffsetZ", new IntTag("WEOffsetZ", 0));  //clipboard.getOffset().getBlockZ()));
 
        // Copy
        byte[] blocks = new byte[width * height * length];
        byte[] addBlocks = null;
        byte[] blockData = new byte[width * height * length];
        ArrayList<Tag> tileEntities = new ArrayList<Tag>();
 
        for (int x = 0; x < width; ++x) {
            for (int y = 0; y < height; ++y) {
                for (int z = 0; z < length; ++z) {
                    int index = y * width * length + z * width + x;
 
                    //  I cannot use clipboard, and I cannot convert Bukkit Block to WorldEdit BaseBlock
                    //  But from the looks of it, this line just gets the block at the x,y,z coordinates of the Cuboid Area. Not the Minecraft world
                    //BaseBlock block = clipboard.getPoint(new BlockVector(x, y, z));
 
                    //So I get the block at the current point in the Cuboid region by adding the x, y, and z values to the origin coordinates
                    Location currentLoc = new Location(origin.getWorld(), origin.getBlockX() + x, origin.getBlockY() + y, origin.getBlockZ() + z);
                    Block block = currentLoc.getBlock();
 
 
                    // Save 4096 IDs in an AddBlocks section
                    //  I change the getId() methods for Bukkits Block class
                    //if (block.getType() > 255) {
                    if (block.getTypeId() > 255) {
                        if (addBlocks == null) { // Lazily create section
                            addBlocks = new byte[(blocks.length >> 1) + 1];
                        }
 
                        //I changed from getType() to getTypeId() again for Bukkits Block class
                        addBlocks[index >> 1] = (byte) (((index & 1) == 0) ?
                                addBlocks[index >> 1] & 0xF0 | (block.getTypeId() >> 8) & 0xF
                                : addBlocks[index >> 1] & 0xF | ((block.getTypeId() >> 8) & 0xF) << 4);
                    }
 
                    // change the same getId() method again...
                    blocks[index] = (byte) block.getTypeId();
                    blockData[index] = (byte) block.getData();
 
                    // Store TileEntity data
 
                    /*
                    * HERE IS WHERE THE PROBLEM IS
                    * Here the WorldEdit code creates a TileEntityBlock from the BaseBlock class so that
                    * it can get the NbtId and NbtData of the TileEntityBlock. There is no method in the Bukkit
                    * Block class that I know about, so I need to find a different way to get these NBT values
                    */
 
                    if (block instanceof TileEntityBlock) {
                        TileEntityBlock tileEntityBlock = block;
 
                        // Get the list of key/values from the block
                        CompoundTag rawTag = tileEntityBlock.getNbtData();
                        if (rawTag != null) {
                            Map<String, Tag> values = new HashMap<String, Tag>();
                            for (Entry<String, Tag> entry : rawTag.getValue().entrySet()) {
                                values.put(entry.getKey(), entry.getValue());
                            }
 
                            values.put("id", new StringTag("id", tileEntityBlock.getNbtId()));
                            values.put("x", new IntTag("x", x));
                            values.put("y", new IntTag("y", y));
                            values.put("z", new IntTag("z", z));
 
                            CompoundTag tileEntityTag = new CompoundTag("TileEntity", values);
                            tileEntities.add(tileEntityTag);
                        }
                    }
                }
            }
        }
 
        // The rest should be fine
 
        schematic.put("Blocks", new ByteArrayTag("Blocks", blocks));
        schematic.put("Data", new ByteArrayTag("Data", blockData));
        schematic.put("Entities", new ListTag("Entities", CompoundTag.class, new ArrayList<Tag>()));
        schematic.put("TileEntities", new ListTag("TileEntities", CompoundTag.class, tileEntities));
        if (addBlocks != null) {
            schematic.put("AddBlocks", new ByteArrayTag("AddBlocks", addBlocks));
        }
 
        // Build and output
        CompoundTag schematicTag = new CompoundTag("Schematic", schematic);
        NBTOutputStream stream = new NBTOutputStream(new FileOutputStream(file));
        stream.writeTag(schematicTag);
        stream.close();
    }

I really need help on this if anyone has any idea. I have been stuck on being able to save schematics for the longest time...

 

I made a library that allows you to get the NMS TileEntities really easily. After getting them you can just call the a(NBTTagCompound) to set the NBT Tags and the b(NBTTagCompound) to retrieve them. You can check it out if you want to use it: http://forums.bukkit.org/threads/li...leentities-and-other-things-with-ease.148257/

 

Why would Bukkit Hide classes like these?? >.>
It has been really hard to find good NBT libraries and documentation.
thanks btw!

 

I'm not sure why they wanted to hide it. Before they were hidden I was making a plugin that allowed you to directly edit the NBTTags of all TileEntities but then they stopped allowing us to be able to easily access them and that pissed me off and so I stopped making that. A little bit ago I needed to be able to change the title of a chest inventory but in order to do that I had to get the TileEntityChest from the NMS code however the CraftBukkit code doesn't allow for that so I spent a few hours trying to figure out a work around for it and I finally figured it out with the use of reflection, which is kind of sketchy but it works. I realized I could just do that for all of the TileEntity objects and then thought I probably wouldn't be the only person that wanted access to the TileEntities so I decided to make a library for it. I also added in infinite config generation to that because I knew people that wanted to do that also.

Anyways thanks, and feel free to either link into the plugin or just copy the files you want directly over from the source as long as you give me credit for it.

 

Would there be a way to get the NBT values of the TileEntity without checking for every kind of TileEntity?

I will most certainly give you credit if I use your code
Awesome work! its ridiculous that you had to use reflection though!

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

I was about to say no to that but then I realized that everything that is a TileEntity is a BlockState in the bukkit API so I'll just write up a method real quick to do that. Give my like 10 minutes.

 

Oh you're right! haha well you are very helpful! thanks!

 

Wow, I don't know why I wanted to use BlockStates when I could have just compared the bock materials but whatever. It's updated and now has a getGeneralTileEntity() method which just returns a base TileEntity object. It also doesn't throw the exception and it just returns null if the block at the sent in location isn't a TileEntity.

 

Awesome! Can you update your bitbukket repository with it too?

 

Sorry, I did but I accidentally had the link go to the previous version. It should be fixed now.

 

Wait.. I am stuck.
ok so I have this worldEdit code that I need to modify so that instead of using WorldEdit BaseBlock class, I use Bukkits Block class. Also, I have to use WorldEdits CompoundTag class because all of the NBT tag handling is done with world edit and I hate messing with NBT and bytes.
Here is the section of the Save method that I need to change. this is the original WorldEdit code:

Code:java

BaseBlock block = clipboard.getPoint(new BlockVector(x, y, z));
 
if (block instanceof TileEntityBlock) {
TileEntityBlock tileEntityBlock = block;
 
// Get the list of key/values from the block
CompoundTag rawTag = tileEntityBlock.getNbtData();
if (rawTag != null) {
Map<String, Tag> values = new HashMap<String, Tag>();
for (Entry<String, Tag> entry : rawTag.getValue().entrySet()) {
values.put(entry.getKey(), entry.getValue());
}
 
values.put("id", new StringTag("id", tileEntityBlock.getNbtId()));
values.put("x", new IntTag("x", x));
values.put("y", new IntTag("y", y));
values.put("z", new IntTag("z", z));
 
CompoundTag tileEntityTag = new CompoundTag("TileEntity", values);
tileEntities.add(tileEntityTag);
}
}

I need to change this code to use the Bukkit block variable as you see below:

Code:java

Location currentLoc = new Location(origin.getWorld(), origin.getBlockX() + x, origin.getBlockY() + y, origin.getBlockZ() + z);
Block block = currentLoc.getBlock();
 
if (block instanceof TileEntityBlock) {
TileEntityBlock tileEntityBlock = block;
 
// Get the list of key/values from the block
CompoundTag rawTag = tileEntityBlock.getNbtData();
if (rawTag != null) {
Map<String, Tag> values = new HashMap<String, Tag>();
for (Entry<String, Tag> entry : rawTag.getValue().entrySet()) {
values.put(entry.getKey(), entry.getValue());
}
 
values.put("id", new StringTag("id", tileEntityBlock.getNbtId()));
values.put("x", new IntTag("x", x));
values.put("y", new IntTag("y", y));
values.put("z", new IntTag("z", z));
 
CompoundTag tileEntityTag = new CompoundTag("TileEntity", values);
tileEntities.add(tileEntityTag);
}
}

So using your class, how could I get the NBTTagCompound? I have:
TileEntities.getGeneralTileEntity(currentLoc).b(nbttagcompound);
and how would I use this to replace "CompoundTag rawTag = tileEntityBlock.getNbtData();" in the worldEdit code? CompoundTag is a HashMap<String, Tag> I would need to convert it to that.
This hurts my head >.>

 

I'm not exactly sure what you are trying to do but to get the NBTTags for a TileEntity it would be something like this:

Code:

NBTTagCompound tag = new NBTTagCompound(); //Creates a blank tag compound
TileEntity te = TileEntities.getGeneralTileEntity(currentLoc); //Get's the TileEntity
if(te != null) te.b(tag); //Sets the tag's fields to that of the TileEntity

from there you can just call getType[eg.String, Int, Long, etc...](String name); to get the values in there. Depending on the TileEntity it has different NBTTags. You can check those out here.

NBTTags aren't actually as hard as you think. It's basically just a list of Objects.

 

How would I know what value to get? like when calling: .b(compound).get[getwhat??]
I am iterating through thousands of blocks and I dont know if one will be a TileEntity or not.
For example, if I want to get the NBT values for a chest which look something like:


how would I be able to get all of those lists?

 

If you call the c() method on it you get a collection of the values. A Collection is a type of List by the way.

Here's the code for NMS NBTTagCompounds if you want to look through it: https://github.com/Bukkit/mc-dev/blob/master/net/minecraft/server/NBTTagCompound.java

 

I know what a collection is haha. I am just really tired of trying to figure this out. thanks for your help though! I will get figure it out some time. At least I am now able to save a schematic with all the proper values except for TileEntities

 

Well I don't actually know many people that really use Collections, I've never actually used them before any ways. And for saving the NBTTags you would just go through the collection and get the value that corresponds to that and you would want to make sure that you don't get another NBTTagCompound or an NBTTagList. From there you would save it's value.

 

WOW. I found the problem! now I don't feel bad because the problem is WorldEdits problem. WorldEdit doesn't properly load the schematics TileEntities! I tried using worldEdit's load command and My own which is just the modified WorldEdit load method. I got the save method working and I checked the schematic files and the TileEntity entries are exactly how they should be with my modified WorldEdit Save method. Stupid WorldEdit >.>

anyway, Thank you so much for your help!

 

No problem