Get an int value from a string

I'm trying to make a PlayerDeathEvent where when a player dies, it gives the killer a set reward in the config. Here is my code:

Code:java

 
package me.signatured.moneyondeath;
 
import net.milkbowl.vault.economy.Economy;
import net.milkbowl.vault.economy.EconomyResponse;
 
import org.bukkit.ChatColor;
import org.bukkit.entity.Player;
import org.bukkit.event.EventHandler;
import org.bukkit.event.Listener;
import org.bukkit.event.entity.PlayerDeathEvent;
 
public class PlayerKillEvent implements Listener {
 
    SettingsManager settings = SettingsManager.getInstance();
    public static Economy econ = null;
 
    @SuppressWarnings("deprecation")
    @EventHandler
    public void onKill(PlayerDeathEvent e) {
 
        Player killed = e.getEntity();
 
        if (killed.isDead()) {
            Player killer = e.getEntity().getKiller();
 
            if (killer instanceof Player) {
 
                int reward = settings.getConfig().getInt("Money per kill");
                EconomyResponse r = econ.depositPlayer(killer.getName(), reward);
 
                if (r.transactionSuccess()) {
                    killer.sendMessage(ChatColor.AQUA + "Killing " + ChatColor.GOLD + killed + ChatColor.AQUA + " got you " + ChatColor.GREEN + reward);
                   killer.sendMessage(String.format(ChatColor.AQUA + "Killing " + ChatColor.GOLD + killed + ChatColor.AQUA + " got you " + "$" + "%s", econ.format(r.amount)));
                }
                else {
                   killer.sendMessage(String.format("An error occured: %s", r.errorMessage));
                }
            }
        }
    }
}
 

Here's my config:

Code:

Money per kill: 1

Here is the error I'm getting: http://paste.md-5.net/yubesolede.avrasm

Any idea why?

 

Show your settingsmanager class

 

Well, it's an NPE so I'd say either settings, settings.getConfig(), or settings.getConfig().getInt("Money per kill") is returning null. I'd try debugging each of those.

 

@SuperOriginal

Code:java

 
package me.signatured.moneyondeath;
 
import java.io.File;
import java.io.IOException;
 
import org.bukkit.Bukkit;
import org.bukkit.ChatColor;
import org.bukkit.configuration.file.FileConfiguration;
import org.bukkit.configuration.file.YamlConfiguration;
import org.bukkit.plugin.Plugin;
import org.bukkit.plugin.PluginDescriptionFile;
 
public class SettingsManager {
 
        private SettingsManager() { }
 
        static SettingsManager instance = new SettingsManager();
 
        public static SettingsManager getInstance() {
                return instance;
        }
 
        Plugin p;
 
        FileConfiguration config;
        File cfile;
 
        FileConfiguration data;
        File dfile;
 
        public void setup(Plugin p) {
                cfile = new File(p.getDataFolder(), "config.yml");
                config = p.getConfig();
                //config.options().copyDefaults(true);
                //saveConfig();
 
                if (!p.getDataFolder().exists()) {
                        p.getDataFolder().mkdir();
                }
 
                dfile = new File(p.getDataFolder(), "data.yml");
 
                if (!dfile.exists()) {
                        try {
                                dfile.createNewFile();
                        }
                        catch (IOException e) {
                                Bukkit.getServer().getLogger().severe(ChatColor.RED + "Could not create data.yml!");
                        }
                }
 
                data = YamlConfiguration.loadConfiguration(dfile);
        }
 
        public FileConfiguration getData() {
                return data;
        }
 
        public void saveData() {
                try {
                        data.save(dfile);
                }
                catch (IOException e) {
                        Bukkit.getServer().getLogger().severe(ChatColor.RED + "Could not save data.yml!");
                }
        }
 
        public void reloadData() {
                data = YamlConfiguration.loadConfiguration(dfile);
        }
 
        public FileConfiguration getConfig() {
                return config;
        }
 
        public void saveConfig() {
                try {
                        config.save(cfile);
                }
                catch (IOException e) {
                        Bukkit.getServer().getLogger().severe(ChatColor.RED + "Could not save config.yml!");
                }
        }
 
        public void reloadConfig() {
            data = YamlConfiguration.loadConfiguration(cfile);
    }
 
        public PluginDescriptionFile getDesc() {
                return p.getDescription();
        }
}
 

 

@Signatured Get rid of your setup method. That completely defeats the purpose of a constructor.

 

Thanks for the tip, removed the setup method. Happen to know why I'm getting the error I posted?

 

@Signatured Post the new class. 'getConfig()' was returning null because you were never invoking 'setup()'

 

@Skionz

Code:java

 
package me.signatured.moneyondeath;
 
import net.milkbowl.vault.economy.Economy;
 
import org.bukkit.Bukkit;
import org.bukkit.plugin.RegisteredServiceProvider;
import org.bukkit.plugin.java.JavaPlugin;
 
public class MoneyOnDeath extends JavaPlugin {
 
    SettingsManager settings = SettingsManager.getInstance();
    public static Economy econ = null;
 
    public void onEnable() {
        if (!setupEconomy() ) {
            getLogger().severe(String.format("[%s] - Disabled due to no Vault dependency found!", getDescription().getName()));
            getServer().getPluginManager().disablePlugin(this);
            return;
        }
 
        saveDefaultConfig();
        Bukkit.getServer().getPluginManager().registerEvents(new PlayerKillEvent(), this);
    }
 
    private boolean setupEconomy() {
        if (getServer().getPluginManager().getPlugin("Vault") == null) {
            return false;
        }
        RegisteredServiceProvider<Economy> rsp = getServer().getServicesManager().getRegistration(Economy.class);
        if (rsp == null) {
            return false;
        }
        econ = rsp.getProvider();
        return econ != null;
    }
}