Solved EventHandler in Main class

Is it possible to get my Player player = (Player) event.getWhoClicked(); from my eventhandler class to my main class?

Code:java

package me.bd.chest;
 
import org.bukkit.entity.Player;
import org.bukkit.event.EventHandler;
import org.bukkit.event.Listener;
import org.bukkit.event.inventory.InventoryClickEvent;
import org.bukkit.inventory.Inventory;
import org.bukkit.inventory.ItemStack;
 
public class ChestEvent implements Listener {
    public ChestEvent(Chest plugin) {
        plugin.getServer().getPluginManager().registerEvents(this, plugin);
 
    }
 
    @EventHandler
    public static void onInventoryClick(InventoryClickEvent event) {
        Player player = (Player) event.getWhoClicked();
        ItemStack clicked = event.getCurrentItem();
        Inventory inventory = event.getInventory();
 
    }
 
 
}
 

Code:java

package me.bd.chest;
 
import org.bukkit.Bukkit;
import org.bukkit.ChatColor;
import org.bukkit.Material;
import org.bukkit.command.Command;
import org.bukkit.command.CommandSender;
import org.bukkit.entity.Player;
import org.bukkit.inventory.Inventory;
import org.bukkit.inventory.ItemStack;
import org.bukkit.plugin.java.JavaPlugin;
 
public class Chest extends JavaPlugin {
    public static Chest plugin;
 
    @Override
    public void onDisable() {
 
    }
 
    @Override
    public void onEnable() {
        new ChestEvent(this);
 
    }
 
    public boolean onCommand(CommandSender sender, Command cmd, String commandLabel, String[] args) {
 
        if(!(sender instanceof Player)) {
                sender.sendMessage(ChatColor.YELLOW + "The console cannot use this command!");
                return true;               
        }
 
        Inventory Chest = Bukkit.createInventory(null, 9, "Getting Wood Achievement Prize!");
 
        Chest.setItem(2, new ItemStack(Material.COOKED_BEEF))
        Chest.setItem(5, new ItemStack(Material.WOOD_SWORD));
        Chest.setItem(8, new ItemStack(Material.FISHING_ROD));
 
        if(cmd.getName().equalsIgnoreCase("wood")) {
 
 
        }
        return false;
 
        }
        }
 

 

What exactly are you trying to do? Additionally, why are you registering your event in your Listener class?

 

I'm trying to do when the player write wood! It will open my custom chest! With the three items inside! When he clicks one of them it will close the inventory... give him the items I specify and done!

 

Why not? You can register events anywhere in the code if you provide the method with the correct arguments.

BurnerDiamond It's best to handle the event in the method (or methods) that it is called in. To answer your question, you'll need to use setters and/or getters to put the player who clicked in another class.

 

So what is the issue?

I would try using this:

Code:java

package me.bd.chest;
 
import org.bukkit.Bukkit;
import org.bukkit.ChatColor;
import org.bukkit.Material;
import org.bukkit.command.Command;
import org.bukkit.command.CommandSender;
import org.bukkit.entity.Player;
import org.bukkit.inventory.Inventory;
import org.bukkit.inventory.ItemStack;
import org.bukkit.plugin.java.JavaPlugin;
 
public class Chest extends JavaPlugin {
    public static Chest plugin;
 
    @Override
    public void onDisable() {
 
    }
 
    @Override
    public void onEnable() {
        new ChestEvent(this);
 
    }
 
    public boolean onCommand(CommandSender sender, Command cmd, String commandLabel, String[] args) {
 
    if (commandLabel.equalsIgnoreCase("wood") {
        if(!(sender instanceof Player)) {
                sender.sendMessage(ChatColor.YELLOW + "The console cannot use this command!");
                return true;             
        }
 
        Inventory Chest = Bukkit.createInventory(null, 9, "Getting Wood Achievement Prize!");
 
        Chest.setItem(2, new ItemStack(Material.COOKED_BEEF))
        Chest.setItem(5, new ItemStack(Material.WOOD_SWORD));
        Chest.setItem(8, new ItemStack(Material.FISHING_ROD));
        return false;
 
        }
        }
        }
 

 

Can I have two player kinds in the same class?

Player p = (Player) sender;
Player player =(Player) event.getWhoClicked();

 

It is generally a good habit to register events in the onEnable(). teej107

 

StaticJava

The problem is I need a player sender and a player event!

 

BurnerDiamond Your Player player = (Player) sender is for your command, if you want to check the player from the event then you can do things such as running a method to give them something, you can add to a list and check it later ect.

 

StaticJava

It's also a bad habit to have a public static reference to your plugin in your JavaPlugin class. I don't see how you could go around telling anyone about habits.

teej107 is right, it absolutely does not matter where you put it, as long as you're consistent and organized with what you do.

 

Could I have an example? Im failing to understand bwfcwalshy

 

I never had a public static reference...? I copied his code and just rearranged things. mythbusterma

 

BurnerDiamond Well check if a player clicks x then run a method such as giveADiamond(player) then your code for that could be

Code:java

public void giveADiamond(Player player){
    player.getInventory().addItem(new ItemStack(Material.DIAMOND));
}

So it would add a diamond to the player who clicked x.

 

And what makes it a good habit?
BurnerDiamond What exactly are you attempting to create (your description thus far is a tad vague)

 

StaticJava

Oh, I guess it was in his code.

 

I want to...

If a guy writes the command wood!
Open my personal chest called ".........."
With my personal items
On the event he clicks wood sword
I want to close the inventory
Give him items
Done

 

I'm not exactly sure what you're trying to do, but for starters, this may improve the code:

Code:java

package me.bd.chest;
 
import org.bukkit.Bukkit;
import org.bukkit.ChatColor;
import org.bukkit.Material;
import org.bukkit.command.Command;
import org.bukkit.command.CommandSender;
import org.bukkit.entity.Player;
import org.bukkit.inventory.Inventory;
import org.bukkit.inventory.ItemStack;
import org.bukkit.plugin.java.JavaPlugin;
 
public class Chest extends JavaPlugin {
public static Chest plugin;
 
@Override
public void onEnable() {
getServer().getPluginManager().registerEvents(new ChestEvent(), this);
}
 
@Override
public void onDisable() {
 
}
 
public boolean onCommand(CommandSender sender, Command cmd, String commandLabel, String[] args) {
 
if (commandLabel.equalsIgnoreCase("wood")) {
if(!(sender instanceof Player)) {
sender.sendMessage(ChatColor.YELLOW + "The console cannot use this command!");
return true;
}
 
Inventory Chest = Bukkit.createInventory(null, 9, "Getting Wood Achievement Prize!");
 
Chest.setItem(2, new ItemStack(Material.COOKED_BEEF))
Chest.setItem(5, new ItemStack(Material.WOOD_SWORD));
Chest.setItem(8, new ItemStack(Material.FISHING_ROD));
return false;
}
}
}
 

Code:java

package me.bd.chest;
 
import org.bukkit.entity.HumanEntity;
import org.bukkit.entity.Player;
import org.bukkit.event.EventHandler;
import org.bukkit.event.Listener;
import org.bukkit.event.inventory.InventoryClickEvent;
import org.bukkit.inventory.Inventory;
import org.bukkit.inventory.ItemStack;
 
public class ChestEvent implements Listener {
 
@EventHandler
public void onInventoryClick(InventoryClickEvent event) {
HumanEntity he = event.getWhoClicked();
if (he instanceof Player) {
Player player = (Player) he;
}
 
ItemStack clicked = event.getCurrentItem();
Inventory inventory = event.getInventory();
 
//finish your method
}
 
 
}

EDIT: Additionally, why are you creating a new instance of Inventory every time /wood is called? I would make one universal inventory in the onEnable and open that.

 

StaticJava You never opened the inventory there you just made it.

 

When the inventory is opened!!!
AND THE PLAYER CLICKS ONE OF THE ITEMS IN IT!
Give him a certain set of items!

I KNOW THAT but once I opened the inventory how would I check the play who clicked the sword?

<Edited by bwfcwalshy: Merged posts, please use the edit button rather than double posting.>

Sorry!

Okay I now have a p.openInventory!

I now want to check what he clicks!

If he clicks the wood sword I want to close the inventory and give him a wood sword!

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

Ok, I won't code the whole thing for you, but this is what you want to do:

Code:java

package me.bd.chest;
 
import org.bukkit.Bukkit;
import org.bukkit.ChatColor;
import org.bukkit.Material;
import org.bukkit.command.Command;
import org.bukkit.command.CommandSender;
import org.bukkit.entity.Player;
import org.bukkit.inventory.Inventory;
import org.bukkit.inventory.ItemStack;
import org.bukkit.plugin.java.JavaPlugin;
 
public class Chest extends JavaPlugin {
    private Inventory chest;
 
    @Override
    public void onEnable() {
        getServer().getPluginManager().registerEvents(new ChestEvent(), this);
        chest = Bukkit.createInventory(null, 9, "Getting Wood Achievement Prize!");
        chest.setItem(2, new ItemStack(Material.COOKED_BEEF));
        chest.setItem(5, new ItemStack(Material.WOOD_SWORD));
        chest.setItem(8, new ItemStack(Material.FISHING_ROD));
    }
 
    @Override
    public void onDisable() {
 
    }
 
    public boolean onCommand(CommandSender sender, Command cmd, String commandLabel, String[] args) {
        if (commandLabel.equalsIgnoreCase("wood")) {
            if(!(sender instanceof Player)) {
                sender.sendMessage(ChatColor.YELLOW + "The console cannot use this command!");
                return true;           
            } else {
                Player player = (Player) sender;
                player.openInventory(chest);
                return true;
            }
        }
        return false;
    }
}
 

Code:java

package me.bd.chest;
 
import org.bukkit.Material;
import org.bukkit.entity.HumanEntity;
import org.bukkit.entity.Player;
import org.bukkit.event.EventHandler;
import org.bukkit.event.Listener;
import org.bukkit.event.inventory.InventoryClickEvent;
import org.bukkit.inventory.Inventory;
import org.bukkit.inventory.ItemStack;
 
public class ChestEvent implements Listener {
 
    @EventHandler
    public void onInventoryClick(InventoryClickEvent event) {
        HumanEntity he = event.getWhoClicked();
        if (he instanceof Player) {
            Player player = (Player) he;
            Inventory inv = event.getInventory();
            if (inv != null) {
                if (inv.getName().equals("Getting Wood Achievement Prize!")) {
                    if (event.getCurrentItem() != null) {
                        ItemStack is = event.getCurrentItem();
                        if (is.getType() == Material.WOOD_SWORD) {
                            player.closeInventory();
                            //finish your code
                        }
                    }
                }
            }
        }
    }
 
 
}

 

Okay but can I ask you one thing? it opens the player chest right? And then it automatically goes on to the chestevent to check if any of the things I write are true?? StaticJava

 

In the event class I coded above, where I have the comment, you will want to add the item to the player's inventory. BurnerDiamond Yes, that is what is happening.

 

Got to love coding! Sorry but why but the chest in the onEnable?

 

BurnerDiamond You were creating a new Inventory instance EVERY time a player used the command, which isn't a good practice and can cause memory problems. I just created one universal inventory in the onEnable.

 

GEnIUS!!!

 

BurnerDiamond On a side note, you may want to use the period punctuation mark (.) instead of the exclamation point(!) if you don't want to come across as yelling or exclaiming something

 

BurnerDiamond Thanks!