[ECON] ChestShop 3.7.18 (iConomyChestShop) - Chest&sign shop for economy plugins [1.8]

Discussion in 'Archived: Plugin Releases' started by Acrobot, Feb 12, 2011.

  1. Offline

    Acrobot

    An easy way to create shops - no protection plugin needed!
    You don't need to be on-line to earn money anymore!
    [​IMG]
    I've put a LOT of effort into making this plugin,
    you can donate if you appreciate my effort =)

    Requirements:
    - An economy plugin supported by Register or Vault, for example iConomy, BOSEconomy or Essentials Eco.
    Optional:
    - For additional economy plugin support - Vault
    - For Permissions: bPermissions, PEX, or any other permission plugin
    - For additional protection: LWC, Lockette, Deadbolt
    - For other item names (aliases): OddItem


    Setup:
    Copy the .jar file from the .zip you downloaded into /plugins folder.
    You can also copy the example files if you want to generate statistics page.

    Translations:
    You can change the plugin's language, here's a list of all user-made translations.
    If you want to update or submit a translation, feel free to PM me.
    Translations (open)

    Arabic - Attarhsase2
    Bulgarian - Muff1Ncho
    Czech - LordPgsa
    Chinese (Simplified) - tab415263
    Danish - Cannafix
    Dutch - speedlegs
    French- DragonSlayer875
    German - RasCas
    Hungarian - Anachen
    Indonesian - Yahya98
    Italian - Massimo1993
    Korean - Zwing87
    Norwegian - _AlexN_ and TheUnkownGamer
    Polish - Holls1
    Portugese (Brasil) - FelipeMarques14
    Russian - VADemon from http://minemania.ru/
    Slovak - LordPgsa
    Slovenian - jEErc
    Spanish - thxaaaa
    Swedish - Maxell
    Turkish - Developer
    Traditional Chinese - hellboyincs
    Vietnamese - etrubi1 from http://minevn.com/


    Permissions:
    How to create a ChestShop?
    - Place a chest, if you haven't already.
    - Place a sign 1 block near the chest (for example, above the chest)
    - On the sign, write:

    [​IMG]
    (Item name can actually be item ID or alias)
    First line will be filled in by the plugin automatically.
    Price is a combination of buy and sell price.
    You have to have B near buy price (people buy from you), and S near sell price (people sell to you).
    If you have both B and S, separate them with a colon - :
    For example:
    [​IMG]

    means that AcrobotPL wants to sell 64 diamonds for 10 currency, and buy them back from you for 5 currency.
    Also, if you put "free" instead of price, it is free to buy or sell :)

    - Now, when you finish editing the sign, if LWC is turned on in config, shop will be automatically created.
    Also, if your default protection is turned on in the config, people won't be able to break chest, sign or the block the sign is on.

    What is an Admin Shop?
    Admin shop is the shop that doesn't require a chest, because it has infinite stock.
    If you sell to it, the items will disappear, and if you buy from it, items will magically appear.
    To create one, you have to be Admin/OP. Just put "Admin Shop" (or anything specified in config file) on the first line of the sign.

    Restricting shops to some groups or regions
    You can either use permissions, or you can just put a sign ABOVE shop sign (you need to be in that group to create the sign) to restrict it to players with ChestShop.group.groupName permission
    The syntax is:
    [restricted]
    firstGroupName
    2ndGroupName
    3rdGroupName
    Only those groups will be able to use that shop

    To restrict a shop to some regions:
    - If you're using Towny, turn TOWNY_INTEGRATION on. Residents will be able to create shops in economy plots (either their or, if specified in config, any)
    - If you're using WorldGuard, you can use an experimental "chestshop" flag. Turn WORLDGUARD_INTEGRATION on and flag a region. (f.e. /region flag ChestShopRegion chestshop allow)

    Do you want to limit the maximum prices for items?
    Well, there's an app.... wait, not that : P
    You can use an experimental feature in ChestShop.
    In your config.yml, add lines like:
    max-buy-price-5: 14
    max-sell-price-5: 15

    That means that the maximum price for items BOUGHT by PLAYER is 14, and items SOLD by PLAYER using the shop is 15.

    You can also use a global setting, like this:
    max-sell-price: 200

    That means that the maximum price for items SOLD to PLAYER is 200 (if there is, for example, a max-sell-price-5 found, it will be used instead of the global sell price)

    USING SHOPS
    You could buy and sell by right and left clicking the sign for a long time.
    Now it's the only way to use the shops.
    It's SIMPLE!
    Just LEFT-CLICK to SELL to shop, and
    RIGHT-CLICK to BUY from shop.
    (This can be changed in the config file)

    DESTROYING SHOPS
    If you want to delete your old shop, simply SNEAK and destroy the sign.
    It's that easy =)

    STOCKING THE SHOPS
    You can either open the chest and stock it up, or click on your own sign - it will open chest's inventory (that way you can have chests not openable by other people for sure :D)

    ItemInfo command
    It's a simple command that shows item information.
    If you use it without any arguments, it shows you information about the item you're holding.
    If you specify item id or item name after the command, it will show you information about that item.

    Source code
    ChestShop is Open-Source =)
    You can find its code on https://github.com/Acrobot/ChestShop-3


    Thanks to:
    - kali876, ziomekYOYO and Herocraft server for testing the plugin and finding every little bug =)
    - Everyone who uses this plugin - really big thanks for this, I never thought it will be so popular
    - Everyone who provided translation - many people's lives will be easier now
    - @Nijikokun for Register
    - @LennardF1989 for awesome Persistence Reimplemented
    - @Temaska for fixing the plugin while I was on holidays
    - @VADemon for providing a great support for other users
    - @Euthyphro for his patience and really good bug spotting
    - vagrant326 for making a great price sheet
    - Epics for his great help
    :)
    If something's not working
    You can't change the sign color - that breaks the formatting.
    If that's not the issue, please give me this information, so I can help you faster.
    - CraftBukkit version (type /version in chat)
    - ChestShop version (type /csversion in chat)
    - Your economy plugin (iConomy? BOSEconomy? other one?)
    - Have you got any Permission plugin? Which one?

    [​IMG]
    Changelog (open)

    Changelog can be found on BukkitDev - http://dev.bukkit.org/server-mods/chestshop/files/
     
  2. Offline

    Tordur

    Did you update to iConomy version 5?
     
  3. Offline

    SleepyPrince

    I was selling a full inventory of 64 cobblestone (4*9*64 = 2304) to an admin shop
    StockAmount 20
    B 20:15 S
    I kept clicking the sign until it shows I dont have enough items to sell
    then I realized something is weird, I sold ALL my cobblestones which are not dividable by 20
    then I tested it again and I found that I got a lot less money then I am suppose to have when selling them

    I went through the source code and I found this in Basic.java
    In "removeItemStackFromInventory"
    if (curItem.getAmount() > left) {
    curItem.setAmount(curItem.getAmount() - left);
    left -= curItem.getAmount();
    } else {
    left -= curItem.getAmount();
    curItem = null;
    }

    The 2 lines shall be reversed!
    every time when you have more than 1 stack of the item and the first stack has less than '2 x StockAmount ' and you sell it, it will deduct more than it should!

    I have been scammed!!! (just joking :p)
    hope the developer can fix this major bug as soon as possible.
     
  4. Offline

    bluejack404

    <333333!!!

    It works. Perfectly. :)
     
  5. Offline

    Syntaxlb

    Hi,

    can you create a new node permission ?

    iConomyChestShop.shop.sellToUser => Allow to sell to user (who have iConomyChestShop.shop.buy or iConomyChestShop.shop.sell)
     
  6. Offline

    Wizbaggd

    this works great and all, however if you have a bunch of mods on the server that use signs, this starts barging in and takes over. Is there any way to disable the damned thing from removing a perfectly working sign for RedstoneChips just because it's not in iConomyChestShop syntax...
     
  7. Offline

    Acrobot

    @Syntaxlb
    What do you mean by "allow to sell to user"? Do you mean creating shops?

    @Wizbaggd
    Thanks, I will try to make it more flexible.
    (Or add a permission/setting to disable it)
     
  8. Offline

    Wizbaggd

    that'd be nice :) thanks man. Sorry if that came across the wrong way, I love the mod, just frustrated I can't make a clock with RedstoneChips on my server until we can figure a way around the issue :p


    EDIT: by "we" I mean... I will keep trying it on any updates until it works, hoping you figure it out :p
     
  9. Offline

    Syntaxlb


    No, i mean if the user have "iConomyChestShop.shop.sellToUser", other user can use his shop.
    But they can't use a shop of another user who doesn't have "iConomyChestShop.shop.sellToUser"


    Exemple: If a user have "iConomyChestShop.shop.shop", he can create a shop, ok. But he can't even sell because he doesn't have "iConomyChestShop.shop.sellToUser"

    Why i need this ?

    In my permission file, i have a group "Trader", and "Default"
    Trader got "iConomyChestShop.shop.create"
    and Default got "iConomyChestShop.shop.sell" and "iConomyChestShop.shop.buy"

    When i move a user in "Trader" group, he can create a shop, ok.
    But if i want to move him in "Default" group, his shops can still be used, then he is no longer trader :\
    I wish his shops are disabled.
     
  10. Offline

    William Hall

    I added all the permissions and when i make a shop nothing happens?
     
  11. Using Iteminfo on Lapis Lazuli gives:
    351:4 - INK_SACK
    .. which isnt right :)
     
  12. Offline

    nathanaelps

    I bet somebody else has asked this... Sometime... in the past 65 pages of posts. Sorry if you've answered it already, my ADD kicked in after the first twelve pages.

    I have created an Admin Shop with the desire that it will purchase any color of wool:

    Admin Shop
    8
    5:3
    35

    It purchases 35:0 just fine, (That's white wool, for the people who don't memorize the data values) but it fails completely to purchase, say, 35:10 (Purple!). Knowing that Minecraft uses damage values for wool color, I thought that perhaps it just wasn't wanting to purchase DAMAGED wool, so I set

    allowUsedItemsToBeSold: true

    And... it *still* fails completely to purchase, say, 35:10.

    Is there some prettier way to make this work than to create an entire array of shops, one for each color?
     
  13. Offline

    Acrobot

  14. Is it not possible for the command to detect damage value aswell? Compare Item ID and damage value to figure out which Dye it is? For instance, if item ID matches any multi-item like wool or dye it would check damage value to figure out which one it is.
     
  15. Offline

    Acrobot

    @Sorken
    I do not like doing that, because every MC update I would have to change that.
     
  16. Offline

    Syntaxlb

    @Acrobot

    Sorry, i think you have not see my post :)

     
  17. Offline

    Bharel

    @Acrobot
    I have a chest, and a sign above it. Just like in the tut video, but it still says the same thing...
     
  18. Offline

    Acrobot

    @Syntaxlb
    I did, but I see it's not really that possible with Permissions :/
    I would have to pass Player object to Permissions, and if player is offline I can't do it :/

    @Bharel
    Paste your config.yml on pastebin.com
     
  19. Offline

    Bharel

  20. Offline

    Acrobot

    @Bharel
    Hmm... That's really weird... Could you send me a screenshot of when you are writing on the sign?
     
  21. Offline

    Bharel

    @Acrobot
    Sure thing, uploading
     
  22. Offline

    Bharel

  23. Offline

    Spl1tz

    How can i sell Mossycobblestones if the name doesn't fit on the sign? Tried the ID and it doesn't fit either...
     
  24. Offline

    William Hall

    Well when i right click a sign it just says no economy plugin found but i have iconomy...?
     
  25. Offline

    Acrobot

    @Spl1tz
    "MOSSY" or any other partial name.

    @William Hall
    You either have iConomy 4 and iConomyChestShop for iConomy 5, or iConomy 5 and iConomyChestShop for iConomy 4.

    @Bharel
    Hmm, that's really weird o.0
    It actually works for me.
    Try:
    • setting up shop in different place (Bukkit bugs, really weird)
    • re-downloading the plugin, if it's corrupted (somehow)
    If it's the first one, I can't help it :/
     
  26. Offline

    nathanaelps

    So it's a no-go for my

    Admin Shop
    8
    5:3
    Wool:Any

    Oh, well. I'll just create a whole wall dedicated to colored wool, I guess. Thanks.
     
  27. Offline

    William Hall

    But i only just got chestshop and i got Iconomy at most a week ago... so surely it should all be up to date? And also NPC traders was working with Iconomy
     
  28. Offline

    Acrobot

    @William Hall
    Type in "/money ?" in chat, and tell me the name of iConomy.
     
  29. Offline

    Wizbaggd

    this might be a really stupid basic question but I don;t mind being the one to ask it... do you have either iConomy or BOSEconomy installed? Gotta also make sure the jar file is in place... Other than that, check to make sure there isn't a plugin conflict (the way I personally test that is having two bukkit directories, a vanilla bukkit install with no mods and my main running one. Any time I upgrade/test new mods, test it on the vanilla backup first with the bare minimums for the mod to work, then once you have confirmed it's working, start adding new mods in one at a time until you find a conflict or problem.
     
  30. Offline

    Wizbaggd


    You sir, are full of win.
     
  31. Offline

    MineralMC

    Getting a "Seller's account doesn't exist!" error. Any ideas, Acro?
     

Share This Page