Solved Disable crafting items with sertain lore?

So i have made a code but it's not working, coud anyone say why that would be?

Here is the code.

Code:java

    @EventHandler
    public void onPlayerCraft(PrepareItemCraftEvent event) {
        HumanEntity human =  event.getView().getPlayer();
        ItemStack item = event.getRecipe().getResult();
 
        if(human instanceof Player) {
            Player player = (Player)human;
 
            if(item.getItemMeta().getLore() != null) {
                if(item.getItemMeta().getLore().get(0).equalsIgnoreCase("§7Daiktas paimtas iš /item!")) {
                    player.sendMessage("§cNegalite craftinti su daiktais iš /item.");
                    event.getInventory().setResult(null);
                }
            }
        }
    }

 

Nojus Maybe you could be more specific than just, 'not working'. Is it giving a stack trace? What is / isn't it specifically doing that you don't want?

 

Maurdekye
I wan't it to do if i place an item in workbench that has lore: "§7Daiktas paimtas iš /item!" then the player can't craft anything with that item.

 

You need to listen for a CraftItemEvent, and check every item involved in the recipe. If one of them has that lore, then cancel the event.

 

Nojus you have to check the items in the 9 slots, not the one in the result slot. It might even be better to listen for the InventoryClickEvent, where you would check if the target inventory is a workbench and the item being moved has the lore.

 

fireblast709 Your idea would probably be more intuitive for players to figure out, but would be harder to code and may not be as stable.

 

I made this

Code:java

 @EventHandler
public void onPlayerCraft(CraftItemEvent event) {
for (HumanEntity entity : event.getViewers()) {
if (entity instanceof Player) {
Player player = (Player) entity;
ItemStack[] item = event.getInventory().getMatrix();
 
if(item[0].getItemMeta().getLore().get(0).equalsIgnoreCase("§7Daiktas paimtas iš /item!")) {
event.setCancelled(true);
player.sendMessage("§cNegalite craftint daiktų paimtų iš /item.");
}
}
}
}

but it only works if item is in slot 0 of crafting table and i dont wan't to do something like

Code:

item[0].getItemMeta().getLore().get(0).equalsIgnoreCase("§7Daiktas paimtas iš /item!") || item[1].getItemMeta().getLore().get(0).equalsIgnoreCase("§7Daiktas paimtas iš /item!")

could someone help ?

 

Nojus You're looking for the magic of loops.

 

I get the error if i craft the item in other slot.

Code:text

[16:03:52] [Server thread/ERROR]: Could not pass event CraftItemEvent to MegaVIPitems v1.5
org.bukkit.event.EventException
    at org.bukkit.plugin.java.JavaPluginLoader$1.execute(JavaPluginLoader.java:294) ~[spigot.jar:git-Spigot-1468]
    at org.bukkit.plugin.RegisteredListener.callEvent(RegisteredListener.java:62) ~[spigot.jar:git-Spigot-1468]
    at org.bukkit.plugin.TimedRegisteredListener.callEvent(TimedRegisteredListener.java:30) ~[spigot.jar:git-Spigot-1468]
    at org.bukkit.plugin.SimplePluginManager.fireEvent(SimplePluginManager.java:502) [spigot.jar:git-Spigot-1468]
    at org.bukkit.plugin.SimplePluginManager.callEvent(SimplePluginManager.java:487) [spigot.jar:git-Spigot-1468]
    at net.minecraft.server.v1_7_R3.PlayerConnection.a(PlayerConnection.java:1403) [spigot.jar:git-Spigot-1468]
    at net.minecraft.server.v1_7_R3.PacketPlayInWindowClick.a(SourceFile:32) [spigot.jar:git-Spigot-1468]
    at net.minecraft.server.v1_7_R3.PacketPlayInWindowClick.handle(SourceFile:10) [spigot.jar:git-Spigot-1468]
    at net.minecraft.server.v1_7_R3.NetworkManager.a(NetworkManager.java:180) [spigot.jar:git-Spigot-1468]
    at net.minecraft.server.v1_7_R3.ServerConnection.c(ServerConnection.java:81) [spigot.jar:git-Spigot-1468]
    at net.minecraft.server.v1_7_R3.MinecraftServer.v(MinecraftServer.java:713) [spigot.jar:git-Spigot-1468]
    at net.minecraft.server.v1_7_R3.DedicatedServer.v(DedicatedServer.java:283) [spigot.jar:git-Spigot-1468]
    at net.minecraft.server.v1_7_R3.MinecraftServer.u(MinecraftServer.java:576) [spigot.jar:git-Spigot-1468]
    at net.minecraft.server.v1_7_R3.MinecraftServer.run(MinecraftServer.java:482) [spigot.jar:git-Spigot-1468]
    at net.minecraft.server.v1_7_R3.ThreadServerApplication.run(SourceFile:628) [spigot.jar:git-Spigot-1468]
Caused by: java.lang.NullPointerException
    at main.main.onPlayerCraft(main.java:74) ~[?:?]
    at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) ~[?:1.7.0_51]
    at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source) ~[?:1.7.0_51]
    at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source) ~[?:1.7.0_51]
    at java.lang.reflect.Method.invoke(Unknown Source) ~[?:1.7.0_51]
    at org.bukkit.plugin.java.JavaPluginLoader$1.execute(JavaPluginLoader.java:292) ~[spigot.jar:git-Spigot-1468]
    ... 14 more

 

Nojus Line 74 - something is null

 

AdamQpzm

Code:java

if(item[i].getItemMeta().getLore().get(0).equalsIgnoreCase("§7Daiktas paimtas iš /item!")) {[/i]

this is that line.

 

Nojus Yes, I assumed as much. Out of interest, can I see the updated code? Also, you'll encounter a problem if there isn't an item in that slot, or if there is an item in that slot without lore. As these result in null, you'll have to check if they're null first.

 

AdamQpzm

Code:java

    @EventHandler
    public void onPlayerCraft(CraftItemEvent event) {
        for (HumanEntity entity : event.getViewers()) {
            if (entity instanceof Player) {
                Player player = (Player) entity;
                ItemStack[] item = event.getInventory().getMatrix();
 
                for(int i =0; i < 8; i++)
                {
                    if(item[i].getItemMeta().getLore().contains("§7Daiktas paimtas iš /item!")) {
                        event.setCancelled(true);
                        player.sendMessage("§cNegalite craftint daiktų paimtų iš /item.");
                    }
                }
            }
        }
    }[/i]

here is the updated code.

 

Nojus Not too bad, although a couple of suggestions I have is to check for nulls, and you should add a return statement after the sending of the message - you already know it's cancelled so no point continuing searching for the item, right?

 

AdamQpzm i fixed it. needed to add

Code:

if(item[i].getItemMeta() != null) {