Solved Commands and Events doesn't work how i wan't it .

Code:java

@EventHandler
 
      public void onPlayerCommandWrite(PlayerCommandPreprocessEvent event) {
        Player player = event.getPlayer(); {
                if (player.performCommand("before")) {
 
            }
            {
          }         
              event.getPlayer().getInventory().contains(new ItemStack(Material.GOLD_BLOCK));
              event.getPlayer().getInventory().removeItem(new ItemStack[] { new ItemStack(Material.GOLD_BLOCK, 1) });
              event.getPlayer().getInventory().addItem(new ItemStack[] { new ItemStack(Material.GOLD_INGOT, 9) });         
              event.getPlayer().sendMessage(ChatColor.DARK_GREEN + "TEST MESSAGE"); }
 
              }
 
 
              }

I made a plugin when you /before it woudl change 1 gold into 9 gold ingots everything works but it works on every command out there.

For an example if i write /before it works how it suppose to be
but if I write /day ,/spawn every existing command this will still work and give the player the 9 gold ingots even if he dont have the gold block he will get the it any help?

 

You do not check IF he has a Gold Block. its not in an if-clause.. you just remove it without checking if it is there. you give them items without checking if the 2 before were true.. you do that stuff no matter what they use as command

So go ahaed and check your brackets and use more if statements

 

L33m4n123 I'm a noob in this can you give a example ?

 

FightManiac
If statements are the basics of Java.... Which you SHOULD by now know already.

 

You need to implement a if statement that "checks" if he has a gold block in his inventory. In addition, there are several other mistakes inside of this code. I will disregard this mistakes as if you are a newbie to this. Here is the code rewritten:

Code:java

public boolean onCommand(CommandSender sender, Command command, String commandLabel, String args){
    if(Sender instanceof Player){
        Player player = (Player) sender;
 
        if(commandLabel.equalsIgnoreCase("before"){
            Inventory playerInventory = player.getInventory();
 
            if(playerInventory.contains(MATERIAL.GOLD_BLOCK){
 
                playerInventory.removeItem(MATERIAL.GOLD_BLOCK, 1);
                                playerInventory.addItem(MATERIAL.GOLD_INGOT, 9);
            }
        }
    }
    return false;
}

I apologize in advanced I was not able to do this in my compiler I did it in notepad. The "adding" & "removing" of the items may be off. Also, you should watch some Java Tutorials instead of Bukkit Programming Tutorials because they lack to give you good base of the basics of Java.

 

I know i will now start learning Java but it's not working what I did wrong?

Code:java

 public boolean onCommand(CommandSender sender, Command command, String commandLabel, String args){
if(sender instanceof Player){
Player player = (Player) sender;
 
if(commandLabel.equalsIgnoreCase("before")){
Inventory playerInventory = player.getInventory();
 
if(player.getInventory().contains(Material.GOLD_BLOCK)){
 
player.getInventory().removeItem(new ItemStack[] { new ItemStack(Material.GOLD_BLOCK, 1) });
player.getInventory().addItem(new ItemStack[] { new ItemStack(Material.GOLD_INGOT, 9) });
}
}
}
return false;
}
}

 

Here are your problems:

• Your way of having the console recognize your command is quite abstract. (Not really a problem but it bothers me)
• You obviously do not understand how a stand a "IF" statement works, which means you do not understand the BASIS of any programming language.

 

Well i admit it. Il start learning Java after this but can anyone help me?
If this plugin will work i will understand how to do better things

xTrollxDudex My friend told your a good dev maybe you can help?


EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

FightManiac
Whats your issue? What's not working?

 

xTrollxDudex when i write the command its told there no command like this.
and there is an error in this line:
PlayerInventory Inventory= player.getInventory();
That i dont use the "inventory"

Note i have my command writed in plugin.yml

Code:java

name: Slifuoti
author: FightManiac
version: 1.5
main: as.FightManiac.Slifuoju.Slifuoti
description: TEST.
commands:
  before:
    description: blahblah

My plugin.yml

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

FightManiac
Does the plugin load?

The variable isn't used because you didn't use it, you only continued to use player.getInventory() instead of playerIntventory.

 

xTrollxDudex Okay i did this but when i write the command nothing is done

Code:

Code:java

public boolean onCommand(CommandSender sender, Command command, String commandLabel, String args){
    if(sender instanceof Player){
    Player player = (Player) sender;
 
    if(commandLabel.equalsIgnoreCase("before")){
        Inventory playerInventory = player.getInventory();
        Player p = (Player) sender;
 
 
    if(playerInventory.contains(Material.GOLD_BLOCK)){
 
        playerInventory.removeItem(new ItemStack[] { new ItemStack(Material.GOLD_BLOCK, 1) });
        playerInventory.addItem(new ItemStack[] { new ItemStack(Material.GOLD_INGOT, 9) });
        p.sendMessage("My Message");
    }
    }
    }
    return false;
    }
}

My plugin.yml

Code:java

name: Slifuoti
author: FightManiac
version: 1.5
main: as.FightManiac.Slifuoju.Slifuoti
description: derp
commands:
  before:
    description: any message here is good

Why is it not working?

Solved It.

EDIT by Moderator: merged posts, please use the edit button instead of double posting.